From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: Gaurav Jain <gaurav.jain@nxp.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Eric Jin <eric.jin@intel.com>,
Prasanth Pulla <Prasanth.Pulla@arm.com>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
nd <nd@arm.com>
Subject: Re: [edk2-test PATCH] SctPkg: Updated Start Address Alignment code
Date: Fri, 17 Apr 2020 13:46:12 +0000 [thread overview]
Message-ID: <DB7PR08MB326003256F353F1FC4341B1090D90@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <DB7PR08MB3260CF60276462F1094980B490D90@DB7PR08MB3260.eurprd08.prod.outlook.com>
Gaurav,
You sent to the old list. Adding the new edk2-devel list
>
> > -----Original Message-----
> > From: Gaurav Jain <gaurav.jain@nxp.com>
> > Sent: Friday, April 17, 2020 2:55 AM
> > To: edk2-devel@lists.01.org
> > Cc: Eric Jin <eric.jin@intel.com>; Supreeth Venkatesh
> > <Supreeth.Venkatesh@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > Mahmoud@arm.com>; Prasanth Pulla <Prasanth.Pulla@arm.com>; Pankaj
> > Bansal <pankaj.bansal@nxp.com>
> > Subject: RE: [edk2-test PATCH] SctPkg: Updated Start Address Alignment
> > code
> >
> > Hi
> >
> > Gentle Reminder!!
> > Please help to review patch.
> >
> > Regards
> > Gaurav Jain
> >
> > > -----Original Message-----
> > > From: Gaurav Jain <gaurav.jain@nxp.com>
> > > Sent: Thursday, April 9, 2020 6:33 PM
> > > To: edk2-devel@lists.01.org
> > > Cc: Eric Jin <eric.jin@intel.com>; Supreeth Venkatesh
> > > <supreeth.venkatesh@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > > Mahmoud@arm.com>; Prasanth Pulla <Prasanth.Pulla@arm.com>; Pankaj
> > > Bansal <pankaj.bansal@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>
> > > Subject: [edk2-test PATCH] SctPkg: Updated Start Address Alignment
> > > code
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2671
> > >
> > > AllocatePages Functionality test.
> > > Updated Start Address Calculation for aligning to 64k.
> > >
> > > Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> > > ---
> > > .../BlackBoxTest/MemoryAllocationServicesBBTestFunction.c | 14
> > > +++++++--
> > > -----
> > > 1 file changed, 7 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/B
> > > la ck BoxTest/MemoryAllocationServicesBBTestFunction.c b/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/B
> > > la ck BoxTest/MemoryAllocationServicesBBTestFunction.c
> > > index d18fe1f..a42cd9a 100644
> > > --- a/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/B
> > > la ck BoxTest/MemoryAllocationServicesBBTestFunction.c
> > > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocatio
> > > +++ nS er
> > > +++ vices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
> > > @@ -706,7 +706,7 @@ BBTestAllocatePagesInterfaceTest (
> > > if (PageNum <= 0x10) {
> > > break;
> > > }
> > > - Start = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > + Start = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > > PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > > Memory = Start;
> > > @@ -836,7 +836,7 @@ BBTestAllocatePagesInterfaceTest (
> > > if (PageNum <= 0x10) {
> > > break;
> > > }
> > > - Start = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > + Start = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > > PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > > Memory = Start;
> > > @@ -959,7 +959,7 @@ BBTestAllocatePagesInterfaceTest (
> > > if (PageNum <= 0x10) {
> > > break;
> > > }
> > > - Start = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > + Start = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > > PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > > Memory = Start + (SctLShiftU64 (PageNum/3, EFI_PAGE_SHIFT)
> > > & 0xFFFFFFFFFFFF0000); @@ -1082,7 +1082,7 @@
> > > BBTestAllocatePagesInterfaceTest (
> > > if (PageNum <= 0x10) {
> > > break;
> > > }
> > > - Start = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > + Start = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > > PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > > Memory = Start + (SctLShiftU64 (PageNum * 2 / 3,
> > > EFI_PAGE_SHIFT) & 0xFFFFFFFFFFFF0000); @@ -1212,7 +1212,7 @@
> > > BBTestAllocatePagesInterfaceTest (
> > > if (PageNum <= 0x10) {
> > > break;
> > > }
> > > - Start = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > + Start = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > > PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > > Memory = Start;
> > > @@ -1335,7 +1335,7 @@ BBTestAllocatePagesInterfaceTest (
> > > if (PageNum <= 0x10) {
> > > break;
> > > }
> > > - Start = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > + Start = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > > PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > > Memory = Start;
> > > @@ -1474,7 +1474,7 @@ BBTestAllocatePagesInterfaceTest (
> > > if (PageNum <= 0x10) {
> > > break;
> > > }
> > > - Start = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > + Start = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > > PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > > Memory = Start;
> > > --
> > > 2.7.4
next parent reply other threads:[~2020-04-17 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1586437393-14249-1-git-send-email-gaurav.jain@nxp.com>
[not found] ` <AM5PR04MB30746F7C68C3FD33E2D7E9D5E7D90@AM5PR04MB3074.eurprd04.prod.outlook.com>
[not found] ` <DB7PR08MB3260CF60276462F1094980B490D90@DB7PR08MB3260.eurprd08.prod.outlook.com>
2020-04-17 13:46 ` Samer El-Haj-Mahmoud [this message]
2020-05-07 3:42 ` [edk2-devel] [edk2-test PATCH] SctPkg: Updated Start Address Alignment code tuanphan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB326003256F353F1FC4341B1090D90@DB7PR08MB3260.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox