Re: [edk2-test PATCH] SctPkg: Updated Start Address Alignment code

Re: [edk2-test PATCH] SctPkg: Updated Start Address Alignment code

[Samer El-Haj-Mahmoud]

Gaurav,

You sent to the old list. Adding the new edk2-devel list


> 
> > -----Original Message-----
> > From: Gaurav Jain <gaurav.jain@nxp.com>
> > Sent: Friday, April 17, 2020 2:55 AM
> > To: edk2-devel@lists.01.org
> > Cc: Eric Jin <eric.jin@intel.com>; Supreeth Venkatesh
> > <Supreeth.Venkatesh@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > Mahmoud@arm.com>; Prasanth Pulla <Prasanth.Pulla@arm.com>; Pankaj
> > Bansal <pankaj.bansal@nxp.com>
> > Subject: RE: [edk2-test PATCH] SctPkg: Updated Start Address Alignment
> > code
> >
> > Hi
> >
> > Gentle Reminder!!
> > Please help to review patch.
> >
> > Regards
> > Gaurav Jain
> >
> > > -----Original Message-----
> > > From: Gaurav Jain <gaurav.jain@nxp.com>
> > > Sent: Thursday, April 9, 2020 6:33 PM
> > > To: edk2-devel@lists.01.org
> > > Cc: Eric Jin <eric.jin@intel.com>; Supreeth Venkatesh
> > > <supreeth.venkatesh@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> > > Mahmoud@arm.com>; Prasanth Pulla <Prasanth.Pulla@arm.com>; Pankaj
> > > Bansal <pankaj.bansal@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>
> > > Subject: [edk2-test PATCH] SctPkg: Updated Start Address Alignment
> > > code
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2671
> > >
> > > AllocatePages Functionality test.
> > > Updated Start Address Calculation for aligning to 64k.
> > >
> > > Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
> > > ---
> > >  .../BlackBoxTest/MemoryAllocationServicesBBTestFunction.c  | 14
> > > +++++++--
> > > -----
> > >  1 file changed, 7 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/B
> > > la ck BoxTest/MemoryAllocationServicesBBTestFunction.c b/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/B
> > > la ck BoxTest/MemoryAllocationServicesBBTestFunction.c
> > > index d18fe1f..a42cd9a 100644
> > > --- a/uefi-
> > > sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocationServices/B
> > > la ck BoxTest/MemoryAllocationServicesBBTestFunction.c
> > > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MemoryAllocatio
> > > +++ nS er
> > > +++ vices/BlackBoxTest/MemoryAllocationServicesBBTestFunction.c
> > > @@ -706,7 +706,7 @@ BBTestAllocatePagesInterfaceTest (
> > >          if (PageNum <= 0x10) {
> > >            break;
> > >          }
> > > -        Start   = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > +        Start   = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > >          PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > >          Memory  = Start;
> > > @@ -836,7 +836,7 @@ BBTestAllocatePagesInterfaceTest (
> > >          if (PageNum <= 0x10) {
> > >            break;
> > >          }
> > > -        Start   = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > +        Start   = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > >          PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > >          Memory  = Start;
> > > @@ -959,7 +959,7 @@ BBTestAllocatePagesInterfaceTest (
> > >          if (PageNum <= 0x10) {
> > >            break;
> > >          }
> > > -        Start   = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > +        Start   = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > >          PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > >          Memory = Start + (SctLShiftU64 (PageNum/3, EFI_PAGE_SHIFT)
> > > & 0xFFFFFFFFFFFF0000); @@ -1082,7 +1082,7 @@
> > > BBTestAllocatePagesInterfaceTest (
> > >          if (PageNum <= 0x10) {
> > >            break;
> > >          }
> > > -        Start   = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > +        Start   = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > >          PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > >          Memory  = Start + (SctLShiftU64 (PageNum * 2 / 3,
> > > EFI_PAGE_SHIFT) & 0xFFFFFFFFFFFF0000); @@ -1212,7 +1212,7 @@
> > > BBTestAllocatePagesInterfaceTest (
> > >          if (PageNum <= 0x10) {
> > >            break;
> > >          }
> > > -        Start   = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > +        Start   = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > >          PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > >          Memory  = Start;
> > > @@ -1335,7 +1335,7 @@ BBTestAllocatePagesInterfaceTest (
> > >          if (PageNum <= 0x10) {
> > >            break;
> > >          }
> > > -        Start   = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > +        Start   = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > >          PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > >          Memory  = Start;
> > > @@ -1474,7 +1474,7 @@ BBTestAllocatePagesInterfaceTest (
> > >          if (PageNum <= 0x10) {
> > >            break;
> > >          }
> > > -        Start   = (Start + 0x10000) & 0xFFFFFFFFFFFF0000;
> > > +        Start   = (Start + 0xFFFF) & 0xFFFFFFFFFFFF0000;
> > >          PageNum = PageNum - EFI_SIZE_TO_PAGES(0x10000);
> > >
> > >          Memory  = Start;
> > > --
> > > 2.7.4

Re: [edk2-devel] [edk2-test PATCH] SctPkg: Updated Start Address Alignment code

[tuanphan]

[-- Attachment #1: Type: text/plain, Size: 56 bytes --]

Tested-by: Tuan Phan <tuanphan@os.amperecomputing.com>

[-- Attachment #2: Type: text/html, Size: 155 bytes --]