From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.49]) by mx.groups.io with SMTP id smtpd.web10.1675.1587388654681379285 for ; Mon, 20 Apr 2020 06:17:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=KzrpQ1Ho; spf=pass (domain: arm.com, ip: 40.107.6.49, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N8h4Dv8nqqg6RdhRA0YvEYkdIAOH9OBhSg6nvINFEcU=; b=KzrpQ1HoUwRBqvWsMnrZ/gbeQ0rM8cd9w8UbKYOXWtHoFd+xNaYB267zU7PM9u4TFJNGjtaZMLkxmigxkZXnugjCHcMUZuvP/ihDP3bVdFbeltjKAGXiT0E13R42v1eaus7xx/wZO0PrCZeEKG6KtzmU120cnG91+ZHxYzy/8es= Received: from AM6PR0202CA0042.eurprd02.prod.outlook.com (2603:10a6:20b:3a::19) by AM6PR08MB3639.eurprd08.prod.outlook.com (2603:10a6:20b:51::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Mon, 20 Apr 2020 13:17:32 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::49) by AM6PR0202CA0042.outlook.office365.com (2603:10a6:20b:3a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Mon, 20 Apr 2020 13:17:32 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.18 via Frontend Transport; Mon, 20 Apr 2020 13:17:31 +0000 Received: ("Tessian outbound 76e9a4cf1540:v53"); Mon, 20 Apr 2020 13:17:31 +0000 X-CR-MTA-TID: 64aa7808 Received: from 3bebd67b602d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 41A3C42D-FD89-41A7-B7BF-4D78A22E20FA.1; Mon, 20 Apr 2020 13:17:26 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3bebd67b602d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Apr 2020 13:17:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IY7YwVoU08fBoACuy/34oogXcwf8pcxu3eL6a26qeAwXXuP+259T6mm/X9WVBWolydmOFQSgpXW0YL5F8/wGrMz86vzMn17w1mmZDSNn43otvbnidhkaQ0e7V+AoeKSKxJb68VXvfE/BC/qw61gzgY1bgOFenRlbM+puQ6gHev6EOVRdbDwQnk+H+6vzDldDODu+45bdUTxiRZ7opauuYH3z2CLjYWLCy5XXbLN/nFC1/Jud9GQRlT3nvAsNea8PSE9jOc7oh+dxUisUoQV6CZA9Usd5gWRHebWapJi8kVyRkw9ivhECHWySzUXCNjL4bBTwxhxIzCmld2y3KNpduQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N8h4Dv8nqqg6RdhRA0YvEYkdIAOH9OBhSg6nvINFEcU=; b=PcS6YcFK5MN823IrVuK4seU5VP9kSrMyUAGnP4dOmRz/ZSxqHtx8L8CbkKzGikhZPUWPUx0cAzvWfTrJOi9kmR7iJjc/F6Lg9MmpJCZovCfnAmp7S7OqLustYXq+0r5UdU11w7u6pnCORdFka9X3ZBmi+bqF86ZUE7A37iYEUZQtiV5M2HJilS7IS0SicTe+OKd5gK8ZvetRLSClwdcEeZ5Gl6sPKeoNTpOZJuUvbYtwVUVBpOb6AFSwCrPkyD4IHxXd51FsuO+RjHKA3fOkYUOLHGTumKr5tUX4gnluqV4PbfiKexuG8baVxYmG3OkfGea8o6tIZeWrWLwhGGg6eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N8h4Dv8nqqg6RdhRA0YvEYkdIAOH9OBhSg6nvINFEcU=; b=KzrpQ1HoUwRBqvWsMnrZ/gbeQ0rM8cd9w8UbKYOXWtHoFd+xNaYB267zU7PM9u4TFJNGjtaZMLkxmigxkZXnugjCHcMUZuvP/ihDP3bVdFbeltjKAGXiT0E13R42v1eaus7xx/wZO0PrCZeEKG6KtzmU120cnG91+ZHxYzy/8es= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB7PR08MB3449.eurprd08.prod.outlook.com (2603:10a6:10:42::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Mon, 20 Apr 2020 13:17:24 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::990e:ed79:bec0:9dac]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::990e:ed79:bec0:9dac%7]) with mapi id 15.20.2921.027; Mon, 20 Apr 2020 13:17:24 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "leif@nuviainc.com" , "Andrei Warkentin (awarkentin@vmware.com)" , Ard Biesheuvel CC: Pete Batard , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Thread-Topic: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Thread-Index: AQHWFksOqDJAoCP0XkGz+579MXqBa6iAcbcAgAAM2gCAAF4XAIABAu0AgAAbp+A= Date: Mon, 20 Apr 2020 13:17:24 +0000 Message-ID: References: <20200419130417.3298-1-samer@elhajmahmoud.com> <8d59e616-9910-4935-2e1f-5da75fc1d34a@arm.com> <831705c6-0915-ba1a-adc0-3078b2af1a43@akeo.ie> <20200420112316.GG14075@vanye> In-Reply-To: <20200420112316.GG14075@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6297568a-cce2-47c2-96a4-d4f63de8ad86.1 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Samer.El-Haj-Mahmoud@arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2ac4f61d-aff4-4c63-d3b6-08d7e52d2eb3 x-ms-traffictypediagnostic: DB7PR08MB3449:|DB7PR08MB3449:|AM6PR08MB3639: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5236;OLM:6790; x-forefront-prvs: 03793408BA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39860400002)(376002)(346002)(136003)(366004)(396003)(2906002)(53546011)(54906003)(6506007)(8936002)(4326008)(316002)(110136005)(26005)(71200400001)(66574012)(66446008)(64756008)(66556008)(66946007)(8676002)(81156014)(66476007)(7696005)(186003)(9686003)(55016002)(6636002)(86362001)(5660300002)(33656002)(52536014)(966005)(478600001)(76116006);DIR:OUT;SFP:1101; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qiLafhhYkIJppNwNXooMmBp+tGK9Pwkqi2s/NHU1kgrVre9UCumdc3Sn2Ty+sx+aUinT6COFXJSN0wsj9glNTz1wF8J3eHIaIp4f6qOivtvtz2ogQC3h+fy87F9hPpn8cn1wyLA8DwMbbi2BVXyhFG6+8BmtFg0u76bpsai3ESBko6WuaiK2MkgabVUKZERHDD+PnNLFHs/oSFKFoIApGMXXy7B9inCIVTGugwrG5JQlIAZe3WthuCRJ4izGQedwYiWGiiq0nbXgviZfGf+iypUCG+lfe3f5GLze7cds7vkU7aPqoCsS22EiShDngrUj/WVyp6/bVbOXb8j1JrENZuZFX3X6tFXAXjVVBJDf9axtewOpopwoCtQ0Z+EpkU1DtiDXKz3rSeUsvfK7qgzTDXlZfwf9gd0Zo4JfUyuUMke0BhKTdvNl98P7vW44/B6I3YwdnVSYyosRoYs77fPZFVrIY8FMeNN20X9UtZXKVrNss3HLE3yZJTTNgoRFiR5eyGThqM/RyG5+BYyU640NYw== x-ms-exchange-antispam-messagedata: nJNc7PlOPH0sRuaBEtUUA2Ww5JiIzZGtOhxt/by1kmmwWSJvyfay9nalEUp+9SnTSBMtaaojjErYm6PT+9frr3uL02GHkVvF50s9ozNTLTxjF+PW44tXncdSsU0q2yV9cabkpwHuolXl+ZQw1Cboxg== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3449 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Samer.El-Haj-Mahmoud@arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966005)(316002)(36906005)(8936002)(8676002)(81156014)(33656002)(7696005)(6506007)(6636002)(53546011)(54906003)(110136005)(86362001)(478600001)(966005)(9686003)(55016002)(336012)(356005)(70586007)(70206006)(52536014)(4326008)(186003)(2906002)(81166007)(5660300002)(66574012)(26005)(47076004)(82740400003);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 8a96cd82-6292-48f6-7832-08d7e52d2a65 X-Forefront-PRVS: 03793408BA X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RWuL+JY6JQ1o7LDDtalo+HPj4W+pFTZLJd5BugdBraJZgP2Tf5tNbKCydbotUOdab2YOrJGsojBwc6kAGD/fnxFtx21c+no3v29vKU96QWyfQlJCedQvvgKwiH7VOb5y055ermPjEBio8kCYipQJgCSzA1GEW7aNY4A7CpXrClF5RmeYo2mT9n/6sCi8LZwUbi/2jU4KG/Q6hLGzyzgFQBPaiVoxopWFl0o0e4CnqImbrk4xzGiH24stJk9H3SATDoFoanWiMbYepkwluEdkgSi96XIhUxIO6ojR3CmPM112GHDKlaqpNxvq4G2tYC3E3+/HCRyH7U/QmDcVsIgcBaiKhLKMOqrsmrIrULLvsUWMMCZoTV+w8+7omXSVoTgv2Vq9B35PbpM6hW23gEc0xW2Eo7degRSu70Usjg2g9QfcAKHP25pfB3bW/l9peXPOxEB2nn1571qe/eZO2oe+Kt+I/EFrijjpPPq/1vVDykqcUwit3b1QrU1mw8vjpUXhlrBdbskHbvmKND3jLWYaLB9IGW76JA5whdEEiI+MOyvSLe3j4NFN+SxebwNK+eeTlIaLJQMNCJ1UaO6eUv7qkw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2020 13:17:31.5280 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ac4f61d-aff4-4c63-d3b6-08d7e52d2eb3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3639 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have no objection to dropping the "enable TFTP by default". I already sta= ted that to Ard in my original reply. That is not really a big issue (or an= issue at all) since we have the -D build option to enable the command in s= ome builds, and the net is no functionality change for end-users. In general, I am in favor of having Shell commands that are wrappers aroun= d useful UEFI protocols/functionality where it makes sense (e.g. would be n= ice to have a CLI HII forms processor/browser..). I thought the TFTP comman= d offered that (a wrapper around the MTFTP4 protocol), which helps in some = Shell remote scripting (although honestly, not very useful on its own). I u= nderstand that there is hesitation in including non-standard commands in th= e Shell by default. I did not consider TFTP as a replacement for Capsule Up= dates, but I can see how it can be abused to be so. I agree that usage shou= ld not be encouraged. I still have not seen a review-by or ack for the ASSERT fix. Can we get pa= tch 1 and 2 in the series reviewed and pushed please, and ignore patches 3/= 4? Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Leif > Lindholm via groups.io > Sent: Monday, April 20, 2020 7:23 AM > To: Andrei Warkentin (awarkentin@vmware.com) > ; Ard Biesheuvel > Cc: Pete Batard ; Samer El-Haj-Mahmoud > ; devel@edk2.groups.io > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/Raspber= ryPi > : Enable TFTP shell command > > Hi Andrei, > > On Sun, Apr 19, 2020 at 19:56:32 +0000, awarkentin@vmware.com wrote: > > If we have to choose abstract goodness over functionality, why > > wouldn't we choose functionality? Functionality that's part of Tiano? > > The real world doesn't care about the TFTP command being an > > "unsupported hack" or not. So there's Tiano-specific code here. Big > > deal? To rephrase differently, why would either Pi 4 developers or Pi > > 4 UEFI users pay the cost of Tiano carrying code that somehow isn't > > "legit enough" to be enabled? > > I agree there is confusion caused by this weird second implementation of= TFTP > in Tianocore. It is yet another piece of unfortunate legacy caused by AR= M's > initial focus on trying to make EDK2 look and work like u-boot instead o= f > understanding how to use it as a generic UEFI implementation. > > For that reason, it should have gone the same way as the ArmBds and the = built- > in linux loader, but people kept arguing it was really useful for debugg= ing - so > we let it be, and permitted platforms to include it as long as it was no= t included > by default. > > But since its main contribution to TianoCore seems to be causing argumen= ts on > the mailing list, perhaps we should finally bite the bullet and nuke it. > > The idea (which was probably mine) that "only permit platforms to includ= e it if > it is disabled by default and people will get the hint" > has demonstrably failed. > > / > Leif > >=20 IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.