From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"rebecca@nuviainc.com" <rebecca@nuviainc.com>
Cc: "ray.ni@intel.com" <ray.ni@intel.com>,
"zhichao.gao@intel.com" <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview
Date: Tue, 20 Oct 2020 21:05:51 +0000 [thread overview]
Message-ID: <DB7PR08MB32601238335C5ECB0CF31DFB901F0@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201020195952.13314-1-rebecca@nuviainc.com>
Thanks for adding this!
Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Tuesday, October 20, 2020 4:00 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; ray.ni@intel.com;
> zhichao.gao@intel.com
> Subject: [edk2-devel] [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor
> Characteristics in smbiosview
>
> SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics field
> to be the ARM64 SoC ID support. Add support for it to the smbiosview
> command.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index 17a2a89d512e..d0796a0e5141 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> +++ c
> @@ -624,6 +624,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = {
> {
> 8,
> L" 128-bit Capable"
> + },
> + {
> + 9,
> + L" ARM64 SoC ID"
> }
> };
>
> --
> 2.26.2
>
>
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2020-10-20 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 19:59 [PATCH 1/2] ShellPkg: add ARM64 SoC ID to Processor Characteristics in smbiosview Rebecca Cran
2020-10-20 21:05 ` Samer El-Haj-Mahmoud [this message]
2020-10-21 1:02 ` 回复: [edk2-devel] " gaoliming
2020-10-21 4:22 ` [EXTERNAL] " Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB32601238335C5ECB0CF31DFB901F0@DB7PR08MB3260.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox