Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
From: devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of Andrei Warkentin via groups.io
Sent: Wednesday, November 18, 2020 6:21 PM
To: Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2.groups.io; leif@nuviainc.com
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; pete@akeo.ie; philmd@redhat.com
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
Hi Leif,
I got these from https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
A
From:
devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Leif Lindholm via groups.io <leif=nuviainc.com@groups.io>
Sent: Tuesday, November 17, 2020 10:02 AM
To: Andrei Warkentin <andrey.warkentin@gmail.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>;
ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>;
pete@akeo.ie <pete@akeo.ie>;
philmd@redhat.com <philmd@redhat.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
Hi Andrei,
On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote:
> Like the Pi 4B, the 3GB/4GB choices apply to it as well.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
Patch looks straghtforward enough, but ideally I'd like someone to
chime in with tested-by. That hasn't happened so far - are these
documented anywhere I could easily sanity check myself?
/
Leif
> ---
> Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> index 5302ccd8..ade91c9f 100644
> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> @@ -596,6 +596,10 @@ RpiFirmwareGetModelName (
> return "Raspberry Pi Compute Module 3+";
> case 0x11:
> return "Raspberry Pi 4 Model B";
> + case 0x13:
> + return "Raspberry Pi 400";
> + case 0x14:
> + return "Raspberry Pi Compute Module 4";
> default:
> return "Unknown Raspberry Pi Model";
> }
> @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily (
> *ModelFamily = 3;
> break;
> case 0x11: // Raspberry Pi 4 Model B
> + case 0x13: // Raspberry Pi 400
> + case 0x14: // Raspberry Pi Computer Module 4
> *ModelFamily = 4;
> break;
> default:
> --
> 2.20.1
>