From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.59]) by mx.groups.io with SMTP id smtpd.web09.20198.1606056545950651961 for ; Sun, 22 Nov 2020 06:49:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=IqTK5bpL; spf=pass (domain: arm.com, ip: 40.107.5.59, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTc8IpjXYYMJV3GJ+0j+erj2Dk0VuIfhbXHzlok3Y4I=; b=IqTK5bpL5cUGroYpl0xRStCaYjB55dG/nc+jSravRdVK05Yk5WsVXz5qEnLaIQCVa3lWssHgouvoa5EylNvsv+FLdAxrKxIdE7yJCOrm2o/PHtcDe4oNf97YOKqzOitdcz8iM3xdftWQQXJR+VBlo25PiWMwfDtM1K2UI7DYEl8= Received: from DB6PR0301CA0017.eurprd03.prod.outlook.com (2603:10a6:4:3e::27) by DBAPR08MB5685.eurprd08.prod.outlook.com (2603:10a6:10:1ad::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Sun, 22 Nov 2020 14:49:02 +0000 Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::e5) by DB6PR0301CA0017.outlook.office365.com (2603:10a6:4:3e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Sun, 22 Nov 2020 14:49:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Sun, 22 Nov 2020 14:49:02 +0000 Received: ("Tessian outbound d6c201accd3c:v71"); Sun, 22 Nov 2020 14:49:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b32300f02241707f X-CR-MTA-TID: 64aa7808 Received: from a5a8e065c78a.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FAFEC93C-C2C1-42F0-9CAC-1B40DF868CAA.1; Sun, 22 Nov 2020 14:48:55 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a5a8e065c78a.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 22 Nov 2020 14:48:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FhqPj8yEKJJUUAfN2LXZ1ESBGBJhLcjbVKO66sj5f2cvQyuDv12Fz6pv5VpyHXd6sGKDNZFwa23brpp2d4OvOuF3oXmbEW4OQd1eEqHQMIdY2mDjS0h3+jjUJwsGtsoNdAirXKaw1jzVUlFHcnIO0LIFMg9HkAZl5HGtfCCS1GkMMGWjM1AaJgpA+gmQD6OcSask7ElhZvfEchQZhPlzL8Ao8PxMu9FVKI9nbg7qWGJK6AG3gZesmfSO2MX+HEaqYLYBalwJQEC84sbZdXLqQLOvij3aSbbOgPzWdde+i9y3zT68oA5fMLCIPLoOJaL5enFEx3414NAIAW3y/qXTwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTc8IpjXYYMJV3GJ+0j+erj2Dk0VuIfhbXHzlok3Y4I=; b=V4ucGtJfi0dv1bS5fl/C4p3DBOQ7qByw5UEtNJrns/2ZT8FlweL5NaqTPFmh0oZuPmS5FYwoRabDNiVZCaZuwWSE+5dkLN54FPk7YUTa8hbBFrwTHXfW1Rk06h22rceUyYLxLtKryFP95Lri6EI8TBJ/Cx9rkxl3umUjmfWmMTDJwv447K+2FeZ6vjyrANDNIgqUHg4Bl+GuVsfKi7wG2k3L3GcwWl79Zw21cVOBsZOn658L655FuuF8Cs4SOdr3nYzmtW1QEGzIa9ZovanFu3usSRo95dgJ2QPPYaAUhrHBw8hdaMel89xS3D+c1t4rgoYGH4M1nprtWHC9m1ksPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VTc8IpjXYYMJV3GJ+0j+erj2Dk0VuIfhbXHzlok3Y4I=; b=IqTK5bpL5cUGroYpl0xRStCaYjB55dG/nc+jSravRdVK05Yk5WsVXz5qEnLaIQCVa3lWssHgouvoa5EylNvsv+FLdAxrKxIdE7yJCOrm2o/PHtcDe4oNf97YOKqzOitdcz8iM3xdftWQQXJR+VBlo25PiWMwfDtM1K2UI7DYEl8= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB7PR08MB3849.eurprd08.prod.outlook.com (2603:10a6:10:79::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Sun, 22 Nov 2020 14:48:52 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6%7]) with mapi id 15.20.3589.021; Sun, 22 Nov 2020 14:48:51 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "Andrei Warkentin (awarkentin@vmware.com)" , Andrei Warkentin , "leif@nuviainc.com" CC: Ard Biesheuvel , "pete@akeo.ie" , "philmd@redhat.com" , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs Thread-Index: AQHWuznADLBSK5f+vEO619W5iGX2xKnMf8SAgAIM2ACABboOsA== Date: Sun, 22 Nov 2020 14:48:51 +0000 Message-ID: References: <20201115102527.2993-1-andrey.warkentin@gmail.com>,<20201117160255.GG1664@vanye> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 59958d24-70e7-4e31-f92b-08d88ef5c084 x-ms-traffictypediagnostic: DB7PR08MB3849:|DBAPR08MB5685: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4303;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gWncSJssvlYPuAX6Wkb2kSYyfF83pS7TrzY79EmpjJF6YrLaGYobdhD5kC33YxrhaA09hb2c/urWC+sgbafWX0TZQ5E3pyhe3UR7q2wDVMIFKVRZH4ntPIGjo1dEra+wQu/2wRhjBUh2pWw8cyqVL5S31KTFuEHROe1slVADrmJV5jo3+QJC7USGLVfPPwYgV19J0/uKKRI0YkoNhHvWkfxmhPXeMXL0aVJ/GHgDa0vbwUS6OLErLSdz4r3uGjiDAAUMg+dJ7qrcioQC+HDJeJv2ea+Z3ASKc+3e8QDx7DC2fPSvkEQE6NeO3RmMIWyHiSGKTXnW9FAJ5NIgB1CJVP+SOTFUOaIE9wux6EiJ2nzi5a795ilbyRrR/G+khmXmHYHVe26RZXIBnJB98UOpdw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(39850400004)(376002)(346002)(136003)(66556008)(64756008)(7696005)(66446008)(66476007)(316002)(166002)(55016002)(76236003)(52536014)(76116006)(83380400001)(86362001)(4326008)(5660300002)(26005)(53546011)(66946007)(6506007)(33656002)(2906002)(8936002)(9686003)(966005)(186003)(71200400001)(110136005)(478600001)(54906003)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: h9IhU6Jd0+q8rigi+yvbk5AiKZtBiLBaX093bPldV3Z/lLqd57xf1CzNWelO5Rzc/OsOZ0mBD2mAOXygMJPdwE5tKbMUSRdXB7KrYXmXirFN7/Vb8r+dseFAa7iDByhjgVseE0hONrcrB5wC5rOVx2D5OJkaBcCztTJZTRbnNFzg6ihtki27VpKTBPGxZ2t2ALB348cZPFiBDl0XLWEgCKuOBllrtw0PbVlJNZuJoHNyq/aIP1EboYf0NvjGNhhJgLOVcjTrWm8RS+vTJ8tTJY8XMi2I540g6e23u+oN4WxV5RnE+ctmXpZKH5eBr7Gx3N21FgBRFgFIOgmkoRGlJN3fktLwhqjQMAQ8jhu/Izu+PsiRiBKbtJwa2C+iaOXIhMU3mP/lqcA58pX8EaIJcsHNitWrbXUjU/56r3/MD38lxvylKbm4VG/phyxSK51ay7osHZm1GzU/NDR7Q4huYUhbptP6HgOyjjvgg5x/6bPmGKmI5ZLAXKsbJK3PTsuUD1orSFlrbuKtNWQIGlndu99O60teGrO1qNZg3qEO/s20cTB8okufOV7e292neVN57Q+QSBX1AvEsfjMzjmnUycl2sPwYiIqwUXIrT3vamASq4YusnKaleTDKeY/Has3RMSWVTZf+mRNBOc36fneUHQ== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3849 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 447d953f-fad8-4271-6092-08d88ef5ba65 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LqsJlwDgE/DzKR6YbbWPTuaMSEhMIF6+i2544O+WlOMt3lQ0WzrkFRv6i8Kaj5Bd9GSVE8yu/mTNRDb+gVD8S/fukofQcl4Co9MQWqqBTclanUEpE0n6sErricyrWpSS2C4St96kcDqWQ4fY7t759BgnBzLaQrMIteDb6NykAgrGBQ6X6hgUqva64RgEwlIlefUnXClQKFif/6kN4wOXIqpTfpAiULVWFzn0HBFoMG0CB7FmHJKLuhhmcrKpanFlfNqQDY4BzTCuXuwJNw15YhEvFC5SSyRSGVb+kl9+brkxxOzf0d/mQ/Rbpn1IY8S/WLW/HqjTIWNxLE3Gws+bHBKxoJKrSK4/OtV8JQiq+/YN6uxsmjqV2o+pgJeCZSFvq6WSmStdI7F/LILXd8NsQFddiwnD82pmMUiM90XpxPkXTdah64+G72EPN0U2azoVioZT/bwx0XegFNA/01ZlZdW8GcB/2Moa94wbtclDTvA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(136003)(39850400004)(376002)(346002)(46966005)(316002)(82310400003)(54906003)(47076004)(52536014)(6506007)(336012)(26005)(7696005)(166002)(82740400003)(53546011)(2906002)(76236003)(81166007)(110136005)(83380400001)(186003)(356005)(5660300002)(55016002)(4326008)(9686003)(8936002)(478600001)(70206006)(966005)(86362001)(70586007)(8676002)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2020 14:49:02.0916 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59958d24-70e7-4e31-f92b-08d88ef5c084 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5685 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DB7PR08MB32601D7CDE83121EF98D4E7390FD0DB7PR08MB3260eurp_" --_000_DB7PR08MB32601D7CDE83121EF98D4E7390FD0DB7PR08MB3260eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Samer El-Haj-Mahmoud > From: devel@edk2.groups.io On Behalf Of Andrei Wark= entin via groups.io Sent: Wednesday, November 18, 2020 6:21 PM To: Andrei Warkentin ; devel@edk2.groups.io; l= eif@nuviainc.com Cc: Ard Biesheuvel ; pete@akeo.ie; philmd@redhat.c= om Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryP= i: add CM4 and 400 as BCM2711 designs Hi Leif, I got these from https://www.raspberrypi.org/documentation/hardware/raspbe= rrypi/revision-codes/README.md A ________________________________ From: devel@edk2.groups.io > on behalf of Leif Lindholm via groups.io = > Sent: Tuesday, November 17, 2020 10:02 AM To: Andrei Warkentin > Cc: devel@edk2.groups.io >; ard.biesheuvel@arm.com >; pete@a= keo.ie >; philmd@red= hat.com > Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryP= i: add CM4 and 400 as BCM2711 designs Hi Andrei, On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote: > Like the Pi 4B, the 3GB/4GB choices apply to it as well. > > Signed-off-by: Andrei Warkentin > Patch looks straghtforward enough, but ideally I'd like someone to chime in with tested-by. That hasn't happened so far - are these documented anywhere I could easily sanity check myself? / Leif > --- > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.= c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > index 5302ccd8..ade91c9f 100644 > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -596,6 +596,10 @@ RpiFirmwareGetModelName ( > return "Raspberry Pi Compute Module 3+"; > case 0x11: > return "Raspberry Pi 4 Model B"; > + case 0x13: > + return "Raspberry Pi 400"; > + case 0x14: > + return "Raspberry Pi Compute Module 4"; > default: > return "Unknown Raspberry Pi Model"; > } > @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily ( > *ModelFamily =3D 3; > break; > case 0x11: // Raspberry Pi 4 Model B > + case 0x13: // Raspberry Pi 400 > + case 0x14: // Raspberry Pi Computer Module 4 > *ModelFamily =3D 4; > break; > default: > -- > 2.20.1 > IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. --_000_DB7PR08MB32601D7CDE83121EF98D4E7390FD0DB7PR08MB3260eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

 

From: devel@edk2.groups.io <devel@edk2.gr= oups.io> On Behalf Of Andrei Warkentin via groups.io
Sent: Wednesday, November 18, 2020 6:21 PM
To: Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2= .groups.io; leif@nuviainc.com
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; pete@akeo.ie; ph= ilmd@redhat.com
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/Ras= pberryPi: add CM4 and 400 as BCM2711 designs

 

Hi Leif,

 

 

A

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf o= f Leif Lindholm via groups.io <leif=3Dnuviainc.com@groups.io>
Sent: Tuesday, November 17, 2020 10:02 AM
To: Andrei Warkentin <andrey.warkentin@gmail.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; ard.biesheuvel@arm.com <<= a href=3D"mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com>; pete@akeo.ie <pete@akeo.ie>; philmd@redhat.com <philmd@redhat.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/Ras= pberryPi: add CM4 and 400 as BCM2711 designs

 

Hi Andrei,

On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote:
> Like the Pi 4B, the 3GB/4GB choices apply to it as well.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>

Patch looks straghtforward enough, but ideally I'd like someone to
chime in with tested-by. That hasn't happened so far - are these
documented anywhere I could easily sanity check myself?

/
    Leif

> ---
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | = 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareD= xe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> index 5302ccd8..ade91c9f 100644
> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -596,6 +596,10 @@ RpiFirmwareGetModelName (
>      return "Raspberry Pi Compute Modul= e 3+";
>    case 0x11:
>      return "Raspberry Pi 4 Model B&quo= t;;
> +  case 0x13:
> +    return "Raspberry Pi 400";
> +  case 0x14:
> +    return "Raspberry Pi Compute Module 4";=
>    default:
>      return "Unknown Raspberry Pi Model= ";
>    }
> @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily (
>        *ModelFamily =3D 3;
>        break;
>    case 0x11:       = ;   // Raspberry Pi 4 Model B
> +  case 0x13:        &nb= sp; // Raspberry Pi 400
> +  case 0x14:        &nb= sp; // Raspberry Pi Computer Module 4
>        *ModelFamily =3D 4;
>        break;
>    default:
> --
> 2.20.1
>




IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in any medium. Thank you. --_000_DB7PR08MB32601D7CDE83121EF98D4E7390FD0DB7PR08MB3260eurp_--