From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.87]) by mx.groups.io with SMTP id smtpd.web11.3024.1596539313549921506 for ; Tue, 04 Aug 2020 04:08:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=0/Bsb3X+; spf=pass (domain: arm.com, ip: 40.107.22.87, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yYd/GNlDDA2EKEWqlquGD+bRMyDWtUVMvZ97MJHwXeY=; b=0/Bsb3X+nQSnX6ylt+XsTBYgDlwHGbESzcXLufxTwlVLXOB36ledaJU48MkUeuwyZa9KKoD24OQJqaZCWlqAGsfmcGco8c7ZvzIpylPxgMnIaAcYw7P5WvixURblqK0vprBaE8JmCq6LOpCfdGspi6mnR3wwMhVA1kzbr1rivhQ= Received: from PR3P191CA0036.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::11) by VI1PR0801MB2094.eurprd08.prod.outlook.com (2603:10a6:800:8f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.21; Tue, 4 Aug 2020 11:08:30 +0000 Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:102:55:cafe::60) by PR3P191CA0036.outlook.office365.com (2603:10a6:102:55::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15 via Frontend Transport; Tue, 4 Aug 2020 11:08:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Tue, 4 Aug 2020 11:08:30 +0000 Received: ("Tessian outbound a0fc03de1592:v63"); Tue, 04 Aug 2020 11:08:30 +0000 X-CR-MTA-TID: 64aa7808 Received: from 2befc4f66de2.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5572530A-C0F2-4FFB-B740-22E0653B66C7.1; Tue, 04 Aug 2020 11:08:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2befc4f66de2.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Aug 2020 11:08:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L8kZUBiCkbChIsoNgjPwAchXHcGhrxqWg6hOIbdqtye1gn+HJSOehhZUI2XX4YJk7Wuq69m3ho5NQRpWuBqKpI+SiOS4Nbdz8RpzrDQT53U59Nn4aoIN8s8v/jf5gAMMKTDcQcsfGqWvYBTUCUMWP15ovWjR61RgH6IBnYaRGMAYA5yXg75faM98mQLHekSCHNZdha91OI2mSGMup6i+x1ZIKXJQENBGfBYTLloNUp3dqKi9yn79nFmugDshAT+vZpYtcZpkFSAdkefh5ckUwfXD68lICOMEBrH+PfsmIiSGMQ/9qEefo1YlMfyFbjwAc9wVp+153wLz/U/7SpzCdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yYd/GNlDDA2EKEWqlquGD+bRMyDWtUVMvZ97MJHwXeY=; b=NzAifly1TPYhsYs9Hcs9MCgMLaQPzRcFO0Lq/4jdiWo9Sb4lTPLBm85gEEu+yagdAFRSOVqDlsHoYP85QOkND8nfMdKZL/7Mb6/rxMQpdSeEIBzWIZIWMGNBQ4kOBYGEuPDnKgZ0baT7WttGtdWSUp6ieyOnvgyUyC8VBtQAGVmMC3RIfYArk0ImuPM65F1V5ZiW2zSlMpnIsNqRwUAZGH0KRUreWSD66puiosDYXe+vaTEwKzSe/xTAeMKLxaecWG/wKmS/m+N86e39vCF6pQbRnLc4Zh4NK4/QM8rJpKvGk+H1MhqyfAVZN6A892986bZ6S7ER7+8HpFTxDxmdcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yYd/GNlDDA2EKEWqlquGD+bRMyDWtUVMvZ97MJHwXeY=; b=0/Bsb3X+nQSnX6ylt+XsTBYgDlwHGbESzcXLufxTwlVLXOB36ledaJU48MkUeuwyZa9KKoD24OQJqaZCWlqAGsfmcGco8c7ZvzIpylPxgMnIaAcYw7P5WvixURblqK0vprBaE8JmCq6LOpCfdGspi6mnR3wwMhVA1kzbr1rivhQ= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DBAPR08MB5752.eurprd08.prod.outlook.com (2603:10a6:10:1ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15; Tue, 4 Aug 2020 11:08:21 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::88ec:d703:3e32:4c6b]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::88ec:d703:3e32:4c6b%5]) with mapi id 15.20.3239.021; Tue, 4 Aug 2020 11:08:20 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "xypron.glpk@gmx.de" CC: Eric Jin , Supreeth Venkatesh , Samer El-Haj-Mahmoud , G Edhaya Chandran Subject: Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: EFI_RNG_PROTOCOL.GetInfo check size != 0 Thread-Topic: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: EFI_RNG_PROTOCOL.GetInfo check size != 0 Thread-Index: AQHVvZS2ZiGR9ygNpkO9fJktEpNHSKkpI1sw Date: Tue, 4 Aug 2020 11:08:20 +0000 Message-ID: References: <20191228153710.46035-1-xypron.glpk@gmx.de> In-Reply-To: <20191228153710.46035-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: f4dc50a9-773b-4807-9a79-7e389090ed0c.0 x-checkrecipientchecked: true Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f118e65c-1e43-4598-7241-08d83866b87a x-ms-traffictypediagnostic: DBAPR08MB5752:|VI1PR0801MB2094: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1247;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qVyEANPKMkMfiC6ZcBj4FinIhGZzrY7qtVg80AUPCCqGzhvc+fjZx6B6EiCftAkATxSJ1zhc0oYDfp4U2/6RvaAqpFQGJKixJJlUPx30jBxH0n/jGBQe33si7SwvFfbTc482yp+saYmfZu3/i0/F4QF5rz04oM5H18vqpA2d+yYaFNW9Z80M23AQ7Azn6SbAORT8TBv9U+MWyN94cWbrynsVlfG72yZQorvbjjUgMLK8dsfsGQ0Z1ZR6Hj/4nBThYpHWNSCYNjYFg1FoO5UNWZlmjvWo/Qm46uOTMzTJRjUc47L+WUMZ8HJeJQk3cZWj4iNCebTkEADcEn0OHx8JlW7R8thT+ONPJCGGRT7kTgwfYuPvD/tVwJbFMIx7ldZqEUDH0GU8t1cwGOLVCjCv1w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(396003)(136003)(346002)(39860400002)(366004)(966005)(8936002)(7696005)(26005)(2906002)(5660300002)(76116006)(19627235002)(64756008)(66556008)(66946007)(66476007)(66446008)(478600001)(110136005)(52536014)(55016002)(33656002)(8676002)(186003)(9686003)(71200400001)(86362001)(53546011)(316002)(83380400001)(6506007)(4326008)(54906003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 0NiO7mOTCJO8KmkIPRdENEP3OSxxKcBzxIAZvfSRUO6So4lfCjP+s4TfVHRTLDm8dXNFMJaOe2T+Gh2mGpePyD785im8jaIQ3epBU+rNFYGEFcI8tIYTvELiIHstkWlP09L/J4EIJVGv2pH5Ms8to5riiOld4IIKqusRdIDfxSnSdTJRCMeKdYvqK48eI8jHH8XAFGbN2+yLG4LNPhHPamQZkzE6ekViVKINoOebWi+eWJkN1MYRtxtDy6RTg5roXxvj47fsiET3o0w7M/D5e3yRLsU219Cj3P1oMpsrpQ0hCFFBhUItcpU95JoWBWtd7W+Yo3o1qoXWZPI5vji3dxEyB/ElRLA/xBuUzCg9xxEgitpjsxDxKyDr/Ri3b9+dIw7gasgEqys8nI9AI7a7ioGtY4LCsVYOeBCrOZLQSVGipy972yI5nW/m6Igmxe3hlKqwOU78/6VRoUTdrgO2G6VI+W73We3/GDEPSBeoksLapJn2BsvrMulQBwPmkHDiyrHYkJWFYenMNbD1geagDhohrpjjy/LZNw/BeeisX0TM/ako9tq99ceDjuyEUNrg1eKVo1/aJUykbBLdKPdx3D7vZ1WSKeD+U5bEpKQ2i0/CwoUwtsqN0Thy+HUyI3iMZBtA6vnjWuM6uP0hHRN36Q== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5752 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 16f3f549-fda2-498e-e406-08d83866b2ba X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LMTJYzZ+4ierJKbtsUAaCqcyvsKdRyBbtjQqX6Fa+0/gt2PuZrjmA1B1E1O6DqBp/AMzjNSu23uOi8GFvlIbBxeO+Nnc55kImpXJ1qBwCP9puoGi2FrBmyT1dYCC4ItoVkh/5RxuShnxlU07u5qbZdFuXr31hJQ4978UFyGojvR48wRUmkRokFdMHg4BtN/EMJe7nasbra7vIwLqaC7qsvJWelMV8QqE0xAYBniSPcPbMjC5FusLWUSDg4VUKOJZLtHbYO39AOo5ywyxWrU8kAeusaYi7+CJVZZSLSlFn6VJAe3l0bbG0q8AEmWQ1VAY/I2fnXqRqvS/AHaLu2xIc2Go8XxWBStZMwqxVMYVQAGeFaKOZHESUXhIMcbg7a9j4NE4ojR1+iKycihFlzHI9FkZe158cb4SEIY1zHJBfPttmKJyQ4meXgR918j44y9IBP8aqfVi26wOl0axt9wZqiWBGLLauzyoOlZAgtY9Nq8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(376002)(136003)(39860400002)(346002)(396003)(46966005)(70586007)(966005)(70206006)(6506007)(53546011)(86362001)(36906005)(478600001)(186003)(356005)(336012)(55016002)(7696005)(26005)(19627235002)(316002)(82310400002)(9686003)(8936002)(2906002)(81166007)(82740400003)(8676002)(47076004)(52536014)(4326008)(54906003)(33656002)(5660300002)(110136005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2020 11:08:30.5188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f118e65c-1e43-4598-7241-08d83866b87a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2094 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Picking old SCT patches that were missed Reviewed-by: Samer El-Haj-Mahmoud > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via Groups.Io > Sent: Saturday, December 28, 2019 10:37 AM > To: EDK II Development > Cc: Eric Jin ; Supreeth Venkatesh > ; Heinrich Schuchardt > > Subject: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: > EFI_RNG_PROTOCOL.GetInfo check size !=3D 0 > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2438 > > The EFI_RNG_PROTOCOL conformance test checks that the size returned by > GetInfo() is a multiple of 16. This would be fulfilled by size =3D=3D 0. > > The UEFI specification requires that at least one algorithm is implemente= d. > So we should check that size is non-zero too. > > Signed-off-by: Heinrich Schuchardt > --- > .../RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | > 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand > omNumberBBTestConformance.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand > omNumberBBTestConformance.c > index f0a7c030..cd419d68 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand > omNumberBBTestConformance.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/Rand > omNumberBBTestConformance.c > @@ -169,7 +169,8 @@ BBTestGetInfoConformanceTestCheckpoint1 ( > return Status; > > } > > > > - if (EFI_BUFFER_TOO_SMALL =3D=3D Status && RNGAlgorithmListSize % > sizeof(EFI_RNG_ALGORITHM) =3D=3D 0) { > > + if (EFI_BUFFER_TOO_SMALL =3D=3D Status && RNGAlgorithmListSize && > > + RNGAlgorithmListSize % sizeof(EFI_RNG_ALGORITHM) =3D=3D 0) { > > AssertionType =3D EFI_TEST_ASSERTION_PASSED; > > } else { > > AssertionType =3D EFI_TEST_ASSERTION_FAILED; > > -- > 2.24.1 > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#52599): https://edk2.groups.io/g/devel/message/52599 > Mute This Topic: https://groups.io/mt/69304206/1945644 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj- > mahmoud@arm.com] > -=3D-=3D-=3D-=3D-=3D-=3D IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.