public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Grant Likely <Grant.Likely@arm.com>
Cc: nd <nd@arm.com>, G Edhaya Chandran <Edhaya.Chandran@arm.com>,
	Barton Gao <gaojie@byosoft.com.cn>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [edk2-devel] [edk2-sct PATCH] buildzip: Add CapsuleApp.efi to the SCT zip file
Date: Tue, 27 Apr 2021 16:20:41 +0000	[thread overview]
Message-ID: <DB7PR08MB32602DC88EE34658085437EA90419@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210427161529.4800-1-grant.likely@arm.com>

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Grant
> Likely via groups.io
> Sent: Tuesday, April 27, 2021 12:16 PM
> To: devel@edk2.groups.io
> Cc: nd <nd@arm.com>; Grant Likely <Grant.Likely@arm.com>; G Edhaya
> Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>
> Subject: [edk2-devel] [edk2-sct PATCH] buildzip: Add CapsuleApp.efi to the
> SCT zip file
> 
> CapsuleApp.efi is necessary for testing capsule updates of the firmware.
> Add it into the default build.
> 
> Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Signed-off-by: Grant Likely <grant.likely@arm.com>
> ---
>  uefi-sct/SctPkg/buildzip.sh | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg/buildzip.sh index
> 6dfb5aec..cdbe80d7 100755
> --- a/uefi-sct/SctPkg/buildzip.sh
> +++ b/uefi-sct/SctPkg/buildzip.sh
> @@ -39,8 +39,8 @@ NUM_CPUS=$((`getconf _NPROCESSORS_ONLN` + 2))
> 
>  make -j"$NUM_CPUS" -C edk2/BaseTools/
> 
> -# Build the SCT and the shell
> -DSC_EXTRA=ShellPkg/ShellPkg.dsc ./SctPkg/build.sh ${TARGET_ARCH} GCC
> RELEASE -j"$NUM_CPUS"
> +# Build the SCT, CapsuleApp.efi, and the shell
> +DSC_EXTRA="ShellPkg/ShellPkg.dsc MdeModulePkg/MdeModulePkg.dsc"
> ./SctPkg/build.sh ${TARGET_ARCH} GCC RELEASE -j"$NUM_CPUS"
> 
>  # Assemble all the files that need to be in the zip file  mkdir -p
> ${TARGET_ARCH}_SCT/EFI/BOOT @@ -50,6 +50,9 @@ mkdir -p
> ${TARGET_ARCH}_SCT/SCT  cp -r
> Build/UefiSct/RELEASE_GCC5/SctPackage${TARGET_ARCH}/${TARGET_ARCH
> }/* ${TARGET_ARCH}_SCT/SCT/  cp
> Build/UefiSct/RELEASE_GCC5/SctPackage${TARGET_ARCH}/SctStartup.nsh
> ${TARGET_ARCH}_SCT/Startup.nsh
> 
> +mkdir -p ${TARGET_ARCH}_SCT/Mde
> +cp Build/MdeModule/RELEASE_GCC5/${TARGET_ARCH}/CapsuleApp.efi
> +${TARGET_ARCH}_SCT/Mde
> +
>  # Copy the SCT Parser tool into the repo  cp sct_parser/*
> ${TARGET_ARCH}_SCT/SCT/Sequence/
> 
> --
> 2.20.1
> 
> 
> 
> 
> 


  reply	other threads:[~2021-04-27 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 16:15 [edk2-sct PATCH] buildzip: Add CapsuleApp.efi to the SCT zip file Grant Likely
2021-04-27 16:20 ` Samer El-Haj-Mahmoud [this message]
2021-04-30 16:06 ` G Edhaya Chandran
     [not found] ` <167AAE679A8A959E.18255@groups.io>
2021-05-08 15:36   ` [edk2-devel] " G Edhaya Chandran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR08MB32602DC88EE34658085437EA90419@DB7PR08MB3260.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox