From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.66]) by mx.groups.io with SMTP id smtpd.web08.13397.1605129453761136654 for ; Wed, 11 Nov 2020 13:17:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=cVErFmrL; spf=pass (domain: arm.com, ip: 40.107.22.66, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V/CD8+Gi7K5wnwX+cCXVniywbgpLaO/pZZ8v2ASpVM8=; b=cVErFmrLqjmwd22lTCCstiPo1RiyY1SzBPaXopDlU42zq2uaHDleM5wKwWQPP3JxNLEvK7QVoLBAHBqG6YkFc0bz7VJNx/jaBg5XU8BgWgnKG9yz8EnEbgc/fDWFPjxi+bvvoszGBh71d0tazrdmms95P4/djezY2FD1xuaOqlU= Received: from AM6P193CA0059.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::36) by PR3PR08MB5692.eurprd08.prod.outlook.com (2603:10a6:102:8a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.22; Wed, 11 Nov 2020 21:17:31 +0000 Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8e:cafe::35) by AM6P193CA0059.outlook.office365.com (2603:10a6:209:8e::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Wed, 11 Nov 2020 21:17:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22 via Frontend Transport; Wed, 11 Nov 2020 21:17:31 +0000 Received: ("Tessian outbound 797fb8e1da56:v71"); Wed, 11 Nov 2020 21:17:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1274e9e7ea7c3a23 X-CR-MTA-TID: 64aa7808 Received: from ab8dfcf460da.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 94F8BB98-60BB-48D3-A588-2C6559AA8570.1; Wed, 11 Nov 2020 21:17:24 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ab8dfcf460da.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Nov 2020 21:17:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mMJfS2ZRhN1BlsvOu01t3JRY/jZpVt/pDgOO/8iHm+llvpxzhKwmlP07TKYev6LrnLoDAhzmE/VdBTE1bwTU2cQt3Vj771Z2j3u0FbVwMk4zb2BVJExDODE+TqfFodL/W5LTxo10Exh2470ZpqmMk3O0IHAhZ9PgdHV3UfYs+ZtYID5ZmTcudlKka/gZahLIbUMwWXnupYKqMIBkGH2iBv2Q9bkGAffa9W0IdzTA/PTyXPSuyz/bt7tdRwxAc2bS+KGtkoTCXfhHa3iXEKNzvTW/zDt1kcjFXnEAV+lPD/sPdI9K5YFEBf2ql2IR+E8tAeFOThxHVO7fCudbfqUPgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V/CD8+Gi7K5wnwX+cCXVniywbgpLaO/pZZ8v2ASpVM8=; b=aypEZ4ohnwqOabwXf/+RRLPI3XJJ60COCczSb3Bh7O2wvDohwL7uRsUni/sG3Cb9masjeB/82zNVUw96U+7BgA6ye2/XKnV01Xr2oidVQCqDFKBAG89SZjjshscl0gK4nR9plev7fLuG/Cm+O/lviIQe/m4vYbNjM3wvoM5Gp7FJOBQ2tKSrjm7FuOPb20JMJVp7F3hsw2r2VveIO/p5H4B22gFxiMDLqZ9QAftGtnSXgPc4BgA3EPMVTwwgEIxsVnBPBW8lXfcNNhSGHdlaeOeX9mZR0Z/S/s2zvOL1UJLK1LW7oXSX8z/esmdnLCZmFx/VaXAnc8YKVfYSstKUqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V/CD8+Gi7K5wnwX+cCXVniywbgpLaO/pZZ8v2ASpVM8=; b=cVErFmrLqjmwd22lTCCstiPo1RiyY1SzBPaXopDlU42zq2uaHDleM5wKwWQPP3JxNLEvK7QVoLBAHBqG6YkFc0bz7VJNx/jaBg5XU8BgWgnKG9yz8EnEbgc/fDWFPjxi+bvvoszGBh71d0tazrdmms95P4/djezY2FD1xuaOqlU= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB6PR0802MB2165.eurprd08.prod.outlook.com (2603:10a6:4:86::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.25; Wed, 11 Nov 2020 21:17:21 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6%7]) with mapi id 15.20.3499.034; Wed, 11 Nov 2020 21:17:21 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "rebecca@nuviainc.com" CC: Eric Jin , G Edhaya Chandran , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh Thread-Topic: [edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some indentation issues in build.sh Thread-Index: AQHWkrsaFdwX+hYgiUOXbSzDZ8lOkKnDupOw Date: Wed, 11 Nov 2020 21:17:21 +0000 Message-ID: References: <20200924212131.22982-1-rebecca@nuviainc.com> <20200924212131.22982-3-rebecca@nuviainc.com> In-Reply-To: <20200924212131.22982-3-rebecca@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 71ca288c-3279-4384-2553-08d88687335a x-ms-traffictypediagnostic: DB6PR0802MB2165:|PR3PR08MB5692: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: o4T0rT1moxBls979nFzM6tvkCR5/C7Tgo8vojWNfihpAL2VE0rQaqCDteQhH/2dDLQDQ39YwhgZe2PQt22S7QUSZC+h46hrCb7sWghwL7JzluAiQhhivA+coz2RZsz5T38wcQl+YEzz/cnCVpyITAxHM1Fv/39g6ymiChoNVpEHRNWni3bwToQTWr16EV+yPuh6KVbtG9JAaMuFseQOdmUZLqG34bzho8zMuPwRQ3LomxA4kQgdxUtLAkxhFXoGXWLNdCfOzXAlOAV1jiPt/9B9/c+pLHT89+C8alcD6SwEmqkgdRSMJLjxBPSQ8EzPg/RYM1CPvm45fq9Oh6+JIlXd+fdHvBU7PcoLhiIiZRSwPPTW1rfTsaEaJz/QfV5F/AhkGot3PtXZj1xDTRt8iFg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39850400004)(396003)(366004)(346002)(376002)(54906003)(2906002)(76116006)(9686003)(71200400001)(55016002)(966005)(5660300002)(64756008)(478600001)(26005)(66446008)(186003)(52536014)(33656002)(53546011)(6506007)(8936002)(66556008)(4326008)(8676002)(83380400001)(66476007)(86362001)(7696005)(66946007)(316002)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: LyxHoDTZgnAUgJz0ORFmbGFP2myNQfhH5BqPkzMLAL09+U5gS3ZOpTkQpCTtyd+Fm1UdgOBG2NRStrf7kC6wEa7PPIsYSWkBaUe5QCY+soZGqI+jjjSFBBx8+7LdARzSzmBeT5rYUedHAbWjtZTiBf62ErWWbfoF+zGo030Qu5C69uDa/Dskv9ABEdFh8aMmDFJyCuyYB57ggYxZyqLtHkBwdGN9Uz3H1mqtqiUVMD6O5lr0mn/3yi0x1CEc1YaA8824F4S2ccXuFkRAALVI+u4B0u4zrwJn8n4ffHDdSJ0FDJ7laMVCcyXYavLpdICedbaJngNPB7MYKbe4RoJ2MmqorIN+fO0Jfc9LVVNWJdz0Dteb/sgV7SUttQzhd92he6CKo42d81ovyZ4UgKjwkgL0IIHmJgs0/RZbVzCAdHJsI+8uthIdRKKJJm7UcjnKvkYUye7aYuiuk1kfpiHdj/HHjBTGOUY0zI/yuF2wSYtOy9v2Y1yjsWnjiIdtjsGkxx2+ZZoupbTVdmzYcktycxFlV88bQAsEcLzbWWpML60Yp6LHh1YsuBXImd4kQAn/eY9jLwDu0paCFwScLlLpMxY7L5bzpY+sB0ulQM1rkxwY1G9S4iFUzVLehFVvEy0KU3pJHnw/OQ8aokFDLAJQpQ== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2165 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cbfb2837-47d2-484e-ef2f-08d886872d7f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 382DOXWx8npI6RaHXkoVpC7+mbenSxqn7h/jp1UONYjm9kaNb6Paqhs9uJnpN2TQfsvfe32DFP8LQqE4FWY3wHNRijVHni7jQnD7fq566MvAn8Xfau3hQXxDmpC4Twgx6j8/blAJ0sp0s0/U3xZvJii4FpUBhDjFN+eHldgmFSEbqbva5l64VmqRzNPj6OwQqR3eXNSylhA3daApjIQ9P4e9A6Azmy9ChlIkey0EyKV903EhztBTofaL3pGeUn/e6+Sv3u30frsgElfajHB/d77jC+tX4f6TmDFypw6KCboL6wjHx2OXwgi6JiV2TgW0C0+6ixhmfndsGLPm91NxrfGviWKu5ysp4FwLquRRicZcpqmexy7ppCBI9z6krP8MimxnC8nbGdwY5uyMA9Ral0v18UdhhMp8IPiv7lY9NAT3aKGCQipqQL0ZUrWkAO5WoYocyVwDWEvAPlh1i02KUqezxhHjzMuz/gzmP2VTOk8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(346002)(376002)(136003)(396003)(46966005)(8936002)(8676002)(81166007)(47076004)(5660300002)(83380400001)(70586007)(2906002)(70206006)(9686003)(55016002)(52536014)(186003)(316002)(110136005)(36906005)(356005)(86362001)(82310400003)(966005)(82740400003)(54906003)(478600001)(33656002)(336012)(6506007)(26005)(53546011)(4326008)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2020 21:17:31.2468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 71ca288c-3279-4384-2553-08d88687335a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5692 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Samer El-Haj-Mahmoud > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran via groups.io > Sent: Thursday, September 24, 2020 5:22 PM > To: devel@edk2.groups.io > Cc: Eric Jin ; G Edhaya Chandran > ; Samer El-Haj-Mahmoud Mahmoud@arm.com>; Rebecca Cran > Subject: [edk2-devel] [edk2-test] [PATCH 3/3] uefi-sct/SctPkg: Fix some > indentation issues in build.sh > > build.sh contains a mixture of tabs and spaces, with differing numbers of > spaces used for indents. Update it so any single block only uses one styl= e of > indentation. > > Signed-off-by: Rebecca Cran > --- > uefi-sct/SctPkg/build.sh | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index > be610deb..37667711 100755 > --- a/uefi-sct/SctPkg/build.sh > +++ b/uefi-sct/SctPkg/build.sh > @@ -56,9 +56,9 @@ function get_gcc_version { > gcc_version=3D$($1 -dumpversion) > > - if [ ${gcc_version%%.*} -gt 5 ]; then > - gcc_version=3D5 > - fi > +if [ ${gcc_version%%.*} -gt 5 ]; then > +gcc_version=3D5 > +fi > > case $gcc_version in > 4.6*|4.7*|4.8*|4.9*|5*) > @@ -152,10 +152,9 @@ case `uname` in > ;; > > GCC* | gcc*) > - set_cross_compile > - CROSS_COMPILE=3D"$TEMP_CROSS_COMPILE" > - export TARGET_TOOLS=3D`get_gcc_version "$CROSS_COMPILE"gcc` > - > +set_cross_compile > +CROSS_COMPILE=3D"$TEMP_CROSS_COMPILE" > +export TARGET_TOOLS=3D`get_gcc_version > "$CROSS_COMPILE"gcc` > ;; > > *) > @@ -224,7 +223,7 @@ then > status=3D$? > if test $status -ne 0 > then > - echo Error while building EDK tools > + echo Error while building EDK tools > exit -1 > fi > else > @@ -239,7 +238,7 @@ make -C SctPkg/Tools/Source/GenBin status=3D$? > if test $status -ne 0 > then > -echo Error while building GenBin > + echo Error while building GenBin > exit -1 > fi > > @@ -258,8 +257,8 @@ build -p SctPkg/UEFI/UEFI_SCT.dsc -a > $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_B status=3D$? > if test $status -ne 0 > then > -echo Could not build the UEFI SCT package > - exit -1 > + echo Could not build the UEFI SCT package exit -1 > fi > > build -p SctPkg/UEFI/IHV_SCT.dsc -a $SCT_TARGET_ARCH -t > $TARGET_TOOLS -b $SCT_BUILD $3 $4 $5 $6 $7 $8 $9 > @@ -268,8 +267,8 @@ build -p SctPkg/UEFI/IHV_SCT.dsc -a > $SCT_TARGET_ARCH -t $TARGET_TOOLS -b $SCT_BU > status=3D$? > if test $status -ne 0 > then > -echo Could not build the IHV SCT package > - exit -1 > + echo Could not build the IHV SCT package > + exit -1 > fi > > > @@ -299,8 +298,8 @@ pwd > status=3D$? > if test $status -ne 0 > then > -echo Could not generate UEFI SCT binary > - exit -1 > + echo Could not generate UEFI SCT binary > + exit -1 > else > echo The SCT binary "SctPackage${SCT_TARGET_ARCH}" is located at > "$EFI_SOURCE/Build/UefiSct/${SCT_BUILD}_${TARGET_TOOLS}" > fi > @@ -315,8 +314,8 @@ pwd > status=3D$? > if test $status -ne 0 > then > -echo Could not generate IHV SCT binary > - exit -1 > + echo Could not generate IHV SCT binary > + exit -1 > else > echo The IHV binary "SctPackage${SCT_TARGET_ARCH}" is located at > "$EFI_SOURCE/Build/IhvSct/${SCT_BUILD}_${TARGET_TOOLS}" > fi > -- > 2.26.2 > > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#65579): https://edk2.groups.io/g/devel/message/65579 > Mute This Topic: https://groups.io/mt/77067562/1945644 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj- > mahmoud@arm.com] > -=3D-=3D-=3D-=3D-=3D-=3D > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.