From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.45]) by mx.groups.io with SMTP id smtpd.web12.751.1610745055217863184 for ; Fri, 15 Jan 2021 13:10:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=zNGQH/9T; spf=pass (domain: arm.com, ip: 40.107.21.45, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKgrkvRUiZTkbMdCYzEK07dZyDCDKwIoZWwZaRcD+8k=; b=zNGQH/9THWX5ldFc9DgdwGFjHkPmgT5DHIzqaxtA4KWCdyYkAlBEKq6zdU7pBrruXtnxWGZHhKUa9QP+sOC5Mm9QwTVvxBn3PTx0eHLP0Su3eogTNIkatFmOPLAJ1EojqvShWrg1qDPxmO/37vYZnh/9oZYqdLQ/tg8HcHa4Kgw= Received: from DB7PR05CA0042.eurprd05.prod.outlook.com (2603:10a6:10:2e::19) by AM8PR08MB5858.eurprd08.prod.outlook.com (2603:10a6:20b:1dc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9; Fri, 15 Jan 2021 21:10:52 +0000 Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2e:cafe::d8) by DB7PR05CA0042.outlook.office365.com (2603:10a6:10:2e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9 via Frontend Transport; Fri, 15 Jan 2021 21:10:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.12 via Frontend Transport; Fri, 15 Jan 2021 21:10:52 +0000 Received: ("Tessian outbound 2b57fdd78668:v71"); Fri, 15 Jan 2021 21:10:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7dd2d96360e6ff10 X-CR-MTA-TID: 64aa7808 Received: from d1a1fd640dbe.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 300A5953-A4C0-438E-8FCC-8F0364ED92F4.1; Fri, 15 Jan 2021 21:10:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d1a1fd640dbe.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Jan 2021 21:10:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e7TQdEMc02TUJUhzzNsDx6pQ1SiCUvKh7hLkehrlqvI24PvpHEWD5Qk4vl2SALb2smz5NVF6c0oJq+LrAk361bb6UyL6FQKbgGSEpD6O1FBDoxVsY9UAHSrfU/m9GnUTFBqGVwuc4pJtFWiU7fjBtU1E+M3cRQ6nHMO6wQSHMRJZ7cM46l4rcu7GYhyotBvddUixWhE1F93+ub1DIEwBKSecr5TykICdWO5a2V4jAntg9mESjqyOlV6er9uCjuXTBsP//f7Tq792BygP+kBoP1JM/XagFmbTRgIeQ0QbUMDL00XqLbawjg/6JQzoRGsy9rzDHhCzapwp/mMzuQi8SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKgrkvRUiZTkbMdCYzEK07dZyDCDKwIoZWwZaRcD+8k=; b=aXAvcrcD7mQZKySRwpZy5G82KXZthYWAXyxb4bHxDK6LcxxBYJ9xa7KO9Z5qguupr16nQvymF3xkxeQ32JqGRms1RCq+uu4uPERtbEWm+nY6RqPZT2iyOikyKP43yLQTcNf2/4eYHEe2KStxRxMM2EyrmDfTHs5BzbhJe4tD1fZ5M0oDSaOz/iyirIIEzcwsECBzZL6D9TzIIJVabiydMP6hrAG8I6U/VjDypIObvlBLFD7ENEkizczF6EQ6qFTSuK5cnUwNWebxpyZrp3EemsHuAM1wDtfdAZvr2gxwrNq0gFF45rGCGqmQw5ZEC5ciYPc7GkpcPa/WJXaN+mMyZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wKgrkvRUiZTkbMdCYzEK07dZyDCDKwIoZWwZaRcD+8k=; b=zNGQH/9THWX5ldFc9DgdwGFjHkPmgT5DHIzqaxtA4KWCdyYkAlBEKq6zdU7pBrruXtnxWGZHhKUa9QP+sOC5Mm9QwTVvxBn3PTx0eHLP0Su3eogTNIkatFmOPLAJ1EojqvShWrg1qDPxmO/37vYZnh/9oZYqdLQ/tg8HcHa4Kgw= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB7PR08MB3259.eurprd08.prod.outlook.com (2603:10a6:5:1f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Fri, 15 Jan 2021 21:10:46 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::a1f1:ccfd:b17f:a490]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::a1f1:ccfd:b17f:a490%5]) with mapi id 15.20.3763.011; Fri, 15 Jan 2021 21:10:46 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "rebecca@nuviainc.com" CC: Leif Lindholm , Ard Biesheuvel , nd , Sami Mujawar , Liming Gao , Michael D Kinney , Zhiguang Liu Subject: Re: [edk2-devel] [PATCH v6 20/22] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32 Thread-Topic: [edk2-devel] [PATCH v6 20/22] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32 Thread-Index: AQHW6pT+b1d+xG3cg0eYpPl3YhWVLaopMJZw Date: Fri, 15 Jan 2021 21:10:45 +0000 Message-ID: References: <20210114163628.31952-1-rebecca@nuviainc.com> <20210114163628.31952-21-rebecca@nuviainc.com> In-Reply-To: <20210114163628.31952-21-rebecca@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 59192ae5-d149-4018-77a9-08d8b99a0a78 x-ms-traffictypediagnostic: DB7PR08MB3259:|AM8PR08MB5858: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:569;OLM:569; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: miEFsp+d9vA5XdWAZLsU0TnL88AeaVDf2RlMAtR/jtkj6xnuRMHmIoxC1P75Ju3rgGOnapXhqTQ4IaqRX22gNQnZ2p9loF64exa+WXMDZ4fa2h3MwU49CDzCSk+X/OkJNWm6x835K21l9yAspha2sJlHucK8PrBWnjkwcWtqN6BvheGGvMw789KR8iPiYei9pIo+JJe/DFOaHg0Rs+koXoxgGI/4jOEerS1a6xnR8JUdwbIGVidzDGvas9aNSrwf41w+XfpVZrLM9EX4Qa76M0sU9YeZadRJ+V6A9NXsW7flEzBVYCAEEn0AcdP4i3yTX/4oMmmo3h6+DeQWfnUyqw9PTlRV32WUB1GH5GdFmVWMJn5pTUpDGeEIkUSC9ZfkoVi4PQDfeFgN1R5TyVbm+NoxVoIqwdxY0qK4+F7lLXDYnTxtUGNDe1z/L0LOrr2tESLCwqFS3iF6CDests0CPg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(39860400002)(366004)(376002)(966005)(8936002)(4326008)(86362001)(71200400001)(55016002)(83380400001)(66556008)(478600001)(52536014)(7696005)(19627235002)(8676002)(5660300002)(2906002)(33656002)(54906003)(26005)(6506007)(53546011)(186003)(64756008)(110136005)(66476007)(9686003)(66446008)(316002)(76116006)(66946007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?faHl9k1Edh7AM5P8maX2twOkPncsL6P8CcU39hD6iEZ6ybykmd5/UHy/2pTY?= =?us-ascii?Q?R4YWuXiqQkmOxj7OTCsY8sw2GGdYkO8GBAKfIBFWdVqBYS+XFTVA7xyOce+g?= =?us-ascii?Q?m2WjkW7S6V2sDBKwJ0w5ERHhHKC0uPXMYCmiao2UUUzcuiTy31BvpsbQ5+3B?= =?us-ascii?Q?gFZ6+iZmXNV3zsZXFX4BiTHO9Ij38KHGG8I8zGH+mWdFgKwJT5pZ0vNWK1Qk?= =?us-ascii?Q?il9ROx2T+896toyZD6NGI4xOfNcB2umzkI1zoXhb7FIpofXkbHR9bUr1Cdjn?= =?us-ascii?Q?pm/y8nmwpaGiZQqXfo0Fm48vwxjm5ZEHF0iWLb8RGtuyWXGJAlc2f9+nMLJd?= =?us-ascii?Q?AyZ6chn10jkGLkmbDTJRniFRKVP7nE8rOJPeueb7uhjHtGi/tmTv4pJoxb7S?= =?us-ascii?Q?+gooJE2H6ieygjPoDqlbjO1gKSSKlYN00uxml3k9kP0cHPFsTG6TiteDdFc5?= =?us-ascii?Q?KW7JOCLZXGu5j592yxlJNVIDBNVXm7+JuNwH5nMRcsNQCe8fH/rnznzF1D/1?= =?us-ascii?Q?xgOQVOhB92WFXl+dB9Wxs3mlgknJTlYOQDMq98xsJ9DjoEreoYpcNqQLMeku?= =?us-ascii?Q?cFvhiVf9+oMHN6jL5R8nwuvvOh2KmyS/izmSWVsTgldofPlTsPS4YaFjegrw?= =?us-ascii?Q?Wue3BXl5cASRDgAAf9TNBaaTdkJnOjSHDptBkHeHRAWfupn6eAKxnLcN0Ui3?= =?us-ascii?Q?rxAYfLHiQC9U7ceREKB9wIyVXwazE1MpbbExgNuVLtbE/rgABcSwzP3SDjiq?= =?us-ascii?Q?qCGrvWwLHe3sMqaJxWTgGpiKHymMNH6WWMy0cP1mC5dFdkHCYmbyjMUn2K9g?= =?us-ascii?Q?zFyYLJeM/AAR60CgxqLFGSbORZoVPjZmO32EAPcTVavHMZmB9YHPCnLJRQVM?= =?us-ascii?Q?0OM7pSLt1Y8G5fOZxiwlNvcLpnI9gJKIQ5MjNGm3PnVCMqVkyjUWUFmW9pLy?= =?us-ascii?Q?ZUm7YoHyhMcdHyWbw7hma3iFjYTeuSrbwlINSBjnNTA=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3259 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e39eb82c-0da8-486f-b286-08d8b99a06a1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3yK61mpQUbqh4PK9o5SJYa+H3Sil4E2trET7eaKC8wSeMWPghJ+FEgS5xUlZ3zo7KBK+Ed+pq+VYzJC2xksx8ncu87wp1RUR+83F7lwrYXy28D1VogGn57zH7qOQ5PPvTGqJp8XEVa0YA3oSlcw+cigHSGmU45MLuy2gUqXo1uUsh0IIx4RThMfsgI63fzaP/g1u9OkupXpz/Lr4jQyb3teenaL4u/LXiZVz7eck9183JlHIHm5YdyFnCmjmwWNUcqyDGzTvSy8JJAiFIzrbOFt1AMPV6Ao2+AcYegPD4KCBxFRnkZSSYrkoBBZYDSYfvehb3jtuqGKSdkIYAjy802TdPjzO4WRyxfYgNyhulGYQNTOkrEdDDlm30Zf6a1SoOHFh8KUw3AaQKzSTp7oSa/jqKww4ZV3+PbtwWAY6R/AgnKrb/3Gmg2kIXbOMDcNUUPyPHHQsKGorCBtSzEauSEuaatoxyY5pqv4x62ZDvygOmh9RsTB4sia4S8B10S2VhmDNuluVLoIye98xIgqXiZBvuVHNwA8M2jDj8ymwzV5UD3tpl7S7kOwLZtDgGylP X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39860400002)(396003)(376002)(346002)(46966006)(8936002)(478600001)(336012)(26005)(86362001)(52536014)(53546011)(6506007)(316002)(186003)(107886003)(966005)(33656002)(7696005)(70206006)(70586007)(81166007)(34020700004)(5660300002)(110136005)(54906003)(19627235002)(356005)(2906002)(9686003)(8676002)(55016002)(47076005)(82310400003)(83380400001)(82740400003)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2021 21:10:52.4624 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59192ae5-d149-4018-77a9-08d8b99a0a78 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5858 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Samer El-Haj-Mahmoud > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran via groups.io > Sent: Thursday, January 14, 2021 11:36 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Leif Lindholm > ; Ard Biesheuvel ; nd > ; Sami Mujawar ; Liming Gao > ; Michael D Kinney > ; Zhiguang Liu > Subject: [edk2-devel] [PATCH v6 20/22] ArmPkg: Add > Universal/Smbios/SmbiosMiscDxe/Type32 >=20 > This code provides information for the SMBIOS Type 32 table. >=20 > Signed-off-by: Rebecca Cran > --- >=20 > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationDat > a.c | 32 +++++++++ >=20 > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFu > nction.c | 73 ++++++++++++++++++++ > 2 files changed, 105 insertions(+) >=20 > diff --git > a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformation > Data.c > b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformation > Data.c > new file mode 100644 > index 000000000000..ebe4ad941c5f > --- /dev/null > +++ > b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformation > Da > +++ ta.c > @@ -0,0 +1,32 @@ > +/** @file > + Based on files under Nt32Pkg/MiscSubClassPlatformDxe/ > + > + Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright > + (c) 2006 - 2009, Intel Corporation. All rights reserved.
> + Copyright (c) 2015, Hisilicon Limited. All rights reserved.
> + Copyright (c) 2015, Linaro Limited. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include "SmbiosMisc.h" > + > +// > +// Static (possibly build generated) Bios Vendor data. > +// > +SMBIOS_MISC_TABLE_DATA(SMBIOS_TABLE_TYPE32, > MiscBootInformation) =3D { > + { // Hdr > + EFI_SMBIOS_TYPE_SYSTEM_BOOT_INFORMATION, // Type, > + 0, // Length, > + 0 // Handle > + }, > + { // Reserved[6] > + 0, > + 0, > + 0, > + 0, > + 0, > + 0 > + }, > + BootInformationStatusNoError // BootInformat= ionStatus > +}; > diff --git > a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationF > unction.c > b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationF > unction.c > new file mode 100644 > index 000000000000..733615bbcf1a > --- /dev/null > +++ > b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationF > u > +++ nction.c > @@ -0,0 +1,73 @@ > +/** @file > + boot information boot time changes. > + SMBIOS type 32. > + > + Based on files under Nt32Pkg/MiscSubClassPlatformDxe/ > + > + Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright > + (c) 2009 - 2011, Intel Corporation. All rights reserved.
> + Copyright (c) 2015, Hisilicon Limited. All rights reserved.
> + Copyright (c) 2015, Linaro Limited. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > +#include #include > + > + > +#include "SmbiosMisc.h" > + > +/** > + This function makes boot time changes to the contents of the > + MiscBootInformation (Type 32) record. > + > + @param RecordData Pointer to SMBIOS table with defau= lt values. > + @param Smbios SMBIOS protocol. > + > + @retval EFI_SUCCESS The SMBIOS table was successfully = added. > + @retval EFI_INVALID_PARAMETER Invalid parameter was found. > + @retval EFI_OUT_OF_RESOURCES Failed to allocate required memory= . > + > +**/ > +SMBIOS_MISC_TABLE_FUNCTION(MiscBootInformation) > +{ > + EFI_STATUS Status; > + SMBIOS_TABLE_TYPE32 *SmbiosRecord; > + SMBIOS_TABLE_TYPE32 *InputData; > + > + // > + // First check for invalid parameters. > + // > + if (RecordData =3D=3D NULL) { > + return EFI_INVALID_PARAMETER; > + } > + > + InputData =3D (SMBIOS_TABLE_TYPE32 *)RecordData; > + > + // > + // Two zeros following the last string. > + // > + SmbiosRecord =3D AllocateZeroPool (sizeof (SMBIOS_TABLE_TYPE32) + 1 + > + 1); if (SmbiosRecord =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + > + (VOID)CopyMem (SmbiosRecord, InputData, sizeof > + (SMBIOS_TABLE_TYPE32)); > + > + SmbiosRecord->Hdr.Length =3D sizeof (SMBIOS_TABLE_TYPE32); > + > + // > + // Now we have got the full smbios record, call smbios protocol to ad= d this > record. > + // > + Status =3D SmbiosMiscAddRecord ((UINT8*)SmbiosRecord, NULL); if > + (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "[%a]:[%dL] Smbios Type32 Table Log Failed! %r > \n", > + __FUNCTION__, __LINE__, Status)); } > + > + FreePool (SmbiosRecord); > + return Status; > +} > -- > 2.26.2 >=20 >=20 >=20 >=20 >=20