public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"rebecca@nuviainc.com" <rebecca@nuviainc.com>
Cc: "ray.ni@intel.com" <ray.ni@intel.com>,
	"zhichao.gao@intel.com" <zhichao.gao@intel.com>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview
Date: Tue, 20 Oct 2020 17:27:32 +0000	[thread overview]
Message-ID: <DB7PR08MB32605485A0C12B9EC46760F7901F0@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201020161643.20293-1-rebecca@nuviainc.com>

Reviewed-By:  Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Tuesday, October 20, 2020 12:17 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; ray.ni@intel.com;
> zhichao.gao@intel.com
> Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Fix a couple of typos in
> smbiosview
>
> Fix a couple of typos in SmbiosViewStrings.uni:
> "Boot form CD" should be "Boot from CD", and "plugged from the wall"
> should be "plugged into the wall".
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  .../SmbiosView/SmbiosViewStrings.uni                          | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView
> Strings.uni
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView
> Strings.uni
> index 7fbcc9a31afb..4160ca40a988 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView
> Strings.uni
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosView
> Strings.uni
> @@ -128,7 +128,7 @@
>  #string STR_SMBIOSVIEW_PRINTINFO_BIOS_SHADOWING
> #language en-US "BIOS shadowing is allowed\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_VESA_SUPPORTED
> #language en-US "VL-VESA is supported\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_ECSD_SUPPORT                   #language
> en-US "ESCD support is available\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED
> #language en-US "Boot form CD is supported\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_BOOT_FORM_CD_SUPPORTED
> #language en-US "Boot from CD is supported\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_SELECTED_BOOT_SUPPORTED
> #language en-US "Selectable Boot is supported\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_BIOS_ROM_SOCKETED
> #language en-US "BIOS ROM is socketed\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD
> #language en-US "Boot From PC Card(PCMCIA)is supported\r\n"
> @@ -373,7 +373,7 @@
>  #string STR_SMBIOSVIEW_PRINTINFO_NOT_APPLICABLE                 #language
> en-US " Not applicable\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_RESERVED_3                     #language
> en-US " Reserved  \r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_UNPLUGGED
> #language en-US "Power supply is unplugged from the wall\r\n"
> -#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED
> #language en-US "Power supply is plugged from the wall\r\n"
> +#string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PLUGGED
> #language en-US "Power supply is plugged into the wall\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_PRESENT
> #language en-US "Power supply is present\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_NOT_PRESENT
> #language en-US "Power supply is not present\r\n"
>  #string STR_SMBIOSVIEW_PRINTINFO_POWER_SUPPLY_REPLACE
> #language en-US "Power supply is hot replaceable\r\n"
> --
> 2.26.2
>
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2020-10-20 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 16:16 [PATCH 1/1] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-20 17:27 ` Samer El-Haj-Mahmoud [this message]
2020-10-21  1:33 ` Gao, Zhichao
2020-10-21  4:07   ` [EXTERNAL] " Rebecca Cran
2020-10-22  2:57     ` Gao, Zhichao
2020-10-21 20:51 ` Rebecca Cran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR08MB32605485A0C12B9EC46760F7901F0@DB7PR08MB3260.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox