From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.62]) by mx.groups.io with SMTP id smtpd.web11.13279.1605127815015910271 for ; Wed, 11 Nov 2020 12:50:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=j+Fz0F17; spf=pass (domain: arm.com, ip: 40.107.2.62, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JjcTZ00BJoRUZ0qhA6PuaIbB/NRHue5zeWZWjPj95G0=; b=j+Fz0F171c2WLBOb2RSBodJHvaYz6YfkrYhF94JgmQ9eArXy+gdk1H606Lu9phc7i8G+Qli6XmvajZtTmK9PaExxMgqrZEfFMWpjYD50DLJX/Jn6NRDzXG5w5wW9SlxWyVQCGCsaVsdRKtaKzrkoEYD27d/dR6yKt5FLBSKGYhY= Received: from AM6PR10CA0095.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::36) by VI1PR0801MB1887.eurprd08.prod.outlook.com (2603:10a6:800:85::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.24; Wed, 11 Nov 2020 20:50:11 +0000 Received: from AM5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::78) by AM6PR10CA0095.outlook.office365.com (2603:10a6:209:8c::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Wed, 11 Nov 2020 20:50:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT006.mail.protection.outlook.com (10.152.16.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22 via Frontend Transport; Wed, 11 Nov 2020 20:50:11 +0000 Received: ("Tessian outbound 797fb8e1da56:v71"); Wed, 11 Nov 2020 20:50:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 41d2ef2674c043ae X-CR-MTA-TID: 64aa7808 Received: from d7c62120b470.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9475E822-1ACD-4349-A5F0-FAABAC634E80.1; Wed, 11 Nov 2020 20:50:04 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d7c62120b470.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Nov 2020 20:50:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BM1q7zaSMg8VnAyZAqdDdB/Sc/6w4aQ9eMI2IsyoKMj28ap6pmnNkj2oZvDNgY+w7v9QxPgQbNIc7kYPIaI8vZn2WlufcOer7zOU0cwKG6IIcIAAToC7fVPk2pW1jxkj9mGXEthtqd8s9kL+bEGZno60L8FkjYBTfTK3Hq4fN20q2vKFnHjHYTgpjXwBV1NyzKUIM59URphW6CkIfTmsUWwKlz7kXb91p6+kJik/tdTslCLRVuicukYWFitkjdxnFXtWcSxpSGjYI9OCAGCt7TX7gQJA/izFLDkTpbdLMXzqp6MK0F4PBn69c59TrbOLE2jVUMSEW8uIKVlwGn0Kwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JjcTZ00BJoRUZ0qhA6PuaIbB/NRHue5zeWZWjPj95G0=; b=PjbsqPZgeqEhsMeWm39DRpUp9KOjDDTmajllFVN5jKlD1mqnI1IELgqigmAzbT9Kv1QMoo7GNG8tmTwUYDDkt2PkZWU2xipg6RPlygOHcKGRtWRE/Yd0JzQPbpb7gK8ozwZ/zX1p7pDRcX81uOBwauUKIqjErwsbd1eHynwfLL9+sZWeMjTIjTIGxGEy3AhjZ8eKisI93qNidQVUBL/pbwh2mvsaictPqdCUYB8UoPd074lgICE7hV89MuUvkpb1QNsk2jPVw5GgGXowvbIu71jFpnlzBiKm6klOw5BN9YbjjNGt+Ww3ehBOsmdbLOlh+Q1wvxh19N0/k3wCPFrj2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JjcTZ00BJoRUZ0qhA6PuaIbB/NRHue5zeWZWjPj95G0=; b=j+Fz0F171c2WLBOb2RSBodJHvaYz6YfkrYhF94JgmQ9eArXy+gdk1H606Lu9phc7i8G+Qli6XmvajZtTmK9PaExxMgqrZEfFMWpjYD50DLJX/Jn6NRDzXG5w5wW9SlxWyVQCGCsaVsdRKtaKzrkoEYD27d/dR6yKt5FLBSKGYhY= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DBAPR08MB5798.eurprd08.prod.outlook.com (2603:10a6:10:1a6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Wed, 11 Nov 2020 20:50:01 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6%7]) with mapi id 15.20.3499.034; Wed, 11 Nov 2020 20:50:01 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "arvinx.chen@intel.com" CC: G Edhaya Chandran , Eric Jin , Wei6 Xu , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: Correct check image test behavior Thread-Topic: [edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: Correct check image test behavior Thread-Index: AQHWsP8GfGic8NOnEU+ue4zhix8x4KnDdhiA Date: Wed, 11 Nov 2020 20:50:00 +0000 Message-ID: References: <20201102095933.715-1-arvinx.chen@intel.com> In-Reply-To: <20201102095933.715-1-arvinx.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9a42e5b4-167b-422d-29f0-08d8868361bc x-ms-traffictypediagnostic: DBAPR08MB5798:|VI1PR0801MB1887: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4303;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TpaWeTNijFPObMogvDf1qOu4SzxWjikdL1zlPTZPubiSmg/ntJ42O0AidbzEYVq6mKMOG+zm1UsYLWzrJKG04dbZra9w/nIYAGqOQrn3u28tErCBnDnSt/NXLeTP/Bc2lKR6f7UQZfp822CVkC/+H50uSnoNsrZTTueduPCVxTjqh0F4hBV001iA09glB11vi5O6EFW979ZmN1GI5KDKM2ZMdWQcNstFQS+9eXNPcsVA10Glv2Y+LZ9TQa1k864fpROsC/QNpgojPjj6r3qnzQvLOo24RcF0x0qXAbNVUSioDRkidf56jZZv64oNQB+aTfj+DosVUPgg7tOZLrNdCJC3Cm+ZpJ07p1RJU2lZrknDOE0Cd1IwVpLt47+Galpy2bUAAnOeAQmzGWCKyfkrNg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(396003)(366004)(376002)(136003)(346002)(19627235002)(66476007)(66556008)(8676002)(76116006)(53546011)(6506007)(66946007)(86362001)(8936002)(186003)(71200400001)(5660300002)(9686003)(7696005)(4326008)(26005)(55016002)(52536014)(54906003)(110136005)(33656002)(64756008)(316002)(2906002)(966005)(83380400001)(478600001)(66446008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: Zdfbll6l72B0poJNQge7IVSq6LvwDU9xlcaWrXhAJmszQpo4izGZg+wHjg6Fs1BDMsqI5K+42Ii07//6Sb61K8cVAmU+/4l0Z1LiFUatrYgBoD1+cMwEFRh0w4eJfrZT7hXoP5EGT9/6Ku+0AEPLMeWuxUZhhbqx8dPQpK5Nee+3TFtkVY9OH7xt4yPFhY2aErHOEQIdDeXn+sr+Tgc8bac4XRmBWZWVS85tsJhDkfBSjf8wx5SwXycJby+Wd+atLvopmQLyPfsqlL3AXKA9eM/gsrG9FgG9FiK+bU/keUy5mJRrfmmu4m+S5fj+0HB6EYyq5gPW7q6AcUBjVE304u+M+q/XjpjhY6Wm/3vAJ8PTUhvE5tDI8s7IBKZld74VRpbxNuDUPL/FG1N6Xw7Bm8JAKl0tY5TDzEuERfmtX0ZHz6kpvQ7DnPgNnfWugGF97JZCRw7Gpq3laqBqaoJKy2JrnxUOwmunKY+oLYyCtB39lRZWd61nFZGmjdcp2J7NH3tVYqTPzZItbdaUmhzqudnaQh4xrcWxDBOXAOv1S4Oyakn9UZytQfUhJ89G/DVLGSIXk25Y2su8XtwtVAzwc4k+j9m5NA3HdTZk4obJwmrOI6dvqWD5puVm7IBj1Lawm6t8rdzzmKQoBL4XJ4ZSoQ== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5798 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8926f4d3-f72e-4263-ded5-08d886835bd9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ymN2GVAlMM9HBSxtTk5LqAMSHZzqmEQk+9HzrmooO6Dl8E0/0X60AXhK9dx5t664kSENMmRyMgMud1M+th5owr9ZKm3jXdf3fgGQ94akfygkWuFlNmyZibXshS+lsa4J+Ah8cEQ8+JgAYI46xwqTcfTg/WUKpDn1HiIhj9THpFoEBr1CTPCydRZtfbTEEYsOQ+e2bzbH9kjuobcJgWr/ogn4kDJAkXfkJGm2/bp+6nCX1V9CnXoi/uR92ZgBantUFOCPh1uCcciBo3DfAROOZoiWdWHj1JYzUW9fG051zFql0Nx7XMLxAQOKqbFR8XFjqZGHyy88jDOahJ6GhIlKepvqOGAPl1yhhQaCSQ2/1/FA0kUvlBO++SeNnM7v678tp7/GdWcsaBEpwZfsA4xpmyQyMKdHP1oN+FAU7gXReQyGgZryw2IZQ31wtmcuGKpNKq0Uxnqb6H5vIOwAsvgOQTvW/beBwQjgxcBZ49flgAA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39850400004)(396003)(346002)(136003)(46966005)(8676002)(33656002)(4326008)(336012)(83380400001)(110136005)(53546011)(86362001)(6506007)(36906005)(2906002)(70206006)(7696005)(316002)(966005)(55016002)(186003)(478600001)(19627235002)(26005)(82310400003)(82740400003)(9686003)(70586007)(47076004)(52536014)(8936002)(81166007)(54906003)(356005)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2020 20:50:11.0934 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a42e5b4-167b-422d-29f0-08d8868361bc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1887 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Samer El-Haj-Mahmoud > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chen, > ArvinX via groups.io > Sent: Monday, November 2, 2020 5:00 AM > To: devel@edk2.groups.io > Cc: G Edhaya Chandran ; Eric Jin > ; Wei6 Xu > Subject: [edk2-devel] [PATCH 2/2] uefi-sct/SctPkg: Correct check image te= st > behavior > > Now, in our SCT test case "CheckImage" behavior have some problems.Once > > tool need to check the "EFI_SECURITY_VIOLATION" have correct return from > > "EFI_FIRMWARE_MANAGEMENT_PROTOCOL->CheckImage" function, the > function wil > > because tool behavior probability return EFI_BUFFER_TOO_SMALL,so we > should > > gave it a correct header info to make the test item can process correctly= . > > > > Cc: ArvinX Chen > > Cc: G Edhaya Chandran > > Cc: Eric Jin > > Cc: Wei6 Xu > > Signed-off-by: ArvinX Chen > > --- > > .../FirmwareManagementBBTestConformance.c | 11 ++++++++- > > .../FirmwareManagement/BlackBoxTest/Guid.c | 1 + > > .../FirmwareManagement/BlackBoxTest/Guid.h | 5 ++++ > > .../SctPkg/UEFI/Protocol/FirmwareManagement.h | 23 > +++++++++++++++++++ > > 4 files changed, 39 insertions(+), 1 deletion(-) > > > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/FirmwareManagementBBTestConformance.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/FirmwareManagementBBTestConformance.c > > index 720326d0..7c6c709b 100644 > > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/FirmwareManagementBBTestConformance.c > > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/FirmwareManagementBBTestConformance.c > > @@ -2901,7 +2901,8 @@ BBTestCheckImageConformanceTestCheckpoint2 ( > > UINTN i; > > EFI_FIRMWARE_IMAGE_DESCRIPTOR *p; > > UINTN FunctionTested; > > - > > + EFI_FIRMWARE_IMAGE_AUTHENTICATION *EFIA; > > + EFI_GUID gEfiCertPkcs7Guid; > > // > > // Init > > // > > @@ -2909,6 +2910,7 @@ BBTestCheckImageConformanceTestCheckpoint2 ( > > Status =3D EFI_SUCCESS; > > AssertionType =3D EFI_TEST_ASSERTION_PASSED; > > TestGuid =3D gFirmwareManagementBBTestConformanceAssertionGuid012; > > + gEfiCertPkcs7Guid =3D > gFirmwareManagementBBTestConformanceSupportGuid005; > > ResultMessageLabel =3D L"CheckImage, conformance checkpoint #2"; > > > > BufferImageInfo =3D NULL; > > @@ -3020,6 +3022,13 @@ BBTestCheckImageConformanceTestCheckpoint2 > ( > > ResultMessageData =3D L"test case initialization failure."; > > goto Exit; > > } > > + > > + EFIA =3D Image; > > + EFIA->AuthInfo.Hdr.dwLength =3D > sizeof(WIN_CERTIFICATE_UEFI_GUID)+0x10; > > + EFIA->AuthInfo.Hdr.wRevision =3D 0x0200; > > + EFIA->AuthInfo.Hdr.wCertificateType =3D WIN_CERT_TYPE_EFI_GUID; > > + for (i=3D0; i >AuthInfo.CertType)[i]=3D((UINT8*)&gEfiCertPkcs7Guid)[i], i++); > > + > > BufferImage =3D Image; > > FunctionTested++; > > Status =3D FirmwareManagement->CheckImage ( > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/Guid.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/Guid.c > > index 91cf1ba6..cd541496 100644 > > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/Guid.c > > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/Guid.c > > @@ -43,6 +43,7 @@ EFI_GUID > gFirmwareManagementBBTestConformanceSupportGuid001=3DEFI_TEST_FIR > MWAREMAN > > EFI_GUID > gFirmwareManagementBBTestConformanceSupportGuid002=3DEFI_TEST_FIR > MWAREMANAGEMENTBBTESTCONFORMANCE_SUPPORT_002_GUID; > > EFI_GUID > gFirmwareManagementBBTestConformanceSupportGuid003=3DEFI_TEST_FIR > MWAREMANAGEMENTBBTESTCONFORMANCE_SUPPORT_003_GUID; > > EFI_GUID > gFirmwareManagementBBTestConformanceSupportGuid004=3DEFI_TEST_FIR > MWAREMANAGEMENTBBTESTCONFORMANCE_SUPPORT_004_GUID; > > +EFI_GUID > gFirmwareManagementBBTestConformanceSupportGuid005=3DEFI_TEST_FIR > MWAREMANAGEMENTBBTESTCONFORMANCE_SUPPORT_005_GUID; > > > > EFI_GUID > gFirmwareManagementBBTestConformanceAssertionGuid001=3DEFI_TEST_FIR > MWAREMANAGEMENTBBTESTCONFORMANCE_ASSERTION_001_GUID; > > EFI_GUID > gFirmwareManagementBBTestConformanceAssertionGuid002=3DEFI_TEST_FIR > MWAREMANAGEMENTBBTESTCONFORMANCE_ASSERTION_002_GUID; > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/Guid.h b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/Guid.h > > index b5277f7e..b045021e 100644 > > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/Guid.h > > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/FirmwareManagement/BlackBoxTes > t/Guid.h > > @@ -67,6 +67,11 @@ extern EFI_GUID > gFirmwareManagementBBTestConformanceSupportGuid003; > > > > extern EFI_GUID > gFirmwareManagementBBTestConformanceSupportGuid004; > > > > +#define > EFI_TEST_FIRMWAREMANAGEMENTBBTESTCONFORMANCE_SUPPORT_005 > _GUID \ > > +{ 0x4aafd29d, 0x68df, 0x49ee, {0x8a, 0xa9, 0x34, 0x7d, 0x37, 0x56, 0x65, > 0xa7 }} > > + > > +extern EFI_GUID > gFirmwareManagementBBTestConformanceSupportGuid005; > > + > > // > ********************************************************** > ****************** > > // Conformance - Assertion > > // > ********************************************************** > ****************** > > diff --git a/uefi-sct/SctPkg/UEFI/Protocol/FirmwareManagement.h b/uefi- > sct/SctPkg/UEFI/Protocol/FirmwareManagement.h > > index b8876a96..c35ed3f4 100644 > > --- a/uefi-sct/SctPkg/UEFI/Protocol/FirmwareManagement.h > > +++ b/uefi-sct/SctPkg/UEFI/Protocol/FirmwareManagement.h > > @@ -58,6 +58,22 @@ UINT64 AttributesSetting; > > UINT64 Compatibilities; > > } EFI_FIRMWARE_IMAGE_DESCRIPTOR; > > > > +typedef struct { > > + /// > > + /// It is included in the signature of AuthInfo. It is used to ensure > freshness/no replay. > > + /// It is incremented during each firmware image operation. > > + /// > > + UINT64 MonotonicCount; > > + /// > > + /// Provides the authorization for the firmware image operations. It i= s a > signature across > > + /// the image data and the Monotonic Count value. Caller uses the priv= ate > key that is > > + /// associated with a public key that has been provisioned via the key > exchange. > > + /// Because this is defined as a signature, > WIN_CERTIFICATE_UEFI_GUID.CertType must > > + /// be EFI_CERT_TYPE_PKCS7_GUID. > > + /// > > + WIN_CERTIFICATE_UEFI_GUID AuthInfo; > > +} EFI_FIRMWARE_IMAGE_AUTHENTICATION; > > + > > // > > // Image Attribute Definitions > > // > > @@ -79,6 +95,13 @@ UINT64 Compatibilities; > > > > #define EFI_FIRMWARE_IMAGE_DESCRIPTOR_VERSION 1 > > > > +// > > +// _WIN_CERTIFICATE.wCertificateType > > +// > > +#define WIN_CERT_TYPE_PKCS_SIGNED_DATA 0x0002 > > +#define WIN_CERT_TYPE_EFI_PKCS115 0x0EF0 > > +#define WIN_CERT_TYPE_EFI_GUID 0x0EF1 > > + > > /*++ > > // > > // Image Attribute Authentication Required > > -- > > 2.26.2.windows.1 > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#66856): https://edk2.groups.io/g/devel/message/66856 > Mute This Topic: https://groups.io/mt/77977756/1945644 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj- > mahmoud@arm.com] > -=3D-=3D-=3D-=3D-=3D-=3D > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.