Re: [edk2-devel] [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain

["Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>]

Thanks!

Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Wednesday, November 11, 2020 4:57 PM
> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
> devel@edk2.groups.io
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>
> Subject: Re: [edk2-devel] [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix
> build.sh when specifying GCC5 toolchain
>
> Samer,
>
>
> That doesn't fix it: the script as written expects you to run it with "GCC" and
> have your path configured for GCC4, GCC5 etc.
>
> However, "./build.sh --help" says:
>
> <architecture (ARM, AARCH64, X64, etc)> <toolchain name (RVCT or
> ARMGCC or GCC*)> [build type (RELEASE OR DEBUG, DEFAULT: DEBUG)]"
>
>
> I interpreted "GCC*" as meaning you could pass "GCC5" and have it work
> like edk2 in that it would build for gcc 5 and newer. My patch at least
> allows "GCC5" to work the same as just "GCC".
>
>
> --
> Rebecca Cran
>
>
> On 11/11/20 2:01 PM, Samer El-Haj-Mahmoud wrote:
> > Rebecca,
> >
> > First, apologies for the delayed review! And thanks for contributing these
> fixes to SCT.
> >
> >   Did you happen to check if https://github.com/tianocore/edk2-
> test/commit/323883de08ec30072c683d7e0602158e6e3e66fe already fixed
> this gcc5 build issue?
> >
> >
> >
> >> -----Original Message-----
> >> From: Rebecca Cran <rebecca@nuviainc.com>
> >> Sent: Thursday, September 24, 2020 5:38 PM
> >> To: devel@edk2.groups.io
> >> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> >> <Edhaya.Chandran@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> >> Mahmoud@arm.com>; Rebecca Cran <rebecca@nuviainc.com>
> >> Subject: [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when
> >> specifying GCC5 toolchain
> >>
> >> build.sh usage indicates that "GCC5" can be specified, but it's currently
> >> rejected due to a case statement only matching "GCC" or "gcc".
> >> Fix this by adding a wildcard match.
> >>
> >> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> >> ---
> >>   uefi-sct/SctPkg/build.sh | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index
> >> cad17ccdedc7..be610debcf3c 100755
> >> --- a/uefi-sct/SctPkg/build.sh
> >> +++ b/uefi-sct/SctPkg/build.sh
> >> @@ -151,7 +151,7 @@ case `uname` in
> >>   TARGET_TOOLS=ARMGCC
> >>   ;;
> >>
> >> -GCC | gcc)
> >> +GCC* | gcc*)
> >>               set_cross_compile
> >>           CROSS_COMPILE="$TEMP_CROSS_COMPILE"
> >>               export TARGET_TOOLS=`get_gcc_version "$CROSS_COMPILE"gcc`
> >> --
> >> 2.26.2
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.