From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.71]) by mx.groups.io with SMTP id smtpd.web12.47463.1591044689894733856 for ; Mon, 01 Jun 2020 13:51:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=5LLULHUa; spf=pass (domain: arm.com, ip: 40.107.20.71, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EK/TcLeY6WVIyo6c8TG/NQS9pWa8rQeQUuUeJyrCy9Q=; b=5LLULHUaloge/CNu+MJRYwlJDoRqXKITTx96gYunvjlutdUgQfxu8F/KXi3FsYj5GSTYBERpMfphUetd4U1+IO+ZhmZvjKI6dv4PM8+l92gT9VcQ7dLD7XcvEHqFBGXA/wiq8nVOcB6pxQHmasyLEdAkKODMmbC5CSBnceXCCpI= Received: from DB8PR09CA0011.eurprd09.prod.outlook.com (2603:10a6:10:a0::24) by AM6PR08MB3141.eurprd08.prod.outlook.com (2603:10a6:209:4a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.25; Mon, 1 Jun 2020 20:51:27 +0000 Received: from DB5EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::67) by DB8PR09CA0011.outlook.office365.com (2603:10a6:10:a0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17 via Frontend Transport; Mon, 1 Jun 2020 20:51:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT049.mail.protection.outlook.com (10.152.20.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Mon, 1 Jun 2020 20:51:27 +0000 Received: ("Tessian outbound d078647f4174:v57"); Mon, 01 Jun 2020 20:51:27 +0000 X-CR-MTA-TID: 64aa7808 Received: from fd2185f90298.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 059275AE-4167-46C9-A336-09D8AB434F03.1; Mon, 01 Jun 2020 20:51:22 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd2185f90298.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 01 Jun 2020 20:51:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gkavr2ZBfmC4nHk+PghoOuCN4J2byZVs89dHYCyJW8npHtYT0hHotiZnpBNqZowyAaQAfq7k58He9E2B8hwHh4L/ml52HTMNY+0eYrHSOJ89oBaulL2/GHywXJ+yzfaBG0N77uoew29Bh4rfgz/S71a+W2Ua2syPn3fE2qwK+JOaQQobiuPMrjBIj6N5SIjk3UiZlTZDKNE4MM46MN3KwJYLyN/mKks+7Yad3KUWS5ohn4vyhaBEMNc4qOspCzDHNKQnBw2r2gKQIAZ7Rk3HYbtveRqEN+VcZsQZRpcMts8HzKfUSi3qGQzlSpMrZyBl7Zd/RMia944AwrsiJCkQ/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EK/TcLeY6WVIyo6c8TG/NQS9pWa8rQeQUuUeJyrCy9Q=; b=mYxnRW7Znxa8kdXISIsYfj0q00wuynZhPHLQ2PaKz1+6hB9r3CEQCsAuAcBy/PpFv9HwHtRQEycckkRAzP7hqi7lsFAYJv07uVZTLGTLf8yX9zxkBERezIHCKCDkSoOFnMZzz3m8e+8MbLoI8E6fMLHjkDqlQ1qfZ2CfpicEN2dVGFNOsMcMTbRLbmdNdRpC18aCyvGfLTsiUdcIHf9mMypt+Xy6xtTUufcE9j8RUCZ1fz1Eg8dloqvDDk2vLzhe1aIYsOCJdnYVkFvZAkOqSSK/A67Ul98pZ/bHwUsK5qH76aIpkihIzxgjaDiNlVadLuEkvvnbJDj93IfWO730Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EK/TcLeY6WVIyo6c8TG/NQS9pWa8rQeQUuUeJyrCy9Q=; b=5LLULHUaloge/CNu+MJRYwlJDoRqXKITTx96gYunvjlutdUgQfxu8F/KXi3FsYj5GSTYBERpMfphUetd4U1+IO+ZhmZvjKI6dv4PM8+l92gT9VcQ7dLD7XcvEHqFBGXA/wiq8nVOcB6pxQHmasyLEdAkKODMmbC5CSBnceXCCpI= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB7PR08MB3099.eurprd08.prod.outlook.com (2603:10a6:5:26::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Mon, 1 Jun 2020 20:51:21 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::990e:ed79:bec0:9dac]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::990e:ed79:bec0:9dac%7]) with mapi id 15.20.3045.024; Mon, 1 Jun 2020 20:51:21 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "ipark@nvidia.com" , "eric.jin@intel.com" CC: G Edhaya Chandran Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Topic: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Index: AQHWNSYOCYJ3Zf2dAEiZM5+IGX/Ce6i97gqQgAZQmVCAAAO0IA== Date: Mon, 1 Jun 2020 20:51:21 +0000 Message-ID: References: <16134CAE37D4DAC5.10634@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-05-28T20:06:39.6568840Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=e5f65812-950b-44cd-a6f2-718925f50870; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic x-ts-tracking-id: 68d03eab-d26b-4c53-9c85-53154b4797bd.1 x-checkrecipientchecked: true Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d2e4085b-7020-4534-750a-08d8066d8df9 x-ms-traffictypediagnostic: DB7PR08MB3099:|AM6PR08MB3141: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:9508; x-forefront-prvs: 0421BF7135 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: powY3h/XCCK4AWgqug1EdFvnYc1pSSeSLEoQxg+iu8TP3fQ/oL/ECok2Uk+CHArt5TE5ZGt/RFr0p66P+VthetH8MPNumXinSad66fK3wHlfb3UHPdDSbKmRxSYDhncBGt+LIBFhheznSIjmBbUShnVkOIgX5hAkHgFC/PTNY3f4XcE5O/SspuZDMOeqwr7h4IZMM0hFDovNoY/0R79sXGc1UVP03PvSAHcixUQVCtARjBRZQ9fc5kYwMpYtnrvZq44wLMYrgJGJgRBO0okoF+ewmWpbtW7xJNylf+qiocgDUbNRbaoZKliIRD89uGA57cZjj723/OSIgQE8xxDVUODaMwqNv+BTPvNr96amC4LMOdMAQjnvxYcCml6yDPSFkia+K8omPMZcL58VVcN5y/zEShDe0tIok+5/cTSuMDkzO4C+EOUc9XNja05zI8ofrBUQ7+9oZLCeHgIELFEAUazvyyFmTox2NRXLSQyDKSc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(8676002)(478600001)(6506007)(55016002)(316002)(2906002)(53546011)(186003)(4326008)(86362001)(966005)(8936002)(7696005)(110136005)(26005)(9686003)(71200400001)(33656002)(76116006)(52536014)(5660300002)(66946007)(66476007)(66556008)(83380400001)(66574014)(64756008)(66446008)(19627235002)(145543001)(145603002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: nNXxa+9McXvO8b4axOUkZCXnOytF/NYyLuCw9Vw3mOdzZEurxJDYfBH6EsXHfhxDA1JKT7jOQnaOHbxn7wVoGsyX9AofXrGruXusBPmLb4KDLXdalkbh6IAmh/DiqR4Hm1nnWp7xeqq2OOKTshtxT3u/+JhtNROtjfpq/uzF0VLbQuKZdjqee8zeTO+wMdAbLSmJlJ6MYXl1YBli6ZLTyjFcwYnRrUqempr5jT5xcL3SRfWGWZxLMjbYU0x8yMxH5fOOxkcqA2x2diMvObllsn6pjWREoaDvFhBBuF3zUhjvr99xYFV6tQHCb93X6aC+NautA5IiWFbePbM3tee7pcs3CnxK5mIkPeCxrWMKph/SC6Pl4yXbTIoVdsCI021JEW/oEuAi0C5uR+H6zbiBUa2+lEF92W6EueBm3dQIa9JYMRlSudMMV6L2wgA0EzPfNrcqWueEf8GkPMpA29A2RwF/cike441mOwP3yS7scFuQV8qiCCGb0n8nTnvgPRyx MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3099 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(136003)(39860400002)(346002)(376002)(396003)(46966005)(81166007)(336012)(82310400002)(2906002)(356005)(966005)(83380400001)(5660300002)(52536014)(66574014)(478600001)(19627235002)(33656002)(26005)(70206006)(186003)(8936002)(4326008)(9686003)(53546011)(55016002)(316002)(6506007)(8676002)(86362001)(7696005)(82740400003)(47076004)(70586007)(110136005)(145543001)(145603002);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 634d7707-e397-4fb3-445f-08d8066d8a3a X-Forefront-PRVS: 0421BF7135 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4er+LmYktBw+TDQnVoZT7t7T1R5wf5/ZfaavvDa2AK/aMgGS/pyQD4DnSNEUOuY685vrSTkiNjs3w1yqxsTOxt85z+6sfrqinV+cPVz/5UNAhavl+P5jmxBrVAJ73B5ifX+4OKQsGg7uPUhJDnUaJPEuSHe4/Wv6aGDDBYJox1mv1skPlz3dzLfPMw+90DxaowFu2hQ3QNpKI+SxJs5ByPA+cE1l4i6vjfMoJ5r5igcbo9ggk3l1bBN03mLXVHf1HI2l//FYPTa0sYueKn9aLjd1N2TEp7URC/kqoO87uyyXDm2oD+2uuNx/P6qpUMB7Y105Nq5bW+hk9pO30DBOXIqOaL5/mHhJnEXPyEn06YIKxNglXWFeHUbASC1j53y4+omJ6YLc5Lct/gpfcOZp6GDy4uiYtBfly/SSVE64UPDxq8HGU8tZN8TchoaEt22Bg4RDZyNA98UkIL8bsE8wkakJ2Rk6thBdeHnG+edaXVWYNKMjmBWRrrvXrxehMDydy/EYtjY3rqlwXRxkolOQSg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2020 20:51:27.5993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2e4085b-7020-4534-750a-08d8066d8df9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3141 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable +Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SC= T patches. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park ; > eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > Hi Eric, > Would you please help review this change? > SCT build fails with the latest EDK2 due to lack of this change. > Thanks, > Irene > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene > Park > Sent: Thursday, May 28, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > External email: Use caution opening links or attachments > > > -----Original Message----- > From: Irene Park > Sent: Thursday, May 28, 2020 3:19 PM > To: devel@edk2.groups.io > Cc: Irene Park > Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid > > From: Irene Park > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2145 > > Replace the gEfiFormBrowserExProtocolGuid with > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > Signed-off-by: Irene Park > --- > .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c |= 4 ++-- > .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf |= 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index d495afd..fe973a3 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c > @@ -1893,7 +1893,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > #if 1 > EFI_STRING Progress; > EFI_STRING Results; > @@ -2190,7 +2190,7 @@ DriverSampleInit ( > // > // Example of how to use BrowserEx protocol to register HotKey. > // > - Status =3D gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, > (VOID **) &FormBrowserEx); > + Status =3D gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, NUL= L, > + (VOID **) &FormBrowserEx); > if (!EFI_ERROR (Status)) { > // > // First unregister the default hot key F9 and F10. > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > index cfa049e..75cb6fb 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf > @@ -99,7 +99,7 @@ > gEfiFormBrowser2ProtocolGuid ## CONSUMES > gEfiHiiDatabaseProtocolGuid ## CONSUMES > gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > - gEfiFormBrowserExProtocolGuid ## CONSUMES > + gEdkiiFormBrowserExProtocolGuid ## CONSUMES > gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES > > [Depex] > -- > 2.7.4 > > > > > >=20 IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.