From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.58]) by mx.groups.io with SMTP id smtpd.web12.14068.1600868602902715822 for ; Wed, 23 Sep 2020 06:43:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=0Yy7YIHd; spf=pass (domain: arm.com, ip: 40.107.20.58, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXVd/CDYsfzycqJsdp7lndxFUCz6HZZFZy+wf3P0Jfc=; b=0Yy7YIHdKFcRGRBHs//GeNE4t4D+tEeBXWQswyI8ph7TAFmEr1lGh5xYIN5bfDWH3HGzhN8p9D87bVtF4vXeT11y4Rk1naMlbEpnouwzjM3WlHaa8U7X1bu0VQ9MVSPstpoX4rqOOIQOmUrolo53hV11xwqxSdoA7E531XwCoOU= Received: from AM6P194CA0097.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::38) by AM0PR08MB5026.eurprd08.prod.outlook.com (2603:10a6:208:158::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14; Wed, 23 Sep 2020 13:43:19 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::3e) by AM6P194CA0097.outlook.office365.com (2603:10a6:209:8f::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Wed, 23 Sep 2020 13:43:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Wed, 23 Sep 2020 13:43:19 +0000 Received: ("Tessian outbound 195a290eb161:v64"); Wed, 23 Sep 2020 13:43:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a78a0be9454f02fc X-CR-MTA-TID: 64aa7808 Received: from 36c5c23d2137.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F4FEFEB7-8AEA-4568-A9C2-F8925847A6E3.1; Wed, 23 Sep 2020 13:40:09 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 36c5c23d2137.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Sep 2020 13:40:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ctug/xkwK5bQdnsOk6cOcDTDbxeb+wHMylvAnfPASBOIAaKsLy0mPT3ZtoVYvvGJx/GiqWrcQYYliVjliQZYjuCmsaqPygqOC/53YgsajcdTFNvzn9NK3FWs9yPd0BEQ1w/BcdDUaXmV5X7yXfHuv7/mDFjexiu6jIVI/3fWVMLPwyeOFMf8vB4Mwv4pbGYJreGRyLlEkuCAJTmdg8Jkyo+vNf2yeqA5GqvJYU4ty1YiwHlLe+X6jjBdw3x0zWd5azohi1Uao6DCntSvZnAB+UcPZ7ofXEFyrLA19lhyoRTEqWoM+hgfrj7gNPGuyHeVMEiMG9cII84PtMD3RuRJ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXVd/CDYsfzycqJsdp7lndxFUCz6HZZFZy+wf3P0Jfc=; b=HK/HKgshnxTrJGjwVOdYfnnT0X7gdZbT/f07nkNqg3k7pMOZfBWsE6b8gggWTw1RpasfYukg2VQPjKkpMWgFcQVSfIOk70Wnjqg6Jr+0BbafpH7sD+AHKRgfjRRtEWWwwIhywxu3t9AVTy8YR3AuxXXTsaolEoNIlAGiLsurCqZmv5zNgKnuGcN2Yl1OpkV9HJN84nCDiZwpo+q9BhsIbsMT4Cyo/1le6wK+fxJya3fC5OkQjptPyQNKrXYJsBEYERNslpD3A0tI9xFm8dG2TXEkUje2CkqCEgCMV1AzM9QzF3irDN0E1y5pGvsCBKbLnNIQ3P9ijxiNVoM1eZ0f0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXVd/CDYsfzycqJsdp7lndxFUCz6HZZFZy+wf3P0Jfc=; b=0Yy7YIHdKFcRGRBHs//GeNE4t4D+tEeBXWQswyI8ph7TAFmEr1lGh5xYIN5bfDWH3HGzhN8p9D87bVtF4vXeT11y4Rk1naMlbEpnouwzjM3WlHaa8U7X1bu0VQ9MVSPstpoX4rqOOIQOmUrolo53hV11xwqxSdoA7E531XwCoOU= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB8PR08MB3994.eurprd08.prod.outlook.com (2603:10a6:10:a6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Wed, 23 Sep 2020 13:40:06 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::2c56:d598:ede:dd52]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::2c56:d598:ede:dd52%6]) with mapi id 15.20.3391.011; Wed, 23 Sep 2020 13:40:06 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , "divneil.r.wadhawan@intel.com" , "matthewfcarlson@gmail.com" CC: "Ni, Ray" , gaoliming , 'Andrew Fish' , "Justen, Jordan L" , "Kinney, Michael D" , Laszlo Ersek , "Yao, Jiewen" , Ard Biesheuvel Subject: Re: [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib Thread-Topic: [PATCH] EmulatorPkg: Add RngLib to satisfy dependency of OpensslLib Thread-Index: AdaORxtzBH3bPg+6RAas6Wi+SL78ngDZO99g Date: Wed, 23 Sep 2020 13:40:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7402844a-d3a7-4a29-44a8-08d85fc6a1a6 x-ms-traffictypediagnostic: DB8PR08MB3994:|AM0PR08MB5026: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7oLDP/0r/+fkAD3sQQlIynFkagfrYnB1ytD5jTqz7nIBscnw68NACvrLevs4bLarp1oZ0o9YTExBqNJrMWzP8y91FnO3Espz/NdxeYR9/SCZgtkvVk/YpR/4HQst3SrXOrgjs1NMxmDBOKjIP/0KSiv1v+szYJZ7/7TeXGTXc+k7anW1P2P9FVTaFk/dzKWrFQtQzHjfnNjpA3tzYFl0PiogoJihS1B93eZK++TM/qRbhq6AnWEtZJinUqKFh8u8T/dku3xhjTt16YQY0h+LrDIi/vPaWmyKG3ukBeKtbhG48hvi8oktbeQ7a5gHjqJOW4nlzn2d2B8ETKgBcVWfXtk2jBtaSnZ1awcmTbESOdJcBXcJWBsPxr0A/e8TOobb8S5S1ZTamGN4BXzbOQRfng== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(39860400002)(346002)(376002)(8676002)(52536014)(66476007)(64756008)(55016002)(54906003)(2906002)(19627235002)(316002)(110136005)(66446008)(66556008)(76116006)(9686003)(66946007)(8936002)(5660300002)(186003)(26005)(6506007)(86362001)(33656002)(966005)(53546011)(7416002)(4326008)(83380400001)(71200400001)(478600001)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: OOrt43EmJauk+ip6NikbS3DtqBKky5bFD6PAGU6WRUBIo4kUe8V2496a9GYuGYwkogXBm2VM5nL0B9+ptyGE/mr7uKHwehJgrImWqG0qpYTJI41doi2EKZce/ynLkBYDiyy5lSRAOcTNMd6Y3doruQEEKyyXuZQFdWR6cK1wHc6+xLGUgYUGoUt0vosaytSYo8T2IjjuTWXvYzkV7AVo8ziIMH5pwRlFhtAmkBmk+eu7pxNAjJBM1t5gy3miygT44ygd3pvqccnCAr2yrVT3Jf06Jct5Cny557XOI6Y+QMeCMKlQTUH9tYOiaOJfBL8fOIvE1t0HKNq+ZrvnvCjNUTWhkNfanx9zmUQzVGOzkQAeGvAIvU7+J23tJBWALABgz2XQH02Lq/pFHzDyvruUxH0IBmDwf/nUxn35P2h18CN2GQxr/tNWQGJx65/K3nQdscSg51g4phTBaOQmGAgnHN85s7dEhyYcROks9IJA2ODC4YwoMPgCYI/YMuixFxTqqpwY/NhR7Gu3wGmom4nahTeRyo75+9FE1FDSiB/X+xVH4iAl6T76gDrlQ949DPynNg8cPE2zWjOyhYteTbmMbuIqPwnN9pA6Pse++cc/9wwpUjLqbeU16UXfKqNX5ggIaR1Z7bkQmcXyfR4n1zLF+w== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3994 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2627bb68-3be3-45a0-f2ad-08d85fc62ecb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MqYlAeGoEGOwny6tOnPFmQiFMx/fB6H1/cW/gXqvopcr3GeUfoa4tvXPbRNd5ov5hR+7dEUfVuqVi6L92sBwbgPn8mnDUaCpXh2fArTNJeYippUJoZ32lf/V0hriOYcGOW/EAAJtiFt2wLhfG444Gd2mEofo1gV95SQKmENPEw4HIP7Ir2naS6jdfpP1e9khGZ4i0eAduC5LlcHiml6logxx3ZNSsCMPM9r5WPqU+490zcHArGGxCLf3J7kFg9/JbVngsIrHXLoakdzx0qcpMhDwg6U0T1PdCQtHKvcFu9ZSTQOvlB4QKBg3i+MsHpBLWow7akZer0sYhIBu9kyLUHv8X3i30E0uurfBMJ9tGRITndwulKiH1IWlpXHTlhEEuMNHjZCEnhrtRMz5LjAE3o2v/2abf3py/gNLKSJGsQpwKm5fskL+RpWKiP4AU1Cf5FN+hxdiavkr7MJHrQgAB3NhfeCYPrkKLu1+4KoVHjPhxTT43mk8JdtPWVm6Ow5R4lly/NcqU+H9m97I6X9V7g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966005)(5660300002)(54906003)(26005)(36906005)(33656002)(336012)(4326008)(186003)(316002)(110136005)(8936002)(6506007)(8676002)(53546011)(55016002)(966005)(52536014)(7696005)(19627235002)(70586007)(81166007)(82740400003)(47076004)(70206006)(2906002)(9686003)(86362001)(356005)(82310400003)(478600001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2020 13:43:19.2007 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7402844a-d3a7-4a29-44a8-08d85fc6a1a6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5026 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Divneil, Thanks for this patch. However, it looks like multiple edk2-platforms are broken because of the O= pensslLib change. I verified at least the following are broken: - RaspberryPi/RPi3 - RaspberryPi/RPi4 - Qemu/SbsaQemu - Socionext/DeveloperBox - SolidRun/Armada80x0McBin - Hisilicon/D0* Etc.. Others are probably impacted. A quick search across edk2 and edk2-pl= atform shows openssllib used in 26 DSC files, but RngLib is implicitly used= in only 13 of them. Mathew, I think the offending commit (b5701a4c7a0fb185e0c5b9db9525939c78664bfd) ne= eds to be reverted, and re-submitted with a series that fixes the build for= all impacted platforms. Also, what would it take to add the Azure pipeline CI that is currently us= ed in edk2 to edk2-platform? I imagine some platform maintainers would appr= eciate that capability. Or should every platform look for their own CI/CD (= possibly outside TianoCore)? Thanks, --Samer From: devel@edk2.groups.io On Behalf Of Wadhawan, D= ivneil R via groups.io Sent: Saturday, September 19, 2020 1:39 AM To: devel@edk2.groups.io Cc: Ni, Ray ; gaoliming ; 'And= rew Fish' ; Justen, Jordan L ; = Kinney, Michael D ; Wadhawan, Divneil R Subject: [edk2-devel] [PATCH] EmulatorPkg: Add RngLib to satisfy dependenc= y of OpensslLib o Recently, OpensslLib [LibraryClasses] has been changed to include RngLib which causes the SECURE_BOOT_ENABLE build to fail in want of RngLib o This patch adds the RngLib for OpensslLib Signed-off-by: Divneil Rai Wadhawan --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index c6e25c745e..a27cb1beb0 100644 --- a/EmulatorPkg/EmulatorPkg.dsc +++ b/EmulatorPkg/EmulatorPkg.dsc @@ -113,6 +113,7 @@ FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSec= ureLibNull.inf -- 2.16.2.windows.1 IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.