Re: [edk2-platform][PATCH v1 4/4] Silicon/AsixPkg: Add ASIX Ax88772c driver

["Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>]

Leif,

Thanks for the review. Most of these are cosmetic changes that I will take care of in v2. There are a couple that may require some experiments to figure out what works and what breaks.



> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Tuesday, May 12, 2020 9:23 AM
> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Cc: devel@edk2.groups.io; Ray Ni <ray.ni@intel.com>; Ard Biesheuvel
> <Ard.Biesheuvel@arm.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-platform][PATCH v1 4/4] Silicon/AsixPkg: Add ASIX
> Ax88772c driver
>
> On Sun, May 10, 2020 at 07:15:30 -0400, Samer El-Haj-Mahmoud wrote:
> > This is the initial revision of ASIX USB networking UEFI driver
> > version 2.8.0 for Ax88772c / Ax88772b / Ax88772a
> > https://www.asix.com.tw/download.php?sub=driverdetail&PItemID=136
> >
> > Source code contributed by ASIX.
>
> Same source version questions as for 3/4.
> Same request to use "provided" rather than "contributed".
>
Will do
> > +++
> b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772c/Ax88772c.inf
> > @@ -0,0 +1,65 @@
> > +## @file
> > +# Component description file for ASIX AX88772 USB/Ethernet driver.
> > +#
> > +# This module provides support for the ASIX AX88772 USB/Ethernet
> adapter.
> > +# Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
>
> Same question regarding Intel copyright.
>
Same situation applies here. These were provided by ASIX with the Intel copyright on all files

> > +
> > +#define ARM  0
> > +
> > +#if ARM
> > +#define MAX_LINKIDLE_THRESHOLD  100
> > +#else
> > +#define MAX_LINKIDLE_THRESHOLD  30
> > +#endif
>
> ?
>
> > +
> > +#define AMI    1
> > +#define ASIX_MCAST_FILTER_CNT 8
> > +#define RXTHOU 0
>
> Again, ?
>
Hmm... Will have to experiment with these to see what happens if I pick one or the other.
I can only test on ARM systems though


> > +#define CMD_PHY_SELECT            0x22  ///<  PHY select register, Value:
> New value
> > +
> > +/*Freddy*/
> > +#define CMD_RXQTC                 0x2a  ///<  RX Queue Cascade Threshold
> Control Register
> > +/*Freddy*/
>
> Here's Freddy again.
> Unfortunately, this one appears to be actually used.
>

Yes... Will remove Freddy's name but keep his macro

> > +
> > +
> > +#if PASS_SCT
>
> Same as for 3/4.
>
Sure

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.