From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.55]) by mx.groups.io with SMTP id smtpd.web10.15224.1589471500193330916 for ; Thu, 14 May 2020 08:51:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=fZ0PrVNU; spf=pass (domain: arm.com, ip: 40.107.1.55, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2jMdJIUEZb1qJF3Jvpooei+Hn1fcyKDvLR8tJc3qah4=; b=fZ0PrVNUhbI5orcUtZBRatuWo+fHixO3yigumhBQ6HjuefKeHvDVQ5EfDWJEWqFtPFg64/YqUqdx+EzFnUzJ6gbJf8c733doXozsl+m+QaDd6XO6a0TnkXTKZLMOlSOUJsup5lqtyn5mTRaO9Spirgbe46+LNbZrQwdjFnoxwYU= Received: from AM7PR02CA0024.eurprd02.prod.outlook.com (2603:10a6:20b:100::34) by AM6PR08MB5144.eurprd08.prod.outlook.com (2603:10a6:20b:ec::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Thu, 14 May 2020 15:51:36 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::ed) by AM7PR02CA0024.outlook.office365.com (2603:10a6:20b:100::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Thu, 14 May 2020 15:51:36 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Thu, 14 May 2020 15:51:35 +0000 Received: ("Tessian outbound e88319d7ccd0:v54"); Thu, 14 May 2020 15:51:35 +0000 X-CR-MTA-TID: 64aa7808 Received: from 5560fe20e3b7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2797B108-8966-47F3-A05C-F3016FBE0024.1; Thu, 14 May 2020 15:51:29 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5560fe20e3b7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 May 2020 15:51:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QxzpNAlWkrCPcyCu+rgnjnTYzo2bjlZBmIOLof7X1JeLDDa6WjUDNVvjXbzAFs8MlxWBGHxEevXS3zj2+4gQU5CDHw1LXFRMyEAGLWdwbdKTJl9a9bGfAUqyBdXnCdrl35yvqIPU6YTAYh1aOVWODpjOgMmYK1+GV1WuRvpEUyKA1dFLRWMxY4DLk3KIYa49quFhHYESZAhMqke5xgh3jd1lrYQ6P29qS/rGZP+wWUzmUEY0qdoKDFeixdjIjLCR6hx5SqBsm+sYQ7utUPrZ84Z+018YG60l8BRe9Wzs0H/t33mpZl/G86w0+rnLz99ZhCZvvoT33X4Yp6zaNhKShQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2jMdJIUEZb1qJF3Jvpooei+Hn1fcyKDvLR8tJc3qah4=; b=CCR3bgXNlf7eehZVNCCwLcSIYQ2YzxkKIYOEhVPTQtuMr9I9dpJw8r4s9v4i7pZc6yXon9MOBotnQ3Cn/qXFMNTE2uzOvygLZYjONVfIljoLpo4h13k8nhJTxYX3ZKMKkQ0cqFb+EjtlGy4qENNP/oOD8zhZPMWBtmLc3YEkZ7E+rRoUmr8nLY1ixBnI299cm+Ul2FfCmCPFQt8orJmuxG6OQYr0g63ZhcCfMN2m1KGWEs8cIPOAYMhHa/3YLx7kwEk1zSW0yPxXlXLP6eifn1mPSDmNrBobiNSG+0dWiZfXEq8no6KZSHSEqDfOAN7JG7AaQ3TatM7IKKYLcRxozQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2jMdJIUEZb1qJF3Jvpooei+Hn1fcyKDvLR8tJc3qah4=; b=fZ0PrVNUhbI5orcUtZBRatuWo+fHixO3yigumhBQ6HjuefKeHvDVQ5EfDWJEWqFtPFg64/YqUqdx+EzFnUzJ6gbJf8c733doXozsl+m+QaDd6XO6a0TnkXTKZLMOlSOUJsup5lqtyn5mTRaO9Spirgbe46+LNbZrQwdjFnoxwYU= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB7PR08MB3833.eurprd08.prod.outlook.com (2603:10a6:10:79::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Thu, 14 May 2020 15:51:27 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::990e:ed79:bec0:9dac]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::990e:ed79:bec0:9dac%7]) with mapi id 15.20.2979.033; Thu, 14 May 2020 15:51:27 +0000 From: "Samer El-Haj-Mahmoud" To: Leif Lindholm CC: "devel@edk2.groups.io" , Ray Ni , Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-platform][PATCH v1 4/4] Silicon/AsixPkg: Add ASIX Ax88772c driver Thread-Topic: [edk2-platform][PATCH v1 4/4] Silicon/AsixPkg: Add ASIX Ax88772c driver Thread-Index: AQHWKGByMHtQGEZ7uE+HX3uoPIwxM6invLOw Date: Thu, 14 May 2020 15:51:27 +0000 Message-ID: References: <20200510111530.26225-1-Samer.El-Haj-Mahmoud@arm.com> <20200510111530.26225-5-Samer.El-Haj-Mahmoud@arm.com> <20200512132248.GE21486@vanye> In-Reply-To: <20200512132248.GE21486@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 122f720f-0a67-4285-8ef3-aec3d31b6481.1 x-checkrecipientchecked: true Authentication-Results-Original: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b55c9522-d227-434a-c48d-08d7f81eae8c x-ms-traffictypediagnostic: DB7PR08MB3833:|DB7PR08MB3833:|AM6PR08MB5144: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:10000; x-forefront-prvs: 040359335D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UyW0CdVceTrBqKDN9bWeS0bVRnLD7qxIRa7f9u9ZtEfmq4HqIjug9JqjqgVTAMZYZ0ApEeN3X8ae17ngePSc28OYM4v5+6nL9LN/lwkaBFgK7llCsdJlHhcvi2jlTJHXI0vs2Sw7pkcZP52Fxc2+9fTPiGN7fM5xILiNIY6gktgTO6/JL9pNN/obeCiwJGY3LIeS8B0t/egpe5Js6D2BQr27JIVud34z/Sli3ox0tnd9cg5ntLLBOLRW//a4hxSGEyK/6e7RPme6BeaPim2d/NZftB2kD+eMxriOTAsJKTUoWoMI3fDcT+N18waZqed5Ukkx2GHiBIHnCyeLKMVz2RosD/miGHiL20ctXn0aBTciEUdHT4Tt0B1dUX8+4s6Nu3jpfGUtCfKgmslIx02uN9sNQBrlJ1N/k8jFi0L6VSWKg31om4bHDc5+M0ZY7ftZuOASH5cO4mJ70aU89Ytjvu/htXcj+8SluePqI23r0i+YdjKsjakL9QnateWha1H1sFqZS6cG1SnD6IpTGmA5uA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(478600001)(8936002)(2906002)(33656002)(9686003)(16799955002)(5660300002)(8676002)(55016002)(76116006)(64756008)(66476007)(86362001)(53546011)(66446008)(186003)(71200400001)(4326008)(966005)(66556008)(26005)(6916009)(54906003)(6506007)(316002)(66946007)(52536014)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: IkTbYr+ohHQHb4QWzmpj7B2iJtk0xo5hl260pH96WbbkhF23FFRCV2SztE9bBUFaUl+1DvinmJkZ2Kh+ZmRGjDYbLlZ2fZaKXjk2xtqgE4b44Yss0e3Y9/DooY/ps4c253AfiR1MWWE/dqZbH+p4m+VB/cF+8BiXH6uF4Z39E8UGcnWmjiY6RsnHatGS9FJL0dFiNU+CSvEdynweccNbnByFjlE3bYTnmzDxl0XyeOAIIrUu6FMo5Rut7RwJyNwy5OeNw/5iVXFKOa83EDyImwKt6YIaVPWsoLMd0L0X99Hwu3EpVcWw6X2ZnHH3WNgVaBURbQXXu8HxLemHQd/Ptpn80y2kc//8KxBVfvHnvkwacHPVtyhl1S0p6nR7tjwV4vR+o/I0Xpx2evBbcF6XjgZrEWE1s4wpkgi6Auio98iO6hTnVr4g/BKd0cYm2nJbwyoxEdwQiUuOZ4e9d4EnUEWfq+H2kcgv+N6IP9Omg0vR8mVPIOAhZX+Gp5Ysyxxt MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3833 Original-Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(136003)(346002)(39860400002)(376002)(396003)(46966005)(966005)(70206006)(186003)(81166007)(54906003)(4326008)(2906002)(16799955002)(82740400003)(356005)(33656002)(52536014)(6506007)(26005)(107886003)(478600001)(53546011)(47076004)(82310400002)(336012)(70586007)(9686003)(5660300002)(36906005)(7696005)(316002)(6862004)(86362001)(55016002)(8676002)(8936002);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: d0dedf19-f052-467f-ac01-08d7f81ea988 X-Forefront-PRVS: 040359335D X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ULUNfIZAHkti8/5PnKDy0VQ+11RSYV4gRoG83zqJrkCLz9vNB/7Fl/LLQ7zZXyTNscKDWp+8j+lxoV+m0f4o639FnenGwaLJfFYqozMkVaKvZX86gNhDhfWwDi/1Lh+O1+1vJm058LYkDBEt/vPX4RMpSbu3u4Fw9hA1RhnVV5z5YP23w95nW2io6Dqm/Ym0/wvUDvT8jQN1C++TU8yCJd/u99yuZHNbYUHZYF08MiVseHTGcOmmWghAajaH9p8OB+CUgh4cbGehtyC+Pc/48hv81FmMY7PzLn0zlND8kdwivglX9hlI7mubfZZSHEiuW4nSxZH7NTuYoW0JSmI2FrgKGAfLnOvvV6jyx0EHc+gP3zSod0E/jku02d6VP6lv+wURWEOnimTlXb+qWog/1XrQ9+RJkLbk4YsIaOfTKroiISqwBq1gVqL/g1v4WIoztm4rb0cjfubSh9CE+F8Q9qTc6Dx6uPGOEJI/iFoX0XrCUzIQuEGwhNcJoBHWAbvamJ7eAm+tiOuKel7vZaol18DYEHw81SNmKJ1WyQpvplu1kN4RNiXBkf7lKdrk/jH+r6d/1ecP3VU2QajGNs890qDVwf/Nor68Sp7CoXbt0Os= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2020 15:51:35.6343 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b55c9522-d227-434a-c48d-08d7f81eae8c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5144 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, Thanks for the review. Most of these are cosmetic changes that I will take = care of in v2. There are a couple that may require some experiments to figu= re out what works and what breaks. > -----Original Message----- > From: Leif Lindholm > Sent: Tuesday, May 12, 2020 9:23 AM > To: Samer El-Haj-Mahmoud > Cc: devel@edk2.groups.io; Ray Ni ; Ard Biesheuvel > ; Michael D Kinney > > Subject: Re: [edk2-platform][PATCH v1 4/4] Silicon/AsixPkg: Add ASIX > Ax88772c driver > > On Sun, May 10, 2020 at 07:15:30 -0400, Samer El-Haj-Mahmoud wrote: > > This is the initial revision of ASIX USB networking UEFI driver > > version 2.8.0 for Ax88772c / Ax88772b / Ax88772a > > https://www.asix.com.tw/download.php?sub=3Ddriverdetail&PItemID=3D136 > > > > Source code contributed by ASIX. > > Same source version questions as for 3/4. > Same request to use "provided" rather than "contributed". > Will do > > +++ > b/Silicon/ASIX/Drivers/Bus/Usb/UsbNetworking/Ax88772c/Ax88772c.inf > > @@ -0,0 +1,65 @@ > > +## @file > > +# Component description file for ASIX AX88772 USB/Ethernet driver. > > +# > > +# This module provides support for the ASIX AX88772 USB/Ethernet > adapter. > > +# Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved. > > Same question regarding Intel copyright. > Same situation applies here. These were provided by ASIX with the Intel cop= yright on all files > > + > > +#define ARM 0 > > + > > +#if ARM > > +#define MAX_LINKIDLE_THRESHOLD 100 > > +#else > > +#define MAX_LINKIDLE_THRESHOLD 30 > > +#endif > > ? > > > + > > +#define AMI 1 > > +#define ASIX_MCAST_FILTER_CNT 8 > > +#define RXTHOU 0 > > Again, ? > Hmm... Will have to experiment with these to see what happens if I pick one= or the other. I can only test on ARM systems though > > +#define CMD_PHY_SELECT 0x22 ///< PHY select register, Val= ue: > New value > > + > > +/*Freddy*/ > > +#define CMD_RXQTC 0x2a ///< RX Queue Cascade Thresho= ld > Control Register > > +/*Freddy*/ > > Here's Freddy again. > Unfortunately, this one appears to be actually used. > Yes... Will remove Freddy's name but keep his macro > > + > > + > > +#if PASS_SCT > > Same as for 3/4. > Sure IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.