From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
EDK II Development <devel@edk2.groups.io>
Cc: Eric Jin <eric.jin@intel.com>,
G Edhaya Chandran <Edhaya.Chandran@arm.com>,
Barton Gao <gaojie@byosoft.com.cn>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion
Date: Mon, 23 Nov 2020 12:46:13 +0000 [thread overview]
Message-ID: <DB7PR08MB3260715C1C1ED7EF1306B88D90FC0@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201121160759.39842-1-xypron.glpk@gmx.de>
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Saturday, November 21, 2020 11:08 AM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>;
> Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Heinrich
> Schuchardt <xypron.glpk@gmx.de>
> Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion
>
> The functional tests for OpenEx() use RecordAssertion() statements that lack
> a print code for the Tpl argument. This leads to a segmentation violation.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++----
> .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c
> index c2bf9b4fdc92..193383993cbe 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackB
> +++ oxTest/SimpleFileSystemExBBTestFunction_OpenEx.c
> @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid027,
> L"OpenEx() Basic Test - checkpoint1 ----Test1----Async",
> - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name - %",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test3_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid039,
> L"OpenEx() Basic Test - checkpoint1 ---Async",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test4_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid043,
> L"OpenEx() Basic Test - checkpoint1 ---Async -- Test4----Open
> File",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test5_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid047,
> L"OpenEx() Basic Test - checkpoint1 ---Async -- Test5---Open File",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c
> index 70ec88f1c065..894d42fc370d 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim
> pleFileSystemExBBTestFunction_OpenEx.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackB
> +++ oxTest/SimpleFileSystemExBBTestFunction_OpenEx.c
> @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid027,
> L"OpenEx() Basic Test - checkpoint1 ----Test1----Async",
> - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name - %",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test3_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid039,
> L"OpenEx() Basic Test - checkpoint1 ---Async",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test4_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid043,
> L"OpenEx() Basic Test - checkpoint1 ---Async -- Test4----Open
> File",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@
> BBTestOpenExBasicTestCheckpoint1_Test5_Async (
> EFI_TEST_ASSERTION_FAILED,
> gSimpleFileSystemExBBTestFunctionAssertionGuid047,
> L"OpenEx() Basic Test - checkpoint1 ---Async -- Test5---Open File",
> - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s",
> + L"%a:%d: Tpl - %d, Status - %r, FileName - %s",
> __FILE__,
> (UINTN)__LINE__,
> FileIoEntity->Tpl,
> --
> 2.29.2
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2020-11-23 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 16:07 [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion Heinrich Schuchardt
2020-11-23 10:29 ` [edk2-devel] " Grant Likely
2020-11-23 12:46 ` Samer El-Haj-Mahmoud [this message]
2020-12-07 18:16 ` G Edhaya Chandran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB3260715C1C1ED7EF1306B88D90FC0@DB7PR08MB3260.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox