From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.71]) by mx.groups.io with SMTP id smtpd.web11.34898.1606135594038427943 for ; Mon, 23 Nov 2020 04:46:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=YmTxGTSl; spf=pass (domain: arm.com, ip: 40.107.14.71, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MMg5qCFyAmhahti+2MO95a5C2Ee3HFurpFioQuWlz9Q=; b=YmTxGTSlF2tP0yCaLUhjHt/DiFC3x7qTpUEhomDhJDdY4AiG83Vupg2y9rbBTIW6WSrCyRtRB2A+7DScBnd2r5vnxiEv4IPgynRXzEOc0oQkw+4dkNEhC9prcgEbvMXP+kZqF8N/knI1LjhjntriOPZmBrfkuqmjFrZ0QVTOj+8= Received: from MRXP264CA0009.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:15::21) by AM0PR08MB4355.eurprd08.prod.outlook.com (2603:10a6:208:13a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.28; Mon, 23 Nov 2020 12:46:30 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:15:cafe::1e) by MRXP264CA0009.outlook.office365.com (2603:10a6:500:15::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Mon, 23 Nov 2020 12:46:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Mon, 23 Nov 2020 12:46:30 +0000 Received: ("Tessian outbound 797fb8e1da56:v71"); Mon, 23 Nov 2020 12:46:30 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1f560e86fa84cccb X-CR-MTA-TID: 64aa7808 Received: from ccfd1fd12a63.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5CA152A2-0710-49B7-B447-7B6D5F57F9CD.1; Mon, 23 Nov 2020 12:46:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ccfd1fd12a63.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 23 Nov 2020 12:46:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjZGiOWfslbxddu1ahHv7M34gHh0LYSetaPiD7QDeFgtQEaZZz/QbNmm1DNHLwuXItC/ZVB3UdUxqEShLw9R1FCpkNd36BR1hmVIBod8dk3ZL7AcaNy3lsstVvQCloZ3AIBYjYXEdRfg2HffNeTKU98Ex/ckyppyLLz2MQs5wRYZXX8yjiI2POCJ3eVP+0wPxaP89ncsYtthBNSTO0fT8SH3dS+4msoS7oCW5RGeyuRwkZ70ozs6NDQbV3FsNQNW5lTO3W0JgKeNPQh1y2fi2b8q1lBo1N8DVU7ClhRXD5N4eYVs4+wehN2h/1XPrt/lgaLHiuUkP5tkNWJRWH9WBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MMg5qCFyAmhahti+2MO95a5C2Ee3HFurpFioQuWlz9Q=; b=QPuiYASNcGW2cT1EXXxfG7excjrgO64gNM6fc8XXSGDP0euM9/aKhKahiB8YjRqYIel5BEycnYF82g7ccTW6Vej1rKaWxXu9Z5EQFOieyE7gSy6jaTZBs/oYO83JqMt6Y4Cve513973Hal/e6Roqa2mUY3q4tyPgo8VPhvKt0am0CT+16ofTLSAxhq5DDP7PWg95SJlCaQiZgmW5AT//Opraw/3MT4skLAZQR4Plwim9Mtr7Um0131jFCMOW6Atv81glxg7UCSALqlg4UbRHGA/K7B4Z0XXqB60rRJb28GoRu20aB17y155WBjAPoz9acljlmstFkUIZmYo1N99a3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MMg5qCFyAmhahti+2MO95a5C2Ee3HFurpFioQuWlz9Q=; b=YmTxGTSlF2tP0yCaLUhjHt/DiFC3x7qTpUEhomDhJDdY4AiG83Vupg2y9rbBTIW6WSrCyRtRB2A+7DScBnd2r5vnxiEv4IPgynRXzEOc0oQkw+4dkNEhC9prcgEbvMXP+kZqF8N/knI1LjhjntriOPZmBrfkuqmjFrZ0QVTOj+8= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DBBPR08MB4773.eurprd08.prod.outlook.com (2603:10a6:10:d9::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.29; Mon, 23 Nov 2020 12:46:13 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6%7]) with mapi id 15.20.3589.030; Mon, 23 Nov 2020 12:46:13 +0000 From: "Samer El-Haj-Mahmoud" To: Heinrich Schuchardt , EDK II Development CC: Eric Jin , G Edhaya Chandran , Barton Gao , Samer El-Haj-Mahmoud Subject: Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion Thread-Topic: [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion Thread-Index: AQHWwCCyFjg47VXF40+fn4jgG3rxUqnVrPDA Date: Mon, 23 Nov 2020 12:46:13 +0000 Message-ID: References: <20201121160759.39842-1-xypron.glpk@gmx.de> In-Reply-To: <20201121160759.39842-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: gmx.de; dkim=none (message not signed) header.d=none;gmx.de; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: df50c10b-cf26-4df0-1559-08d88fadcd17 x-ms-traffictypediagnostic: DBBPR08MB4773:|AM0PR08MB4355: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:30;OLM:820; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eckcv3lr62sI7vUDOJ7xAXdR+Ksys+XpmxB1IaX8J0mLnwJ3U6o84n2DR4eZQHeytLRmEDwPLTP1ztF0hLRzBjUkW8Cf4NFRbim6RYYLsU4IUKxEFG89GVOFGDOVdQNnFebKPVkcCMNpkLaV3KRb1lu9MnL5b335Y/OqJctjIb+ZA/oZx/x/tz727ZRcms6aTZmDoU5bgUpM/rOd3TlW1hmgwARU5usSCV+9lVpD5l7oNbt5hyb9nHpVLbTSqJwynefmG5gA1cBupcKWkEX/YfZiy180zdu1ypWWq9yWSeE0YAkyGGChkKkD7Sn7+EqZaenyAqDZg/wCliw0BtP2tA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(136003)(366004)(39860400002)(86362001)(83380400001)(33656002)(52536014)(71200400001)(66446008)(9686003)(53546011)(5660300002)(66556008)(64756008)(26005)(76116006)(55016002)(6506007)(66946007)(66476007)(478600001)(316002)(186003)(4326008)(2906002)(7696005)(8676002)(54906003)(8936002)(19627235002)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: Vm9qwpXV8Jmt4uXsv/Lq9VEtFN/j5xT3f83VR83Z7FMdmYUrpyMRP8uDCT+toiuuYJKgFzfN9kcomtmgfXcc35Flv8DfhqdWccOBi16a4x5YxcDIrqT9l5jNvx1dRuv6fLkgij6btGdWOaOBwVeZShqhojPexDv6p1ErjNZy0UXeR8/IZM8AdDKiBBRpdjenGJV+QN2UVY/viWR10F7ju0n/sX6cDhYeO+KHHCUdyz4ENyitmLC0v0y+0hbaN30ac563IDPeCk2AWHDprFq3uZiC5g4eFCSMSJE5nXRHP2l/pbXa9gcBuvW/PdFWbDTwoUv//Pg9wR415RbuKQ1i0BmYq9pF5fSqmXM95bxbZOJfXAzrNP8xVWH5nxiqUTqZpRCY02kK1GLenasfx55SsZZznD1kaKaaFjYkaceTyJZCnrbEnBE3McG7Z7Xm7pIcjGGngOYSmdDRj4SxaQgnUQtDv+39K4L3EYZF/+m2bEX6jxBQSvJcNOPug0fvteId3q/WBcwi5oYBpmpsdwsajcL6GHebdQgTd0adpZrSKkz+c7ZR2oIrsC/3kL74tEqcrD+6pr8+Gtss+rd4reTeVy23YeolqPCy61z/PksDg3gMT4LbFBBWQ0cqRiZR9L5BGgo2ocSsOJTqg93mgl+Qsw== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4773 Original-Authentication-Results: gmx.de; dkim=none (message not signed) header.d=none;gmx.de; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4bb7258c-bcbc-461c-b2c3-08d88fadc2fe X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Bg5u/w8hzmUhEkeAiQr2bDdA/jiMSLGf7LybVjHWyO0dRUiiJ7YrRsTjVqsaAnvNCSngHmjL46a/bS5gazMPaaLtQvHgNTvTB2hGcSiFDqnEzYOuHPK1hAfaExCE+9h+qs8SbVbS3CN6QN328MTJ9gZnI5uOZ68lUWl9KMi4zUXGrwBnCCBwN95v6EXdgMQ+JJakmEdERQ9wz/lzlAW2HB3MYoHUIQJ9d7o809L68Pd/Ib/cJF9IfS9axYHwLbWksCyr9N8ao43ZJKYX26l5sIr/iFnPDlwclu5E0tXJQNVvb3KB4+1Jhq6bT0ky6NISXnRfwqZIvU9cxiq/4jyz8Jaa9aOBBTQw99ROQV8FU9IwRM4lpRnQlCxXHYLa6nn9lLz5muJkXnKFRt/LmT4TQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(346002)(376002)(39860400002)(46966005)(7696005)(81166007)(4326008)(8676002)(52536014)(2906002)(82310400003)(70586007)(55016002)(478600001)(8936002)(19627235002)(82740400003)(83380400001)(356005)(26005)(47076004)(9686003)(5660300002)(6506007)(86362001)(70206006)(33656002)(53546011)(336012)(54906003)(110136005)(186003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2020 12:46:30.4582 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df50c10b-cf26-4df0-1559-08d88fadcd17 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4355 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Samer El-Haj-Mahmoud > -----Original Message----- > From: Heinrich Schuchardt > Sent: Saturday, November 21, 2020 11:08 AM > To: EDK II Development > Cc: Eric Jin ; G Edhaya Chandran > ; Barton Gao ; > Samer El-Haj-Mahmoud ; Heinrich > Schuchardt > Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertio= n > > The functional tests for OpenEx() use RecordAssertion() statements that l= ack > a print code for the Tpl argument. This leads to a segmentation violation= . > > Signed-off-by: Heinrich Schuchardt > --- > .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++---- > .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c > index c2bf9b4fdc92..193383993cbe 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackB > +++ oxTest/SimpleFileSystemExBBTestFunction_OpenEx.c > @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid027, > L"OpenEx() Basic Test - checkpoint1 ----Test1----As= ync", > - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name = - %", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test3_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid039, > L"OpenEx() Basic Test - checkpoint1 ---Async", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %= s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test4_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid043, > L"OpenEx() Basic Test - checkpoint1 ---Async -- Tes= t4----Open > File", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %= s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test5_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid047, > L"OpenEx() Basic Test - checkpoint1 ---Async -- Tes= t5---Open File", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %= s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c > index 70ec88f1c065..894d42fc370d 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackB > +++ oxTest/SimpleFileSystemExBBTestFunction_OpenEx.c > @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid027, > L"OpenEx() Basic Test - checkpoint1 ----Test1----As= ync", > - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name = - %", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test3_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid039, > L"OpenEx() Basic Test - checkpoint1 ---Async", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %= s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test4_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid043, > L"OpenEx() Basic Test - checkpoint1 ---Async -- Tes= t4----Open > File", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %= s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test5_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid047, > L"OpenEx() Basic Test - checkpoint1 ---Async -- Tes= t5---Open File", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %= s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, > -- > 2.29.2 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.