* [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion @ 2020-11-21 16:07 Heinrich Schuchardt 2020-11-23 10:29 ` [edk2-devel] " Grant Likely 2020-11-23 12:46 ` Samer El-Haj-Mahmoud 0 siblings, 2 replies; 4+ messages in thread From: Heinrich Schuchardt @ 2020-11-21 16:07 UTC (permalink / raw) To: EDK II Development Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Samer El-Haj-Mahmoud, Heinrich Schuchardt The functional tests for OpenEx() use RecordAssertion() statements that lack a print code for the Tpl argument. This leads to a segmentation violation. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++---- .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemExBBTestFunction_OpenEx.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemExBBTestFunction_OpenEx.c index c2bf9b4fdc92..193383993cbe 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemExBBTestFunction_OpenEx.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemExBBTestFunction_OpenEx.c @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async ( EFI_TEST_ASSERTION_FAILED, gSimpleFileSystemExBBTestFunctionAssertionGuid027, L"OpenEx() Basic Test - checkpoint1 ----Test1----Async", - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name - %", + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", __FILE__, (UINTN)__LINE__, FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@ BBTestOpenExBasicTestCheckpoint1_Test3_Async ( EFI_TEST_ASSERTION_FAILED, gSimpleFileSystemExBBTestFunctionAssertionGuid039, L"OpenEx() Basic Test - checkpoint1 ---Async", - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", __FILE__, (UINTN)__LINE__, FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@ BBTestOpenExBasicTestCheckpoint1_Test4_Async ( EFI_TEST_ASSERTION_FAILED, gSimpleFileSystemExBBTestFunctionAssertionGuid043, L"OpenEx() Basic Test - checkpoint1 ---Async -- Test4----Open File", - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", __FILE__, (UINTN)__LINE__, FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@ BBTestOpenExBasicTestCheckpoint1_Test5_Async ( EFI_TEST_ASSERTION_FAILED, gSimpleFileSystemExBBTestFunctionAssertionGuid047, L"OpenEx() Basic Test - checkpoint1 ---Async -- Test5---Open File", - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", __FILE__, (UINTN)__LINE__, FileIoEntity->Tpl, diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemExBBTestFunction_OpenEx.c b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemExBBTestFunction_OpenEx.c index 70ec88f1c065..894d42fc370d 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemExBBTestFunction_OpenEx.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/SimpleFileSystemExBBTestFunction_OpenEx.c @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async ( EFI_TEST_ASSERTION_FAILED, gSimpleFileSystemExBBTestFunctionAssertionGuid027, L"OpenEx() Basic Test - checkpoint1 ----Test1----Async", - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name - %", + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", __FILE__, (UINTN)__LINE__, FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@ BBTestOpenExBasicTestCheckpoint1_Test3_Async ( EFI_TEST_ASSERTION_FAILED, gSimpleFileSystemExBBTestFunctionAssertionGuid039, L"OpenEx() Basic Test - checkpoint1 ---Async", - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", __FILE__, (UINTN)__LINE__, FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@ BBTestOpenExBasicTestCheckpoint1_Test4_Async ( EFI_TEST_ASSERTION_FAILED, gSimpleFileSystemExBBTestFunctionAssertionGuid043, L"OpenEx() Basic Test - checkpoint1 ---Async -- Test4----Open File", - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", __FILE__, (UINTN)__LINE__, FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@ BBTestOpenExBasicTestCheckpoint1_Test5_Async ( EFI_TEST_ASSERTION_FAILED, gSimpleFileSystemExBBTestFunctionAssertionGuid047, L"OpenEx() Basic Test - checkpoint1 ---Async -- Test5---Open File", - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", __FILE__, (UINTN)__LINE__, FileIoEntity->Tpl, -- 2.29.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion 2020-11-21 16:07 [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion Heinrich Schuchardt @ 2020-11-23 10:29 ` Grant Likely 2020-11-23 12:46 ` Samer El-Haj-Mahmoud 1 sibling, 0 replies; 4+ messages in thread From: Grant Likely @ 2020-11-23 10:29 UTC (permalink / raw) To: Heinrich Schuchardt, devel [-- Attachment #1: Type: text/plain, Size: 79 bytes --] Looks like an obvious fix Reviewed-by: Grant Likely <grant.likely@arm.com> [-- Attachment #2: Type: text/html, Size: 93 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion 2020-11-21 16:07 [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion Heinrich Schuchardt 2020-11-23 10:29 ` [edk2-devel] " Grant Likely @ 2020-11-23 12:46 ` Samer El-Haj-Mahmoud 2020-12-07 18:16 ` [edk2-devel] " G Edhaya Chandran 1 sibling, 1 reply; 4+ messages in thread From: Samer El-Haj-Mahmoud @ 2020-11-23 12:46 UTC (permalink / raw) To: Heinrich Schuchardt, EDK II Development Cc: Eric Jin, G Edhaya Chandran, Barton Gao, Samer El-Haj-Mahmoud Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> > -----Original Message----- > From: Heinrich Schuchardt <xypron.glpk@gmx.de> > Sent: Saturday, November 21, 2020 11:08 AM > To: EDK II Development <devel@edk2.groups.io> > Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran > <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; > Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Heinrich > Schuchardt <xypron.glpk@gmx.de> > Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion > > The functional tests for OpenEx() use RecordAssertion() statements that lack > a print code for the Tpl argument. This leads to a segmentation violation. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++---- > .../SimpleFileSystemExBBTestFunction_OpenEx.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c > index c2bf9b4fdc92..193383993cbe 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleFileSystem/BlackB > +++ oxTest/SimpleFileSystemExBBTestFunction_OpenEx.c > @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid027, > L"OpenEx() Basic Test - checkpoint1 ----Test1----Async", > - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name - %", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test3_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid039, > L"OpenEx() Basic Test - checkpoint1 ---Async", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test4_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid043, > L"OpenEx() Basic Test - checkpoint1 ---Async -- Test4----Open > File", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test5_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid047, > L"OpenEx() Basic Test - checkpoint1 ---Async -- Test5---Open File", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c > index 70ec88f1c065..894d42fc370d 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackBoxTest/Sim > pleFileSystemExBBTestFunction_OpenEx.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleFileSystem/BlackB > +++ oxTest/SimpleFileSystemExBBTestFunction_OpenEx.c > @@ -1155,7 +1155,7 @@ BBTestOpenExBasicTestCheckpoint1_Test1_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid027, > L"OpenEx() Basic Test - checkpoint1 ----Test1----Async", > - L"%a:%d: FileIoEntity->Tpl, Status - %r, File Name - %", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -2152,7 +2152,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test3_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid039, > L"OpenEx() Basic Test - checkpoint1 ---Async", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -2656,7 +2656,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test4_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid043, > L"OpenEx() Basic Test - checkpoint1 ---Async -- Test4----Open > File", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, @@ -3302,7 +3302,7 @@ > BBTestOpenExBasicTestCheckpoint1_Test5_Async ( > EFI_TEST_ASSERTION_FAILED, > gSimpleFileSystemExBBTestFunctionAssertionGuid047, > L"OpenEx() Basic Test - checkpoint1 ---Async -- Test5---Open File", > - L"%a:%d: FileIoEntity->Tpl,Status - %r,FileName - %s", > + L"%a:%d: Tpl - %d, Status - %r, FileName - %s", > __FILE__, > (UINTN)__LINE__, > FileIoEntity->Tpl, > -- > 2.29.2 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion 2020-11-23 12:46 ` Samer El-Haj-Mahmoud @ 2020-12-07 18:16 ` G Edhaya Chandran 0 siblings, 0 replies; 4+ messages in thread From: G Edhaya Chandran @ 2020-12-07 18:16 UTC (permalink / raw) To: Samer El-Haj-Mahmoud, devel [-- Attachment #1: Type: text/plain, Size: 174 bytes --] Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com> Upstreamed by commit-id : https://github.com/tianocore/edk2-test/commit/00257df4e7a6b80548d60731448e18ec1feb4476 [-- Attachment #2: Type: text/html, Size: 192 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-07 18:16 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-11-21 16:07 [PATCH edk2-test 1/1] uefi-sct/SctPkg: OpenEx incorrect assertion Heinrich Schuchardt 2020-11-23 10:29 ` [edk2-devel] " Grant Likely 2020-11-23 12:46 ` Samer El-Haj-Mahmoud 2020-12-07 18:16 ` [edk2-devel] " G Edhaya Chandran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox