From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
"Andrei Warkentin (awarkentin@vmware.com)"
<awarkentin@vmware.com>,
Andrei Warkentin <andrey.warkentin@gmail.com>,
"leif@nuviainc.com" <leif@nuviainc.com>
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
"pete@akeo.ie" <pete@akeo.ie>,
"philmd@redhat.com" <philmd@redhat.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
Date: Mon, 7 Dec 2020 18:31:06 +0000 [thread overview]
Message-ID: <DB7PR08MB326073924360339F53AD0E8E90CE0@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1649DBEB9E2C2292.16773@groups.io>
[-- Attachment #1: Type: text/plain, Size: 4553 bytes --]
Any update on getting this merged?
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-Haj-Mahmoud via groups.io
Sent: Sunday, November 22, 2020 9:49 AM
To: devel@edk2.groups.io; Andrei Warkentin (awarkentin@vmware.com) <awarkentin@vmware.com>; Andrei Warkentin <andrey.warkentin@gmail.com>; leif@nuviainc.com
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; pete@akeo.ie; philmd@redhat.com; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com<mailto:Samer.El-Haj-Mahmoud@arm.com>>
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Andrei Warkentin via groups.io
Sent: Wednesday, November 18, 2020 6:21 PM
To: Andrei Warkentin <andrey.warkentin@gmail.com<mailto:andrey.warkentin@gmail.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; leif@nuviainc.com<mailto:leif@nuviainc.com>
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com<mailto:Ard.Biesheuvel@arm.com>>; pete@akeo.ie<mailto:pete@akeo.ie>; philmd@redhat.com<mailto:philmd@redhat.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
Hi Leif,
I got these from https://www.raspberrypi.org/documentation/hardware/raspberrypi/revision-codes/README.md
A
________________________________
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Leif Lindholm via groups.io <leif=nuviainc.com@groups.io<mailto:leif=nuviainc.com@groups.io>>
Sent: Tuesday, November 17, 2020 10:02 AM
To: Andrei Warkentin <andrey.warkentin@gmail.com<mailto:andrey.warkentin@gmail.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com> <ard.biesheuvel@arm.com<mailto:ard.biesheuvel@arm.com>>; pete@akeo.ie<mailto:pete@akeo.ie> <pete@akeo.ie<mailto:pete@akeo.ie>>; philmd@redhat.com<mailto:philmd@redhat.com> <philmd@redhat.com<mailto:philmd@redhat.com>>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs
Hi Andrei,
On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote:
> Like the Pi 4B, the 3GB/4GB choices apply to it as well.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com<mailto:andrey.warkentin@gmail.com>>
Patch looks straghtforward enough, but ideally I'd like someone to
chime in with tested-by. That hasn't happened so far - are these
documented anywhere I could easily sanity check myself?
/
Leif
> ---
> Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> index 5302ccd8..ade91c9f 100644
> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> @@ -596,6 +596,10 @@ RpiFirmwareGetModelName (
> return "Raspberry Pi Compute Module 3+";
> case 0x11:
> return "Raspberry Pi 4 Model B";
> + case 0x13:
> + return "Raspberry Pi 400";
> + case 0x14:
> + return "Raspberry Pi Compute Module 4";
> default:
> return "Unknown Raspberry Pi Model";
> }
> @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily (
> *ModelFamily = 3;
> break;
> case 0x11: // Raspberry Pi 4 Model B
> + case 0x13: // Raspberry Pi 400
> + case 0x14: // Raspberry Pi Computer Module 4
> *ModelFamily = 4;
> break;
> default:
> --
> 2.20.1
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 9217 bytes --]
next prev parent reply other threads:[~2020-12-07 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 10:25 [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs Andrei Warkentin
2020-11-17 16:02 ` Leif Lindholm
2020-11-18 23:21 ` [edk2-devel] " Andrei Warkentin
2020-11-22 14:48 ` Samer El-Haj-Mahmoud
[not found] ` <1649DBEB9E2C2292.16773@groups.io>
2020-12-07 18:31 ` Samer El-Haj-Mahmoud [this message]
2020-12-08 8:10 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB326073924360339F53AD0E8E90CE0@DB7PR08MB3260.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox