From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.70]) by mx.groups.io with SMTP id smtpd.web10.55.1607365897703992770 for ; Mon, 07 Dec 2020 10:31:39 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=y8snYGtF; spf=pass (domain: arm.com, ip: 40.107.14.70, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gue2EWAt6X+VHH3V8p5goWMf3SOupmz8Fz5nAQxDUSI=; b=y8snYGtFnv7aMC4dAgefwQEGX3LtgWRKx0F4txIRcAVxo4cpsrZvR0u7sXZhKLfyOvJCFkbxr127Gi6GmtEAn/F0Ug8Q07fKCRswkYVkVP87UoSEIJ6+iZeUHrWERIoa+VkYWLUVM9uMsyhqB8GZCHB7H+t3hYpfjMtgxM6E75o= Received: from AM6PR08CA0003.eurprd08.prod.outlook.com (2603:10a6:20b:b2::15) by HE1PR08MB2905.eurprd08.prod.outlook.com (2603:10a6:7:31::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Mon, 7 Dec 2020 18:31:29 +0000 Received: from AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:b2:cafe::3b) by AM6PR08CA0003.outlook.office365.com (2603:10a6:20b:b2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Mon, 7 Dec 2020 18:31:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT012.mail.protection.outlook.com (10.152.16.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Mon, 7 Dec 2020 18:31:29 +0000 Received: ("Tessian outbound eeda57fffe7b:v71"); Mon, 07 Dec 2020 18:31:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b5d2862e63254729 X-CR-MTA-TID: 64aa7808 Received: from 40a7bee5b581.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 69A49F57-ED05-4C20-A488-CD251ADB2E16.1; Mon, 07 Dec 2020 18:31:13 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 40a7bee5b581.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Dec 2020 18:31:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A9uJsYB9JcP9npIFk9AzunSxzR/XkO4yPutvXDvqwx29iZJygPLwZNbQ9YVe0SXBrH/w0V83AcgSR6IldOQZTMvuLEfB0qBrE/D76e9agsac8CCpkK7cc0exLwyfX0mi6OaPYjMsN4R+RWOQUNYEZWQ7NWWJK/xJLbdYdNeMUclYnHD3AcheqwFW0GpyJgT+IXZnO9VAXW8omKgUczRjACK4NFASwQZoSkpixNCuNlgNFnFaXadPAaQ4ehxwzKYqmmrlzj5PTZtzd+DaOXFG8FR7XEvxLnZepQULhiBZa8rn7uVRMvFP1hNkjAtKr2X1wKve4QGK7D6SEsbmUYtftg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gue2EWAt6X+VHH3V8p5goWMf3SOupmz8Fz5nAQxDUSI=; b=AK0F1kFzoRdp2VvWGV3QHLvqLGF1IaGOeWReXosZPH/tTd0ppONMhfwHxe7tkQK0KwvrXgzGI+OORvk55KEhk+7viipP7QGoWtpxwoPAHoK04tknsecAytmVLLvAjGySeiKVU6TuA1r8Mis5pAsPZsXDSy3X2R8MksoJ5Y9bno8LIhmBm3BMSQ4oRrTamop/W2vuVNLPUzihVNHoVDsqcamOXFaClaqE+A7y+Y12Xte5G3108EGcZhgwRcouaO+GzExn9LZFngkoI/ZeOzjho+Ro/5TEOij1csnB8OQPve+sGxR0uJj7p0VoYO7PctAEqU8vmaApueqKzL0xY4ruew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gue2EWAt6X+VHH3V8p5goWMf3SOupmz8Fz5nAQxDUSI=; b=y8snYGtFnv7aMC4dAgefwQEGX3LtgWRKx0F4txIRcAVxo4cpsrZvR0u7sXZhKLfyOvJCFkbxr127Gi6GmtEAn/F0Ug8Q07fKCRswkYVkVP87UoSEIJ6+iZeUHrWERIoa+VkYWLUVM9uMsyhqB8GZCHB7H+t3hYpfjMtgxM6E75o= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB8PR08MB4138.eurprd08.prod.outlook.com (2603:10a6:10:a4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17; Mon, 7 Dec 2020 18:31:07 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::a1f1:ccfd:b17f:a490]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::a1f1:ccfd:b17f:a490%5]) with mapi id 15.20.3632.018; Mon, 7 Dec 2020 18:31:06 +0000 From: "Samer El-Haj-Mahmoud" To: "devel@edk2.groups.io" , Samer El-Haj-Mahmoud , "Andrei Warkentin (awarkentin@vmware.com)" , Andrei Warkentin , "leif@nuviainc.com" CC: Ard Biesheuvel , "pete@akeo.ie" , "philmd@redhat.com" , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: add CM4 and 400 as BCM2711 designs Thread-Index: AQHWuznADLBSK5f+vEO619W5iGX2xKnMf8SAgAIM2ACABboOsIAX0PNQ Date: Mon, 7 Dec 2020 18:31:06 +0000 Message-ID: References: <20201115102527.2993-1-andrey.warkentin@gmail.com>,<20201117160255.GG1664@vanye> <1649DBEB9E2C2292.16773@groups.io> In-Reply-To: <1649DBEB9E2C2292.16773@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e44e28e1-6545-4cd2-bbf5-08d89ade503a x-ms-traffictypediagnostic: DB8PR08MB4138:|HE1PR08MB2905: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: K7rmwcXiylcaZuTSvgRljGQhy2rsc42U11mFGl/ROsZItEyZTT3rb/LDiUdcdjvRr7Hq0/AvHiM779ZH+3vP3EMYIeFIjcILvwkKprhm0M/T6755jmH1AF8bvvvM7ENqCuz97aMufYyBmFK/+B7EzhXdu12m3VQnW5ChFS0ClpTqEwslhH8tPUAogkifA/uMybMORBn7kS7eMaUQd6cHYtjbwFzjC+E8kwXUvVTpSp2qVqj/1ZEiADi+u/N/ozDWUjot2SCFjIVQ9K9zzH5kGRkO0oZX6spzy9BJ5uYN7HdJRXnSMG+JgzExvSZa8NJGyhcMKQLZ3hoi/x4q/ilv5TRXTa8d2ZNSQElh+QKYxEQ4L97LSLbr+JPs7qhgFRMRA3yXwzcU2KqGhdgbGIKAcQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(66476007)(316002)(86362001)(71200400001)(64756008)(54906003)(76236003)(66556008)(110136005)(76116006)(166002)(966005)(4326008)(66446008)(83380400001)(66946007)(478600001)(2906002)(9686003)(33656002)(8936002)(8676002)(6506007)(53546011)(186003)(26005)(55016002)(52536014)(5660300002)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?oIudmqRZa+PVOmRxYGM+VmGJtLcV5Z2mPpmiIdRAht8gxxTaJ+coDm8FA0zr?= =?us-ascii?Q?qWCcljdw+mzZb/tXHDFqu2q5s1z7QYbcNdq+XUbD4NztJ0RM6qoWox/VILsX?= =?us-ascii?Q?D+HbqrsiA1ZDCMc7LtASRkub02vMuEdJ1gEfXhiUpHVTPg17GzVumO1Wsnfx?= =?us-ascii?Q?81ohcTkJKrcN9fvlOOUpXnZq3dVwh1g5YWMTINbWV/QKBMWmI5h5hW1OYcLV?= =?us-ascii?Q?UMUQkcfdmF4Hp0zBWrDOmd26WF08ZPmJz7UXr3HK2keEPUoveqo0XPhqpI08?= =?us-ascii?Q?SBiZ0VsVLGiDjbLoFq+oq52PuDFdsq1+GyQRlr6t0MSW+MuKJwspDkSDL5or?= =?us-ascii?Q?6qhp6Gl2w77SGLlWB9P2fRU/jsTK+SKoVlRxm2U7e+veuQrha89TihgrQdPJ?= =?us-ascii?Q?xPoLCKCdhwukpV178RTM1Ge8P8/ZZwl8iQNn165AAICtLGcbH6ifNvoLT2Ut?= =?us-ascii?Q?+vdqBTCRKU5WP/UVswdIY5HYUSMJCRX4ijswNCLhfJqpmFVr4mBy3vWnCr9a?= =?us-ascii?Q?c+SILSutqIiJiI4OiwT/O0bW/Asg5B6vYxbGDTGvXP1b2oVGRRxxcc+BBDK4?= =?us-ascii?Q?2x6XvTAbEhQxEsQKCDXMMUZQP7s3el0fyWY1DMzYTKZamCBRlBjw//3OB1/K?= =?us-ascii?Q?pM7piVjQvw0V4+QBcItxu9ZaZS/pqIsMT/j/k58ApjItYf3QQHBEu/pjMpcZ?= =?us-ascii?Q?bpIcPX7V3DTP8leAYMEACMvOezdDLMWIW5iJxhWiyB86rr3rs8mLygZSCLox?= =?us-ascii?Q?m52sn17jLOL+lALV5m1KNPdJc+5QnyvLXtY3I7HncoWvinb7xoKTDpSEu3yv?= =?us-ascii?Q?seFWRbAKaAvaYPGRGQ0xdpzifl6ewBtMLFgVjq3I8P5Y8WbZJu/TrY1XRUMU?= =?us-ascii?Q?BVDSlTUDeL5XGsd9LMdkbiDdDDOXS74PTTmhmFonue0abuP5Ppus4JA8Ce11?= =?us-ascii?Q?g9ijhjoCdhezrNfmG0tNsie+f11XRIhBwUuGjcu9z/s=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4138 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1ea6a9b9-4b3c-43f2-4725-08d89ade42e4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lZwYsVQ4J2vytrOkk1H8JjpwcIpbUsLoKnpHIlFYsOcOO2k4sXYOheq5hG/4hkzoTVJrF7bLRwuxRY15yN8bXWsm752EswJHm4cUYJpXhOrs0Z0SpulwmDAl+eR7gVnG2vP8qd1+bqAaRcPYV5PTRYk9NfIOarts/ODx8ttB/N4rF/aPuBECw6DnLFtWWHtHY1k1ubdd3ZxASumXt1UpMG0dqIVS3WHbcrovY6yqkCfvg+N59sfADHdsTT6wPlYsgzBhwvjElTPqJIQvpanaoXxijmOOvRk3mUU0XJZUDwvjAGNA1zG55vLapb7Xnn9Mis4N6pV55iI79Hcp4eppdKZTXUKGYcTp2B93HqwGoY4OZHD+JRbRtQU5hPxquPcxQwaloVxjPRCtcI9vdBQ5cUkpnmtRYSLgzWLPUVW8K2o6LTlrutdyHjFKs15nK9dSqX1z9KHBcUl1r9MXbcxnfBawTl4yW+nyVbvOmuqZVHs= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(46966005)(336012)(81166007)(86362001)(9686003)(70586007)(166002)(52536014)(6506007)(356005)(55016002)(76236003)(7696005)(70206006)(33656002)(83380400001)(82310400003)(110136005)(8936002)(186003)(26005)(82740400003)(478600001)(53546011)(966005)(54906003)(8676002)(4326008)(36906005)(5660300002)(316002)(47076004)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2020 18:31:29.1559 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e44e28e1-6545-4cd2-bbf5-08d89ade503a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2905 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DB7PR08MB326073924360339F53AD0E8E90CE0DB7PR08MB3260eurp_" --_000_DB7PR08MB326073924360339F53AD0E8E90CE0DB7PR08MB3260eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Any update on getting this merged? From: devel@edk2.groups.io On Behalf Of Samer El-Ha= j-Mahmoud via groups.io Sent: Sunday, November 22, 2020 9:49 AM To: devel@edk2.groups.io; Andrei Warkentin (awarkentin@vmware.com) ; Andrei Warkentin ; leif@nuvia= inc.com Cc: Ard Biesheuvel ; pete@akeo.ie; philmd@redhat.c= om; Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryP= i: add CM4 and 400 as BCM2711 designs Reviewed-by: Samer El-Haj-Mahmoud > From: devel@edk2.groups.io > On Behalf Of Andrei Warkentin via groups.= io Sent: Wednesday, November 18, 2020 6:21 PM To: Andrei Warkentin >; devel@edk2.groups.io; leif@nuviain= c.com Cc: Ard Biesheuvel >= ; pete@akeo.ie; philmd@redhat.com Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryP= i: add CM4 and 400 as BCM2711 designs Hi Leif, I got these from https://www.raspberrypi.org/documentation/hardware/raspbe= rrypi/revision-codes/README.md A ________________________________ From: devel@edk2.groups.io > on behalf of Leif Lindholm via groups.io = > Sent: Tuesday, November 17, 2020 10:02 AM To: Andrei Warkentin > Cc: devel@edk2.groups.io >; ard.biesheuvel@arm.com >; pete@a= keo.ie >; philmd@red= hat.com > Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryP= i: add CM4 and 400 as BCM2711 designs Hi Andrei, On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote: > Like the Pi 4B, the 3GB/4GB choices apply to it as well. > > Signed-off-by: Andrei Warkentin > Patch looks straghtforward enough, but ideally I'd like someone to chime in with tested-by. That hasn't happened so far - are these documented anywhere I could easily sanity check myself? / Leif > --- > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.= c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > index 5302ccd8..ade91c9f 100644 > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -596,6 +596,10 @@ RpiFirmwareGetModelName ( > return "Raspberry Pi Compute Module 3+"; > case 0x11: > return "Raspberry Pi 4 Model B"; > + case 0x13: > + return "Raspberry Pi 400"; > + case 0x14: > + return "Raspberry Pi Compute Module 4"; > default: > return "Unknown Raspberry Pi Model"; > } > @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily ( > *ModelFamily =3D 3; > break; > case 0x11: // Raspberry Pi 4 Model B > + case 0x13: // Raspberry Pi 400 > + case 0x14: // Raspberry Pi Computer Module 4 > *ModelFamily =3D 4; > break; > default: > -- > 2.20.1 > IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. --_000_DB7PR08MB326073924360339F53AD0E8E90CE0DB7PR08MB3260eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Any update on getting this merged?

 

From: devel@edk2.groups.io <devel@edk2.gr= oups.io> On Behalf Of Samer El-Haj-Mahmoud via groups.io
Sent: Sunday, November 22, 2020 9:49 AM
To: devel@edk2.groups.io; Andrei Warkentin (awarkentin@vmware.com) = <awarkentin@vmware.com>; Andrei Warkentin <andrey.warkentin@gmail.= com>; leif@nuviainc.com
Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; pete@akeo.ie; ph= ilmd@redhat.com; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com><= br> Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/Ras= pberryPi: add CM4 and 400 as BCM2711 designs

 

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

 

From: devel@edk2.groups.io <deve= l@edk2.groups.io> On Behalf Of Andrei Warkentin via groups.io
Sent: Wednesday, November 18, 2020 6:21 PM
To: Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2.groups.io; leif@nuviainc.com
Cc: Ard Biesheuvel <Ar= d.Biesheuvel@arm.com>; pete@akeo.ie; philmd@redhat.com
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/Ras= pberryPi: add CM4 and 400 as BCM2711 designs

 

Hi Leif,

 

 

A

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf o= f Leif Lindholm via groups.io <leif=3Dnuviainc.com@groups.io>
Sent: Tuesday, November 17, 2020 10:02 AM
To: Andrei Warkentin <andrey.warkentin@gmail.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; ard.biesheuvel@arm.com <<= a href=3D"mailto:ard.biesheuvel@arm.com">ard.biesheuvel@arm.com>; pete@akeo.ie <pete@akeo.ie>; philmd@redhat.com <philmd@redhat.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/Ras= pberryPi: add CM4 and 400 as BCM2711 designs

 

Hi Andrei,

On Sun, Nov 15, 2020 at 04:25:27 -0600, Andrei Warkentin wrote:
> Like the Pi 4B, the 3GB/4GB choices apply to it as well.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>

Patch looks straghtforward enough, but ideally I'd like someone to
chime in with tested-by. That hasn't happened so far - are these
documented anywhere I could easily sanity check myself?

/
    Leif

> ---
>  Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | = 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareD= xe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c
> index 5302ccd8..ade91c9f 100644
> --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -596,6 +596,10 @@ RpiFirmwareGetModelName (
>      return "Raspberry Pi Compute Modul= e 3+";
>    case 0x11:
>      return "Raspberry Pi 4 Model B&quo= t;;
> +  case 0x13:
> +    return "Raspberry Pi 400";
> +  case 0x14:
> +    return "Raspberry Pi Compute Module 4";=
>    default:
>      return "Unknown Raspberry Pi Model= ";
>    }
> @@ -670,6 +674,8 @@ RPiFirmwareGetModelFamily (
>        *ModelFamily =3D 3;
>        break;
>    case 0x11:       = ;   // Raspberry Pi 4 Model B
> +  case 0x13:        &nb= sp; // Raspberry Pi 400
> +  case 0x14:        &nb= sp; // Raspberry Pi Computer Module 4
>        *ModelFamily =3D 4;
>        break;
>    default:
> --
> 2.20.1
>



IMPORTANT NOTICE: The contents of this email and an= y attachments are confidential and may also be privileged. If you are not t= he intended recipient, please notify the sender immediately and do not disc= lose the contents to any other person, use it for any purpose, or store or copy the information in any medium. T= hank you.

IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in any medium. Thank you. --_000_DB7PR08MB326073924360339F53AD0E8E90CE0DB7PR08MB3260eurp_--