From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.53]) by mx.groups.io with SMTP id smtpd.web10.13107.1605127999477417727 for ; Wed, 11 Nov 2020 12:53:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=wYgTcJdY; spf=pass (domain: arm.com, ip: 40.107.20.53, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4UhvtS/TOgPmdXgq0ONqm80mC6/W/99e5we5CbKTGjU=; b=wYgTcJdYWtoEbCTGxRnNmuOK8LO9WJnZ5qXXDOLaAruforlbKFZ0W+iYLS7YJFbG0UCJvMSq91stzrzdxVa1h4zqJjYxWQmM9oKyeEX8CSZqQ1Qh4RfU4xqzYodymzY7PpsXpkM1Sy9XjlqHnw9WCREjt1C1ezOlHov5ZvOZx+I= Received: from DB6P192CA0020.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::30) by PR3PR08MB5786.eurprd08.prod.outlook.com (2603:10a6:102:85::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Wed, 11 Nov 2020 20:53:17 +0000 Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::a0) by DB6P192CA0020.outlook.office365.com (2603:10a6:4:b8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Wed, 11 Nov 2020 20:53:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22 via Frontend Transport; Wed, 11 Nov 2020 20:53:16 +0000 Received: ("Tessian outbound 797fb8e1da56:v71"); Wed, 11 Nov 2020 20:53:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5715a91bba26ff52 X-CR-MTA-TID: 64aa7808 Received: from f7112a8d15e6.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2EA9082C-60A0-4ED7-9815-FAB1F9693728.1; Wed, 11 Nov 2020 20:53:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f7112a8d15e6.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Nov 2020 20:53:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHUHjykR0pjfArKvVuJfBdLgpojXy+ju3fIPPnCO8fIrQ2aBW2hQ8M4HZwb5u9TW23uOPAzGzroHbVC+bG/iMBpBu6U+kO8OdnI4FQPMNcHhSOqZ9KgsnZgb0aicjjeuynIqGjY3PxbOmUTn4T9qCA28SrQL8LXyikhHf1GI8b3+NeHU6m+I5VcjRTMhM/CfblZ6xqeV1nKMdUvRbAGJabWY1Ha5AV1WbzQptNLQMLbY+wL5Jo0E1x34sRe+I/w98N+JsHnOHN+jZUTrNMgWHWrIZsWFSi0mYIhfmpeRV+8wPsiiXgpoYvKTVn2p1cLLgcAdD+z/w4xJnR+ETaUqaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4UhvtS/TOgPmdXgq0ONqm80mC6/W/99e5we5CbKTGjU=; b=TXBePQmlIGmQkYWy9zzc7K7KPY9iBUq8+f02FRRXqA/BbPQl/32Vcn0VDQ5PJztH/Qc/STotgrkpRRAXQ0KRtekQgfQMRPXxvk++igKEfW3vv7hi1x78svBS0jYHG8jQIxSGsQO2kF1gOEn+WKBDwo6vOkkJ23eGLGPu/34fs5Cun6vQN3pPSLN/xtNiXhKi3MCt5QClLGZR3RL+A4jynHSKdgdcy0JQJLQtv9qLzI8aKt6s2xyyFmDB0kJj1v1C/EVmdnM2McKSZmTNXzuSF5wIdKGQ/hqdOf3wjH9mDvi88swQ04xyRCczr/055Yt0OVtHYF8nVog6kUEzPgNKVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4UhvtS/TOgPmdXgq0ONqm80mC6/W/99e5we5CbKTGjU=; b=wYgTcJdYWtoEbCTGxRnNmuOK8LO9WJnZ5qXXDOLaAruforlbKFZ0W+iYLS7YJFbG0UCJvMSq91stzrzdxVa1h4zqJjYxWQmM9oKyeEX8CSZqQ1Qh4RfU4xqzYodymzY7PpsXpkM1Sy9XjlqHnw9WCREjt1C1ezOlHov5ZvOZx+I= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DBAPR08MB5798.eurprd08.prod.outlook.com (2603:10a6:10:1a6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Wed, 11 Nov 2020 20:53:07 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6%7]) with mapi id 15.20.3499.034; Wed, 11 Nov 2020 20:53:07 +0000 From: "Samer El-Haj-Mahmoud" To: Grant Likely , "devel@edk2.groups.io" CC: nd , Grant Likely , G Edhaya Chandran , Eric Jin , Barton Gao , Samer El-Haj-Mahmoud Subject: Re: [edk2-test] [PATCH] Fix missing symbols on edk2-test build Thread-Topic: [edk2-test] [PATCH] Fix missing symbols on edk2-test build Thread-Index: AQHWuEPoL5v4NdpS4EujTxRoUS6jSKnDaCYA Date: Wed, 11 Nov 2020 20:53:06 +0000 Message-ID: References: <20201111160010.8881-1-grant.likely@arm.com> In-Reply-To: <20201111160010.8881-1-grant.likely@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f68f8d01-f113-4188-4264-08d88683d080 x-ms-traffictypediagnostic: DBAPR08MB5798:|PR3PR08MB5786: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: P+GuHlB+ZEw+4SYuMu1rN72EKu7zXvjTAghztMGFe5SSG+pigFnwbe8y3evkxDBW6X4BPQ0BosF8IfMvFuPvg31YRLRq0Gz4+X2byjECQKWKMMhCrE1xJ4m1hwx4a1ACWqLVkA4rJ8vJancZUv9IFmg5435JRiQFq1jZVKEFM0pqmIAxAqsJOmeQnCmROKvXc7I70Q8fYWP4XP0NScvbC4ZueG53cygatld6fadsdYt8K3zIBr/C9kqc9QBjA0ZMTEzptMtT0GXMV7YbDRHsFAzYU7xrhyZzHlmk7EpIulzF3/w4FPPRt7jkNqxd8VurLlNQjCEFUEWy5m3sZzKVzA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(396003)(366004)(376002)(136003)(346002)(66476007)(66556008)(8676002)(76116006)(53546011)(6506007)(66946007)(86362001)(8936002)(186003)(71200400001)(5660300002)(9686003)(7696005)(4326008)(26005)(55016002)(52536014)(54906003)(110136005)(33656002)(64756008)(316002)(2906002)(66574015)(83380400001)(478600001)(66446008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 09Z3/LYIJC3B+0LJnVEzK9K1yJaKttkbrBs1rpjxBv/v84ZIieLQFPCuilNy7vRQrokC1QNN7FT7x1VqL+hR/+jVeHdF+Ht1UB9bC+4fEuIlmIKM2Wn5uR0e28xP4ZuhYztiBjV0dpZrq6JER7K0oZOHFGL6E2sUZMUHjnXvDrycjlzSqRpz5TL7OdLpbvcff2vs2WH3m5Xc9oP1QIHpGQxP8Qx9qxtNfrTP3TpzNZk4KQCF2RsQh9CSwGDXlBZqTtjvDbfPBO99x9YjC3RovIN1n8lfgGUQ7x5Y2K9qWpHX5YbXDVWBlzBIwZLGp7PcjTVEhQBlQfjKouZmI7RSguI+s4AD/S22lXOfJPYjTkrUhftIkcKsVHACv6Thdat2NaxZ5vD/CIGnAJkm1As9xfyOclJ6xwb7wHmjphDCWxUsNruj9QRpc7OHGkGp5yNrtfO8i4RWvOryeY4EVPkulIQHebFQ/oie8VIOemVzx5d3NtFP2b5HAFux8FG6nmWsf8HX3+8ZZDqHRZ0TgUtroUx3lR+NqIjRvUlf1+5u0ayFjrUqSjkUCOwjWsPliNDNka0WiVXpS/8UMQvXMNW2u6AMP2YbNBjIN1H6HBZU+oxzZI2gx2Op2EXGRn6YxiBtkZgo9BqHOWO/33KhQfDWnQ== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5798 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 802712d3-30fa-4229-3196-08d88683ca99 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G1RETGcsj2ZL4Z+Zl6sQvzIcL53f2LBPGrL1gGjhOa44hk6Jf+pnQL2C1WCNlmjLYCk/Q/82wCVWz7nN5I5hiuFLJPoel39ILKpt8OGCCC9VGzrMsuVZ19CxtNzZYCpxhjE4IzWr4EA67xjulX7TeTByB2ONSzMC3VMkHQWv2/IlWevACJyffF/+RXmUu42QVR8IxdR4z/NvewHGGGE6Twb8rWA11WP+BrM7+CgngCGrAyYN8JYczgH7hlscu8mpC1cAQctooLjh+BHEoJhWxL3tF7bCCZI1v+GhrpIi7UamzmfQZF4+htSEfIyDM/ke4LSlx+osyiMmx3NcX6czu7PXPTBhUzz/P/TrUbr4NhvYJigM/YZRmjWrebhRpZ/wht2+lNsL9G2UcO3WpxypVg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(376002)(346002)(396003)(136003)(46966005)(33656002)(52536014)(478600001)(53546011)(2906002)(7696005)(66574015)(47076004)(83380400001)(6506007)(8936002)(186003)(336012)(8676002)(81166007)(82310400003)(26005)(110136005)(82740400003)(356005)(70586007)(70206006)(55016002)(9686003)(4326008)(316002)(86362001)(54906003)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2020 20:53:16.9769 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f68f8d01-f113-4188-4264-08d88683d080 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5786 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Samer El-Haj-Mahmoud > -----Original Message----- > From: Grant Likely > Sent: Wednesday, November 11, 2020 11:00 AM > To: devel@edk2.groups.io > Cc: nd ; Grant Likely ; Grant Likely > ; Samer El-Haj-Mahmoud Mahmoud@arm.com>; G Edhaya Chandran ; > Eric Jin ; Barton Gao > Subject: [edk2-test] [PATCH] Fix missing symbols on edk2-test build >=20 > EDK2 has removed some deprecated function wrappers. The BlackBoxTest > still uses StrnCpy() and UnicodeValueToString(). This patch fixes the > build by moving to UnicodeValueToStringS(). However, the code using > StrnCpy() is simply #ifdef'd out because on reading the code it is > apparent that the testcase is non-functional and the fix is not > straightforward. As I understand it, there are no functional > implementations of the interface in the wild anyway. If/when it does > become important someone can do the work of making a proper test case. >=20 > Fixes: Bug 2068 >=20 > Signed-off-by: Grant Likely > Cc: Samer El-Haj-Mahmoud > Cc: G Edhaya Chandran > Cc: Eric Jin > Cc: Barton Gao > --- > .../Dependency/SampleDriver/DriverSample.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) >=20 > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index fe973a33..584ee8b4 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > @@ -920,8 +920,9 @@ ExtractConfig ( >=20 > BackupChar =3D Value[ValueStrLen]; > *Value++ =3D L'=3D'; > - Value +=3D UnicodeValueToString ( > + Value +=3D UnicodeValueToStringS ( > Value, > + BufferSize - (Value - *Results), > PREFIX_ZERO | RADIX_HEX, > PrivateData->Configuration.NameValueVar0, > sizeof (PrivateData->Configuration.NameValueVar0) * 2 > @@ -939,8 +940,9 @@ ExtractConfig ( >=20 > BackupChar =3D Value[ValueStrLen]; > *Value++ =3D L'=3D'; > - Value +=3D UnicodeValueToString ( > + Value +=3D UnicodeValueToStringS ( > Value, > + BufferSize - (Value - *Results), > PREFIX_ZERO | RADIX_HEX, > PrivateData->Configuration.NameValueVar1, > sizeof (PrivateData->Configuration.NameValueVar1) * 2 > @@ -962,7 +964,8 @@ ExtractConfig ( > // > StrPointer =3D (CHAR16 *) PrivateData->Configuration.NameValueVar2= ; > for (; *StrPointer !=3D L'\0'; StrPointer++) { > - Value +=3D UnicodeValueToString (Value, PREFIX_ZERO | RADIX_HEX, > *StrPointer, 4); > + Value +=3D UnicodeValueToStringS (Value, BufferSize - (Value - *= Results), > + PREFIX_ZERO | RADIX_HEX, *StrPoi= nter, 4); > } > } >=20 > @@ -1894,7 +1897,7 @@ DriverSampleInit ( > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > -#if 1 > +#if 0 > EFI_STRING Progress; > EFI_STRING Results; > UINT32 ProgressErr; > @@ -2243,7 +2246,9 @@ DriverSampleInit ( > HiiRemovePackages (HiiHandle[1]); > } >=20 > -#if 1 > +#if 0 // gcl - This test case is incomplete and fails to compile. StrnCp= y needs > to be > + // changed to StrnCpyS() to fix build error, but there is a larger= problem > that > + // the testcases don't match the spec or test any behaviour > // > // Test Cases 1: Keyword - GetData and change the value by SetData > // > -- > 2.20.1