Re: [edk2-devel] [PATCH v6 02/22] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h

["Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>]

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Thursday, January 14, 2021 11:36 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Leif Lindholm
> <leif@nuviainc.com>; Ard Biesheuvel <Ard.Biesheuvel@arm.com>; nd
> <nd@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Michael D Kinney
> <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>; Sami
> Mujawar <Sami.Mujawar@arm.com>
> Subject: [edk2-devel] [PATCH v6 02/22] ArmPkg: Add ARM SMC Architecture
> functions to ArmStdSmc.h
> 
> The ARM SMC Architecture functions were missing from ArmStdSmc.h.
> Add them, based on the SMC Calling Convention version 1.2 specification.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>  ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> index 3509eb680f18..9e0a3a3960d5 100644
> --- a/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> +++ b/ArmPkg/Include/IndustryStandard/ArmStdSmc.h
> @@ -1,9 +1,13 @@
>  /** @file
>  *
> +*  Copyright (c) 2020, NUVIA Inc. All rights reserved.<BR>
>  *  Copyright (c) 2012-2017, ARM Limited. All rights reserved.
>  *
>  *  SPDX-License-Identifier: BSD-2-Clause-Patent
>  *
> +* @par Revision Reference:
> +*  - SMC Calling Convention version 1.2
> +*    (https://developer.arm.com/documentation/den0028/c/?lang=en)
>  **/
> 
>  #ifndef __ARM_STD_SMC_H__
> @@ -52,6 +56,18 @@
>  #define ARM_SMC_MM_RET_DENIED              -3
>  #define ARM_SMC_MM_RET_NO_MEMORY           -4
> 
> +// ARM Architecture Calls
> +#define SMCCC_VERSION           0x80000000
> +#define SMCCC_ARCH_FEATURES     0x80000001
> +#define SMCCC_ARCH_SOC_ID       0x80000002
> +#define SMCCC_ARCH_WORKAROUND_1 0x80008000 #define
> +SMCCC_ARCH_WORKAROUND_2 0x80007FFF
> +
> +#define SMC_ARCH_CALL_SUCCESS            0
> +#define SMC_ARCH_CALL_NOT_SUPPORTED     -1
> +#define SMC_ARCH_CALL_NOT_REQUIRED      -2
> +#define SMC_ARCH_CALL_INVALID_PARAMETER -3
> +
>  /*
>   * Power State Coordination Interface (PSCI) calls cover a subset of the
>   * Standard Service Call range.
> --
> 2.26.2
> 
> 
> 
> 
>