public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
	EDK II Development <devel@edk2.groups.io>
Cc: Eric Jin <eric.jin@intel.com>,
	G Edhaya Chandran <Edhaya.Chandran@arm.com>,
	"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: illegal dereference in CheckEbcProtocol()
Date: Wed, 11 Nov 2020 14:02:35 +0000	[thread overview]
Message-ID: <DB7PR08MB32609832F1AD9286352052FF90E80@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201111075532.1561-1-xypron.glpk@gmx.de>

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>


> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: Wednesday, November 11, 2020 2:56 AM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; gaoliming@byosoft.com.cn; Heinrich Schuchardt
> <xypron.glpk@gmx.de>
> Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: illegal dereference in
> CheckEbcProtocol()
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3065
>
> If LocateProtocol() has failed, variable Ebc is not valid and we may not
> dereference it.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  .../BlackBoxTest/EfiCompliantBBTestPlatform_uefi.c          | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompli
> antBBTestPlatform_uefi.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompli
> antBBTestPlatform_uefi.c
> index be06d139d59e..052f45b71599 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompli
> antBBTestPlatform_uefi.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompli
> antBBTestPlatform_uefi.c
> @@ -3162,12 +3162,6 @@ CheckEbcProtocol (
>                          );
>
>      if (!EFI_ERROR (Status) && (SctStriCmp (String, L"yes") == 0)) {
>
>        AssertionType = EFI_TEST_ASSERTION_FAILED;
>
> -      if (!GenTestConfigTitle (IniFile, &AssertionType, L"EBCSupport")) {
>
> -        GenTestConfigContent (L"Ebc->CreateThunk", Ebc->CreateThunk !=
> NULL);
>
> -        GenTestConfigContent (L"Ebc->UnloadImage", Ebc->UnloadImage !=
> NULL);
>
> -        GenTestConfigContent (L"Ebc->RegisterICacheFlush", Ebc-
> >RegisterICacheFlush != NULL);
>
> -        GenTestConfigContent (L"Ebc->GetVersion ", Ebc->GetVersion !=
> NULL);
>
> -      }
>
>      }
>
>    }
>
>
>
> --
> 2.28.0

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2020-11-11 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  7:55 [PATCH edk2-test 1/1] uefi-sct/SctPkg: illegal dereference in CheckEbcProtocol() Heinrich Schuchardt
2020-11-11 14:02 ` Samer El-Haj-Mahmoud [this message]
2020-11-23 10:26 ` [edk2-devel] " Grant Likely
2020-11-24 15:39 ` G Edhaya Chandran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR08MB32609832F1AD9286352052FF90E80@DB7PR08MB3260.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox