From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.72]) by mx.groups.io with SMTP id smtpd.web12.6894.1605103388676050952 for ; Wed, 11 Nov 2020 06:03:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=nWgZP0lO; spf=pass (domain: arm.com, ip: 40.107.8.72, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0wfd6+5f2vvcCyt+s04OSXig9Doe1XWnlxxAWggo7jU=; b=nWgZP0lOI/dHrjO4fpKW0hD7hhExPZwLrL26c0wYDJyYwf/U/YtBEWpbQapZhmwOtqqisy4TNO0ijq7UHzWr7ZJEpEPVHOecmBCCCtdeX1qrAChwFPYY1w8kvtkN4E+Ne/Aw6vK1VPF4P03W7cN1LE5NRGdlpjGoZBDn6aALKDA= Received: from DB6PR0301CA0040.eurprd03.prod.outlook.com (2603:10a6:4:3e::50) by VI1PR08MB3903.eurprd08.prod.outlook.com (2603:10a6:803:c4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Wed, 11 Nov 2020 14:03:05 +0000 Received: from DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::2) by DB6PR0301CA0040.outlook.office365.com (2603:10a6:4:3e::50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Wed, 11 Nov 2020 14:03:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT039.mail.protection.outlook.com (10.152.21.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22 via Frontend Transport; Wed, 11 Nov 2020 14:03:05 +0000 Received: ("Tessian outbound 39167997cde8:v71"); Wed, 11 Nov 2020 14:03:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b2d690cb72111a4d X-CR-MTA-TID: 64aa7808 Received: from 26353d078eff.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EF090C1D-3764-40C7-98E6-89E8EE8D462E.1; Wed, 11 Nov 2020 14:02:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 26353d078eff.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Nov 2020 14:02:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KoDCsIPuqdv2vrT48xSeAI5eUOXgRPX6tMA+N/VtZKKImHxuieu1mQShEr4W5H3dApsJCM1QtA2lks4gsiXciAvM/Xc+Z9a6T84J0XbYr5eKs6JZQg4WUFQGdOEqv18+g1ysfxcTsIRqJJ8hiub7PF4y4VEzF0QfdTufg5d/gWd+Bs27u1tgTBe9autN2JbCgAUcdgP4qwqg7ETqB82pCEugQb2H8Wp+tnFAZRvoykYx2ADrjaSXTwRmpFHUrTbwsAckCWHQYeSLM+clD3WMOudAUzBOPAiNAqKgI23xHNX375HydBYlGqFZ6sWKDCTcqYlPNEAbNM4bc6ngd34SXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0wfd6+5f2vvcCyt+s04OSXig9Doe1XWnlxxAWggo7jU=; b=K2T5h0TL/oaAzeeuXMDyU6jnqab5yNMJErGFQiZOtTiOBqKinh8RyixCzrCe79a39Iz1JAlZEIrz92cO2Mda5BU7ugKkNMx2RfUnFJYpBbI3NrSS9HYFve8VCj5L/XKhxz7VSGGLuNw29e2VrcupRwLjoep8FW9a4mnXfY3/+unS7kN+eRPnHhhS5mXWr9KS9BcDmivGC3iTmLdTy0iS9UnsR+0cb6C7WWcUtZkorR/mBvcQt00XBM/GSy/nS51SMA9kaESGAPox6WqhKPOcuNm5kTsHC3HbWs80PHn3lPVTsB2UL6YmudVB7q3ZOl966U8Pm6DFvKVc7mu9LNj/+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0wfd6+5f2vvcCyt+s04OSXig9Doe1XWnlxxAWggo7jU=; b=nWgZP0lOI/dHrjO4fpKW0hD7hhExPZwLrL26c0wYDJyYwf/U/YtBEWpbQapZhmwOtqqisy4TNO0ijq7UHzWr7ZJEpEPVHOecmBCCCtdeX1qrAChwFPYY1w8kvtkN4E+Ne/Aw6vK1VPF4P03W7cN1LE5NRGdlpjGoZBDn6aALKDA= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB7PR08MB3516.eurprd08.prod.outlook.com (2603:10a6:10:4f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Wed, 11 Nov 2020 14:02:35 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::41d6:2494:e616:78a6%7]) with mapi id 15.20.3499.034; Wed, 11 Nov 2020 14:02:35 +0000 From: "Samer El-Haj-Mahmoud" To: Heinrich Schuchardt , EDK II Development CC: Eric Jin , G Edhaya Chandran , "gaoliming@byosoft.com.cn" , Samer El-Haj-Mahmoud Subject: Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: illegal dereference in CheckEbcProtocol() Thread-Topic: [PATCH edk2-test 1/1] uefi-sct/SctPkg: illegal dereference in CheckEbcProtocol() Thread-Index: AQHWuAA1XusgYbfroEybkPqRhN6WHKnC9oRw Date: Wed, 11 Nov 2020 14:02:35 +0000 Message-ID: References: <20201111075532.1561-1-xypron.glpk@gmx.de> In-Reply-To: <20201111075532.1561-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: gmx.de; dkim=none (message not signed) header.d=none;gmx.de; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: fbaf03ec-271f-49fa-7f04-08d8864a82a1 x-ms-traffictypediagnostic: DB7PR08MB3516:|VI1PR08MB3903: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:862;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: E/3Q3JqF37kAMrfXYeJpQ8RBnBDPAU8I4i8b3kQwGTnTeJAIcUrmpeRAO6fm0pyy5wXgFYsbs4knmNUKGBWCSSAoFQ3D5Ql9oHvtH4bJI+PrUoSonj5jj0rQxBomm4GXd3Tpq/vdq6kyNvn5pFPtSdBNbhDsCNa5FJSZQq+YAGz/I7vsfxVpgfKPUMbUqstw8Vy/5czZeYJTv3QPoDfYd8iv8tH3Ro4aYNm/3jfBnVmpmsdBSnAHtA9sxZdWNxpnxFLfEjQ9bGOEDqt29bq45NC++tS2Ijr794s4Wrej6H6qMI2pkJ1I+9y9kKix3wo1choCHRLN8AuwalZQerYqwp7grq4x0EaScgslbl2I02izQ+shc96tTFJoYJUdPYQR95Vwby11Jzli4eNpa91gqg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(186003)(7696005)(26005)(54906003)(6506007)(110136005)(53546011)(5660300002)(83380400001)(52536014)(55016002)(9686003)(2906002)(71200400001)(66446008)(33656002)(66946007)(76116006)(86362001)(66476007)(66556008)(64756008)(966005)(478600001)(4326008)(8676002)(8936002)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: o3j/8uLn/xxWgxKCumkvLDWaLAsbzutgbPVejlHEEqx0gUfIAUabtrTehNnAmSMLotvsnOHpQG1VKYTx30Jyff48URCu1PPuJaU9EQjp117EnFRnA4tOecrMZmQPRvm8Z8D+O8VXCcwb3wtsK0aFZG0GuzGSm5eHqoNnFMkUUgffh9UrHCH6VZz412XP4QE/S/8yqBJOxxcQjapdHWyNwMSY4mDhD9dGwDsL85PGuHeT82PYixmMrsV+beC3eRxmdJLRQWOP3g3b4qAnBbYgpW9QSzTYCIXsJRhHspylrOF51i3wclmhfcaN7+J8kYZKU2TXkjtGLRwq0XQN3K/ZzQ6dCT6Ulb8M0dcsGvTQhG+e0SURFSCKMI+Ar5jqwI1Ym90CfWbJPZdeZGQ2UdExQH0fBLt2pfUfvzaUJq2lkuRBPxD8I9XkHfbfNN+6zenYxJH97/W45cvpk29tAP1ZLrZTEHSz2L2GMWcbI9/04eqU4F2A7JgICYsYcI3CpO3mr4J6cSFEj5ppF0pP77H5FL7HHjWzs5ET98J0G8pezXY3Ev8/HCkvIP1gsHskX3Wb7Ea9nALurn1qdTCGVb5qaH61nKVOG5I2xNFP7aDTtW2qnD8poKoxnoazM1B2y7qGYrwWAhhUFU7nEWgvJntt/Q== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3516 Original-Authentication-Results: gmx.de; dkim=none (message not signed) header.d=none;gmx.de; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 72ac2061-214c-493d-bce8-08d8864a70da X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: brfbbkdSPpRi/vizCxYdjcAICOB72hmgIywhnSnVY3GF7NJtPbLnc3Nv9j4g/yb7V6inU8Chesu59l2nEP4B6GCJxCmsUJpv9cWPzIIKr+bppjpDS/7DuVQkwiWFoYt8KF0ihhjoh0rN16Nrejbp63hMJ3CPkCnnTexWMbFxlLvIFukMZbA/Hhf5v81lEfNQR7iuM/eQDXbFmekT1OMEFzv9h5SsZMMVVIqNDft27dmHQGaByOnDnPQFQLcTBQJPfI3sA3d52BjzjOoTLBehFUR9+45M0NEpCtvaOTAmSUGv+rhkF9cslMwv4QKJxsyWfIS3OwgMfrwQD/I5TZ+PrcLGqPrnzOBqIpqhOpPDOI10RvEqYQYPdcWhq7iaWow/FVlbLGV/abOeZqneP474+4YKwQKs/3TfivRfKdIp+Tof4sBCEvpUuLwEUXicAIJuXo+HHnxgSWOYxkrXmRgh+DY2V6S+XYR5ttNkvXyzDi8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(39860400002)(136003)(46966005)(5660300002)(26005)(7696005)(55016002)(966005)(4326008)(2906002)(70206006)(82310400003)(478600001)(316002)(9686003)(47076004)(54906003)(33656002)(110136005)(8936002)(52536014)(70586007)(6506007)(53546011)(186003)(83380400001)(82740400003)(336012)(8676002)(86362001)(356005)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2020 14:03:05.0169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbaf03ec-271f-49fa-7f04-08d8864a82a1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3903 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Samer El-Haj-Mahmoud > -----Original Message----- > From: Heinrich Schuchardt > Sent: Wednesday, November 11, 2020 2:56 AM > To: EDK II Development > Cc: Eric Jin ; G Edhaya Chandran > ; Samer El-Haj-Mahmoud Mahmoud@arm.com>; gaoliming@byosoft.com.cn; Heinrich Schuchardt > > Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: illegal dereference in > CheckEbcProtocol() > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3065 > > If LocateProtocol() has failed, variable Ebc is not valid and we may not > dereference it. > > Signed-off-by: Heinrich Schuchardt > --- > .../BlackBoxTest/EfiCompliantBBTestPlatform_uefi.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompli > antBBTestPlatform_uefi.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompli > antBBTestPlatform_uefi.c > index be06d139d59e..052f45b71599 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompli > antBBTestPlatform_uefi.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Generic/EfiCompliant/BlackBoxTest/EfiCompli > antBBTestPlatform_uefi.c > @@ -3162,12 +3162,6 @@ CheckEbcProtocol ( > ); > > if (!EFI_ERROR (Status) && (SctStriCmp (String, L"yes") =3D=3D 0)) { > > AssertionType =3D EFI_TEST_ASSERTION_FAILED; > > - if (!GenTestConfigTitle (IniFile, &AssertionType, L"EBCSupport")) = { > > - GenTestConfigContent (L"Ebc->CreateThunk", Ebc->CreateThunk !=3D > NULL); > > - GenTestConfigContent (L"Ebc->UnloadImage", Ebc->UnloadImage !=3D > NULL); > > - GenTestConfigContent (L"Ebc->RegisterICacheFlush", Ebc- > >RegisterICacheFlush !=3D NULL); > > - GenTestConfigContent (L"Ebc->GetVersion ", Ebc->GetVersion !=3D > NULL); > > - } > > } > > } > > > > -- > 2.28.0 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.