public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: Pete Batard <pete@akeo.ie>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
	"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
	"zhiguang.liu@intel.com" <zhiguang.liu@intel.com>
Subject: Re: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib
Date: Wed, 11 Nov 2020 17:37:32 +0000	[thread overview]
Message-ID: <DB7PR08MB3260A1E35FCB1681B8BAD4AA90E80@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201104190346.8096-1-pete@akeo.ie>

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: Pete Batard <pete@akeo.ie>
> Sent: Wednesday, November 4, 2020 2:04 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>
> Subject: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER
> class to RngLib
>
> The Raspberry Pi platform with Secure Boot enabled currently fails to build
> with error:
>
>   Module type [DXE_RUNTIME_DRIVER] is not supported by library instance
>
> [/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLi
> b.inf]
>
> Add the missing class to fix this issue.
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
>  MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> index 68554ad21146..9c11959f8aeb 100644
> --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf
> @@ -14,7 +14,7 @@ [Defines]
>    FILE_GUID       = FF9F84C5-A33E-44E3-9BB5-0D654B2D4149
>    MODULE_TYPE     = DXE_DRIVER
>    VERSION_STRING  = 1.0
> -  LIBRARY_CLASS   = RngLib|DXE_DRIVER UEFI_APPLICATION UEFI_DRIVER
> +  LIBRARY_CLASS   = RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER
> UEFI_APPLICATION UEFI_DRIVER
>
>  [Packages]
>    MdePkg/MdePkg.dec
> --
> 2.21.0.windows.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  parent reply	other threads:[~2020-11-11 17:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 19:03 [PATCH 1/1] MdePkg/BaseRngLibDxe: Add DXE_RUNTIME_DRIVER class to RngLib Pete Batard
2020-11-11 17:05 ` [edk2-devel] " Andrei Warkentin
2020-11-11 17:37 ` Samer El-Haj-Mahmoud [this message]
2020-11-12  1:52   ` 回复: " gaoliming
2020-11-12 12:09     ` Pete Batard
2020-11-12 13:41       ` 回复: " gaoliming
     [not found]       ` <1646C675163A08FD.26994@groups.io>
2020-11-13  5:48         ` gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR08MB3260A1E35FCB1681B8BAD4AA90E80@DB7PR08MB3260.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox