Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

["Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>]

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> Biesheuvel via groups.io
> Sent: Sunday, April 19, 2020 9:34 AM
> To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>;
> devel@edk2.groups.io
> Cc: Leif Lindholm <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>; Andrei
> Warkentin (awarkentin@vmware.com) <awarkentin@vmware.com>
> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi
> : Enable TFTP shell command
> 
> On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote:
> > Fix an ASSERT with the TFTP dynamic Shell command on the
> > RPi3 and RPi4 when running DEBUG builds. Also, enable the command by
> > default for all builds.
> >
> 
> Fixing the ASSERT is fine but I am reluctant to enable this by default.
> It is a non-standard hack that ARM contributed in the past, and is not covered
> by the EFI of Shell specifications. If RPi4 is intended to be a showcase for UEFI
> on ARM done right, we should not enable this at all.
> 

That is OK. 

Are you fine just reviewing/pushing the PCD patches (and dropping the enable ones), or want me to send a new series without the enable patches ?

> 
> 
> 
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Cc: Pete Batard <pete@akeo.ie>
> > Cc: Andrei Warkentin <awarkentin@vmware.com>
> >
> > Samer El-Haj-Mahmoud (4):
> >    Platform/RaspberryPi/RPi3: Fix TFTP dynamic command initialization
> >    Platform/RaspberryPi/RPi4: Fix TFTP dynamic command initialization
> >    Platform/RaspberryPi/RPi3: Enable TFTP command by default
> >    Platform/RaspberryPi/RPi4: Enable TFTP command by default
> >
> >   Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +++++--
> >   Platform/RaspberryPi/RPi4/RPi4.dsc | 7 +++++--
> >   2 files changed, 10 insertions(+), 4 deletions(-)
> >
> 
> 
>