From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.69]) by mx.groups.io with SMTP id smtpd.web11.12085.1589463032925493757 for ; Thu, 14 May 2020 06:30:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=0ydfMr7d; spf=pass (domain: arm.com, ip: 40.107.21.69, mailfrom: samer.el-haj-mahmoud@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BEshCWowXLD+uhYUkrkmeVoMW7rhaVgkb5pqtcX3YeA=; b=0ydfMr7d2BcZbIGo0/71uynklbKWOJFhbtZvTVK+O2IDRgwh7wamgNQz6se18fZ+ly263RKn4/iF7jSGG+xmkHsxFqHJzED4Qe1M8cjizHVTpA1rrBNAiUZVQum+Kv2nlxxVyopWyBWAhh1vu2jMnfQqok7v8psxf2CDcgHQ6qM= Received: from AM6P194CA0083.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::24) by DB8PR08MB4155.eurprd08.prod.outlook.com (2603:10a6:10:a3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20; Thu, 14 May 2020 13:30:29 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8f:cafe::84) by AM6P194CA0083.outlook.office365.com (2603:10a6:209:8f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Thu, 14 May 2020 13:30:29 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.19 via Frontend Transport; Thu, 14 May 2020 13:30:28 +0000 Received: ("Tessian outbound e88319d7ccd0:v54"); Thu, 14 May 2020 13:30:28 +0000 X-CR-MTA-TID: 64aa7808 Received: from 055579ef7091.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3EF3AD35-3F5C-46BB-A9F7-D981A122767A.1; Thu, 14 May 2020 13:30:23 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 055579ef7091.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 May 2020 13:30:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QRb9Jx0jUlfmhoF0KGnINAimDlV9oV7Di/CNYiG5iPykvyG1k8M4GJ+uyKdzIdY7NFNuaHMO45p23aMo81E7H8bPsJydL8j5w9CdJNzg87CEpUlG55ZBWqZS+vGjE9eNGWIZm+L6jFk0xRXuYIigJQXb1iJc6JjYJpXni0VGnyvpJzY0pFBLDgOOc/zPieTrG4WhAhTS2eANIBBfNL9ShlatYUi/rMeQSebUu6TJShvRr3hXWxxRv0AO5yaoklqwBEHJ9/+cFBxSuwHwYfUp09Aj0fdbHO1gl9ylbaiatYec03WM70SU9fju+r6ZghT9076q+Ulcw+3KaSacyYd0XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BEshCWowXLD+uhYUkrkmeVoMW7rhaVgkb5pqtcX3YeA=; b=ZebA0ORaATAWVpZNTQm6A9AMrvb61U1K6VKQjn+UmCSvWnRWzeRFjkExTSNv+9AwxjbD1NWcwKgWccORanPo+I0MZEECYal2Dn/4u8DFXbr5MT02kYFDhjl0oalvqOk6sOYfe3bY2SwonkHpiEuIehwZtP7AyAf3g2xp9wh95pv1t9FULJjWu66gkivz3zP8S8Te60ohHKUWEVhtBjA/xXsTagb+ZNXCjPeJjgb5I73oNmhWhGSp/oXrxiMComBz4W3jPgolSLTdRxhUD+QVdQzbde5wGBZ0GKF4JzflybGLKXDuroImq5NkFE1GN5ValX7/83eRxjke+Q5s3VPA6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BEshCWowXLD+uhYUkrkmeVoMW7rhaVgkb5pqtcX3YeA=; b=0ydfMr7d2BcZbIGo0/71uynklbKWOJFhbtZvTVK+O2IDRgwh7wamgNQz6se18fZ+ly263RKn4/iF7jSGG+xmkHsxFqHJzED4Qe1M8cjizHVTpA1rrBNAiUZVQum+Kv2nlxxVyopWyBWAhh1vu2jMnfQqok7v8psxf2CDcgHQ6qM= Received: from DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) by DB7PR08MB3081.eurprd08.prod.outlook.com (2603:10a6:5:25::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Thu, 14 May 2020 13:30:21 +0000 Received: from DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::990e:ed79:bec0:9dac]) by DB7PR08MB3260.eurprd08.prod.outlook.com ([fe80::990e:ed79:bec0:9dac%7]) with mapi id 15.20.2979.033; Thu, 14 May 2020 13:30:21 +0000 From: "Samer El-Haj-Mahmoud" To: Leif Lindholm , Ard Biesheuvel CC: "devel@edk2.groups.io" , Ray Ni , Michael D Kinney Subject: Re: [edk2-platform][PATCH v1 0/4] Update ASIX USB Networking drivers Thread-Topic: [edk2-platform][PATCH v1 0/4] Update ASIX USB Networking drivers Thread-Index: AQHWJ6v/zBynyRPMgkirQjgTiwczF6ikTe+AgANKD0A= Date: Thu, 14 May 2020 13:30:21 +0000 Message-ID: References: <20200510111530.26225-1-Samer.El-Haj-Mahmoud@arm.com> <3ae3d8da-2f51-edce-4457-b1db79e501f5@arm.com> <20200512111527.GC21486@vanye> In-Reply-To: <20200512111527.GC21486@vanye> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 93cce7d5-cd45-452f-a6d1-df42e0731821.1 x-checkrecipientchecked: true Authentication-Results-Original: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [99.132.126.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4ebfe339-2853-4ec8-7b43-08d7f80af7e5 x-ms-traffictypediagnostic: DB7PR08MB3081:|DB7PR08MB3081:|DB8PR08MB4155: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:9508; x-forefront-prvs: 040359335D X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ADdf/wxRxWme81f1emBT8LmhRHH81xNdwhyOdwsp4IgEip4RiDShF0ZTlGX7p7HY8+e/JKTdCg3iIfaSsp+UCIon4DHnEiQf6lvIeFIqjKlQEWY93DZrQeGmisllgcXnFDV1lJjAqAPukjRjscr5IT7VuZvDUi48GMtnM9KmrQxZqjQnO6nyHblN3iUd0gLQMmoLRDePxSlW/9RpQRoZ7oUaE1vrA3UwPLuPcj3QoxIECXJizNrPiBCZtgBArQm3f1kmz/PDFHEdaDPNmAyG25oewtf90gP31At6Q5lui3FdUTivZYi6dj/EgIfc3hni+7ZAOZKOROeLQwzu/wAWDnFlDjd1h7G8Itb047YECpbapUhHliSzxxG63fZ+Gjh9/di2N/aDImmYLvOe3K3Fq/BKTTMDP5q1naR5rVAMotLcbfehTKcMjsHXlu2DXWK8JRdHYN5dnDJ3DgeOxWEDJBsGvW0ujDMoJp8NaujweadXHmjLV/M5h1sNZsv7hGgQxj7KGejKFbBwnocQgJh2JA0e2dK3AgsTZtO8HYCYzkZC/Mt4CcgJcAWfYE398XTO0FA+UNhIt+qbEHpAqmolzA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3260.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(376002)(396003)(346002)(366004)(110136005)(8936002)(8676002)(4326008)(76116006)(53546011)(66446008)(478600001)(316002)(86362001)(64756008)(5660300002)(7696005)(6506007)(71200400001)(966005)(54906003)(66946007)(33656002)(66476007)(55016002)(2906002)(15650500001)(66556008)(52536014)(9686003)(6636002)(186003)(26005)(46800400005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 7EcDRW6jy8oUsYbuBLr/vbyHAyS3GWERnk7g75irpOdp9PWweS2SIZLCMVHktfyl4qvt4nveWFYD0j2Nt/NwgOn5JDfSjbTAjJnp0kk+PbjcUA7ikNdc33Hu802oW2cIe7fkfpL9HdsEa9pmfDlG2SNatwbagVRLYFk7J+u7Ds6m2gdRB7JSO1Ad7zgud+3HtNQt6SO5x/JCnzbN5CfY3flnKvTX7ziiUyFR0RX5IO8fq3lrqBsGYNeur5l1wCHQ9anlMtZezbZXwfOew5BWfQbCu3C85MXj2/v8Ti+BRhFp1qaFGlob9zucwHQ9IijPQc7ObJZG6VYg7ZUMUW+epROMQOoAnFZcSdEimPxp2C+l40pI/+frueGdM9P+Q+Pi3ANim+8bZx6QxIkmkj2vXasUpys0/1DTXXRC1gtNEDm3xERrLBRsgQmY75WrYi2nTrEtD+5glw5bY6HVIi5HAbTXKbsF8qnSin0yBnMGg5sE7wvxolDu+Yw+P5S1+8G7 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3081 Original-Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; Return-Path: Samer.El-Haj-Mahmoud@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(46966005)(6506007)(110136005)(36906005)(336012)(15650500001)(316002)(5660300002)(186003)(53546011)(54906003)(81166007)(26005)(86362001)(2906002)(82310400002)(356005)(7696005)(33656002)(47076004)(6636002)(966005)(4326008)(9686003)(8676002)(8936002)(107886003)(55016002)(478600001)(82740400003)(70586007)(70206006)(52536014)(46800400005);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 97cef014-d085-4b8b-d605-08d7f80af38e X-Forefront-PRVS: 040359335D X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IpU7/NCeIIoHN6oc+GVVMOOMlIfC7rBc4gtI387LMtH9XtQ3FOarxYHen4ERRtcKwsTf2hJ/secdv5rQXviuVbClZRfah40yHfHU7MIEA/iaFjZMXpMfEzGiGLK/EK04om0rgnHnMfIv5MPbNJstD0WVRnKiiU6/9+fWR8OhBugYcsP/A70ojUr27q55yr6cZmi8pJpjUSp+Y7fYwcjBwONnK/RhEwTbhL29FWSFpTzcfbDFdYSGt777HdSqJa9vqamsxxeJBHcN7N3xeEzvxkQTKvVX+0f1U9uJP37/bKCLuqzI+bkYicwj5wQd0MTsX43tX/T5adCwXlpLn9r4lCcbt+09y5kK1SQGtu8c3ZRHEDXs2Zp9y1Gq3Wd6aPiwETpoHqYUiS28gk3Y3Lk/nuaUTVhFzw1lANrqOe3+2I52TcM1Gq+6IzOYCrXuhl5jub8kv7mxzyOmVmbRJelv54Fl3HZIKkFkNsohFUEQ//pGinzLdpTDhxh54mXkIn0IdrNKbsV3dMn7XJ8FDRpC4e+KLpgQCxqNr0Eq45UBP8he0Hgu+/IKP/j2H1eANGGtAnmrXKpSO/21Xvs5sPFjoU0DvEaiVkc111+wOEKRkDjqeyCw9/Iy4O4VY1sHiwzp X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2020 13:30:28.8017 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4ebfe339-2853-4ec8-7b43-08d7f80af7e5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4155 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm > Sent: Tuesday, May 12, 2020 7:15 AM > To: Ard Biesheuvel > Cc: Samer El-Haj-Mahmoud ; > devel@edk2.groups.io; Ray Ni ; Michael D Kinney > > Subject: Re: [edk2-platform][PATCH v1 0/4] Update ASIX USB Networking > drivers > > On Mon, May 11, 2020 at 17:50:54 +0200, Ard Biesheuvel wrote: > > On 5/10/20 1:15 PM, Samer El-Haj-Mahmoud wrote: > > > This series updates the ASIX USB networking drivers: > > > > > > - Create new Silicon/ASIX/ package > > > - Move existing Ax88772 and Ax88772b drivers from OptionRomPkg > > > to the newly created AsixPkg > > > - Add new ASIX drivers Ax88179 and Ax88772c > > > > > > Code pushed to > > > https://github.com/samerhaj/edk2-platforms/tree/asix_usb_nic_drivers > > > _v2 > > > > > > version 1: https://edk2.groups.io/g/devel/message/58771 > > > version 2 changes: > > > - Create new ASIX Package to host existing and new ASIX > > > drivers[Ray] > > > > > > Cc: Ray Ni > > > Cc: Leif Lindholm > > > Cc: Ard Biesheuvel > > > Cc: Michael D Kinney > > > > > > Signed-off-by: Samer El-Haj-Mahmoud mahmoud@arm.com> > > > > > > Samer El-Haj-Mahmoud (4): > > > Silicon/AsixPkg: Create AsixPkg > > > Drivers/OptionRomPkg: Move ASIX drivers to AsixPkg > > > Silicon/AsixPkg: Add ASIX Ax88179 driver > > > Silicon/AsixPkg: Add ASIX Ax88772c driver > > > > > > > I happened to have one of each of these dongles in my drawer, so I > > managed to test them both. > > > > Both work fine, although the 88179 one was rather slow. > > > > In any case, the 10/100 one I tried is an Apple one (05ac:1402) which > > is also supported by the 88772b driver. The only other vid/pid pair > > which that old driver supports is also supported by the new one, so I > > think we can drop the old one altogether. The non-b 7720 driver is > > also supported by the new > > 10/100 driver, so we can drop the old 88772 as well, afaict. > > If we can drop the old ones, I will be very happy. > I was just about to start providing some feedback on those (beyond what > you have) including bits like "drop the Hungarian notation". > Sure, I can drop the old 8872/8872b drivers if we can replace with 8872c > Fixing those would be a fair amount of effort, and moving out of their le= gacy > home before that would set a bad example. > > / > Leif IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.