public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer.el-haj-mahmoud@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ardb@kernel.org" <ardb@kernel.org>
Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
Date: Sat, 20 Feb 2021 17:22:46 +0000	[thread overview]
Message-ID: <DB7PR08MB3260DB7693F32932E10DFF3490839@DB7PR08MB3260.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXFxhke1zxt8VPyxCCFerf658y08W3yuj_2WcYHRBe3WrA@mail.gmail.com>

Thank you!

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> Biesheuvel via groups.io
> Sent: Saturday, February 20, 2021 11:51 AM
> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Leif Lindholm <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>
> On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com> wrote:
> >
> > the DEBUG message for using compilation time epoch is appearing very
> > frequently on DEBUG firmware builds, for example during UEFI SCT runs.
> > Reduce verbosity to avoid the annoying repetitive message.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Pete Batard <pete@akeo.ie>
> > Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>
>
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>
> Merged as #1434 into master.
>
> > ---
> >  EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.
> > c
> > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.
> > c index 5c13ed4cf190..4210708cff36 100644
> > ---
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.
> > c
> > +++
> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClock
> > +++ Lib.c
> > @@ -88,7 +88,7 @@ LibGetTime (
> >      //
> >      EpochSeconds = BUILD_EPOCH;
> >      DEBUG ((
> > -      DEBUG_INFO,
> > +      DEBUG_VERBOSE,
> >        "LibGetTime: %s non volatile variable was not found - Using compilation
> time epoch.\n",
> >        mEpochVariableName
> >        ));
> > --
> > 2.25.1
> >
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2021-02-20 17:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-20 16:41 [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity Samer El-Haj-Mahmoud
2021-02-20 16:50 ` Ard Biesheuvel
2021-02-20 17:22   ` Samer El-Haj-Mahmoud [this message]
2021-02-20 21:46   ` Leif Lindholm
2021-02-20 23:25     ` Samer El-Haj-Mahmoud
2021-02-21 10:50     ` Ard Biesheuvel
2021-02-21 20:43       ` Leif Lindholm
2021-02-21 20:50         ` Ard Biesheuvel
2021-02-21 21:33           ` Leif Lindholm
     [not found] <1652824B75E1BD30.11931@groups.io>
2020-12-20 19:14 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-12-23 16:37   ` Pete Batard
2021-01-05 20:46     ` Samer El-Haj-Mahmoud
2021-01-06 10:34       ` Ard Biesheuvel
2021-01-06 14:36         ` Samer El-Haj-Mahmoud
     [not found]         ` <1657AB5D550B1C6A.2692@groups.io>
2021-02-20 16:09           ` Samer El-Haj-Mahmoud
2021-02-20 16:13             ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR08MB3260DB7693F32932E10DFF3490839@DB7PR08MB3260.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox