* Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
[not found] <1652824B75E1BD30.11931@groups.io>
@ 2020-12-20 19:14 ` Samer El-Haj-Mahmoud
2020-12-23 16:37 ` Pete Batard
0 siblings, 1 reply; 16+ messages in thread
From: Samer El-Haj-Mahmoud @ 2020-12-20 19:14 UTC (permalink / raw)
To: devel@edk2.groups.io, Samer El-Haj-Mahmoud
Cc: Leif Lindholm, Pete Batard, Ard Biesheuvel
Using Ard's correct e-mail
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer
> El-Haj-Mahmoud via groups.io
> Sent: Sunday, December 20, 2020 2:08 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
> <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
> Subject: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>
> the DEBUG message for using compilation time epoch is appearing very
> frequently on DEBUG firmware builds, for example during UEFI SCT runs.
> Reduce verbosity to avoid the annoying repetitive message.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> ---
> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c |
> 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> index 5c13ed4cf190..4210708cff36 100644
> ---
> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> +++
> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> @@ -88,7 +88,7 @@ LibGetTime (
> //
>
> EpochSeconds = BUILD_EPOCH;
>
> DEBUG ((
>
> - DEBUG_INFO,
>
> + DEBUG_VERBOSE,
>
> "LibGetTime: %s non volatile variable was not found - Using compilation
> time epoch.\n",
>
> mEpochVariableName
>
> ));
>
> --
> 2.25.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#69269): https://edk2.groups.io/g/devel/message/69269
> Mute This Topic: https://groups.io/mt/79110001/1945644
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> mahmoud@arm.com]
> -=-=-=-=-=-=
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2020-12-20 19:14 ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2020-12-23 16:37 ` Pete Batard
2021-01-05 20:46 ` Samer El-Haj-Mahmoud
0 siblings, 1 reply; 16+ messages in thread
From: Pete Batard @ 2020-12-23 16:37 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, devel@edk2.groups.io; +Cc: Leif Lindholm, Ard Biesheuvel
On 2020.12.20 19:14, Samer El-Haj-Mahmoud wrote:
> Using Ard's correct e-mail
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer
>> El-Haj-Mahmoud via groups.io
>> Sent: Sunday, December 20, 2020 2:08 PM
>> To: devel@edk2.groups.io
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
>> <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
>> Subject: [edk2-devel] [edk2-platform][PATCH v1 1/1]
>> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>>
>> the DEBUG message for using compilation time epoch is appearing very
>> frequently on DEBUG firmware builds, for example during UEFI SCT runs.
>> Reduce verbosity to avoid the annoying repetitive message.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Pete Batard <pete@akeo.ie>
>> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>> ---
>> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c |
>> 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
>> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
>> index 5c13ed4cf190..4210708cff36 100644
>> ---
>> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
>> +++
>> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
>> @@ -88,7 +88,7 @@ LibGetTime (
>> //
>>
>> EpochSeconds = BUILD_EPOCH;
>>
>> DEBUG ((
>>
>> - DEBUG_INFO,
>>
>> + DEBUG_VERBOSE,
>>
>> "LibGetTime: %s non volatile variable was not found - Using compilation
>> time epoch.\n",
>>
>> mEpochVariableName
>>
>> ));
>>
>> --
>> 2.25.1
>>
>>
>>
>> -=-=-=-=-=-=
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#69269): https://edk2.groups.io/g/devel/message/69269
>> Mute This Topic: https://groups.io/mt/79110001/1945644
>> Group Owner: devel+owner@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
>> mahmoud@arm.com]
>> -=-=-=-=-=-=
>>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
Reviewed-by: Pete Batard <pete@akeo.ie>
Tested-by: Pete Batard <pete@akeo.ie> (On an RPi4 platform where we
would see tons of these unwanted messages without this patch)
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2020-12-23 16:37 ` Pete Batard
@ 2021-01-05 20:46 ` Samer El-Haj-Mahmoud
2021-01-06 10:34 ` Ard Biesheuvel
0 siblings, 1 reply; 16+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-01-05 20:46 UTC (permalink / raw)
To: Pete Batard, devel@edk2.groups.io, Ard Biesheuvel, Leif Lindholm
Gentle reminder...
> -----Original Message-----
> From: Pete Batard <pete@akeo.ie>
> Sent: Wednesday, December 23, 2020 11:37 AM
> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
> devel@edk2.groups.io
> Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel
> <Ard.Biesheuvel@arm.com>
> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>
> On 2020.12.20 19:14, Samer El-Haj-Mahmoud wrote:
> > Using Ard's correct e-mail
> >
> >> -----Original Message-----
> >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Samer
> >> El-Haj-Mahmoud via groups.io
> >> Sent: Sunday, December 20, 2020 2:08 PM
> >> To: devel@edk2.groups.io
> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
> >> <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
> >> Subject: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> >> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> verbosity
> >>
> >> the DEBUG message for using compilation time epoch is appearing very
> >> frequently on DEBUG firmware builds, for example during UEFI SCT runs.
> >> Reduce verbosity to avoid the annoying repetitive message.
> >>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> Cc: Leif Lindholm <leif@nuviainc.com>
> >> Cc: Pete Batard <pete@akeo.ie>
> >> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>
> >> ---
> >>
> >> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> >> |
> >> 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git
> >> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> >> .c
> >>
> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> >> .c index 5c13ed4cf190..4210708cff36 100644
> >> ---
> >> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> >> .c
> >> +++
> >>
> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> >> .c
> >> @@ -88,7 +88,7 @@ LibGetTime (
> >> //
> >>
> >> EpochSeconds = BUILD_EPOCH;
> >>
> >> DEBUG ((
> >>
> >> - DEBUG_INFO,
> >>
> >> + DEBUG_VERBOSE,
> >>
> >> "LibGetTime: %s non volatile variable was not found - Using
> >> compilation time epoch.\n",
> >>
> >> mEpochVariableName
> >>
> >> ));
> >>
> >> --
> >> 2.25.1
> >>
> >>
> >>
> >> -=-=-=-=-=-=
> >> Groups.io Links: You receive all messages sent to this group.
> >> View/Reply Online (#69269):
> >> https://edk2.groups.io/g/devel/message/69269
> >> Mute This Topic: https://groups.io/mt/79110001/1945644
> >> Group Owner: devel+owner@edk2.groups.io
> >> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> >> mahmoud@arm.com] -=-=-=-=-=-=
> >>
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
> >
>
> Reviewed-by: Pete Batard <pete@akeo.ie>
> Tested-by: Pete Batard <pete@akeo.ie> (On an RPi4 platform where we
> would see tons of these unwanted messages without this patch)
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-01-05 20:46 ` Samer El-Haj-Mahmoud
@ 2021-01-06 10:34 ` Ard Biesheuvel
2021-01-06 14:36 ` Samer El-Haj-Mahmoud
[not found] ` <1657AB5D550B1C6A.2692@groups.io>
0 siblings, 2 replies; 16+ messages in thread
From: Ard Biesheuvel @ 2021-01-06 10:34 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud, Pete Batard, devel@edk2.groups.io,
Leif Lindholm
On 1/5/21 9:46 PM, Samer El-Haj-Mahmoud wrote:
> Gentle reminder...
>
Please resend this with me on cc so I have it in my mailbox.
>> -----Original Message-----
>> From: Pete Batard <pete@akeo.ie>
>> Sent: Wednesday, December 23, 2020 11:37 AM
>> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
>> devel@edk2.groups.io
>> Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel
>> <Ard.Biesheuvel@arm.com>
>> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
>> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>>
>> On 2020.12.20 19:14, Samer El-Haj-Mahmoud wrote:
>>> Using Ard's correct e-mail
>>>
>>>> -----Original Message-----
>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>> Samer
>>>> El-Haj-Mahmoud via groups.io
>>>> Sent: Sunday, December 20, 2020 2:08 PM
>>>> To: devel@edk2.groups.io
>>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
>>>> <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
>>>> Subject: [edk2-devel] [edk2-platform][PATCH v1 1/1]
>>>> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
>> verbosity
>>>>
>>>> the DEBUG message for using compilation time epoch is appearing very
>>>> frequently on DEBUG firmware builds, for example during UEFI SCT runs.
>>>> Reduce verbosity to avoid the annoying repetitive message.
>>>>
>>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>>> Cc: Pete Batard <pete@akeo.ie>
>>>> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
>> Mahmoud@arm.com>
>>>> ---
>>>>
>>>> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
>>>> |
>>>> 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git
>>>> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
>>>> .c
>>>>
>> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
>>>> .c index 5c13ed4cf190..4210708cff36 100644
>>>> ---
>>>> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
>>>> .c
>>>> +++
>>>>
>> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
>>>> .c
>>>> @@ -88,7 +88,7 @@ LibGetTime (
>>>> //
>>>>
>>>> EpochSeconds = BUILD_EPOCH;
>>>>
>>>> DEBUG ((
>>>>
>>>> - DEBUG_INFO,
>>>>
>>>> + DEBUG_VERBOSE,
>>>>
>>>> "LibGetTime: %s non volatile variable was not found - Using
>>>> compilation time epoch.\n",
>>>>
>>>> mEpochVariableName
>>>>
>>>> ));
>>>>
>>>> --
>>>> 2.25.1
>>>>
>>>>
>>>>
>>>> -=-=-=-=-=-=
>>>> Groups.io Links: You receive all messages sent to this group.
>>>> View/Reply Online (#69269):
>>>> https://edk2.groups.io/g/devel/message/69269
>>>> Mute This Topic: https://groups.io/mt/79110001/1945644
>>>> Group Owner: devel+owner@edk2.groups.io
>>>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
>>>> mahmoud@arm.com] -=-=-=-=-=-=
>>>>
>>>
>>> IMPORTANT NOTICE: The contents of this email and any attachments are
>> confidential and may also be privileged. If you are not the intended recipient,
>> please notify the sender immediately and do not disclose the contents to any
>> other person, use it for any purpose, or store or copy the information in any
>> medium. Thank you.
>>>
>>
>> Reviewed-by: Pete Batard <pete@akeo.ie>
>> Tested-by: Pete Batard <pete@akeo.ie> (On an RPi4 platform where we
>> would see tons of these unwanted messages without this patch)
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-01-06 10:34 ` Ard Biesheuvel
@ 2021-01-06 14:36 ` Samer El-Haj-Mahmoud
[not found] ` <1657AB5D550B1C6A.2692@groups.io>
1 sibling, 0 replies; 16+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-01-06 14:36 UTC (permalink / raw)
To: devel@edk2.groups.io
Cc: Ard Biesheuvel, Pete Batard, Leif Lindholm, Samer El-Haj-Mahmoud
resent
> -----Original Message-----
> From: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Sent: Wednesday, January 6, 2021 5:34 AM
> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Pete
> Batard <pete@akeo.ie>; devel@edk2.groups.io; Leif Lindholm
> <leif@nuviainc.com>
> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>
> On 1/5/21 9:46 PM, Samer El-Haj-Mahmoud wrote:
> > Gentle reminder...
> >
>
> Please resend this with me on cc so I have it in my mailbox.
>
> >> -----Original Message-----
> >> From: Pete Batard <pete@akeo.ie>
> >> Sent: Wednesday, December 23, 2020 11:37 AM
> >> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
> >> devel@edk2.groups.io
> >> Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel
> >> <Ard.Biesheuvel@arm.com>
> >> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> >> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> verbosity
> >>
> >> On 2020.12.20 19:14, Samer El-Haj-Mahmoud wrote:
> >>> Using Ard's correct e-mail
> >>>
> >>>> -----Original Message-----
> >>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> >> Samer
> >>>> El-Haj-Mahmoud via groups.io
> >>>> Sent: Sunday, December 20, 2020 2:08 PM
> >>>> To: devel@edk2.groups.io
> >>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
> >>>> <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
> >>>> Subject: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> >>>> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> >> verbosity
> >>>>
> >>>> the DEBUG message for using compilation time epoch is appearing
> >>>> very frequently on DEBUG firmware builds, for example during UEFI
> SCT runs.
> >>>> Reduce verbosity to avoid the annoying repetitive message.
> >>>>
> >>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >>>> Cc: Leif Lindholm <leif@nuviainc.com>
> >>>> Cc: Pete Batard <pete@akeo.ie>
> >>>> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> >> Mahmoud@arm.com>
> >>>> ---
> >>>>
> >>>>
> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> >>>> .c
> >>>> |
> >>>> 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git
> >>>>
> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL
> >>>> ib
> >>>> .c
> >>>>
> >>
> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> >>>> .c index 5c13ed4cf190..4210708cff36 100644
> >>>> ---
> >>>>
> a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL
> >>>> ib
> >>>> .c
> >>>> +++
> >>>>
> >>
> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> >>>> .c
> >>>> @@ -88,7 +88,7 @@ LibGetTime (
> >>>> //
> >>>>
> >>>> EpochSeconds = BUILD_EPOCH;
> >>>>
> >>>> DEBUG ((
> >>>>
> >>>> - DEBUG_INFO,
> >>>>
> >>>> + DEBUG_VERBOSE,
> >>>>
> >>>> "LibGetTime: %s non volatile variable was not found - Using
> >>>> compilation time epoch.\n",
> >>>>
> >>>> mEpochVariableName
> >>>>
> >>>> ));
> >>>>
> >>>> --
> >>>> 2.25.1
> >>>>
> >>>>
> >>>>
> >>>> -=-=-=-=-=-=
> >>>> Groups.io Links: You receive all messages sent to this group.
> >>>> View/Reply Online (#69269):
> >>>> https://edk2.groups.io/g/devel/message/69269
> >>>> Mute This Topic: https://groups.io/mt/79110001/1945644
> >>>> Group Owner: devel+owner@edk2.groups.io
> >>>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> >>>> mahmoud@arm.com] -=-=-=-=-=-=
> >>>>
> >>>
> >>> IMPORTANT NOTICE: The contents of this email and any attachments are
> >> confidential and may also be privileged. If you are not the intended
> >> recipient, please notify the sender immediately and do not disclose
> >> the contents to any other person, use it for any purpose, or store or
> >> copy the information in any medium. Thank you.
> >>>
> >>
> >> Reviewed-by: Pete Batard <pete@akeo.ie>
> >> Tested-by: Pete Batard <pete@akeo.ie> (On an RPi4 platform where we
> >> would see tons of these unwanted messages without this patch)
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
[not found] ` <1657AB5D550B1C6A.2692@groups.io>
@ 2021-02-20 16:09 ` Samer El-Haj-Mahmoud
2021-02-20 16:13 ` Ard Biesheuvel
0 siblings, 1 reply; 16+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-02-20 16:09 UTC (permalink / raw)
To: devel@edk2.groups.io, Samer El-Haj-Mahmoud
Cc: Ard Biesheuvel, Pete Batard, Leif Lindholm,
ardb+tianocore@kernel.org
Resending with Ard's new e-mail address
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer
> El-Haj-Mahmoud via groups.io
> Sent: Wednesday, January 6, 2021 9:37 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Pete Batard
> <pete@akeo.ie>; Leif Lindholm <leif@nuviainc.com>; Samer El-Haj-
> Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>
> resent
>
> > -----Original Message-----
> > From: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Sent: Wednesday, January 6, 2021 5:34 AM
> > To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Pete
> Batard
> > <pete@akeo.ie>; devel@edk2.groups.io; Leif Lindholm
> > <leif@nuviainc.com>
> > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> verbosity
> >
> > On 1/5/21 9:46 PM, Samer El-Haj-Mahmoud wrote:
> > > Gentle reminder...
> > >
> >
> > Please resend this with me on cc so I have it in my mailbox.
> >
> > >> -----Original Message-----
> > >> From: Pete Batard <pete@akeo.ie>
> > >> Sent: Wednesday, December 23, 2020 11:37 AM
> > >> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
> > >> devel@edk2.groups.io
> > >> Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel
> > >> <Ard.Biesheuvel@arm.com>
> > >> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > >> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> > verbosity
> > >>
> > >> On 2020.12.20 19:14, Samer El-Haj-Mahmoud wrote:
> > >>> Using Ard's correct e-mail
> > >>>
> > >>>> -----Original Message-----
> > >>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > >> Samer
> > >>>> El-Haj-Mahmoud via groups.io
> > >>>> Sent: Sunday, December 20, 2020 2:08 PM
> > >>>> To: devel@edk2.groups.io
> > >>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
> > >>>> <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
> > >>>> Subject: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > >>>> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> > >> verbosity
> > >>>>
> > >>>> the DEBUG message for using compilation time epoch is appearing
> > >>>> very frequently on DEBUG firmware builds, for example during UEFI
> > SCT runs.
> > >>>> Reduce verbosity to avoid the annoying repetitive message.
> > >>>>
> > >>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >>>> Cc: Leif Lindholm <leif@nuviainc.com>
> > >>>> Cc: Pete Batard <pete@akeo.ie>
> > >>>> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> > >> Mahmoud@arm.com>
> > >>>> ---
> > >>>>
> > >>>>
> > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > >>>> .c
> > >>>> |
> > >>>> 2 +-
> > >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>>
> > >>>> diff --git
> > >>>>
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL
> > >>>> ib
> > >>>> .c
> > >>>>
> > >>
> > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > >>>> .c index 5c13ed4cf190..4210708cff36 100644
> > >>>> ---
> > >>>>
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL
> > >>>> ib
> > >>>> .c
> > >>>> +++
> > >>>>
> > >>
> > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > >>>> .c
> > >>>> @@ -88,7 +88,7 @@ LibGetTime (
> > >>>> //
> > >>>>
> > >>>> EpochSeconds = BUILD_EPOCH;
> > >>>>
> > >>>> DEBUG ((
> > >>>>
> > >>>> - DEBUG_INFO,
> > >>>>
> > >>>> + DEBUG_VERBOSE,
> > >>>>
> > >>>> "LibGetTime: %s non volatile variable was not found -
> > >>>> Using compilation time epoch.\n",
> > >>>>
> > >>>> mEpochVariableName
> > >>>>
> > >>>> ));
> > >>>>
> > >>>> --
> > >>>> 2.25.1
> > >>>>
> > >>>>
> > >>>>
> > >>>> -=-=-=-=-=-=
> > >>>> Groups.io Links: You receive all messages sent to this group.
> > >>>> View/Reply Online (#69269):
> > >>>> https://edk2.groups.io/g/devel/message/69269
> > >>>> Mute This Topic: https://groups.io/mt/79110001/1945644
> > >>>> Group Owner: devel+owner@edk2.groups.io
> > >>>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> > >>>> mahmoud@arm.com] -=-=-=-=-=-=
> > >>>>
> > >>>
> > >>> IMPORTANT NOTICE: The contents of this email and any attachments
> > >>> are
> > >> confidential and may also be privileged. If you are not the
> > >> intended recipient, please notify the sender immediately and do not
> > >> disclose the contents to any other person, use it for any purpose,
> > >> or store or copy the information in any medium. Thank you.
> > >>>
> > >>
> > >> Reviewed-by: Pete Batard <pete@akeo.ie>
> > >> Tested-by: Pete Batard <pete@akeo.ie> (On an RPi4 platform where
> we
> > >> would see tons of these unwanted messages without this patch)
> > >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
>
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-20 16:09 ` Samer El-Haj-Mahmoud
@ 2021-02-20 16:13 ` Ard Biesheuvel
0 siblings, 0 replies; 16+ messages in thread
From: Ard Biesheuvel @ 2021-02-20 16:13 UTC (permalink / raw)
To: devel, Samer El-Haj-Mahmoud
Cc: Ard Biesheuvel, Pete Batard, Leif Lindholm,
ardb+tianocore@kernel.org
On Sat, 20 Feb 2021 at 17:11, Samer El-Haj-Mahmoud
<samer.el-haj-mahmoud@arm.com> wrote:
>
> Resending with Ard's new e-mail address
>
Thanks Samer, but I cannot apply it from the garbled mess below.
Can you please send directly to me with git send-email?
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer
> > El-Haj-Mahmoud via groups.io
> > Sent: Wednesday, January 6, 2021 9:37 AM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Pete Batard
> > <pete@akeo.ie>; Leif Lindholm <leif@nuviainc.com>; Samer El-Haj-
> > Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
> >
> > resent
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > > Sent: Wednesday, January 6, 2021 5:34 AM
> > > To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Pete
> > Batard
> > > <pete@akeo.ie>; devel@edk2.groups.io; Leif Lindholm
> > > <leif@nuviainc.com>
> > > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > > EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> > verbosity
> > >
> > > On 1/5/21 9:46 PM, Samer El-Haj-Mahmoud wrote:
> > > > Gentle reminder...
> > > >
> > >
> > > Please resend this with me on cc so I have it in my mailbox.
> > >
> > > >> -----Original Message-----
> > > >> From: Pete Batard <pete@akeo.ie>
> > > >> Sent: Wednesday, December 23, 2020 11:37 AM
> > > >> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
> > > >> devel@edk2.groups.io
> > > >> Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel
> > > >> <Ard.Biesheuvel@arm.com>
> > > >> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > > >> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> > > verbosity
> > > >>
> > > >> On 2020.12.20 19:14, Samer El-Haj-Mahmoud wrote:
> > > >>> Using Ard's correct e-mail
> > > >>>
> > > >>>> -----Original Message-----
> > > >>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > >> Samer
> > > >>>> El-Haj-Mahmoud via groups.io
> > > >>>> Sent: Sunday, December 20, 2020 2:08 PM
> > > >>>> To: devel@edk2.groups.io
> > > >>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
> > > >>>> <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
> > > >>>> Subject: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> > > >>>> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message
> > > >> verbosity
> > > >>>>
> > > >>>> the DEBUG message for using compilation time epoch is appearing
> > > >>>> very frequently on DEBUG firmware builds, for example during UEFI
> > > SCT runs.
> > > >>>> Reduce verbosity to avoid the annoying repetitive message.
> > > >>>>
> > > >>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > >>>> Cc: Leif Lindholm <leif@nuviainc.com>
> > > >>>> Cc: Pete Batard <pete@akeo.ie>
> > > >>>> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> > > >> Mahmoud@arm.com>
> > > >>>> ---
> > > >>>>
> > > >>>>
> > > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > > >>>> .c
> > > >>>> |
> > > >>>> 2 +-
> > > >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >>>>
> > > >>>> diff --git
> > > >>>>
> > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL
> > > >>>> ib
> > > >>>> .c
> > > >>>>
> > > >>
> > > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > > >>>> .c index 5c13ed4cf190..4210708cff36 100644
> > > >>>> ---
> > > >>>>
> > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockL
> > > >>>> ib
> > > >>>> .c
> > > >>>> +++
> > > >>>>
> > > >>
> > > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib
> > > >>>> .c
> > > >>>> @@ -88,7 +88,7 @@ LibGetTime (
> > > >>>> //
> > > >>>>
> > > >>>> EpochSeconds = BUILD_EPOCH;
> > > >>>>
> > > >>>> DEBUG ((
> > > >>>>
> > > >>>> - DEBUG_INFO,
> > > >>>>
> > > >>>> + DEBUG_VERBOSE,
> > > >>>>
> > > >>>> "LibGetTime: %s non volatile variable was not found -
> > > >>>> Using compilation time epoch.\n",
> > > >>>>
> > > >>>> mEpochVariableName
> > > >>>>
> > > >>>> ));
> > > >>>>
> > > >>>> --
> > > >>>> 2.25.1
> > > >>>>
> > > >>>>
> > > >>>>
> > > >>>> -=-=-=-=-=-=
> > > >>>> Groups.io Links: You receive all messages sent to this group.
> > > >>>> View/Reply Online (#69269):
> > > >>>> https://edk2.groups.io/g/devel/message/69269
> > > >>>> Mute This Topic: https://groups.io/mt/79110001/1945644
> > > >>>> Group Owner: devel+owner@edk2.groups.io
> > > >>>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [samer.el-haj-
> > > >>>> mahmoud@arm.com] -=-=-=-=-=-=
> > > >>>>
> > > >>>
> > > >>> IMPORTANT NOTICE: The contents of this email and any attachments
> > > >>> are
> > > >> confidential and may also be privileged. If you are not the
> > > >> intended recipient, please notify the sender immediately and do not
> > > >> disclose the contents to any other person, use it for any purpose,
> > > >> or store or copy the information in any medium. Thank you.
> > > >>>
> > > >>
> > > >> Reviewed-by: Pete Batard <pete@akeo.ie>
> > > >> Tested-by: Pete Batard <pete@akeo.ie> (On an RPi4 platform where
> > we
> > > >> would see tons of these unwanted messages without this patch)
> > > >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended recipient,
> > please notify the sender immediately and do not disclose the contents to any
> > other person, use it for any purpose, or store or copy the information in any
> > medium. Thank you.
> >
> >
> >
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
>
>
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
@ 2021-02-20 16:41 Samer El-Haj-Mahmoud
2021-02-20 16:50 ` Ard Biesheuvel
0 siblings, 1 reply; 16+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-02-20 16:41 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Pete Batard
the DEBUG message for using compilation time epoch is appearing very
frequently on DEBUG firmware builds, for example during UEFI SCT runs.
Reduce verbosity to avoid the annoying repetitive message.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Pete Batard <pete@akeo.ie>
Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
---
EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
index 5c13ed4cf190..4210708cff36 100644
--- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
+++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
@@ -88,7 +88,7 @@ LibGetTime (
//
EpochSeconds = BUILD_EPOCH;
DEBUG ((
- DEBUG_INFO,
+ DEBUG_VERBOSE,
"LibGetTime: %s non volatile variable was not found - Using compilation time epoch.\n",
mEpochVariableName
));
--
2.25.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-20 16:41 [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity Samer El-Haj-Mahmoud
@ 2021-02-20 16:50 ` Ard Biesheuvel
2021-02-20 17:22 ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-02-20 21:46 ` Leif Lindholm
0 siblings, 2 replies; 16+ messages in thread
From: Ard Biesheuvel @ 2021-02-20 16:50 UTC (permalink / raw)
To: Samer El-Haj-Mahmoud; +Cc: devel, Ard Biesheuvel, Leif Lindholm, Pete Batard
On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud
<Samer.El-Haj-Mahmoud@arm.com> wrote:
>
> the DEBUG message for using compilation time epoch is appearing very
> frequently on DEBUG firmware builds, for example during UEFI SCT runs.
> Reduce verbosity to avoid the annoying repetitive message.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Pete Batard <pete@akeo.ie>
> Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Merged as #1434 into master.
> ---
> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> index 5c13ed4cf190..4210708cff36 100644
> --- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> @@ -88,7 +88,7 @@ LibGetTime (
> //
> EpochSeconds = BUILD_EPOCH;
> DEBUG ((
> - DEBUG_INFO,
> + DEBUG_VERBOSE,
> "LibGetTime: %s non volatile variable was not found - Using compilation time epoch.\n",
> mEpochVariableName
> ));
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-20 16:50 ` Ard Biesheuvel
@ 2021-02-20 17:22 ` Samer El-Haj-Mahmoud
2021-02-20 21:46 ` Leif Lindholm
1 sibling, 0 replies; 16+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-02-20 17:22 UTC (permalink / raw)
To: devel@edk2.groups.io, ardb@kernel.org
Thank you!
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> Biesheuvel via groups.io
> Sent: Saturday, February 20, 2021 11:51 AM
> To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Leif Lindholm <leif@nuviainc.com>; Pete Batard <pete@akeo.ie>
> Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 1/1]
> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>
> On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com> wrote:
> >
> > the DEBUG message for using compilation time epoch is appearing very
> > frequently on DEBUG firmware builds, for example during UEFI SCT runs.
> > Reduce verbosity to avoid the annoying repetitive message.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Pete Batard <pete@akeo.ie>
> > Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>
>
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>
> Merged as #1434 into master.
>
> > ---
> > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.
> > c
> > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.
> > c index 5c13ed4cf190..4210708cff36 100644
> > ---
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.
> > c
> > +++
> b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClock
> > +++ Lib.c
> > @@ -88,7 +88,7 @@ LibGetTime (
> > //
> > EpochSeconds = BUILD_EPOCH;
> > DEBUG ((
> > - DEBUG_INFO,
> > + DEBUG_VERBOSE,
> > "LibGetTime: %s non volatile variable was not found - Using compilation
> time epoch.\n",
> > mEpochVariableName
> > ));
> > --
> > 2.25.1
> >
>
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-20 16:50 ` Ard Biesheuvel
2021-02-20 17:22 ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2021-02-20 21:46 ` Leif Lindholm
2021-02-20 23:25 ` Samer El-Haj-Mahmoud
2021-02-21 10:50 ` Ard Biesheuvel
1 sibling, 2 replies; 16+ messages in thread
From: Leif Lindholm @ 2021-02-20 21:46 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Samer El-Haj-Mahmoud, devel, Ard Biesheuvel, Pete Batard
*How* annoying was this?
This is kind of useful information, well at the "would be good to see
in a regular DEBUG build" level.
This change will have suddenly effectively hidden a message that was
already present in many platforms, where they were not (very) annoyingly
repetitive during a normal boot.
It feels the test suite is not the thing that we need to optimise
debug output for.
Is there some alternative way we can rate limit this?
/
Leif
On Sat, Feb 20, 2021 at 17:50:43 +0100, Ard Biesheuvel wrote:
> On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com> wrote:
> >
> > the DEBUG message for using compilation time epoch is appearing very
> > frequently on DEBUG firmware builds, for example during UEFI SCT runs.
> > Reduce verbosity to avoid the annoying repetitive message.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Pete Batard <pete@akeo.ie>
> > Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>
> Merged as #1434 into master.
>
> > ---
> > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > index 5c13ed4cf190..4210708cff36 100644
> > --- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > @@ -88,7 +88,7 @@ LibGetTime (
> > //
> > EpochSeconds = BUILD_EPOCH;
> > DEBUG ((
> > - DEBUG_INFO,
> > + DEBUG_VERBOSE,
> > "LibGetTime: %s non volatile variable was not found - Using compilation time epoch.\n",
> > mEpochVariableName
> > ));
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-20 21:46 ` Leif Lindholm
@ 2021-02-20 23:25 ` Samer El-Haj-Mahmoud
2021-02-21 10:50 ` Ard Biesheuvel
1 sibling, 0 replies; 16+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-02-20 23:25 UTC (permalink / raw)
To: Leif Lindholm, Ard Biesheuvel
Cc: devel@edk2.groups.io, Ard Biesheuvel, Pete Batard,
Samer El-Haj-Mahmoud
Leif,
I admit, this is not *super* annoying on a normal DEBUG build boot. On the RPi4 for instance, this shows up between 25-50 times until the OS boots (depending on the boot source).
On a test run (such as running SCT), this message is *EXTREMLY* annoying. I see ~6600 instances on one run, accounting for ~60% of the entire debug output during the test. I agree we should not be optimizing for a test run, but this is just beyond being reasonable..
How useful is this message in non-verbose DEBUG output? Does it need to be repeated for every call to LibGetTime() ? I am open for suggestions on rate limiting the output.
--Samer
> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Saturday, February 20, 2021 4:46 PM
> To: Ard Biesheuvel <ardb@kernel.org>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
> devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>; Pete
> Batard <pete@akeo.ie>
> Subject: Re: [edk2-platform][PATCH v1 1/1]
> EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
>
> *How* annoying was this?
>
> This is kind of useful information, well at the "would be good to see in a
> regular DEBUG build" level.
>
> This change will have suddenly effectively hidden a message that was already
> present in many platforms, where they were not (very) annoyingly repetitive
> during a normal boot.
>
> It feels the test suite is not the thing that we need to optimise debug output
> for.
>
> Is there some alternative way we can rate limit this?
>
> /
> Leif
>
> On Sat, Feb 20, 2021 at 17:50:43 +0100, Ard Biesheuvel wrote:
> > On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud
> > <Samer.El-Haj-Mahmoud@arm.com> wrote:
> > >
> > > the DEBUG message for using compilation time epoch is appearing very
> > > frequently on DEBUG firmware builds, for example during UEFI SCT runs.
> > > Reduce verbosity to avoid the annoying repetitive message.
> > >
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Leif Lindholm <leif@nuviainc.com>
> > > Cc: Pete Batard <pete@akeo.ie>
> > > Signed-off-by: Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>
> >
> >
> > Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> >
> > Merged as #1434 into master.
> >
> > > ---
> > >
> > > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.
> > > c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLi
> > > b.c
> > > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLi
> > > b.c index 5c13ed4cf190..4210708cff36 100644
> > > ---
> > > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLi
> > > b.c
> > > +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClo
> > > +++ ckLib.c
> > > @@ -88,7 +88,7 @@ LibGetTime (
> > > //
> > > EpochSeconds = BUILD_EPOCH;
> > > DEBUG ((
> > > - DEBUG_INFO,
> > > + DEBUG_VERBOSE,
> > > "LibGetTime: %s non volatile variable was not found - Using
> compilation time epoch.\n",
> > > mEpochVariableName
> > > ));
> > > --
> > > 2.25.1
> > >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-20 21:46 ` Leif Lindholm
2021-02-20 23:25 ` Samer El-Haj-Mahmoud
@ 2021-02-21 10:50 ` Ard Biesheuvel
2021-02-21 20:43 ` Leif Lindholm
1 sibling, 1 reply; 16+ messages in thread
From: Ard Biesheuvel @ 2021-02-21 10:50 UTC (permalink / raw)
To: Leif Lindholm; +Cc: Samer El-Haj-Mahmoud, devel, Ard Biesheuvel, Pete Batard
On Sat, 20 Feb 2021 at 22:46, Leif Lindholm <leif@nuviainc.com> wrote:
>
> *How* annoying was this?
>
> This is kind of useful information, well at the "would be good to see
> in a regular DEBUG build" level.
>
> This change will have suddenly effectively hidden a message that was
> already present in many platforms, where they were not (very) annoyingly
> repetitive during a normal boot.
>
> It feels the test suite is not the thing that we need to optimise
> debug output for.
>
> Is there some alternative way we can rate limit this?
>
Given that the sole purpose of this library is to paper over the fact
that the platform violates the spec, and lacks the ability to tell
time, I think it makes little sense to obsess over how wrong the value
is that it returns.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-21 10:50 ` Ard Biesheuvel
@ 2021-02-21 20:43 ` Leif Lindholm
2021-02-21 20:50 ` Ard Biesheuvel
0 siblings, 1 reply; 16+ messages in thread
From: Leif Lindholm @ 2021-02-21 20:43 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Samer El-Haj-Mahmoud, devel, Ard Biesheuvel, Pete Batard
On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote:
> On Sat, 20 Feb 2021 at 22:46, Leif Lindholm <leif@nuviainc.com> wrote:
> >
> > *How* annoying was this?
> >
> > This is kind of useful information, well at the "would be good to see
> > in a regular DEBUG build" level.
> >
> > This change will have suddenly effectively hidden a message that was
> > already present in many platforms, where they were not (very) annoyingly
> > repetitive during a normal boot.
> >
> > It feels the test suite is not the thing that we need to optimise
> > debug output for.
> >
> > Is there some alternative way we can rate limit this?
>
> Given that the sole purpose of this library is to paper over the fact
> that the platform violates the spec, and lacks the ability to tell
> time, I think it makes little sense to obsess over how wrong the value
> is that it returns.
I'm not obsessing about anything, I'm saying that using tediousness
when running a testsuite as an argument, potential issues with the
only aspect that makes this implementation useful without having to
rebuild firmware every few weeks are now hidden.
If we truly don't care about the feature, nuke it. Don't hide when it
breaks.
/
Leif
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-21 20:43 ` Leif Lindholm
@ 2021-02-21 20:50 ` Ard Biesheuvel
2021-02-21 21:33 ` Leif Lindholm
0 siblings, 1 reply; 16+ messages in thread
From: Ard Biesheuvel @ 2021-02-21 20:50 UTC (permalink / raw)
To: Leif Lindholm; +Cc: Samer El-Haj-Mahmoud, devel, Ard Biesheuvel, Pete Batard
On Sun, 21 Feb 2021 at 21:43, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote:
> > On Sat, 20 Feb 2021 at 22:46, Leif Lindholm <leif@nuviainc.com> wrote:
> > >
> > > *How* annoying was this?
> > >
> > > This is kind of useful information, well at the "would be good to see
> > > in a regular DEBUG build" level.
> > >
> > > This change will have suddenly effectively hidden a message that was
> > > already present in many platforms, where they were not (very) annoyingly
> > > repetitive during a normal boot.
> > >
> > > It feels the test suite is not the thing that we need to optimise
> > > debug output for.
> > >
> > > Is there some alternative way we can rate limit this?
> >
> > Given that the sole purpose of this library is to paper over the fact
> > that the platform violates the spec, and lacks the ability to tell
> > time, I think it makes little sense to obsess over how wrong the value
> > is that it returns.
>
> I'm not obsessing about anything, I'm saying that using tediousness
> when running a testsuite as an argument, potential issues with the
> only aspect that makes this implementation useful without having to
> rebuild firmware every few weeks are now hidden.
>
> If we truly don't care about the feature, nuke it. Don't hide when it
> breaks.
>
Nuke what exactly? I think the library has a use, I simply don't see
the point of reporting 25-50 times every boot that no timestamp was
recorded in a variable.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity
2021-02-21 20:50 ` Ard Biesheuvel
@ 2021-02-21 21:33 ` Leif Lindholm
0 siblings, 0 replies; 16+ messages in thread
From: Leif Lindholm @ 2021-02-21 21:33 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Samer El-Haj-Mahmoud, devel, Ard Biesheuvel, Pete Batard
On Sun, Feb 21, 2021 at 21:50:20 +0100, Ard Biesheuvel wrote:
> On Sun, 21 Feb 2021 at 21:43, Leif Lindholm <leif@nuviainc.com> wrote:
> >
> > On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote:
> > > On Sat, 20 Feb 2021 at 22:46, Leif Lindholm <leif@nuviainc.com> wrote:
> > > >
> > > > *How* annoying was this?
> > > >
> > > > This is kind of useful information, well at the "would be good to see
> > > > in a regular DEBUG build" level.
> > > >
> > > > This change will have suddenly effectively hidden a message that was
> > > > already present in many platforms, where they were not (very) annoyingly
> > > > repetitive during a normal boot.
> > > >
> > > > It feels the test suite is not the thing that we need to optimise
> > > > debug output for.
> > > >
> > > > Is there some alternative way we can rate limit this?
> > >
> > > Given that the sole purpose of this library is to paper over the fact
> > > that the platform violates the spec, and lacks the ability to tell
> > > time, I think it makes little sense to obsess over how wrong the value
> > > is that it returns.
> >
> > I'm not obsessing about anything, I'm saying that using tediousness
> > when running a testsuite as an argument, potential issues with the
> > only aspect that makes this implementation useful without having to
> > rebuild firmware every few weeks are now hidden.
> >
> > If we truly don't care about the feature, nuke it. Don't hide when it
> > breaks.
> >
>
> Nuke what exactly? I think the library has a use, I simply don't see
> the point of reporting 25-50 times every boot that no timestamp was
> recorded in a variable.
Nuke the variable and always use the build timestamp EPOCH.
I would prefer that to silent failure.
Or we can figure out and alternative way to stop it spamming the
console.
The library is declared as a BASE library, but that's clearly untrue
as it depends on UefiRuntimeLib.
So we could, for example, break out the "check for EPOCH in variable"
into a protocol and print the message only once at protocol init.
Or we could add a Pcd for "no point, I have no persistent storage".
/
Leif
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-02-21 21:33 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-20 16:41 [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity Samer El-Haj-Mahmoud
2021-02-20 16:50 ` Ard Biesheuvel
2021-02-20 17:22 ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-02-20 21:46 ` Leif Lindholm
2021-02-20 23:25 ` Samer El-Haj-Mahmoud
2021-02-21 10:50 ` Ard Biesheuvel
2021-02-21 20:43 ` Leif Lindholm
2021-02-21 20:50 ` Ard Biesheuvel
2021-02-21 21:33 ` Leif Lindholm
[not found] <1652824B75E1BD30.11931@groups.io>
2020-12-20 19:14 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-12-23 16:37 ` Pete Batard
2021-01-05 20:46 ` Samer El-Haj-Mahmoud
2021-01-06 10:34 ` Ard Biesheuvel
2021-01-06 14:36 ` Samer El-Haj-Mahmoud
[not found] ` <1657AB5D550B1C6A.2692@groups.io>
2021-02-20 16:09 ` Samer El-Haj-Mahmoud
2021-02-20 16:13 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox