From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.52]) by mx.groups.io with SMTP id smtpd.web12.6616.1635843019556471049 for ; Tue, 02 Nov 2021 01:50:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=1CUwqbH/; spf=pass (domain: arm.com, ip: 40.107.20.52, mailfrom: ryan.harkin@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CINl8xRFjyBrbfMntwddGKhCVlWC5J7IyXD7pmMqGW0=; b=1CUwqbH/J8sxw2ALjhvOq67WRxpqDIWDoMlBuHpkxIFNXNUU2BecQryWxbq0754rqtIY6O51h+Su8eVx1p0wR2sSys8FMXVymD49o4Itq8/RpJ+MntLB8/xjYLYntjAoyfKLjdQDWXPkZDAexGwQWh84KKA85T0c/rFwlEp/eco= Received: from DB9PR02CA0006.eurprd02.prod.outlook.com (2603:10a6:10:1d9::11) by AM0PR08MB3922.eurprd08.prod.outlook.com (2603:10a6:208:128::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Tue, 2 Nov 2021 08:50:15 +0000 Received: from DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::a5) by DB9PR02CA0006.outlook.office365.com (2603:10a6:10:1d9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Tue, 2 Nov 2021 08:50:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT019.mail.protection.outlook.com (10.152.20.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Tue, 2 Nov 2021 08:50:15 +0000 Received: ("Tessian outbound e7ce0d853b63:v108"); Tue, 02 Nov 2021 08:50:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 51c3a008e5001962 X-CR-MTA-TID: 64aa7808 Received: from e8e10287f854.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7D73A0CA-25F2-43A5-9CAE-7386E71B9AB8.1; Tue, 02 Nov 2021 08:50:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e8e10287f854.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 02 Nov 2021 08:50:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TLMIFSI17noMQDUfyxjys9St6x/x/veV6L03eC0UJ25JOM7ckF6f5hty3ID53lmQmyRGftseaq7hzNUjx6sgjb98l0jOlmK2sICIvQDJr7flMydRR2FThWa7kcVHNM003PhFFxSt6eZZG65Xw+f595m5r+IzNRwlcqEf4iw55k8Nckph3OFP9xrO1V9V0XbFYovnj/M68VfKsbVvDsdJ2o6g/+MkrXEo1AjaLxURuayJlfPWcg1utngscjXVC0ef6hRnvZ3U+s5q7r0Kn7RCIH6e2na0Y2kqn5ZqKN8V+F8P/A7YaBkG/MUZ8sXz61/rnHtoC3vdwyW5T9Zbv/6IBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CINl8xRFjyBrbfMntwddGKhCVlWC5J7IyXD7pmMqGW0=; b=I4FWGSml88WQtDknzkbcKOGYHeyd2nFx6PAWKqlNnTNFWgYfY7SouQtvQ4CSqujM/G/2GJykOMfV6oMn52CIOz+B51tPTUQkSv4QC1vKdJguGhUVacRNXYdxBK0/8DEQTTn8oEVOmj2OVqHnZow921bBO8KFJr4iGQKyo4ScuxSIwnVQ507mws4bP8n4/2R2wFvrFTUzaeeD2HJt7KQetx8g77tZAluNiTGFNgfT2u+/Kldo9XulvpppVraZhZrVF6I6iPEx/ZyhT1F3PNpw/ibQGBNVlE2pwgSSZUecT75ub0RXwDInpai2yQwavAVZvFyxvEUKSi1YmXwCzi835g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CINl8xRFjyBrbfMntwddGKhCVlWC5J7IyXD7pmMqGW0=; b=1CUwqbH/J8sxw2ALjhvOq67WRxpqDIWDoMlBuHpkxIFNXNUU2BecQryWxbq0754rqtIY6O51h+Su8eVx1p0wR2sSys8FMXVymD49o4Itq8/RpJ+MntLB8/xjYLYntjAoyfKLjdQDWXPkZDAexGwQWh84KKA85T0c/rFwlEp/eco= Received: from DB7PR08MB3418.eurprd08.prod.outlook.com (2603:10a6:10:27::25) by DBBPR08MB4807.eurprd08.prod.outlook.com (2603:10a6:10:d9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Tue, 2 Nov 2021 08:50:06 +0000 Received: from DB7PR08MB3418.eurprd08.prod.outlook.com ([fe80::6503:321c:372:4b7b]) by DB7PR08MB3418.eurprd08.prod.outlook.com ([fe80::6503:321c:372:4b7b%6]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 08:50:06 +0000 From: ryan.harkin@arm.com To: "brbarkel@microsoft.com" , "devel@edk2.groups.io" , "leif@nuviainc.com" CC: Ard Biesheuvel , Sean Brogan Subject: Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM Thread-Topic: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM Thread-Index: AQHXz1rNgTZBdC4nEkmDZGHcAI8MBqvv7KKAgAABpJ4= Date: Tue, 2 Nov 2021 08:50:05 +0000 Message-ID: References: <20211101195648.6420-1-brbarkel@microsoft.com> <20211101195648.6420-2-brbarkel@microsoft.com> <20211102084313.scwv3uycao44o4l7@leviathan> In-Reply-To: <20211102084313.scwv3uycao44o4l7@leviathan> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: bcc63e56-fe91-3808-93fd-97917c6bcac4 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b33d1473-4785-4f5a-b8fe-08d99dddc9ee x-ms-traffictypediagnostic: DBBPR08MB4807:|AM0PR08MB3922: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: E6qVH5kUhL3iIfecLQlRX5SeHWn04PonW2AhWAvlnfZRdREAxpEcO4bbm8YsCtvzLnHtp3tfmWY6l6tmPkAhGqrgHtycrWgfrWoA/HYqdHGQ3IsUGovjbefI4RM+aKRa8bbc+TCR/rFS/nEkN/P6AwfBqm6dnpNo6k/Y1j35Iaz3/nNZmaGyFnG11i58Igp2q2lJ1AqszLplpl8kUv2uH1lqL0iogUym7q3mjoIGZ6xQkbj1dmE1w5qp5h2RtUlAY3HIIdqmOJJWOPTfdZVxPGSsvlUDtso7DRabEaTupUD3TK9J9CVcZH9TUAh0I0afBUjIR6fDbRWSeLQsMCsO5nK8Kbn+yCdLTfhK0m0aTf/iOnxvNxKim4kw26sqhFr+K//hw+YJZXBQ8AYppf2zYLVLvCU3LjHmDVMoqSd83OrSjSdjnv6ukOQNO7rcTZyyYY8otVr8DXVMTK7Ma6C5GSPiGrWjWKxVciLuH3Tt9FJOrr63CljyulQlpcTHovqvm7CaxztSJ4mykkvMkDDip2IFuDgl8x73rXN3rXsPHahUMseXH/JoUUFq04Z/RuhTs4ynZnyNmmDqmv0k5lSiSTHXAYxNY2+75w6MQIt4nx8Z7KZLg8TJYzUlwges/3c9EqrPeOSWpUCUvBQ10hOvGCj1SCNy3IW2/J1wJYq1HD/lUQelKWbpX2DD7y85ccobJDaku975qP3d7qPBdWbUhaCl5XKM7vaPREs9A6jBGl4/LBMv9l8MmbxqMoXzBl/vHryAj5IPDVUUXIrcxn5akX9Vv8c3kQFB8LQ1MoGuEkQUDYmf6Gv/4fHmkkEKFKgvyLEqUKnAVZN6L74poiJyWQHBHB30d8ULKpUh/cCRLCc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR08MB3418.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(9686003)(83380400001)(71200400001)(508600001)(53546011)(166002)(6506007)(7696005)(45080400002)(33656002)(110136005)(54906003)(966005)(66946007)(91956017)(66476007)(76116006)(66556008)(64756008)(8936002)(5660300002)(66446008)(55016002)(186003)(52536014)(316002)(86362001)(38100700002)(8676002)(2906002)(4326008)(122000001)(26005)(38070700005)(19627405001)(491001);DIR:OUT;SFP:1101; MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4807 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Ryan.Harkin@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ad7cf6e0-f14f-4e70-f020-08d99dddc492 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6860473Vo/c1OOPZwyRiwGRNBtdNTHjx17/AW5XeKfTKkBkansxASYKiHPpitWAyBTrQE0NXAgpaaD6s5vScYkWk/PUtz/b2gLBqtcsItYXI3REpgJZ53ONbliryiOrsZd0LqJlCaMujpLrk5kmGL9P4DKf19Cpnd4NhLPUSlwKfgelmFxpnaTJyFCcYtrfU07gCHNozQPD1kIgVTrDF9Ypi7Lb/EwP1AhlSr5urvGoGPVGPrT0orh5Ro5G/dm8108WR+78DZFJDOjvMoyYaxLQqytKgELl3LMR2m1+8GAF3h5Rfo6xm/CKy3rogyPqWk7fpfxkOM428sSsxl90C24WcVt7+HxFP6+npzAqTGaPIuk71TGFU/XPBqHy2W0A4VBGJl6F2/yy2RgPrDKgCmRDGmFwosQ4ZUWaUOtKUkyf1AQJDLReC8eGDpQkSPyDikZTNx6dG0BO9IRreaaPw/JBx6c6I8i+WdSqV2RSib06cHyIsCGzvObgNSx2+TBpnsK9GIRqZIw2Va3I7bkoY+z0r72cZulBI5VJybapGIr0D5uDX7JYPp4NCpiy/1/z3FaeTUEXuaaVwCz4D1BdBnjQ8+hk7xg3eagh6ABy2UheoDBxzL0+BH4nIbgv0yJc90iKlGje6cgKjOffUltef7PxKcsMSFJiI9vNNumV6yTeaaAimQnCUB6zKGXGAJZCn9NqgzsYQoxHaMqL3E252zwhpYf8y5DRqT8zM6KXFW8EyLAaXE9CxiPMZogAq96QifbpzxC54Gp9wH0TJkRQ/8CrKFOlM3N+Gflc98l+ZXBBCungmjDPO7+SLvryxUcHwpHI0d0zFZXsz2+ouPHRvepXlvCjRtg+pXZkujJtfOnA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(7696005)(54906003)(107886003)(26005)(356005)(4326008)(81166007)(36860700001)(336012)(186003)(316002)(110136005)(508600001)(33656002)(8936002)(45080400002)(70206006)(55016002)(166002)(70586007)(9686003)(82310400003)(53546011)(6506007)(47076005)(83380400001)(5660300002)(19627405001)(86362001)(966005)(52536014)(8676002)(2906002)(491001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 08:50:15.0744 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b33d1473-4785-4f5a-b8fe-08d99dddc9ee X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3922 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_DB7PR08MB3418DAE35CAF1A6D0614FD69F68B9DB7PR08MB3418eurp_" --_000_DB7PR08MB3418DAE35CAF1A6D0614FD69F68B9DB7PR08MB3418eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, There's a 00/16 in the series with a brief explanation that I'll paste here= : "This series of patch commits moves a number of modules and libraries aroun= d in order to better un-silo the Arm-specific code. Unnecessary abstractions were remo= ved, some duplicate code was abstracted, and generally things were cleaned up so that= common code (e.g. MdePkg, MdeModulePkg, StandaloneMmPkg) does not require ArmPkg o= r ArmPlatformPkg. Also, some things that were previously hidden away under ArmPkg are now loc= ated with the core functionality or build tooling that makes sense for it." Cheers, Ryan ________________________________ From: devel@edk2.groups.io on behalf of Leif Lindhol= m via groups.io Sent: 02 November 2021 08:43 To: brbarkel@microsoft.com Cc: devel@edk2.groups.io ; Ard Biesheuvel ; Sean Brogan Subject: Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow S= TANDALONE_MM Hi Bret, Is there some overall scope this set is aiming towards, or are these 16 unrelated patches to ArmPkg? Could you send out a cover-letter separately to clarify? Best Regards, Leif On Mon, Nov 01, 2021 at 12:56:33 -0700, brbarkel@microsoft.com wrote: > From: Bret Barkelew > > Not sure what all module types this HAS been validated against, but it > doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3647 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sean Brogan > Signed-off-by: Bret Barkelew > --- > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf b/ArmPkg/Library/= ArmMmuLib/ArmMmuBaseLib.inf > index 2a7e7147958c..d0988b27d582 100644 > --- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > +++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > @@ -13,7 +13,7 @@ [Defines] > FILE_GUID =3D da8f0232-fb14-42f0-922c-63104d2c70b= d > MODULE_TYPE =3D BASE > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D ArmMmuLib > + LIBRARY_CLASS =3D ArmMmuLib | DXE_DRIVER PEIM PEI_COR= E DXE_CORE DXE_RUNTIME_DRIVER SEC > > [Defines.AARCH64] > CONSTRUCTOR =3D ArmMmuBaseLibConstructor > -- > 2.31.1.windows.1 > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. --_000_DB7PR08MB3418DAE35CAF1A6D0614FD69F68B9DB7PR08MB3418eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Leif,

There's a 00/16 in the series with a brief explanation that I'll paste here= :

"This series of patch commits moves a number of modules and libraries around in = order
to better un-silo th= e Arm-specific code. Unnecessary abstractions were removed, some
duplicate code was abstracted, and generally things were cleaned up so that common
code (e.g. MdePkg, MdeModulePkg, StandaloneMmPkg) does not require ArmPkg or
ArmPlatformPkg.

Also, some things th= at were previously hidden away under ArmPkg are now located
with the core functi= onality or build tooling that makes sense for it."

Cheers,
Ryan

From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Leif Lindholm via groups.io <l= eif=3Dnuviainc.com@groups.io>
Sent: 02 November 2021 08:43
To: brbarkel@microsoft.com <bret@corthon.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Ard Biesheuve= l <ardb+tianocore@kernel.org>; Sean Brogan <sean.brogan@microsoft.= com>
Subject: Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Dis= allow STANDALONE_MM
 
Hi Bret,

Is there some overall scope this set is aiming towards, or are these
16 unrelated patches to ArmPkg? Could you send out a cover-letter
separately to clarify?

Best Regards,

Leif

On Mon, Nov 01, 2021 at 12:56:33 -0700, brbarkel@microsoft.com wrote:
> From: Bret Barkelew <brbarkel@microsoft.com>
>
> Not sure what all module types this HAS been validated against, but it=
> doesn't work with STANDALONE_MM or STANDALONE_MM_CORE.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3647
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Bret Barkelew <bret.barkelew@microsoft.com>
> ---
>  ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf b/ArmPkg/Libra= ry/ArmMmuLib/ArmMmuBaseLib.inf
> index 2a7e7147958c..d0988b27d582 100644
> --- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> +++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> @@ -13,7 +13,7 @@ [Defines]
>    FILE_GUID       &= nbsp;           &nbs= p;  =3D da8f0232-fb14-42f0-922c-63104d2c70bd
>    MODULE_TYPE       = ;             = =3D BASE
>    VERSION_STRING      &n= bsp;          =3D 1.0
> -  LIBRARY_CLASS        &= nbsp;         =3D ArmMmuLib
> +  LIBRARY_CLASS        &= nbsp;         =3D ArmMmuLib | DXE_D= RIVER PEIM PEI_CORE DXE_CORE DXE_RUNTIME_DRIVER SEC
> 
>  [Defines.AARCH64]
>    CONSTRUCTOR       = ;             = =3D ArmMmuBaseLibConstructor
> --
> 2.31.1.windows.1
>





IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in any medium. Thank you. --_000_DB7PR08MB3418DAE35CAF1A6D0614FD69F68B9DB7PR08MB3418eurp_--