Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2

["Sunny Wang" <Sunny.Wang@arm.com>]

Add Liming's new email.

Hi Marcin,

There seems no LF (0A).
1. From the patch I got below in this email, several lines got merged into one line.
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART                      0x000e #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC                                        0x000f #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART                               0x0010+#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS                             0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394                                                   0x8001 #define   EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD                                     0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB

2. In https://edk2.groups.io/g/devel/topic/patch_1_1_mdepkg_add_new/83024903?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,83024903, I saw "=0D" appending to each line. I'm not sure if this is relevant.

Moreover, I don't see #1 and #2 in another similar code change https://edk2.groups.io/g/devel/message/75283?p=,,,20,0,0,0::relevance,,MdePkg%3A+Update+DBG2+and+SPCR+header+with+NVIDIA+16550+Subtype,20,2,0,82919032.

Of course, if this won't cause any issue with pushing the patch, I'm totally fine with this.

Reviewed-by: Sunny Wang <sunny.wang@arm.com>


Best Regards,
Sunny Wang

-----Original Message-----
From: Marcin Wojtas <mw@semihalf.com>
Sent: Monday, May 24, 2021 10:21 AM
To: Sunny Wang <Sunny.Wang@arm.com>
Cc: devel@edk2.groups.io; michael.d.kinney@intel.com; leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; gjb@semihalf.com; upstream@semihalf.com
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2

Hi Sunny,


pon., 24 maj 2021 o 04:09 Sunny Wang <Sunny.Wang@arm.com> napisał(a):
>
> Looks good, Marcin.
> However, it looks like something wrong with the line-ending. Could you check if your line-ending setting is CR/LF? Did you use /edk2/BaseTools/Scripts/PatchCheck.py tool to check your patch? If not, could you use it? I expect this tool can catch the line-ending problem.

The line endings are fine in my repo, I generated and sent the patch as usual.

And of course prior to sending I ran PatchCheck.py - it complains only about too long URL line in the commit message, but the line-endings are ok.

$ python3 /home/mw/git/edk2-workspace/edk2/BaseTools/Scripts/PatchCheck.py -1 Checking git commit: HEAD
MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 WARNING - Line 9 of commit message is too long (91 >= 76).
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
The commit message format passed all checks.
The code passed all checks.

Do you check the line endings in a different way?

Best regards,
Marcin

>
> Best Regards,
> Sunny Wang
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin
> Wojtas via groups.io
> Sent: Sunday, May 23, 2021 5:15 PM
> To: devel@edk2.groups.io
> Cc: liming.gao@intel.com; michael.d.kinney@intel.com;
> leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang <Sunny.Wang@arm.com>;
> gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas
> <mw@semihalf.com>
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible
> Serial Port Subtypes to DBG2
>
> The Microsoft Debug Port Table 2 (DBG2) specification revision May 31,
> 2017 adds support for 16550-compatible Serial Port Subtype with
> parameters defined in Generic Address Structure (GAS) [1]
>
> Reflect that in the EDK2 headers.
>
> [1]
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi
> -debug-port-table
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  MdePkg/Include/IndustryStandard/DebugPort2Table.h                   | 1 +
>  MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h |
> 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..9ccfc1b1ee 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -47,6 +47,7 @@ typedef struct {
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART                      0x000e #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC                                        0x000f #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_BCM2835_UART                               0x0010+#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS                             0x0012 #define EFI_ACPI_DBG2_PORT_TYPE_1394                                                   0x8001 #define   EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD                                     0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB                                                    0x8002diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..7796796afe 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -100,6 +100,11 @@ typedef struct {
>  /// #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_BCM2835_UART              0x10 +///+/// 16550-compatible with parameters defined in Generic Address Structure+///+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_16550_WITH_GAS            0x12+ // // Interrupt Type //--
> 2.29.0
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#75464):
> https://edk2.groups.io/g/devel/message/75464
> Mute This Topic: https://groups.io/mt/83024903/5985097
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com]
> -=-=-=-=-=-=
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.