Re: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use unique UID's

["Sunny Wang" <Sunny.Wang@arm.com>]

Looks good to me as well. By the way, this fixed Windows PE blue screen issue.
Reviewed-by: Sunny Wang <sunny.wang@arm.com>

-----Original Message-----
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Monday, May 24, 2021 7:00 PM
To: Marcin Wojtas <mw@semihalf.com>; devel@edk2.groups.io
Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Sunny Wang <Sunny.Wang@arm.com>; gjb@semihalf.com; upstream@semihalf.com; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: RE: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use unique UID's

Reviewed-By: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: Marcin Wojtas <mw@semihalf.com>
> Sent: Monday, May 24, 2021 1:29 AM
> To: devel@edk2.groups.io
> Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; Sunny Wang
> <Sunny.Wang@arm.com>; gjb@semihalf.com; upstream@semihalf.com;
> Marcin Wojtas <mw@semihalf.com>
> Subject: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use
> unique UID's
>
> The CN9131 variant's SSDT comprised UID's, whose values
> overlapped the ones used in the main DSDT file. Fix that.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
>  Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl
> b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl
> index dc32fe836a..691a709c18 100644
> --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl
> +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl
> @@ -18,7 +18,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2,
> "MVEBU ", "CN9131", 3)
>          Device (AHC1)
>
>          {
>
>              Name (_HID, "LNRO001E")     // _HID: Hardware ID
>
> -            Name (_UID, 0x00)           // _UID: Unique ID
>
> +            Name (_UID, 0x01)           // _UID: Unique ID
>
>              Name (_CCA, 0x01)           // _CCA: Cache Coherency Attribute
>
>              Name (_CLS, Package (0x03)  // _CLS: Class Code
>
>              {
>
> @@ -43,7 +43,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2,
> "MVEBU ", "CN9131", 3)
>          Device (XHC2)
>
>          {
>
>              Name (_HID, "PNP0D10")      // _HID: Hardware ID
>
> -            Name (_UID, 0x01)           // _UID: Unique ID
>
> +            Name (_UID, 0x02)           // _UID: Unique ID
>
>              Name (_CCA, 0x01)           // _CCA: Cache Coherency Attribute
>
>
>
>              Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
>
> @@ -62,7 +62,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2,
> "MVEBU ", "CN9131", 3)
>          {
>
>              Name (_HID, "MRVL0110")                             // _HID: Hardware ID
>
>              Name (_CCA, 0x01)                                   // Cache-coherent controller
>
> -            Name (_UID, 0x00)                                   // _UID: Unique ID
>
> +            Name (_UID, 0x01)                                   // _UID: Unique ID
>
>              Name (_CRS, ResourceTemplate ()
>
>              {
>
>                  Memory32Fixed (ReadWrite, 0xf4000000 , 0x100000)
>
> --
> 2.29.0


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.