From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.77]) by mx.groups.io with SMTP id smtpd.web11.10014.1621950756935823408 for ; Tue, 25 May 2021 06:52:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=+GsksGS5; spf=pass (domain: arm.com, ip: 40.107.8.77, mailfrom: sunny.wang@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9bJnBmKwAD7MOTpIvPRhx21qMYsMhJkM6r+Fhqk5PfY=; b=+GsksGS5J/1dF3RTZsnbr8DwKdWDy5MIFB51jLd40gqzKgnpyy5m+sbD3jRCD4KV1dpUg1KdMRBc5MJVsnF9p8hwaHCpaq+9LiFIzLtJmHtQ+qydCoTonDW0nxc8pJJQlCqTUnP/hQD5R8/xGWibxrZt8VOxOs+YIe+cSylxS9g= Received: from MR2P264CA0122.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::14) by AM5PR0801MB1905.eurprd08.prod.outlook.com (2603:10a6:203:43::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.26; Tue, 25 May 2021 13:52:33 +0000 Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:30:cafe::3) by MR2P264CA0122.outlook.office365.com (2603:10a6:500:30::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Tue, 25 May 2021 13:52:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Tue, 25 May 2021 13:52:32 +0000 Received: ("Tessian outbound ea2c9a942a09:v92"); Tue, 25 May 2021 13:52:32 +0000 X-CR-MTA-TID: 64aa7808 Received: from bb122956aabd.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5E026D9F-03AE-4710-98BC-916F229E03EF.1; Tue, 25 May 2021 13:52:22 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bb122956aabd.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 25 May 2021 13:52:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PThw9rElHaedEvDZX/CIsjHDX5iGv4psfUA5ZQSoJ7Pyjs/QArLNx1HImkBOo5aoelsXaQ6KOrNJ6RgldoBHYnWK8Gjayrt5t95OL2zPvoJjxUMJ4NQviFXCuvYbw52vCH/ZKss1Q6hdSp0Z65KHE85xRYxDCi1ROC1tbrEnMVgnH7pUUN4ltlEl8a0rUMUF1lHZI51D2RXXJt9vVHVeE9ahqwg3vGQWTz+OjVP6Ct3D8NeE9R472pEwPyn/WYJLLOTbJm+f9wGac767HtBOEn/9X6+Bbvr5PFMxuexZMWkhNA0yPfMQqJd8TO0PObkPZOA4agCheGnZEK0K8/aL2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9bJnBmKwAD7MOTpIvPRhx21qMYsMhJkM6r+Fhqk5PfY=; b=nFTdLLjdQXQz2HVMOT9mZ+U05u9WJN7Ya5GD57MkvJjF24TRv02TW1IjUjDZyBPKSt9O/uMqQBZfzo9BdKkzQqVhfN8YHSoopAiyGqRyycgBoMRh4VKE4Ld9JqZGfK7/fQXBTZ0uRwURGrGHlcHlwEK5a8v/o+vcyw02Cvi7VH+y2sa1RwK1XIi/VZAL1TqMiX3fKHABshspni1oncJe19Gp2D/rRpTFKzrYaHj4QFqX+MvJTpu1kywJyvIm26YB+jWmY/N5fVP9HlXb8DFG03CNxCUYL4neiEkQaN5nMOcXRaLHQGn90MZ5LprgZ30W8LRy1D9qEGmwlYCfsZQU+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9bJnBmKwAD7MOTpIvPRhx21qMYsMhJkM6r+Fhqk5PfY=; b=+GsksGS5J/1dF3RTZsnbr8DwKdWDy5MIFB51jLd40gqzKgnpyy5m+sbD3jRCD4KV1dpUg1KdMRBc5MJVsnF9p8hwaHCpaq+9LiFIzLtJmHtQ+qydCoTonDW0nxc8pJJQlCqTUnP/hQD5R8/xGWibxrZt8VOxOs+YIe+cSylxS9g= Received: from DB8PR08MB3993.eurprd08.prod.outlook.com (2603:10a6:10:ad::26) by DB9PR08MB6523.eurprd08.prod.outlook.com (2603:10a6:10:256::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Tue, 25 May 2021 13:52:18 +0000 Received: from DB8PR08MB3993.eurprd08.prod.outlook.com ([fe80::9154:9191:b8a3:388c]) by DB8PR08MB3993.eurprd08.prod.outlook.com ([fe80::9154:9191:b8a3:388c%7]) with mapi id 15.20.4173.020; Tue, 25 May 2021 13:52:18 +0000 From: "Sunny Wang" To: Samer El-Haj-Mahmoud , Marcin Wojtas , "devel@edk2.groups.io" CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , "gjb@semihalf.com" , "upstream@semihalf.com" , Sunny Wang Subject: Re: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use unique UID's Thread-Topic: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use unique UID's Thread-Index: AQHXUF3TGI14Irc+mUGFOQ55njrZ8KrydzqAgAGhSyA= Date: Tue, 25 May 2021 13:52:18 +0000 Message-ID: References: <20210524052919.2496579-1-mw@semihalf.com> <20210524052919.2496579-5-mw@semihalf.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 145E030A802B0844999E74F047A19BBF.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [2001:b011:200f:44bf:1082:4e81:1cf8:48a3] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 5713353f-ea39-41ae-868b-08d91f845887 x-ms-traffictypediagnostic: DB9PR08MB6523:|AM5PR0801MB1905: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1775;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: daAoVBwT4OcMqTUtAPFPdvgBrsnq+LbYGiDRsPO5RF3A9wQiENiq8DLeI9ZsnpotGQtZQe2J+Rd7vKXPidOEJC3P4sQKcI250MkBRK92yeobLu3iq7qBCe1FNazc5/vTDlxdm3wftmN/fNV5SLMrY0Rx3/vYYIbKwEipUPzRZkl7cwN7dxr39pagDwD2OWVdsRCmar4m8pcpftiY0ocRCuAmZaNq/NXMOuM3jKxXhKxtbhBwbrciY6EbH1tOFbnW0l1tRcQXAV2mDYWztIJCm29r3Xn5wR+VgaOkjD3iiNIFLa16o2n5WPMgcwvDjgO+T+WPyiKuaSFzUr61WvyoWsTuaMf9GJwqbHveOAb8Ibb4Qh6fr8nZakEuzKKjjlYhUj+bxA7KOWXlnjLMLuVhYxx7C1+qOC6gBouMZLy0Ne6bbGozcyvWSaDqliVp7m0LTVsxvlqUYhbTKg+nccsJNGY6Icso84vqptU7ISoVk3/eAlWJAGrd2IykYC46T8XoznC5WBAOW0KC0NwGArY3uN8AP00KJnVw3oO0Nas8FkjX1j/yHkabRXfeu7ajWP3oa4HiRBS1Ia4O1o1C7lc0KjeOPsQdGqO8b8q/kYx5orc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB3993.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(376002)(396003)(366004)(136003)(346002)(83380400001)(66476007)(66946007)(66556008)(2906002)(33656002)(64756008)(54906003)(76116006)(7696005)(66446008)(55016002)(71200400001)(316002)(110136005)(478600001)(186003)(4326008)(5660300002)(52536014)(53546011)(8936002)(86362001)(122000001)(9686003)(38100700002)(6506007)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?crI2MMYqJ7pRDxDQ3RfvSqDV76HuQqY2oQkSd87WfXNl063Qca1mCZtm7X+R?= =?us-ascii?Q?m+KEs4Shhy8HlDH9ja+ML0z9gzot9Zn1why/wKGxlb5Nrw7R2L5qbMAKOgWU?= =?us-ascii?Q?XUoJa4cZC1LNjh0bZh6KexZrACBZZTO3wpXRghIXI56VWHzNwUriD+r6PjVs?= =?us-ascii?Q?EXEoxOkTlXogYt4cfQkrhb1lllYgtXlCHqRsCEdr6ugjEp3Zg0Lpf7HFOXgB?= =?us-ascii?Q?Ay2v7ecNGLKdjqXGR0CT8cI7ER7XFLDn/AjccML4b899wshR17XW6S8pmMPk?= =?us-ascii?Q?NhWk9u1RC3qTsThJSOr7hUuoQRI/6Q6W1rnON3N0o2E5mo2Eef7JRv4sTGJ+?= =?us-ascii?Q?yXFXAMlj1OKdCm/KZ9xhN0WtSJPv1Ia7lLaMtXGNtelAol4glXNVaxfDcPEn?= =?us-ascii?Q?Z4tCcAev7utq3csnmALs0gPuBlncRGDBVWBB4a/emwCNzFWvKROgbKwkHhLF?= =?us-ascii?Q?X3vVOg0nKyOWN/xqJN+eLf/AKKpdHgZ35tf2Ja5ch3TtGAcQLrZO2f4ARR9A?= =?us-ascii?Q?6sPdS8X51Xc043TDXKwYYJc0Tcym0fDmgtzZlfMFwi4gudqF5Q+y+yh2Xe78?= =?us-ascii?Q?KXMY2pKafH1Sgornlt39eUoZJim2rxir7JyIH/X3O60Nl+3S0v99e602ZO24?= =?us-ascii?Q?4SeFE+oO/Py649wL3SPJTCQRIXJIs2vPWGKbd/ouHZ+hebCfZ4ntxzusAjnE?= =?us-ascii?Q?NyCXYzAHtGAF1wtenaBGVAduXc4XacLQQDI2ULXBsxkcFSVpYUsXj4ka5F16?= =?us-ascii?Q?QfBosV9GinUbj7wblWzkJbbwfi//pim+TZqwXCmKOhlBf9TMfC9//pboVGZn?= =?us-ascii?Q?YUbGruo3fJCMYxYjefyux2EuAN88Z8ktTD0dHbgx9f5ph13P3G1RxIJqri4m?= =?us-ascii?Q?ZoOJNJWWWuZFA8i40gjBgU9QbohRWV0crMwUlRzas67l265sRrMbLtEmYVjd?= =?us-ascii?Q?3XP/7sDjVoTIO3B5cf2Hf9gAF1lYj3cgz37BiuoHAbufh6b232D34upeg3s+?= =?us-ascii?Q?f4CqQtZzCmiWaOqVSM8gb+uJKw1iQFV9kutSLHL3sFh1vuhvmRgpMqVrMjjN?= =?us-ascii?Q?HeS5iia1MYB5uKS48t9eIQ584bCOVPExm5W17H3I6mkacSpcUzb3grtyDbrU?= =?us-ascii?Q?Sawhx50DYlWQmZTlyu0KbAm31NqLXvoLqgMlFDi6iazo3sHLhAXIUtScM5Tl?= =?us-ascii?Q?f0vA6BEuckWTYJ6gQ0dcoleZqujYCIyeLEmp9jjgHI/u7O5rWamsv0zW4bGa?= =?us-ascii?Q?OuO3q2dLXPbdh9CIImbMAe8pTD+eXjfyvLBnqfl8rH2LJQnKYTa+M5E/i4Az?= =?us-ascii?Q?2PdfkUUvfuwHMSzmEsyb0445QMxLyFmkIhvhjKAqhJCr524K8WdPZERI+itO?= =?us-ascii?Q?dGLkgEFp3HhuZIHIW6xZ2Y+iqoaU?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6523 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sunny.Wang@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 581c4a08-4de2-4f61-2249-08d91f844fdc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5qHHldnGyupEoa/HouujBXXyaKB8slb+F4NmFrbrKlzQYC2dA3/8ICKU/VAmxrzxu+VBzs9ZUmHmsEf3Jj3WdlG1BTlniIhRgfh2hm4Hf1+MmnjfkdKQJioAi2JamG6wyeqWDbixTl1U885bY6H5bjMJouw7Lrcl5DtLXWQ5Z6SBMPfv9FGxU+tzdQS18AM5CqZan/fl4AaxjSqYTxf/QSxsanhrpoXkSGp4RbbRPskwno8wFM1S8Gl4dFCTBegGfRjy3eWfMQdonAgqlkNS1G6eQn3PqZTHTuMQOnmCXDL7YdKfSEDr7T68Jo1iU9HXmOeK3YAweNeGxarT2Y8bCaSEI4QDATEO3MSTTED6rDDmO+3BYQeom0/ANMUSylSmjml5jkQBDv2tX4n/F5fRaIa6vOm7qTtbOPD/RlbtIWDCsSUjDIII76qqKH4O3Gad9AoIMPmKx6F1aGFL8SvNjELelqmqNZc7jg3Zc9STi+Wh5WyqtJ6t4MCSjN8b9CKTtlxxJr2rYnSmXyJYWcJX9wkqq9DxhwuPw1rzuIDeOgBvcgOGr/qvV7eZL/Cubk5G+cHby1Bb4w6aQy6SzDvL4FCy5jjokKXrAvE5ZLquAXaErmboERwiJapn2vz7hd7oQda/S7nOAHfElSsNgyxdvQjQkl3Rjt7E758K2HfOQYc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(136003)(39860400002)(346002)(376002)(396003)(36840700001)(46966006)(86362001)(2906002)(356005)(70206006)(47076005)(8676002)(478600001)(82740400003)(83380400001)(8936002)(336012)(52536014)(4326008)(54906003)(110136005)(186003)(7696005)(70586007)(5660300002)(81166007)(55016002)(33656002)(82310400003)(316002)(6506007)(26005)(53546011)(9686003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 13:52:32.9727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5713353f-ea39-41ae-868b-08d91f845887 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1905 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me as well. By the way, this fixed Windows PE blue screen iss= ue. Reviewed-by: Sunny Wang -----Original Message----- From: Samer El-Haj-Mahmoud Sent: Monday, May 24, 2021 7:00 PM To: Marcin Wojtas ; devel@edk2.groups.io Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Sunny Wang ; gjb@semihalf.com; upstream@semihalf.com; Samer El-Haj-Mahmoud Subject: RE: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use = unique UID's Reviewed-By: Samer El-Haj-Mahmoud > -----Original Message----- > From: Marcin Wojtas > Sent: Monday, May 24, 2021 1:29 AM > To: devel@edk2.groups.io > Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud > ; Sunny Wang > ; gjb@semihalf.com; upstream@semihalf.com; > Marcin Wojtas > Subject: [edk2-platforms PATCH 4/6] Marvell/Cn913xDbA: AcpiTables: Use > unique UID's > > The CN9131 variant's SSDT comprised UID's, whose values > overlapped the ones used in the main DSDT file. Fix that. > > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl > b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl > index dc32fe836a..691a709c18 100644 > --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl > +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9131DbA/Ssdt.asl > @@ -18,7 +18,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2, > "MVEBU ", "CN9131", 3) > Device (AHC1) > > { > > Name (_HID, "LNRO001E") // _HID: Hardware ID > > - Name (_UID, 0x00) // _UID: Unique ID > > + Name (_UID, 0x01) // _UID: Unique ID > > Name (_CCA, 0x01) // _CCA: Cache Coherency Attribu= te > > Name (_CLS, Package (0x03) // _CLS: Class Code > > { > > @@ -43,7 +43,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2, > "MVEBU ", "CN9131", 3) > Device (XHC2) > > { > > Name (_HID, "PNP0D10") // _HID: Hardware ID > > - Name (_UID, 0x01) // _UID: Unique ID > > + Name (_UID, 0x02) // _UID: Unique ID > > Name (_CCA, 0x01) // _CCA: Cache Coherency Attribu= te > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource S= ettings > > @@ -62,7 +62,7 @@ DefinitionBlock ("Cn9131DbASsdt.aml", "SSDT", 2, > "MVEBU ", "CN9131", 3) > { > > Name (_HID, "MRVL0110") // _HID:= Hardware ID > > Name (_CCA, 0x01) // Cache= -coherent controller > > - Name (_UID, 0x00) // _UID:= Unique ID > > + Name (_UID, 0x01) // _UID:= Unique ID > > Name (_CRS, ResourceTemplate () > > { > > Memory32Fixed (ReadWrite, 0xf4000000 , 0x100000) > > -- > 2.29.0 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.