* [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
@ 2021-06-11 7:07 Sunny Wang
2021-06-11 8:23 ` Heinrich Schuchardt
0 siblings, 1 reply; 3+ messages in thread
From: Sunny Wang @ 2021-06-11 7:07 UTC (permalink / raw)
To: devel
Cc: Sunny Wang, Samer El-Haj-Mahmoud, G Edhaya Chandran, Barton Gao,
Heinrich Schuchardt, Michael D Kinney, Sunny Wang
The commit a9d1fb58 caused SCT BS.CreateEvent failures.
Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
exclusive use by the firmware. The creation of events by UEFI
applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
level.
Therefore, revert TPL_HIGH_LEVEL change in commit a9d1fb58 to not create
event with TPL_HIGH_LEVEL to be compliant with UEFI Spec and fix the
failures.
For more information, https://edk2.groups.io/g/devel/message/76338
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Sunny Wang <sunny.wang@arm.com>
---
.../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
index a7e7366e..d5c033f7 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
@@ -2,6 +2,7 @@
Copyright 2006 - 2012 Unified EFI, Inc.<BR>
Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2021, ARM Limited. All rights reserved.
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
@@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
@@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
EFI_TPL NotifyTpls[] = {
TPL_CALLBACK,
TPL_NOTIFY,
- TPL_HIGH_LEVEL,
0
};
EFI_TEST_ASSERTION AssertionType;
--
2.31.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
2021-06-11 7:07 [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL Sunny Wang
@ 2021-06-11 8:23 ` Heinrich Schuchardt
2021-06-11 8:37 ` [edk2-devel] " Sunny Wang
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-06-11 8:23 UTC (permalink / raw)
To: Sunny Wang
Cc: Samer El-Haj-Mahmoud, G Edhaya Chandran, Barton Gao,
Michael D Kinney, devel
On 11.06.21 09:07, Sunny Wang wrote:
> The commit a9d1fb58 caused SCT BS.CreateEvent failures.
>
> Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> exclusive use by the firmware. The creation of events by UEFI
> applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> level.
>
> Therefore, revert TPL_HIGH_LEVEL change in commit a9d1fb58 to not create
> event with TPL_HIGH_LEVEL to be compliant with UEFI Spec and fix the
> failures.
>
> For more information, https://edk2.groups.io/g/devel/message/76338
Please, have a look at commit ae7e5477b555 ("uefi-sct/SctPkg: allowable
NotifyTpl in CreateEventEx") too.
Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>
> ---
> .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> index a7e7366e..d5c033f7 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2012 Unified EFI, Inc.<BR>
> Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2021, ARM Limited. All rights reserved.
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
2021-06-11 8:23 ` Heinrich Schuchardt
@ 2021-06-11 8:37 ` Sunny Wang
0 siblings, 0 replies; 3+ messages in thread
From: Sunny Wang @ 2021-06-11 8:37 UTC (permalink / raw)
To: devel@edk2.groups.io, xypron.glpk@gmx.de
Cc: Samer El-Haj-Mahmoud, G Edhaya Chandran, Barton Gao,
Michael D Kinney, Sunny Wang
Thanks for catching this, Heinrich.
I sent v2 to also revert TPL_HIGH_LEVEL changes in ae7e5477b555.
Best Regards,
Sunny Wang
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heinrich Schuchardt via groups.io
Sent: Friday, June 11, 2021 4:24 PM
To: Sunny Wang <Sunny.Wang@arm.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Michael D Kinney <michael.d.kinney@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL
On 11.06.21 09:07, Sunny Wang wrote:
> The commit a9d1fb58 caused SCT BS.CreateEvent failures.
>
> Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed for
> exclusive use by the firmware. The creation of events by UEFI
> applications, UEFI drivers, and UEFI OS Loaders should not use this TPL
> level.
>
> Therefore, revert TPL_HIGH_LEVEL change in commit a9d1fb58 to not create
> event with TPL_HIGH_LEVEL to be compliant with UEFI Spec and fix the
> failures.
>
> For more information, https://edk2.groups.io/g/devel/message/76338
Please, have a look at commit ae7e5477b555 ("uefi-sct/SctPkg: allowable
NotifyTpl in CreateEventEx") too.
Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: G Edhaya Chandran <edhaya.chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>
> ---
> .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> index a7e7366e..d5c033f7 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices/BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c
> @@ -2,6 +2,7 @@
>
> Copyright 2006 - 2012 Unified EFI, Inc.<BR>
> Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2021, ARM Limited. All rights reserved.
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
> @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 (
> EFI_TPL NotifyTpls[] = {
> TPL_CALLBACK,
> TPL_NOTIFY,
> - TPL_HIGH_LEVEL,
> 0
> };
> EFI_TEST_ASSERTION AssertionType;
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-11 8:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-11 7:07 [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL Sunny Wang
2021-06-11 8:23 ` Heinrich Schuchardt
2021-06-11 8:37 ` [edk2-devel] " Sunny Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox