From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.77]) by mx.groups.io with SMTP id smtpd.web11.19662.1621837561154890211 for ; Sun, 23 May 2021 23:26:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=HZA5REEx; spf=pass (domain: arm.com, ip: 40.107.21.77, mailfrom: sunny.wang@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjE5wmrp8Cuie1X5LylRwALo0vkwuFqT7ewa44qR2Ng=; b=HZA5REEx0eMCMGUvuCvLlciJ+avUs0rmglH5Ld+z7cOxn/xiEUWIwXroQzoJ59+cx99rlfHB1ilynAFMQ26cXD2+P0pMYAbP7cD/inJRXY1Bdw9bs/Rf9HhR2o4bGiwniZIfIFbZg5YKwzOEwrSNy4SULNeaDFd+H63aZQIpRmA= Received: from AM5PR0701CA0066.eurprd07.prod.outlook.com (2603:10a6:203:2::28) by AM6PR08MB3639.eurprd08.prod.outlook.com (2603:10a6:20b:51::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23; Mon, 24 May 2021 06:25:48 +0000 Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::d7) by AM5PR0701CA0066.outlook.office365.com (2603:10a6:203:2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.12 via Frontend Transport; Mon, 24 May 2021 06:25:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 24 May 2021 06:25:47 +0000 Received: ("Tessian outbound 2cd7db0b285f:v92"); Mon, 24 May 2021 06:25:47 +0000 X-CR-MTA-TID: 64aa7808 Received: from 25c9cdea2838.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4230348B-B907-4533-8515-E1823FE4ECFE.1; Mon, 24 May 2021 06:25:40 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 25c9cdea2838.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 May 2021 06:25:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bpnCMI3VFRbF3oSSiMBbvOsPhhPIKbTTsDx6d+JNAJYW9gB2ykQrOYDMISNWEnZFJikWI0zCrwwd2Dd2/9s3l2/ZpLJNlAP1TIa5eKrGLa2FuAwWt3B6kMSL/vzewGrtqvYFzt6NTTvsVNEUqcvZwCOSnqTle56PsHYozkLJkQmdQiEdMyuW9k7gY7Sb/TpKd0A4l6z24KNNQj+RkQPy1yK5beDU3gIwkjl1STCQ4ITfvFatvTiYVYp/t58EXHmdfMn/H9rnOWOSISP/yuVfOiWYvVDv8U6y6jiO3ZPj1eC+62BhMWFojxi0ZysaFsXKRZSxdDPAhIPqSSq7XKR0QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjE5wmrp8Cuie1X5LylRwALo0vkwuFqT7ewa44qR2Ng=; b=C6NkSl7sy3mnTwuJYn+nEpufSPiU+k4YqGzZBvieuc3+cEk6Mhe/BYHLFbjOfUfnDDl5MCjEVKrA+AzLjbb1n/VQBuKEfSptKdK7juOy/nJ8eZLIZNLjnnYHKNi3g5Cct/aFSf9fAcagi30AOrEf5YuWAF2NlDAGGFjIVrB0qKFbSDZZyWObM9hWi7jrlAV2Ud4rIDroNbsZHPX8kiuSix+JDWIIM578gzS+MesqWEJ1FNvXY13p0dobhsB6H2CEEo+D3u9HxloJgp+tTlb94FPWDlzUSnMLkJ+HCoDUu/A+wcS0YdF0jSrEWUVUVDA2m1ad3HDxnAH6yOZQ2OfHMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjE5wmrp8Cuie1X5LylRwALo0vkwuFqT7ewa44qR2Ng=; b=HZA5REEx0eMCMGUvuCvLlciJ+avUs0rmglH5Ld+z7cOxn/xiEUWIwXroQzoJ59+cx99rlfHB1ilynAFMQ26cXD2+P0pMYAbP7cD/inJRXY1Bdw9bs/Rf9HhR2o4bGiwniZIfIFbZg5YKwzOEwrSNy4SULNeaDFd+H63aZQIpRmA= Received: from DB8PR08MB3993.eurprd08.prod.outlook.com (2603:10a6:10:ad::26) by DBBPR08MB4252.eurprd08.prod.outlook.com (2603:10a6:10:c2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.25; Mon, 24 May 2021 06:25:38 +0000 Received: from DB8PR08MB3993.eurprd08.prod.outlook.com ([fe80::9154:9191:b8a3:388c]) by DB8PR08MB3993.eurprd08.prod.outlook.com ([fe80::9154:9191:b8a3:388c%7]) with mapi id 15.20.4150.027; Mon, 24 May 2021 06:25:38 +0000 From: "Sunny Wang" To: Marcin Wojtas , "devel@edk2.groups.io" CC: "michael.d.kinney@intel.com" , "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Samer El-Haj-Mahmoud , "gjb@semihalf.com" , "upstream@semihalf.com" , Sunny Wang Subject: Re: [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime Thread-Topic: [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime Thread-Index: AQHXUFCd84UHjmXpTUm1/XwfjR6wDKryKJbA Date: Mon, 24 May 2021 06:25:38 +0000 Message-ID: References: <20210524035441.2489465-1-mw@semihalf.com> In-Reply-To: <20210524035441.2489465-1-mw@semihalf.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 18CD3860F0EE9A4BBFC1312B622B28C4.0 x-checkrecipientchecked: true Authentication-Results-Original: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [2001:b011:200f:2691:1082:4e81:1cf8:48a3] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: d38e97fd-0043-4906-604c-08d91e7cc4dc x-ms-traffictypediagnostic: DBBPR08MB4252:|AM6PR08MB3639: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3826;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3eHP1nJq8nh/HyTVY8wvO/WgG2IhYDBm5Sv3ZPh6SdvkOwte2mH/kUM1bHNVwLVdi5ERMm4yKt+nbi1bpY/cAeMNkDfp61dPXfxSNRPEMpy+k1PrxqDwv6z3B2CpNMWdK7oGmksTpbg3fVISMcmzSaNbrRQZJLDvr+hwt3kjm9jKyaFLtM3agJVyolLQy0AjRRecQtQZYXzkVJ9n3hdNpWlQpoZosHbxFtk2BbNie+Kep/bWi93VvnMVf3mCuP1mYIEHN120wZS5x+JiPEh8FSOZHiFeF8Ha0e1gysEy7ui41RqJOmb8Yn1ypyfDk+3YrH0g/12JLzbxLJDhN57qr00skViJuK9OOiQfebJNg2JrTTdXhDXlDphxIMyDQw7hQIkEH6/oR7CMspHFDmivo3+OHoOXW5Zu7KDCLF1KQs5IuYcai53zjAy+dPaDAEIeE1H2kq98b2+jdX1gi17bdHq+DEJR/X0RtcgeNAaoKcoXLX/ASUEKJ1DWGD0pR6Pi8hEFxP4XNHCHMkefv+96VC0CJDQ1MItTO0XSn5zfKEVi41UKGsigLTo1U8+89NB4fx77hQOqpmxL8ikZ3PB41KioZ8/qL41ylio0hYkiIIkpFftVX5R9L0HSTM6j76H4odyfz7aUsw5U9j+Z16DScsnA/cGFxAF8yUemctGwrSiK5vyZNi8URhI5qu4xxbkTv0rweEEdQvrggfpMe/t/jp9yAzg5N23wk1hPQzhu5rxNnfuxOToP0EUpzIzzPXqJfYmR8tL0BU3pgjvEkOWfjw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB3993.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(55016002)(4326008)(66946007)(66476007)(66556008)(64756008)(45080400002)(122000001)(71200400001)(52536014)(38100700002)(7696005)(86362001)(8676002)(966005)(5660300002)(186003)(2906002)(66446008)(83380400001)(53546011)(6506007)(110136005)(54906003)(76116006)(33656002)(9686003)(316002)(478600001)(8936002)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?4q/nCj4wAgmDJdV9WCsQLpnnaS0M0cVhIIf8+Zjf3NUzrYfOE8l/Hwp+k85U?= =?us-ascii?Q?kGLFl2xuoPNd/qI8ToBsISsLyROSdo8tSCc24P1K14EZYCwe8HkUqGuFqbV7?= =?us-ascii?Q?tO+/6keVYUaQxJBY7eBhdrCVNy0X3ZsKq1SWjPjLD2zP8k4I9T0KF3A671h2?= =?us-ascii?Q?vkPIs7Oyys1Fx0LDJZzwgBXpJlKdoRsWF0lLJJKiT+N/GiiGqty5Ql9QFh1S?= =?us-ascii?Q?sGfIJknEdYlR49IK1Mk4+IquLT7FhFKpeI2b06wLKsiqv+VrZ6GjXsRlcsfk?= =?us-ascii?Q?KeLGeHZi462GNl5sBkgQKblEPzOI/JWAU1sUvzPVVU/pwDk1V9zAFWfgidz0?= =?us-ascii?Q?OvQXnm6BxGX+MiLrWoK2BZ6ofK+jpCwnVIBU/SwYpA6Bi7A/ifLZwnL/b19G?= =?us-ascii?Q?8OjxDPL8g30KJswYy9lTJXey12AKcFJuYhHumbLUM0UJcD9AtUOwh5U9t4uA?= =?us-ascii?Q?FDkwq4HdQCI7USsABTuFogIZU6ijdEPm/Dw48S1NTUpaj1Vkc5Q7vm107Rw2?= =?us-ascii?Q?PjU3LtLQZwjA/Gr9UMlZUeI5Q9yagiJj3+Q0Hb+dwbZt9kppJq5njVzkK2QT?= =?us-ascii?Q?kbAJoGIyeHfSroOfthXI0VFS4VI85px2iii4Dt88VXEXw/ZtGY6h9JNlt+od?= =?us-ascii?Q?ZvUWkQ9VrNqi5BWCjoejOKrr8WfDRnF76aCrhFHj3D/dN8YsUbZbDSNoRdiy?= =?us-ascii?Q?9UyddyBPAENNWc9zuzWCUBqlI8SEAgobXbShPcqaEGNyLLGqIaR6bDlYABRD?= =?us-ascii?Q?ySK4oFWBixTlbUidIQa7qFOmLVLhwXEkapBBShMv9nBlzHW000e3SiPvfyu2?= =?us-ascii?Q?flb2ZRG9F6npYn9e77V8kjurgoavVQ/TiQINeM/eFlmzlZtc4aY9V9BafrDv?= =?us-ascii?Q?fFIqTG/FfXlJWAn/6oWGdrwLwE/os/hAw3sFCrfDOxMLHVBLabihv03bC+6B?= =?us-ascii?Q?TIGOPj48tP0aSvOHFWjcxTXoBas5mWrG1bHom6yGwn9rvUDMilj4Fdr14rHe?= =?us-ascii?Q?epYKcbptxGvG7b61DUXNbwzwBzsqASZNqbpm4vv3szyva5eQSjMIiFTCiKSv?= =?us-ascii?Q?cqR3kCnTQi7NASrRYh5HLXxjhJa5Lo/Of+Z2mTLDixu6v96uCJiNiqF01YxJ?= =?us-ascii?Q?MOT4pwhMCoKLeXr6b/7aQwbl2HOAI4mVa1STDeOBfXfL7wfidi+YLa5zJ9qI?= =?us-ascii?Q?PMscIsNssmFmtmi1oV0GbwX77niDUH4Eod8uX9sY2FRlvwX4NyOyE04NMpVR?= =?us-ascii?Q?FZb8u2BilA1PZQba0kKQsLyF/B4Oh4/7UrFPSVxwEdJfG7lTF3ywerT/sH+t?= =?us-ascii?Q?FP6A9+pQbwn2gTMLL4dS7qc+By88qJGOhjU1y0jXWGaIZOIgNFv/+DmpEjpq?= =?us-ascii?Q?H6Y+SxuVKEQkBK6UO1G8+jvlDyCP?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4252 Original-Authentication-Results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; Return-Path: Sunny.Wang@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7aa0e490-5836-4d91-d7ba-08d91e7cbf2f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eHZ59DfLL/rKIb6HBNREMsqQtkqbyF/eQusYuCocmvBlWG8G+rr/Y8rn801xI/wqZi5tNn6PVDRWOKjPzn0/ygKLSaFBpl5wHtaf5ndvIEnvOz98k3f9fUjdFLTBg9KWEzSusbIXPeGCCSgaRqXcmzk7hHUB1zeDBJpr2NL+SVBTzEDA9m6JEdL7SEEjqjRtpGSW/HMy0/emXG/hJOxY8qIENzSY36NUjLhHKPHzERoZhbU10y6DQEbYMGECPn29HYy8PUkRpF/1CSsRAXG8wxc9Vl/g/8gEJkDyC0zBPP0sZc2xnb3/Xmj5aiAoS9iosVmPBxT8IwRxdLU/HiZyg9YTSeRZRiKiAvhk0rlUltr8pOWPaj5Y5EplPZ7Ilv4puyh2fdcNDhDDUK+wIANk4hGMdN9Ub+PngGuH2aSroE8dAymzdiWgc5yWbVXL56q9MDJ6dT9aYix9IbdRPO6G/8Ahxeh5FYwNfe8wo3fWJL3UfEVe+VHUyALPLHMLZ+YUe44AdnuCHr5/B8XuN2PPecGVdCKjKgMyUa6Ke5NJ2q8rSRA4UBBFAmXkW7cllPWP6tmKlezlN/R2Ko9wcTt8kw1tY4ErP+j+jgBcnu1FC7VS+D0312OrJgbOyq+0zZtBqU9bWnflx0/08mODUuidRl7iYjrMT1fqGbhVDydxmxknCUGFdwD73P9eWdRhm7otOjKKpb/m8dQADszEBJcxwS511h1AlpNTtVDseGN+mJyq3GSTUuQ5MZavILIhJQfeYf89BqAGbLZ7e1dL2vK93liCiFvOFR2aSXt/PmNbZ6xuL0a9G/TXqmUQCOqf/Ovi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(136003)(346002)(39860400002)(396003)(46966006)(36840700001)(83380400001)(81166007)(55016002)(52536014)(336012)(82740400003)(47076005)(82310400003)(8936002)(26005)(8676002)(70206006)(45080400002)(356005)(9686003)(966005)(54906003)(4326008)(53546011)(110136005)(478600001)(2906002)(86362001)(5660300002)(7696005)(36860700001)(70586007)(33656002)(316002)(6506007)(186003)(213903007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 06:25:47.5858 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d38e97fd-0043-4906-604c-08d91e7cc4dc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3639 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Good catch! Reviewed-by: Sunny Wang By the way, just FYI, I still run into the same problem (line-ending proble= m) with Windows Outlook and EDK2 email archive https://edk2.groups.io/g/dev= el/topic/patch/83043513?p=3D,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,8= 3043513. Moreover, Gmail works well, so I used it to review this patch. Best Regards, Sunny Wang -----Original Message----- From: Marcin Wojtas Sent: Monday, May 24, 2021 11:55 AM To: devel@edk2.groups.io Cc: michael.d.kinney@intel.com; leif@nuviainc.com; ardb+tianocore@kernel.or= g; Samer El-Haj-Mahmoud ; Sunny Wang ; gjb@semihalf.com; upstream@semihalf.com; Marcin Wojtas Subject: [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime GetWakeupTime should return full time information, including the daylight/t= imezone. Make use of the existing non-volatile variables for that purpose. = Moreover add an error checking of possibly invalid parameters. This partially fixes FWTS and SCT Set/GetWakeupTime tests on Marvell platfo= rms. Signed-off-by: Marcin Wojtas --- EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c b/Embedded= Pkg/RealTimeClockRuntimeDxe/RealTimeClock.c index e59036badc..85650a6ede 100644 --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c @@ -143,6 +143,17 @@ GetWakeupTime ( OUT EFI_TIME *Time ) {+ if (Time =3D=3D NULL || Enabled =3D=3D NUL= L || Pending =3D=3D NULL) {+ return EFI_INVALID_PARAMETER;+ }++ //+ /= / Set these first so the RealTimeClockLib implementation+ // can override = them based on its own settings.+ //+ Time->TimeZone =3D mTimeSettings.Tim= eZone;+ Time->Daylight =3D mTimeSettings.Daylight;+ return LibGetWakeupT= ime (Enabled, Pending, Time); } -- 2.29.0 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.