Re: [edk2-platforms PATCH 0/8] Marvell Pp2Dxe fixes

["Sunny Wang" <Sunny.Wang@arm.com>]

Sorry for the delay and thanks for fixing the issues, Marcin.

The patch series look good to me.  Also, we have tested the patches on a CN9130 based system, and it works fine. The patches fix the SCT failures below, and UEFI network function works fine.
    - PlatformSpecificElements: [FAILED]
    - Shutdown_Func: [FAILED]
    - Start_Conf: [FAILED]
    - Start_Func: [FAILE]
    - Stop_Conf: [FAILED]

Reviewed-by: Sunny Wang <sunny.wang@arm.com>

Best Regards,
Sunny
-----Original Message-----
From: Marcin Wojtas <mw@semihalf.com>
Sent: 06 April 2022 21:02
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Grzegorz Jaszczyk <jaz@semihalf.com>; Grzegorz Bernacki <gjb@semihalf.com>; upstream@semihalf.com; Sunny Wang <Sunny.Wang@arm.com>
Subject: Re: [edk2-platforms PATCH 0/8] Marvell Pp2Dxe fixes

Hi,


pon., 14 mar 2022 o 16:38 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> Hi,
>
> ES ACS v1.0 test suite (https://github.com/ARM-software/arm-systemready)
> unveiled a number of issues in Pp2Dxe SNP callbacks.
> This patchset fixes all of them and allow for
> successful SCT tests run.
>
> For convenience, the patches are exposed on a public branch:
> https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/pp2dxe-upstream-r20220314
>
> Any comments or remarks would be welcome.
>
> Best regards,
> Marcin
>
> Marcin Wojtas (8):
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpShutdown
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceiveFilters
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpStart & Pp2SnpStop
>   Marvell/Drivers: Pp2Dxe: Implement Pp2SnpIpToMac
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpGetStatus
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpTransmit
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReset
>   Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceive
>
>  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 333 ++++++++++++++++++--
>  1 file changed, 299 insertions(+), 34 deletions(-)
>

Do you have any feedback about the patchset?

Best regards,
Marcin
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.