From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.88]) by mx.groups.io with SMTP id smtpd.web09.8707.1625823164244947259 for ; Fri, 09 Jul 2021 02:32:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=AEH2abr/; spf=pass (domain: arm.com, ip: 40.107.20.88, mailfrom: sunny.wang@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/kn2lSYGlf8y2ILuLFyNir4ToOLuE2tECSeUGfMC0R8=; b=AEH2abr/f9HRuM+aa6O7Rq8wMJCHCaVcPIX4bdJ/kPHLh8Q8+w2vOljevjcvKbvBOsrErSMHnHgUNlyd+JSATx3gU8LbnSh2i5y7UhJka1Mai1e4+rowRE4si5RxBkUEsiGqmAh7jku2ctvK1sY3e3v55me8e9tKW7qhTsOgZHc= Received: from AS8PR04CA0008.eurprd04.prod.outlook.com (2603:10a6:20b:310::13) by AM0PR08MB4963.eurprd08.prod.outlook.com (2603:10a6:208:159::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20; Fri, 9 Jul 2021 09:32:18 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::3e) by AS8PR04CA0008.outlook.office365.com (2603:10a6:20b:310::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Fri, 9 Jul 2021 09:32:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Fri, 9 Jul 2021 09:32:18 +0000 Received: ("Tessian outbound ecba17995f61:v98"); Fri, 09 Jul 2021 09:32:17 +0000 X-CR-MTA-TID: 64aa7808 Received: from 206c20e8159c.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 12AE0AE9-E746-46A7-A774-95F9210D99B8.1; Fri, 09 Jul 2021 09:32:10 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 206c20e8159c.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 09 Jul 2021 09:32:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kpHZo3u70uRF7lSohkazAtsAttFq1Ztt074wufFAra2fufjckE1N1Q4rHWnU5cdESGA0mDibOZai/WV4jp6xfaQkRiHXNq9FXzKr2ItjmL2s7OO8DZIcbsATBhxx/uxPc5dEuVNWQ0yyte1aqJP+qWX/fN+PNjt1PyVrY6+FAWdwnE+U+Zls0yNvVg4szr6VophBD273/ixtiKRbnFM0F16NtB7llf/UNpQy0dDQ45nXbntXgEj51Qtq8QJeU49V6INuj7yaT9tE47Y8WfYIWjpAkBlcanvbmInviDpm7qupf7WNXWyRkgEwPi17vu6O+XhnXWRYO9ePjH+W2/aDxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/kn2lSYGlf8y2ILuLFyNir4ToOLuE2tECSeUGfMC0R8=; b=XDyKrkyTuErszTGjA1SpuuQdHs4kYnGror/wJXEXUFmyfQ77vcoYjsrwXNbuAGem7q0DMIOclR8hiXzDrB9ybspkgomfRD+VJsPWWwqX8TsAyCJWdxE2j6LvkiyKrTsKzvStqCXgZhwYK1Av/GiwJ3lA46La+GVQ9to8N+C84H5fl+nWF1X/nTeFPbY93k2B+Q/t4Z6RFRgtHfx7mLvddhHTkurrBOulOXF+rEXR7y8Y+23GjwX+h5WccTh1gl25M9usEuz8/Djq0Apbixi9nf1ZaelHkFcYFkOZrskLTX0mJBz1CLOKQBpAq1ESBy4qQ21hkC4hUK27zWroWtVbAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/kn2lSYGlf8y2ILuLFyNir4ToOLuE2tECSeUGfMC0R8=; b=AEH2abr/f9HRuM+aa6O7Rq8wMJCHCaVcPIX4bdJ/kPHLh8Q8+w2vOljevjcvKbvBOsrErSMHnHgUNlyd+JSATx3gU8LbnSh2i5y7UhJka1Mai1e4+rowRE4si5RxBkUEsiGqmAh7jku2ctvK1sY3e3v55me8e9tKW7qhTsOgZHc= Received: from DB8PR08MB3993.eurprd08.prod.outlook.com (2603:10a6:10:ad::26) by DBBPR08MB5882.eurprd08.prod.outlook.com (2603:10a6:10:200::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20; Fri, 9 Jul 2021 09:32:05 +0000 Received: from DB8PR08MB3993.eurprd08.prod.outlook.com ([fe80::14b0:85d6:deeb:9ee0]) by DB8PR08MB3993.eurprd08.prod.outlook.com ([fe80::14b0:85d6:deeb:9ee0%7]) with mapi id 15.20.4308.023; Fri, 9 Jul 2021 09:32:05 +0000 From: "Sunny Wang" To: Grzegorz Bernacki , "devel@edk2.groups.io" CC: "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Samer El-Haj-Mahmoud , "mw@semihalf.com" , "upstream@semihalf.com" , "jiewen.yao@intel.com" , "jian.j.wang@intel.com" , "min.m.xu@intel.com" , "lersek@redhat.com" , Sami Mujawar , "afish@apple.com" , "ray.ni@intel.com" , "jordan.l.justen@intel.com" , "rebecca@bsdio.com" , "grehan@freebsd.org" , Thomas Abraham , "chasel.chiu@intel.com" , "nathaniel.l.desimone@intel.com" , "gaoliming@byosoft.com.cn" , "eric.dong@intel.com" , "michael.d.kinney@intel.com" , "zailiang.sun@intel.com" , "yi.qian@intel.com" , "graeme@nuviainc.com" , "rad@semihalf.com" , "pete@akeo.ie" , Sunny Wang Subject: Re: [PATCH v5 02/10] ArmVirtPkg: add SecureBootVariableLib class resolution Thread-Topic: [PATCH v5 02/10] ArmVirtPkg: add SecureBootVariableLib class resolution Thread-Index: AQHXblotfd71g8FpEUGY97OubwYiYas6bXwQ Date: Fri, 9 Jul 2021 09:32:05 +0000 Message-ID: References: <20210701091758.1057485-1-gjb@semihalf.com> <20210701091758.1057485-3-gjb@semihalf.com> In-Reply-To: <20210701091758.1057485-3-gjb@semihalf.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BF2C033D61D74C44B58064B7B3412E07.0 x-checkrecipientchecked: true Authentication-Results-Original: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 5a012899-8c33-464c-e20f-08d942bc7219 x-ms-traffictypediagnostic: DBBPR08MB5882:|AM0PR08MB4963: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5236;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JjEl+huKmm1Tz5SM4g4p7W8t7o2XBcwIZSDFNJq1PctYHzjoNgurv7ib3M9X1XoY7+aRbVmwp0QrbCwjYkXYXVVs4h8IdJP0yk07V6gMLHoyFX082B0F2rZQcyvgl0CER7lFthGlY3btVGJOf3AOhp77LkxcwheDyH5Ar0Usw3MQyDa6U4R4K8Rx5tBnoEVVTXRzbsdITQEq8Z/TjtQ0th7cZZ6gk2TiKezleDLqNhRUbUGsyXuOOb8YzBUv1wt6963RqIJlNXJPRLtnwm7TcabWF48QY6CxoK0NX+iONOoBKnbNDW0/G6zTXgbqsfD9N0Iy7ecauhl2Ty5dNUWoBd3g9JSU17os5Zn5ZUSYAJlJWQb/17Cddv2B/qouu3U39lqhd+B0sugfis2Saivyp4+R4bf//ZLm0bn2lBDZoHB54dUF/7XieaX5jWpkCrT/uM4Aor2Z23Geuzp5MsU5RjlWOqP4XI176bgVsH2ugoKE6P4IU52i163rt5q991mg2LjTZBvjsNyWBNivVMX/E6H7KfzquQKF/6UpJEqoNpQhe4wowxLBoDdXs5tpgMu50LdMr94MnxuUaugFm7Wz+gwOireDNfWI492t6pE4TB4+nr0fkx1rOWLErRrfFRBYUXf4v4dJoiwHNXo/KjDCfg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB3993.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39850400004)(346002)(366004)(396003)(376002)(7416002)(7696005)(52536014)(122000001)(8936002)(54906003)(86362001)(110136005)(71200400001)(478600001)(38100700002)(2906002)(5660300002)(83380400001)(4326008)(6506007)(53546011)(55016002)(33656002)(66476007)(316002)(66446008)(76116006)(64756008)(66556008)(66946007)(186003)(8676002)(9686003)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gAfqMRSU3p4Guw2KICEyprnC0Go05MqRKR0OgLqGJLmrsAtanbGJh1JmwdSc?= =?us-ascii?Q?4eOMaEn9Q3o5dgdk5R0ZdKwm/D1s65b9PglbHlPq+vkK+0Ihrec6TCBCRncW?= =?us-ascii?Q?cXit90AaO5XRJru2HDkH4KmFYelCl9QvfLcRprgQo2cu7Es+0HBn+vdE43f2?= =?us-ascii?Q?OhMU8LF15CNjBX1brkIM3o/uDUvNDVzbDGYiy5SHfStb1tFzQiKflL4na8Pu?= =?us-ascii?Q?6zzubq5SU288b2o9GzL9pOWmKy8Uv+pBRLAniSoQA1epWii0KProIkbthhoi?= =?us-ascii?Q?+a9aCoJD+KbEVDeZ6VTKOKJ+7CrI7OhcTQkEfLdVmWNqCM5MqN7jarlSx5mD?= =?us-ascii?Q?VdA4rW6gDjIhiz8U4VY1a1wOrSF7qDcEZjnYIinCxIxAcpkjOqVOcljXUR5x?= =?us-ascii?Q?n1bi7f1yekpdOdfMq8SkO2JeBqWSeqsXTrx1IVxQHeMlhdwb84fh8NeCCYJ6?= =?us-ascii?Q?23o1jFo5PLjSDxR6k5snJ7+6fI8xY9ODrguUf4lAm3/ffxkTPA1eTC5WbV9Z?= =?us-ascii?Q?ABPEnq6RpyixlmSNsUcVhznhQMtoBL6OeErk8C2xkbFDb32G5LctLq6qOIdI?= =?us-ascii?Q?g1HG+mlesIjXOxIEAz+QOMAXQVlLEapxCuXSn+ZgvL/849wlxRpClXjkOo04?= =?us-ascii?Q?sw11AL5mAHjBOfdjuMFR6rstAyRL3zPfKH62xpC0VenIqPDfbY8aVp2lavMk?= =?us-ascii?Q?WMN0Z1mKMZdUNG71/pEty/D+J0OvZriZvOZDRDgWA4en0MfvwM3s1kkvy1aT?= =?us-ascii?Q?9YC3N3mNv54OsFdULuJSvzMUbfZmzOUp+brlGHYisHazO8Rm8ZAwllFLnM5b?= =?us-ascii?Q?EEWxD+XHZitOPRjlxCRb75S3U6LXIXrtVIKbZHV3NhlGpgnzdozZTAiRQAE2?= =?us-ascii?Q?iwj2aDsw71sDXWFVAyYNOMb5kMT6bzqpiPn74KsBbr/+5NvKTfzKx7GtHJiO?= =?us-ascii?Q?+u8MvXK+O+JMvuumDfchaVfIOYhyso0qTj+m0e7uzjO4rU8E+vP0Ws+GGG5W?= =?us-ascii?Q?PaP4wmWm5qtbQpK4iaxzeal+8KDzDJOGlkZulakX8L5dYKkgilQxU/DeVQE1?= =?us-ascii?Q?PfLN7ZRVgjktpspF81yq7imWMjrhseuVktZe7EC8TeTJcnzxZV0ZBQTRUW/L?= =?us-ascii?Q?ymJYrTz6sfnRuRqUnoCQaa2WYPlWbXBUuJx9hrqsGleG6nmJURFNmYfLgR6O?= =?us-ascii?Q?hjmSBDvexO9ekjjDDoWymJ7KooRAX5IxisttgbfwH+Giwcmc7+5ozjPSwJ6L?= =?us-ascii?Q?D2QrFzAeJI9qvy09njTMFc6hbZDNLP66v+zQVIrWQ5SVdDq2RrEW+Wry9QI2?= =?us-ascii?Q?ineSUpFRhPZrNKQBdKH640MN?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5882 Original-Authentication-Results: semihalf.com; dkim=none (message not signed) header.d=none;semihalf.com; dmarc=none action=none header.from=arm.com; Return-Path: Sunny.Wang@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: fe2f72a4-d2a1-4d19-8a95-08d942bc6a77 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yv71iwfsZEpZdRH8hVF13s+C0pJnOBBfS3++5d17lQz6hwQ2DL71oRVnuKNcOAQYPDFqA0QXTBg8jo9/vkuOUoLy3hLPtV3EBI+59Mpk9F9fGn8zbdpqEDo5voLeGl+Z3XVzC+Zezqla7qTtKVeKMWO2VWAWykfFWjIPwEG7EHQupilEYYp4U0ErtzoezT3N/dKXWILkoh+p33FXha9ylxxmvAn7l2MkXQ2kZm1X2tDomAXzx0YJGFT59Uup/WbjwYkHi13ARd5HjPEfK7ATXUvvVQvObCmeN7BtdKulwJGLPUcLxjuY52v/N6VE52RJDCWW3vnknpYSp+iNcKjNJFU2cEEXg4CqVYt+Il2sc3ysUz7jt3gZRbRKEewZT4shvGi7ZdgU0QjjwPiSFx3DkJxTZEbPtIh7k0gmANZtcZs5K6weSdv1iHu5ZN53ZqqX7Mb8uqX3kCtDKHcL8IJTGJCTq3uYuCm+vJL4H2uOsJpmnpFGwF8vkC8PmOj+i7G9trfsZXc9t/KGmqi319iz9omhdBDh64oDjJX/JeFPekwudAO3T+JMDqu3soQZUtKgwjUDR8GebLXzZ6+t7z45g6/DU3oqEWsxx5jIP4/11Gv/1+igQ9PSz1Tqdu7rZ4ep4e7lUlRcDk9DKwfvjDJyRhghf4t2UU/j1JjExsuE2pWK4V36Sq0CBjuSs2I6e+YXFpyeN53k3k0ZExlQD5Y7Ww== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39850400004)(376002)(396003)(136003)(36840700001)(46966006)(4326008)(316002)(82740400003)(52536014)(6506007)(53546011)(110136005)(8676002)(83380400001)(336012)(9686003)(33656002)(86362001)(186003)(70586007)(70206006)(26005)(55016002)(54906003)(5660300002)(8936002)(2906002)(36860700001)(7696005)(81166007)(82310400003)(47076005)(356005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2021 09:32:18.3660 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a012899-8c33-464c-e20f-08d942bc7219 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4963 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-by: Sunny Wang -----Original Message----- From: Grzegorz Bernacki Sent: Thursday, July 1, 2021 5:18 PM To: devel@edk2.groups.io Cc: leif@nuviainc.com; ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; mw@semihalf.co= m; upstream@semihalf.com; jiewen.yao@intel.com; jian.j.wang@intel.com; min.= m.xu@intel.com; lersek@redhat.com; Sami Mujawar ; afi= sh@apple.com; ray.ni@intel.com; jordan.l.justen@intel.com; rebecca@bsdio.co= m; grehan@freebsd.org; Thomas Abraham ; chasel.chiu= @intel.com; nathaniel.l.desimone@intel.com; gaoliming@byosoft.com.cn; eric.= dong@intel.com; michael.d.kinney@intel.com; zailiang.sun@intel.com; yi.qian= @intel.com; graeme@nuviainc.com; rad@semihalf.com; pete@akeo.ie; Grzegorz B= ernacki Subject: [PATCH v5 02/10] ArmVirtPkg: add SecureBootVariableLib class resol= ution The edk2 patch SecurityPkg: Create library for setting Secure Boot variables. moves generic functions from SecureBootConfigDxe and places them into SecureBootVariableLib. This patch adds SecureBootVariableLib mapping for ArmVirtPkg platform. Signed-off-by: Grzegorz Bernacki --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index d9abadbe70..11c1f53537 100644 --- a/ArmVirtPkg/ArmVirt.dsc.inc +++ b/ArmVirtPkg/ArmVirt.dsc.inc @@ -168,6 +168,7 @@ # !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf + SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBo= otVariableLib.inf # re-use the UserPhysicalPresent() dummy implementation from the ovmf tr= ee PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.in= f -- 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.