From: "Joey Gouly" <joey.gouly@arm.com>
To: Leif Lindholm <leif@nuviainc.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
Thomas Abraham <thomas.abraham@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH v1 1/1] ShellPkg: Validate that the Boot CPU is present in MADT
Date: Tue, 8 Dec 2020 15:43:43 +0000 [thread overview]
Message-ID: <DB8PR08MB543341AF50C40AA3E5AC3F4E94CD0@DB8PR08MB5433.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20201202123301.GG1664@vanye>
> > +/**
> > + This function validates that the GICC structure contains an entry for
> > + the Boot CPU.
> > +
> > + @param [in] Ptr Pointer to the start of the field data.
> > + @param [in] Context Pointer to context specific information e.g. this
> > + could be a pointer to the ACPI table header.
> > +**/
> > +STATIC
> > +VOID
> > +EFIAPI
> > +ValidateBootMpidr (
> > + IN UINT8* Ptr,
> > + IN VOID* Context
> > + )
> > +{
> > +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64)
>
> Surely all of the struct that should be called mGicCParser is only for
> ARM/AARCH64 and could be moved into a source file just included for
> those, and this function with it?
>
> With the only filtering on architectures done in ParseAcpiMadt?
I think that could be done if/when another architecture wants to add some
specific support to this file. Otherwise, in my opinion it just adds more
files / layers without any real benefit.
Thanks for the other comments, I have fixed them, and will wait for your reply
to the above comment.
Joey
prev parent reply other threads:[~2020-12-08 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 16:05 [PATCH v1 1/1] ShellPkg: Validate that the Boot CPU is present in MADT Joey Gouly
2020-12-02 12:33 ` Leif Lindholm
2020-12-08 15:43 ` Joey Gouly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR08MB543341AF50C40AA3E5AC3F4E94CD0@DB8PR08MB5433.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox