From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.61]) by mx.groups.io with SMTP id smtpd.web12.10386.1607442264289651428 for ; Tue, 08 Dec 2020 07:44:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Z+tBxHbP; spf=pass (domain: arm.com, ip: 40.107.6.61, mailfrom: joey.gouly@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Ffy4fuFL7D6wbIUe5KAb3Jj+GWDDmNXiQLIpes5OYo=; b=Z+tBxHbPFHc764t5f8OilY0cVnLq6wRLwhArm7EWXSTljzHJs+SW6dLyro1CujZItzVLc4Y6qxbJ83+0u0dIVt2Q6su+yprZsHTpkMoUZlmE12U4AGD3oAKsoV+RkJZPHkR7wq4E51AARB90IvM0d5aw0YpuwIhLqcvBToZe3Nc= Received: from DB6PR0801CA0063.eurprd08.prod.outlook.com (2603:10a6:4:2b::31) by AM6PR08MB4613.eurprd08.prod.outlook.com (2603:10a6:20b:80::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Tue, 8 Dec 2020 15:44:22 +0000 Received: from DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::c7) by DB6PR0801CA0063.outlook.office365.com (2603:10a6:4:2b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12 via Frontend Transport; Tue, 8 Dec 2020 15:44:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT035.mail.protection.outlook.com (10.152.20.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Tue, 8 Dec 2020 15:44:21 +0000 Received: ("Tessian outbound 6ec21dac9dd3:v71"); Tue, 08 Dec 2020 15:44:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fbffd902b7b0602b X-CR-MTA-TID: 64aa7808 Received: from 91b892d63aff.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2C460203-8644-457B-B8EA-F799D5DFAB0B.1; Tue, 08 Dec 2020 15:43:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 91b892d63aff.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Dec 2020 15:43:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ns33xy3z/34FLcTNVlKw0M9wPnepn/rVoHYgxiD0HznrgOmM51qlUzJDM7Osn6MOjYzpBBOZyuSfwnbflRIOIp/8+PBXDod/UHxGfdGA/udCXfYJ0IeLc0I8c3HiaRl9MH13rplwaZwjteG1rUHNYTCiECFRa5sobBfyBarezdWredaJR5DaCmKzEyFXKXAIaM9TQOLCAdJPJtjNrW8mSM0skzWDLdL144hSb6ajgAWaFsltCBnMTGddoBuOz3RMts5OUegJOltpLMSqwvyRZrhoPkHTNPcGbfYI79mUAS8BjS6ZmvNw012B34RzUL1xpJGpRxq9JbGNOWK34Oqvxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Ffy4fuFL7D6wbIUe5KAb3Jj+GWDDmNXiQLIpes5OYo=; b=Wa1l94AK87ZXBbNIM2ttbk6NUcgejnXdraTvzpk5YS/nL23diy2necgiVh22vFUWqVsw1okeBzJilaVeq/41Mhl9STM0gwfw0FeAyHwR3CNqSWvlwaDvjzQY9rmyk7s2OF6vK/ZydoxSWbFzDuEv6Z2JiiuK22WABp52gS0JRMA5Y5PdQH5bGVOp9OcP9NK5fsJ4CTJhyXAXvjpgREHmlLLxWKamlvvJUSAakkN0Pnhdum1ti9B+inAu6Rpp60qehgadU9nGhzJmclsgPLkczfaQY9jpoQSfmrkXxY4p8VlwqBdG9kcVE4Hhj1swOntEaNqydh8hGSkFdZox4k9j/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Ffy4fuFL7D6wbIUe5KAb3Jj+GWDDmNXiQLIpes5OYo=; b=Z+tBxHbPFHc764t5f8OilY0cVnLq6wRLwhArm7EWXSTljzHJs+SW6dLyro1CujZItzVLc4Y6qxbJ83+0u0dIVt2Q6su+yprZsHTpkMoUZlmE12U4AGD3oAKsoV+RkJZPHkR7wq4E51AARB90IvM0d5aw0YpuwIhLqcvBToZe3Nc= Received: from DB8PR08MB5433.eurprd08.prod.outlook.com (2603:10a6:10:118::13) by DB8PR08MB5449.eurprd08.prod.outlook.com (2603:10a6:10:119::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.18; Tue, 8 Dec 2020 15:43:43 +0000 Received: from DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::51ff:a8cc:1426:4dfd]) by DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::51ff:a8cc:1426:4dfd%4]) with mapi id 15.20.3632.023; Tue, 8 Dec 2020 15:43:43 +0000 From: "Joey Gouly" To: Leif Lindholm CC: "devel@edk2.groups.io" , Ard Biesheuvel , Thomas Abraham , nd Subject: Re: [PATCH v1 1/1] ShellPkg: Validate that the Boot CPU is present in MADT Thread-Topic: [PATCH v1 1/1] ShellPkg: Validate that the Boot CPU is present in MADT Thread-Index: AQHWx/vn17jt7olP/0mIVLpaWWt2ManjvpOAgAmi79Y= Date: Tue, 8 Dec 2020 15:43:43 +0000 Message-ID: References: <20201201160536.16903-1-joey.gouly@arm.com>,<20201202123301.GG1664@vanye> In-Reply-To: <20201202123301.GG1664@vanye> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4f644388-ec26-4c6b-2043-08d89b9021f0 x-ms-traffictypediagnostic: DB8PR08MB5449:|AM6PR08MB4613: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3kooUxLeJXy8yLPSZgG1GNDuif0u60DKbJiIyT5V5Tx9CIAY5KiHIDfIHm/l6IM1HgAX0iGcNPAkWNtACSuXopAQw4RaX584k7V8zIRNvNP37FPqfQNZVEHPpo/75Drey0Kxbuy7/weLlTKm3KApC8fJdla3GOs63GIRl3M/PtQBJmJUSquENI4iJrFBgaX3VJVwvz1FWgXpy6kBqrt5uW1K9l6IdwN8jgZrRMG1w7vA2IExd7wxt+VZxjkRTqQ7Y1nB4NE8e43bIa6vd87wmMPdjD4CPq7ASzCkSvT1f7+0vlyH81a2AYiD2lPeAH7H1zLO8jMY4+BSfIhM2PFy0Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB5433.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(376002)(186003)(91956017)(5660300002)(64756008)(6916009)(86362001)(7696005)(6506007)(83380400001)(66556008)(66446008)(8676002)(54906003)(71200400001)(66476007)(8936002)(66946007)(4326008)(508600001)(26005)(15650500001)(33656002)(76116006)(9686003)(55016002)(52536014)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?/NN4PRiQJXm7J6u8Cp8q02djM2N0ZyQBidluP4hYSNc2P0wbGOQx0yTiz4?= =?iso-8859-1?Q?nm6t7P3I5RBsUHyxZlceAJLs1iYelejy9MONH3593M8ubALHEcS/pPATqd?= =?iso-8859-1?Q?Q2tQUaEN9eUcDnRx7hgtmnhyJi471V8ab7ycH6DpGNJ6sHfIlJfaPjI5YE?= =?iso-8859-1?Q?3nL08hFDABBBOVrNDQO7fEfsktYVjY5aHy6lu8nPnT4kOUKZITzAT+HLJ7?= =?iso-8859-1?Q?xWw//Jy9go0uugxFv09ZeC3XOk5NIGbtdOJszUamusT3zoNwc81iuacIND?= =?iso-8859-1?Q?FY/GV0TuCvkzYR9KYmZ7Acs+xtSY8IaP9YeWNzNUw4yLIK8EKwkWNj+cdz?= =?iso-8859-1?Q?ioU+bL5kDw2lrgS6YLwc1EQB++/ezZoHno73oPDrqFalZ6lkI+Usk1n/ml?= =?iso-8859-1?Q?gPM0twYcFmS9OqIPnsYWo49plo6xBHgo8bxFlAkXSoGk2VD9lnwtX9XYpG?= =?iso-8859-1?Q?Z+KyEV8cuWJ1hk8pNGkhgkZ2jzXX1hL5p/APTSPo4DRPaCZEx7fexJRNJG?= =?iso-8859-1?Q?9S0c9VpaxkgwUSfjp89XDMxGGhob9B/TNsrzmlN36XxBK/If1pRoxgpihN?= =?iso-8859-1?Q?rjBX0ajQCz9snq5Xr0MAcBkABTDoYwp/syZR7An9G6jcRRSzRiiRxRN5FJ?= =?iso-8859-1?Q?8OMP4VB+3YC7hZHoGNQHDqkfRJMmJPUh65Fop0TwWNFf1FUQuuEFg4h1Qj?= =?iso-8859-1?Q?fASE8oriD6oogswfzvz0//D2bZxxr+6KTLzY2Pl51Hn8BtLAuE3/tE0w6x?= =?iso-8859-1?Q?50/fA2Gi6qEZRYQXTZHotiS5kl+UirLbl60z68ckMIvhlYpzJqDTL1oIcT?= =?iso-8859-1?Q?S1IoVc+yxquZV3B6Q4Ryj7rjajkNGPj7INjYGUjYFvbQDleBqgFqhSq7Y9?= =?iso-8859-1?Q?M6NcH+PaFckO8H0d4HnTkpg0Z/f8iGVMSD+qSeAGGEGwwGTJFwg6SEd9Gv?= =?iso-8859-1?Q?eqgVgjwbvxyYZlCyrg2Zx5GS39XvZ9l+wobBXLSfX2mexpNC8P9JL5L6e7?= =?iso-8859-1?Q?2+mbdNFf/AXDeeoAA=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5449 Original-Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=arm.com; Return-Path: Joey.Gouly@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 83b66d46-84fc-45ef-b1b5-08d89b900afa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PeHHJ9JdOw0Y1Q4ZxEDbhDCy24QiBIganP1pxhJjC7KTCSqeZmr8na6OgbpUN05ohpDGeW8iXiZxUz4mJMxSEiqrSxjYoMm+hOWZOepoHqSkgT9zRkTrDgsZ80inOChJYCQhQwjZaxEgOPaAWZAoaDx+2K/jc3XabJPW7WMzSUU/D+k5yXV6ZEzs/wJXMy1UNDVmbELVF9ChOWloocCg2HepVl1SDZCnxowBNsGqrzLDBnUbtp+Jh1MzMhJEeoOEMW78SckwwmvG7i02fEL/nAr/8pHleo1Y1/cbueFm3mEwe8qOZfHvNb6q+4vgJM5sQmDWTQx0joguiOjnh5ouPIGVaHAjgBaIFps85I5+YEbjYG5ySiixJjuzWO5YEPIVQzYkk17FGSGZZDhNyEKiXA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(136003)(346002)(46966005)(356005)(70206006)(8936002)(6862004)(5660300002)(70586007)(81166007)(86362001)(33656002)(15650500001)(83380400001)(7696005)(47076004)(8676002)(9686003)(52536014)(6506007)(55016002)(2906002)(508600001)(4326008)(54906003)(82310400003)(186003)(26005)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2020 15:44:21.9841 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f644388-ec26-4c6b-2043-08d89b9021f0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4613 Content-Language: en-GB Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > > +/**=0A= > > + This function validates that the GICC structure contains an entry fo= r=0A= > > + the Boot CPU.=0A= > > +=0A= > > + @param [in] Ptr Pointer to the start of the field data.=0A= > > + @param [in] Context Pointer to context specific information e.g. thi= s=0A= > > + could be a pointer to the ACPI table header.=0A= > > +**/=0A= > > +STATIC=0A= > > +VOID=0A= > > +EFIAPI=0A= > > +ValidateBootMpidr (=0A= > > + IN UINT8* Ptr,=0A= > > + IN VOID* Context=0A= > > + )=0A= > > +{=0A= > > +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64)=0A= >=0A= > Surely all of the struct that should be called mGicCParser is only for=0A= > ARM/AARCH64 and could be moved into a source file just included for=0A= > those, and this function with it?=0A= >=0A= > With the only filtering on architectures done in ParseAcpiMadt?=0A= =0A= I think that could be done if/when another architecture wants to add some= =0A= specific support to this file. Otherwise, in my opinion it just adds more= =0A= files / layers without any real benefit.=0A= =0A= Thanks for the other comments, I have fixed them, and will wait for your re= ply=0A= to the above comment.=0A= =0A= Joey=