From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.59]) by mx.groups.io with SMTP id smtpd.web12.11022.1615304900653942904 for ; Tue, 09 Mar 2021 07:48:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=z+dDAnie; spf=pass (domain: arm.com, ip: 40.107.7.59, mailfrom: joey.gouly@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VznzQpcA1sDL8qhqIYY2VIttH/GJgG9MQKt6wTf68j4=; b=z+dDAnieNRyiHAXuyjz4F977CYT8lo3EG4p7QFagKTOOCcV7U7hdJP78CJqZUQDrYtMj1NmQHcR7wkN1N4VQ9VpDmpo2oJkBSHas2kHWl/rbWkEhd+MUmJWw0CS3LQLn0sHTmUTKc8UuCVITA/RpP/mD5sK5lMaGqnV0Gt2G+00= Received: from AM5P194CA0003.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::13) by AM7PR08MB5462.eurprd08.prod.outlook.com (2603:10a6:20b:10b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Tue, 9 Mar 2021 15:47:51 +0000 Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::30) by AM5P194CA0003.outlook.office365.com (2603:10a6:203:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Tue, 9 Mar 2021 15:47:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Tue, 9 Mar 2021 15:47:50 +0000 Received: ("Tessian outbound 67e186bef91c:v71"); Tue, 09 Mar 2021 15:47:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3948b12a08e4e3b2 X-CR-MTA-TID: 64aa7808 Received: from ec068351f9ee.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6F94DC5C-48B5-494D-B9F8-AFED55B886DF.1; Tue, 09 Mar 2021 15:47:42 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec068351f9ee.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Mar 2021 15:47:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJuLD8HZlmLSonoJqMwaWl0g93yg0hZvqcEGGD8BcvhbcI9eVKsBpOblw/cQzMeE3YKIIT1Ls1GmqXomWmHChaDY4HVw9cxwksdmxmOHmJLGQItpyHzOXhEjR9PT92/AulkoTSjwBWHl8nhG0fZN+WLh4fKPicuqcqGlz1sp1GhCO7j5OKDj7dNUq+W+BvtAyl1GYCdrLxlpISEydzxcnu0C2W0BpNPlI3CVKDqIKpCk9gZIbqvdcc0N+72j+gFwIqH2yjN8oUvpzAudNrmkij5EsC5G2V344xjKLkPnEFFB1Xt0GSSGZZAK5rTI73Qjg1/JZC7VRonkfBEzFXDqBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VznzQpcA1sDL8qhqIYY2VIttH/GJgG9MQKt6wTf68j4=; b=EzwTlnBNQcOQRPuP/vxeh2+lflTJ4K1GQrHpOi5FujTK590x512905q3wLXw7TsSsqzFndgQH863Ulx/GbIMJtgL+c61eHk5gZPsmOm00en++2S7+V5gzC9fseS8ZpT4YOH8RneDG2exb4ts97j5ssSIo5xYxz6TaxnCfBP+/40hhV6cr4snGkeYjF41tZV0kpCH+E9+GMx8hbfMXUreD5K/rmeFdytZvTpmi1Iuzbo18CAxUNc3YYXU52kEBW+Hg+/W7/Vi01mvlBmH/mN7aCXJd3LbsNDDYQ9rfBIrKXWetokHBezpP3fnT1WBY/MBR6dnoH8P5Y+ILZeba+RifA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VznzQpcA1sDL8qhqIYY2VIttH/GJgG9MQKt6wTf68j4=; b=z+dDAnieNRyiHAXuyjz4F977CYT8lo3EG4p7QFagKTOOCcV7U7hdJP78CJqZUQDrYtMj1NmQHcR7wkN1N4VQ9VpDmpo2oJkBSHas2kHWl/rbWkEhd+MUmJWw0CS3LQLn0sHTmUTKc8UuCVITA/RpP/mD5sK5lMaGqnV0Gt2G+00= Received: from DB8PR08MB5433.eurprd08.prod.outlook.com (2603:10a6:10:118::13) by DBBPR08MB4346.eurprd08.prod.outlook.com (2603:10a6:10:ca::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.23; Tue, 9 Mar 2021 15:47:40 +0000 Received: from DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::1cd8:27a0:a98f:29a3]) by DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::1cd8:27a0:a98f:29a3%8]) with mapi id 15.20.3846.054; Tue, 9 Mar 2021 15:47:40 +0000 From: "Joey Gouly" To: "devel@edk2.groups.io" CC: "ardb+tianocore@kernel.org" , "leif@nuviainc.com" , Sami Mujawar , nd Subject: Re: [PATCH v2 1/1] ShellPkg: Validate that the Boot CPU is present in MADT Thread-Topic: [PATCH v2 1/1] ShellPkg: Validate that the Boot CPU is present in MADT Thread-Index: AQHW60zYhhJn2H76V0idC9vkbSNtsqp8H8R9 Date: Tue, 9 Mar 2021 15:47:40 +0000 Message-ID: References: <20210115144340.6511-1-joey.gouly@arm.com> In-Reply-To: <20210115144340.6511-1-joey.gouly@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 644a689d-c6b4-48f3-6cc5-08d8e312b22f x-ms-traffictypediagnostic: DBBPR08MB4346:|AM7PR08MB5462: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +u2MuThv/HLB8qscG5msEfT3qPr3JdxHkXJBZhwoeyOmMSPUc/J06GWmT9lVoR9vPOi7RRVfitMgmu85rRZo62u3F3Gnp4Hc5ECsheHzwkuAfmEDQv6LkgRL3lXPzWVeIPqX+hWB5cdLvgPQ81bKbqvlQKe2UL19Qlg+OHeURxyCIlG2X2mKtI9Fx3xL/iTVzwwRfyucxGKQJO00KE7OHdGQyLHUPTSEQ2Q2XcnPlp+bug0LwU38tqubA8yHjtfKa2zAtHh8Q88/mETadlEDN+WihKpf3biGYP0dht2kRyK9SSug9XMjHIeFDg7fu3mgBVPtGYjZGgUH3nprN5tweu84snuDJyf9cEo57hrFlWSrxM5UzjSG5IJJijKr9+UeaWrf+L1ggkXUx3Oz6E9qHmEhA+araz4OOIfpuOfBch3MFM9koQ8ScWXNceK7P3jR+0HgLe6Yp4cdynLs4urHwWcbL1OIAvh875v3hNF/RW/S3me4O2dQF/vTYCKMb0DzoIW+gpm9wNFAe/V6+Vr7Ow== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB5433.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(136003)(39860400002)(366004)(15650500001)(76116006)(66556008)(478600001)(91956017)(6916009)(64756008)(52536014)(33656002)(4744005)(2906002)(8936002)(5660300002)(7696005)(6506007)(8676002)(55016002)(66946007)(54906003)(83380400001)(316002)(66446008)(9686003)(86362001)(26005)(186003)(4326008)(71200400001)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?iiS3cJmfGzVTQdsp9yPNI66PbIc1312+B5JxF2pYpxHHpsgpBmIbUC2L?= =?Windows-1252?Q?cf/2diRoAxEJ8jLVZj20Z2f9WngIaivTzcie1cbX8KzCUY0EGDCNrlQm?= =?Windows-1252?Q?g0aIl5Rfn56j2Xz0GS19/A4JnR/KCLOTEb6oqHWXzRbRtAjFmRY8UKwu?= =?Windows-1252?Q?vtmNEa049mGWSSijqKD2/rUnnHGzKEe+Ol3goUfhw4DX5i8qv+kUKunt?= =?Windows-1252?Q?yVnRrUFZR9tz+DCfT4lEZ7j60ITEpAE7Hq25b1OEiKpKcUViCRlv56pd?= =?Windows-1252?Q?JeD0dqwGT9behcA0Gsq5X0BNHV/PMDYNK6zVwa3MBuz+egrBgDqXyE+4?= =?Windows-1252?Q?Nd+eXyCIWhcH8OF+/YbzfgvKBHv2V/Kx3DGe+RpfMKCRgTA4vE3adI8X?= =?Windows-1252?Q?iGa5er9NWUI4MhjLWS6sX/C++3B/uSccw3VuI/2xyiZNEOzj+GT+B4C0?= =?Windows-1252?Q?m3LNRAhLSBua9r17PZEIgaF+UwZkfEFuOPrnzzKnjvapnTfsRFSlEwQb?= =?Windows-1252?Q?w221vE65EE6qF2IQQ6PCX+js6iYNj1rAnw6CAk6Y9BzJwIAY/YtjGaiT?= =?Windows-1252?Q?BzkriR6Pj8mPtf9TWGQANMOUNJwzGax+e6ts0+yqpv00PvwdplYelNnv?= =?Windows-1252?Q?Tnu5gD6PXH7Fwo11dENKQR8fjwzBAqxjwnXpfKRBeR4ku+DxGEteImhf?= =?Windows-1252?Q?Lurm88rpAASJelVW/f1AsQ3ySQpqk0LNNXTmoxSgTCDi5srDrZsZCIFi?= =?Windows-1252?Q?dp2I7avWxhXyy5AAnHCzZaPt68V6PUR5WbR0KUiBUNPrh3qIF63TiA0b?= =?Windows-1252?Q?UzGK92MZzLLi69nzMukE84Fxr1soqQQzaRXbTa3MXR/+60RRSl1MCaz2?= =?Windows-1252?Q?elPEyXO8vfvZ8K7VTT+CpGPUY8O7g7E+T4VNDOJaCZ0zXoxT1FCdsuae?= =?Windows-1252?Q?4JMfgkmc0TCs8+V/BaYhJX0fx6zVvc3xo+SGxfcjiMD9y4x08Npmtf1e?= =?Windows-1252?Q?nClnLMqJSDWhL7jcXC2bkW7FtFZclGSG2iRwsy+aFtW99vcj0O29aSOg?= =?Windows-1252?Q?qcMrkDMUkNer2OWzAGnn1QwLZxwo+qV96ONGo/gs2gcI3ABgh3N81UGe?= =?Windows-1252?Q?9McsxgQOFnWi7V9+rhLJvIhkoWx8AGCZNb3a3+14SCe2CaoeuHLGtsS8?= =?Windows-1252?Q?x02bv+DTQp6bdTJi2M7raWSPfy9Sqho7d4TVDQ77ZlaGlscCwL+M8a5g?= =?Windows-1252?Q?kNP7sUUnAjbz0R6Q6Baxtuz4Ahd8TBIOVyV0yUIb5MaTPGcnb0OQvwCN?= =?Windows-1252?Q?nl8yopXwPRC0AYwYeePNhq4MuKLEhQSAlIlXmPQv8eytTskcCByeTFli?= =?Windows-1252?Q?IXCtInfsOD22MDRZFlZ5cQLVAr89zQ+plCg=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4346 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Joey.Gouly@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 700e302a-8095-4946-94e5-08d8e312abd5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fwnP3dZBzjO+IiWJ3BbXSg/5RBoI918YzlJcKk13of+0LbZ8Aly12vzEygegGMb7oOBBUQbVzAKg0XYOybPu/HIxo7RUNTc77wNmwCgefgKzt5QQZx2qk1dqhJh5HSxJCigAOdGu/kl2IOl4hAt2y/d4FYb0TgoMdaznLzJKrt0iBQZJfd33QoXfryDa7zLcOfHArJJOM8crSwB5nXTwgDXWiMnmhrdiOEcAA/r6BeDuBXJzszUJZ92kZbU4FkUp4Kjb6eybhQXfJUtfcbmEnfD3jGGTfKL9AYJHFdJUB3oslNd66KzpfN9dUtID58lPBnkjBu21/s7XsWthvfiyB3Hfm0d6ooBXKH6jBDX+Xb/r2JjzuYMt4X4TvQSvD1nDQ3GjEwHRQHnkxgb0m4uicGyWp7na9CwDo6xE5DLT9d9uLIYZaXYooUeE/w33y2nTY4fPOknpPkYazMtrAqhTEfBZHziK7SfWf9G3KdRhrQg8wL3aO2JZxzpDelRkCCTHZOMawEMManjMuKB55lHmwO4QheWjMjhdWWNfjqPQc3+jyN6M6eEYANld4XPtebPcrWCBK9dG2quVT8Cib1b+L8efyUfbiN25Wo78jLdwA8ZBHUKLkOm+FK3/1KGzeu1OMqtTI/H7IwN/gpgYfVfLvSWc1ru7DFXMXsXbFFW+nB4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(396003)(136003)(346002)(376002)(46966006)(36840700001)(70206006)(54906003)(186003)(356005)(47076005)(8676002)(36860700001)(336012)(55016002)(6916009)(316002)(81166007)(86362001)(15650500001)(9686003)(26005)(6506007)(82740400003)(52536014)(4744005)(7696005)(478600001)(4326008)(82310400003)(33656002)(8936002)(70586007)(5660300002)(83380400001)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2021 15:47:50.9976 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 644a689d-c6b4-48f3-6cc5-08d8e312b22f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5462 Content-Language: en-GB Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable > From: Joey Gouly =0A= > Subject: [PATCH v2 1/1] ShellPkg: Validate that the Boot CPU is present i= n MADT=0A= >=0A= > The ACPI 6.3 Specification, January 2019, section 5.2.12.14 states that= =0A= > the firmware must convey each processor=92s GIC information to the OS usi= ng=0A= > the GICC structure.=0A= >=0A= > If a GICC structure for the boot CPU is missing some standards-based=0A= > operating system may crash with an error code. It may be difficult to=0A= > diagnose the reason for the crash as the error code may be too generic=0A= > and mean firmware error.=0A= >=0A= > Therefore add validation to the MADT table parser to check that a GICC is= =0A= > present for the boot CPU.=0A= =0A= Ping.=0A= =0A= Is anyone able to review this patch adding some more validation checks to A= cpiview / MADT?=0A= =0A= Thanks,=0A= Joey=