From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (EUR02-HE1-obe.outbound.protection.outlook.com [40.107.1.63]) by mx.groups.io with SMTP id smtpd.web12.6687.1618306114540478446 for ; Tue, 13 Apr 2021 02:28:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=MTCZ31Ir; spf=pass (domain: arm.com, ip: 40.107.1.63, mailfrom: joey.gouly@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R9ZZU52MhjCGmjNM/eLXC6uSAB/DRR8jrlRGVjJPXUI=; b=MTCZ31Irq4pyuJA67jD+KWQU3y72CeEzyTDx4us8ViamgqvdCwTkq0Snkz6KpikO3Ud4shJGRQ5RkTTbV8MCKw1KtxYraILKNZCbTkxEuRA5uBUWvG+pr834QVh4j1S4YYGq3n3d5FA2Pq8ONfEume1uH1Kc9r38UbsOO0hvfiQ= Received: from AM5P194CA0021.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::31) by AM9PR08MB6899.eurprd08.prod.outlook.com (2603:10a6:20b:309::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Tue, 13 Apr 2021 09:28:26 +0000 Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::9a) by AM5P194CA0021.outlook.office365.com (2603:10a6:203:8f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Tue, 13 Apr 2021 09:28:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Tue, 13 Apr 2021 09:28:26 +0000 Received: ("Tessian outbound b610e7b4d771:v90"); Tue, 13 Apr 2021 09:28:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9850dd6083f0233b X-CR-MTA-TID: 64aa7808 Received: from ad7705b69847.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 14F0B2A0-E4DB-4BCD-8B9D-F7F9534B5CC2.1; Tue, 13 Apr 2021 09:28:15 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ad7705b69847.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Apr 2021 09:28:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qx7Is8ol029n0XXR0KqluxoV7zOrY3+MlIXV+MCYcwxhxOpN+98E4AepYEYfuuMsMUm7mLAIXtFuYZAbZjlEt0oT3my4eDElKNSDhQZ0Ng0VEHOZK6valwSqr4NaZRiygHZy/v+BEmbWea9rtGSJGlEkjAOoC2PAmMeTlqidpoqPV1t70ZeRJS66Ii+ByYxlStFP7HO6fX43bRWJyGMNeEImAG5j2QlKfL+/EztQAxXgyrEoAS3EdnF/ee4Na6XiHu1oZvvjXzfTjqej9l2nPjwBpsKCtAvJJ+8NiTR/VUMfd/f1YR9Mquk31nUcYgRJ0pXfRJwHIu5iZJPih9rC5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R9ZZU52MhjCGmjNM/eLXC6uSAB/DRR8jrlRGVjJPXUI=; b=ZIHKA93Dit7KmPpgr+tV1D2qBg2e+j2DwRp87lxi27BY6jPsnkmtF9r2a5igORCFn2M784JqRdGcxYwAXOs4ACUre44H2kiBRVaGJdDN1wEl7tTIhtyy3v8nwywJrPs1P+JcAeNHlCZqFv6sd7TGXl4nCIXf4Cum2nsKozkwYgRDEheCBqrHYKTvo7vC0ALlslf6K7NrquBO2QTinN9v5FkzRlDmGcyGPaKHHeqfg5t0nkLOOYjwZZ+VyKE1US82MWZ5Oxi9vZSmLmsd1BkuERRl/DsG8hKEw/oPcGjZ0uDAGNR4KXHCO2f8rKlDU9FN4hdgBe4xuxbl4qFayq7yQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R9ZZU52MhjCGmjNM/eLXC6uSAB/DRR8jrlRGVjJPXUI=; b=MTCZ31Irq4pyuJA67jD+KWQU3y72CeEzyTDx4us8ViamgqvdCwTkq0Snkz6KpikO3Ud4shJGRQ5RkTTbV8MCKw1KtxYraILKNZCbTkxEuRA5uBUWvG+pr834QVh4j1S4YYGq3n3d5FA2Pq8ONfEume1uH1Kc9r38UbsOO0hvfiQ= Received: from DB8PR08MB5433.eurprd08.prod.outlook.com (2603:10a6:10:118::13) by DB7PR08MB3916.eurprd08.prod.outlook.com (2603:10a6:10:7e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Tue, 13 Apr 2021 09:28:10 +0000 Received: from DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::dc7a:d295:abdc:f039]) by DB8PR08MB5433.eurprd08.prod.outlook.com ([fe80::dc7a:d295:abdc:f039%6]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 09:28:09 +0000 From: "Joey Gouly" To: "devel@edk2.groups.io" , Sami Mujawar CC: nd Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: add validation for PcdNonBsaCompliant16550SerialHid Thread-Topic: [edk2-devel] [PATCH] DynamicTablesPkg: add validation for PcdNonBsaCompliant16550SerialHid Thread-Index: AQHXLTgHCy+JC1uXYk+7htsluJy9Z6qwqyqAgAGIbUk= Date: Tue, 13 Apr 2021 09:28:08 +0000 Message-ID: References: <20210409120058.13313-1-joey.gouly@arm.com>,<21280.1618221687657567382@groups.io> In-Reply-To: <21280.1618221687657567382@groups.io> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.99.251] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c82d49f4-4195-433f-f231-08d8fe5e7da3 x-ms-traffictypediagnostic: DB7PR08MB3916:|AM9PR08MB6899: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SOU2e2lv5+3tBCA6ROuHy/1SWySYSax324UM0/6a5GwmBH4Ce5sD+TZAWUzrFZ3aDNT26e8S3lCwBAupfOjbd3BESnrxZJwBhAnHb0zVWQnNhCe5APDT5mGyL+Z16AqT28avnUiLLMDLnXQ09z+SGjc538vyL3fpBjfxKRoRry9S7QzSlV1lphiiAkSjesqSp0fO2UOT5jMWhAkv8Es07pH93ex8VoYDTME9YUcEsuW/aPC+l4BJjZFTYVORkpwAqGsxSgKJYmizY+aChAMPEAACkCQhs+89U9IO52aV9N/uKmB1OCS466+NeMUZLpMiHGsI7AkSVIJnKHl9kNFAobdSoYee4tiHtV5ZvhiY1hxuHf890KL7VewmxBFZrcUfQQrQoD14aqdBtTD5IGup3/TjGMCl0VJty6N8y0dFhhGg1QibDDrsUheJkoCNoJyzgbR0erGheUUnbueI/Et0lyVhw5jjwxy+r/vQc0ZYiWzm5xe46Ly57fgV3ad4uBvbmaOG9GdbkE698m8PtTCFTk+e688JkF0nFVoHhLPD8O4jYH6+ejoZpEsn5TsQst+EsDMb3Sy8cBSZ108rHQWVD+8Mz8iWY3JmPExCpgyWOKQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB5433.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(396003)(39860400002)(376002)(8676002)(9686003)(8936002)(55016002)(66946007)(71200400001)(4326008)(66446008)(26005)(110136005)(52536014)(66556008)(64756008)(7696005)(66476007)(6506007)(316002)(2906002)(122000001)(558084003)(76116006)(478600001)(33656002)(6636002)(83380400001)(86362001)(186003)(5660300002)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?0B/VVMm9nr6rZHMHtUu4mDkF3Wk2aBWjOym5EuR9K5V5in3BMVQcVdPn1q?= =?iso-8859-1?Q?AhLEwrEBK4Xjt3S8WA/CIfq02S/+aFFTeSGRN7Q6JAPivRG+9dL/0Q9662?= =?iso-8859-1?Q?QfdNCXj8nKB3glrwoHoYTAJzx9NVt3PzA/nV/tV7l55Afm0mc7/Ekgk6vR?= =?iso-8859-1?Q?SoJVaH456YHW4W7LJzc0Ucm1gvUWdw6H7sZMVjIDbdHSFKomnZzIJy3C2y?= =?iso-8859-1?Q?8iFGKq92J2H4RDQQ5YUYR1DHKbRDeEy6yYhBL/124V3Q9eMhoQrKTH8g5r?= =?iso-8859-1?Q?PjLxM9Zyyz1nccFK/NxIDH+JDmZ+PGr2sPDtjx6yIc4Jj+PTcL+ynKHrzN?= =?iso-8859-1?Q?zmAcToii3ry9sbwKSqNrrf91VEGVWA1ZQnyMIbTOl6CTRhlKC2geyI47D6?= =?iso-8859-1?Q?tynTVqVhFONiMHmpv/iKIa24IjIWIy7usV6vjK2hZ9Cvsud5En96vh9+l8?= =?iso-8859-1?Q?ABofuIQyxcujCxwlS28bEVUtIylf4ZOZT2F2fnuv5S9hKDuxHS7nO/cnuC?= =?iso-8859-1?Q?BsT8mHLTrk2k40wUk+YM8CJ6CIMl3u8lvD3SSDJbQMbig3bhjnpvJ4BPR3?= =?iso-8859-1?Q?mbl/CQne2CGr3A5oPNYOVE9uFmjXmSgFeoo+EQfwcaxsVsNnYZC+G0vuaV?= =?iso-8859-1?Q?PGEj6Zx1CQAr27kD9u9ziiM53h3sDyqt0WaW2yXm/xDWRSJJ1644CnyxEl?= =?iso-8859-1?Q?hCJ4c4avrx/JkCTvk52RNOzRPHUgo2b0bqaKjMD8jkilPEPJojj3EuW76R?= =?iso-8859-1?Q?tXqYPd0Z2tBeSf4CzuhrJAI60akqxhwQKU3YODfovk7/947mE1zNRWX/9V?= =?iso-8859-1?Q?U9Fkzy327VZ+a5EZygQzbZpEoWDOWkHDD8kPPiAaHDYOzFFMmQbzEibrI0?= =?iso-8859-1?Q?GCP/ZJSs1ls3/K8GyOL+NpCouPNYVdTvvu5aepJ7ZuccAP7MdS4ewl0EXq?= =?iso-8859-1?Q?bQkh2wEietPE64B+FAdxTeSzvLEQSTSb9NDZc6nnhsJoJTfoGPH8VVfDMT?= =?iso-8859-1?Q?iqeCjovhjmzViGQyeTwz87jQ/O6lz9WPC5B+OdTjojHMmisfODoKFoaRwR?= =?iso-8859-1?Q?5Df2Nn0v9W149Qtm8LdyefR6FZd6u0V2JePULceiNz4PeZ4OPr1nHjETOq?= =?iso-8859-1?Q?L47a0Kda5Yq7MBbQB7nSc6vaio9iHFKtZ/wUTbWAvB9nTJcNS3eTzos79f?= =?iso-8859-1?Q?oCS+DWRIMOGQ3VDJCVq3a257dR4dHRsFedoNeJsEO7q+A7N4g0eZKAhA8n?= =?iso-8859-1?Q?fsNKE56/ZYt3slY5gDGzjN0nyjG+DAEFJ629rGavxv+iPXWL5BDueHZlXi?= =?iso-8859-1?Q?5S/QNbhOGkSWTg+jAeMdeDesEMzNFUX0MqUMEl1Yi5fMcyw=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3916 Original-Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=arm.com; Return-Path: Joey.Gouly@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ad2f4e25-b313-4673-a1b8-08d8fe5e7375 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4pSjrIAOlU3qDE994Xga3wQSE7HfStM14FnHKtTDk0Hm6CN3TdTleMmdamzsiARLcHLObtB/HTWiD4Xi8vehvu2VQjrofYwzKiGiMHTi4t5SytA7xV1H6+Lc//xs07Fx+TI5Y7iX4b0CAuNBDdUAJzPJOsSKnhiRyoa3Y0uUfu8PwkRsZbAWnqS8rnLqCPyGv08uoIyz469HjhG5HbEUV9wLXtA/74sbhTi172EYwI9XL2i3I1oFQBVFQAOzup2KihdW1+2iU/p0nBrFktnr8MlGX2tsXjzXyf++VeqdJXXAXGlRVTZFXhko1BIAQuluEGFEwWCaXlMD1TmrcXi53vQIcAPNlanOU2glbme5rZ5aOFeZ1bjrVYPleo0+3lf/wJYo7cnh3qh3GqvOlAqv01lKYdzz+qRzTpLjV+gZP1ij7UAYKBlN+4zV5hXwL7tdOvkI6IJAQgvTZG1JVRYzwTRwVgya50hOmNUmKUJbQS72bau4bCKN+YAl9IxYZknoRSY6MKKgS41DyheuA017VOqAiATIYf/TnSSgrH1oTjaZzZ+/6gX7ujw19AyDq+jawwDgxufk/w//H53XNABB/3hE9u7OILyW7OZ1K7wlpuCuZWCKsNOOVy1vwnhvV0GOhAQx419vEifufPkjxK90vXQy6clW/oFdUf5Qcbwe7q0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(136003)(376002)(46966006)(36840700001)(82740400003)(83380400001)(2906002)(81166007)(356005)(316002)(336012)(26005)(478600001)(6506007)(70206006)(36860700001)(82310400003)(558084003)(7696005)(8676002)(186003)(52536014)(86362001)(47076005)(33656002)(55016002)(4326008)(70586007)(110136005)(6636002)(5660300002)(9686003)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2021 09:28:26.0392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c82d49f4-4195-433f-f231-08d8fe5e7da3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6899 Content-Language: en-GB Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > Hi Joey,=0A= > =0A= > Can you confirm that your sign-off ID is correct, please?=0A= > Otherwise this patch looks good to me.=0A= =0A= That was silly to typo my own name!=0A= =0A= Signed-off-by: Joey Gouly =0A= =0A= Thanks for the review!=0A= Joey=