From: "Andy Hayes" <andy.hayes@displaylink.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [External] Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop
Date: Tue, 17 Sep 2019 15:32:04 +0000 [thread overview]
Message-ID: <DB8PR10MB2684943F21F445929C730CF0958F0@DB8PR10MB2684.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20190917152751.GM28454@bivouac.eciton.net>
[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]
That's right, the only (current) request was index 0 - that is why it didn't show up. It was a refactoring error.
It was picked up when we ported some of the changes back into our "closed source" version of the driver and the unit tests failed.
Thanks for pushing this.
From: Leif Lindholm <leif.lindholm@linaro.org>
Sent: 17 September 2019 16:28
To: Andy Hayes <andy.hayes@displaylink.com>
Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [External] Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop
On Wed, Sep 11, 2019 at 07:42:03AM +0000, Andy Hayes wrote:
> Corrected initialisation of one of data structures used to transmit USB
> control messages. Mistake had no practical effects but fixing to be on safe
> side.
So, was the only request used index 0? Or why didn't this cause an
issue? Nevertheless, a clear fix.
> Cc: Leif Lindholm <leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org<mailto:ard.biesheuvel@linaro.org>>
> Signed-off-by: Andy Hayes <andy.hayes@displaylink.com<mailto:andy.hayes@displaylink.com>>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>>
Pushed as 958aaf600728.
/
Leif
> ---
> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> index 252293da39d4..9871ab0378ce 100644
> --- a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> +++ b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> @@ -107,7 +107,7 @@ DlUsbSendControlWriteMessage (
> UINT32 UsbStatus;
> EFI_USB_DEVICE_REQUEST UsbRequest;
>
> - ZeroMem (&Request, sizeof (Request));
> + ZeroMem (&UsbRequest, sizeof (UsbRequest));
> UsbRequest.RequestType = USB_REQ_TYPE_VENDOR | USB_TARGET_INTERFACE;
> UsbRequest.Index = Device->InterfaceDescriptor.InterfaceNumber;
> UsbRequest.Request = Request;
> --
> 1.8.3.1<http://1.8.3.1>
>
[-- Attachment #2: Type: text/html, Size: 4911 bytes --]
prev parent reply other threads:[~2019-09-17 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 7:42 [PATCH v1 0/1] DisplayLink GOP driver USB msg initialisation Andy Hayes
2019-09-11 7:42 ` [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop Andy Hayes
2019-09-17 15:27 ` Leif Lindholm
2019-09-17 15:32 ` Andy Hayes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR10MB2684943F21F445929C730CF0958F0@DB8PR10MB2684.EURPRD10.PROD.OUTLOOK.COM \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox