From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@displaylink.com header.s=mimecast20151025 header.b=ePnuvB2M; spf=pass (domain: displaylink.com, ip: 207.82.80.167, mailfrom: andy.hayes@displaylink.com) Received: from eu-smtp-delivery-167.mimecast.com (eu-smtp-delivery-167.mimecast.com [207.82.80.167]) by groups.io with SMTP; Tue, 17 Sep 2019 08:32:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=displaylink.com; s=mimecast20151025; t=1568734329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ptlbr1O6Sktu+D+t8ZL2QkDdR6c5CcTD70XQwaltJk0=; b=ePnuvB2MgHeIi4iviW4o6nEHT5qqNSmhQthh/6/BMyU6Gf11auIkjZ9PJnBDsWU2pzt/Ho MkHJQiYd930QOPgF9tPcfd0ML/gd1NjN+OYVw4zcj05G8fJByYmxccwo+va775Ew2FJuB/ Zyi98x2vcIPXRy1lVn4zEFyO3eM2Zn8= Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-132-heGZ1gmHMueMNjXm9vyTag-1; Tue, 17 Sep 2019 16:32:07 +0100 Received: from DB8PR10MB2684.EURPRD10.PROD.OUTLOOK.COM (20.179.10.22) by DB8PR10MB3484.EURPRD10.PROD.OUTLOOK.COM (10.186.167.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.15; Tue, 17 Sep 2019 15:32:05 +0000 Received: from DB8PR10MB2684.EURPRD10.PROD.OUTLOOK.COM ([fe80::fc15:624b:1727:b7b4]) by DB8PR10MB2684.EURPRD10.PROD.OUTLOOK.COM ([fe80::fc15:624b:1727:b7b4%3]) with mapi id 15.20.2263.023; Tue, 17 Sep 2019 15:32:05 +0000 From: "Andy Hayes" To: Leif Lindholm CC: "devel@edk2.groups.io" , Ard Biesheuvel Subject: Re: [External] Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop Thread-Topic: [External] Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop Thread-Index: AQHVaHRmtK40Zs/IZ0acLECkU+ehCacwCAaAgAAAgyA= Date: Tue, 17 Sep 2019 15:32:04 +0000 Message-ID: References: <1568187713-4492-1-git-send-email-andy.hayes@displaylink.com> <1568187713-4492-2-git-send-email-andy.hayes@displaylink.com> <20190917152751.GM28454@bivouac.eciton.net> In-Reply-To: <20190917152751.GM28454@bivouac.eciton.net> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [213.146.140.62] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8310f6b1-b647-4862-c53b-08d73b8431cc x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:DB8PR10MB3484; x-ms-traffictypediagnostic: DB8PR10MB3484: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 01630974C0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(39840400004)(366004)(346002)(376002)(396003)(199004)(189003)(76176011)(54906003)(236005)(486006)(66446008)(66476007)(9686003)(52536014)(54896002)(6306002)(5660300002)(8936002)(256004)(476003)(66556008)(64756008)(33656002)(76116006)(44832011)(66946007)(14454004)(86362001)(6916009)(8676002)(55016002)(229853002)(14444005)(74316002)(6436002)(7736002)(11346002)(3846002)(478600001)(186003)(606006)(81166006)(81156014)(26005)(6116002)(102836004)(446003)(6246003)(99286004)(2906002)(71190400001)(71200400001)(316002)(53546011)(6506007)(4326008)(25786009)(66066001)(790700001)(7696005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB8PR10MB3484;H:DB8PR10MB2684.EURPRD10.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: FOzPoCX4gYg3H2Hv5+0BS1dxqegFvscpvbsEwtxVQsc3bVjTx6yH1UtSLu8V1TQaQY/dEzSoeOIVF9TE8mXlJ+6jhuIm9RWilB4kZn8cb78tDoDbU7e23yJ86d4xfmMLIvVDlJ9M+Oa00YOPerFdtghiZFUMNByQVWHRytXigTtuPAQXS5re6qxpiPpSa9MvTDvcShuon6FxflK4AYpDrreLvLrQxGF52V0+LhddBXxRFzkx75zDSzwhsi8K4EaAus/RSMAZXtnC26FshubM3smTHsWU/D5G3/6KD7/dTBvDDBEGdVAo6mNYKRhFSbfaKJD8yTd9aeFM6dMZ9lN7ddXjTkCJqrep1dfKZG2Ec+3cZ+0OhSJyOd37uNUASDUrtxzMOvZoJIkdR9ZL2Gy8KFHaDGpR0pvWl86Q5KQBxnI= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: displaylink.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8310f6b1-b647-4862-c53b-08d73b8431cc X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2019 15:32:05.2030 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a4bda75a-b444-4312-9c90-44a7c4b2c91a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s+Hw2SAoWhNLtgOhZ3fjF+MNq7eKvo3XU3Bugj6cIEVJrFvfd/s9+erwZsxzMePKUkYkzEqkg7A6uAayQm0Cer3oL4p3Fr4QSuxRIKqhdK0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3484 X-MC-Unique: heGZ1gmHMueMNjXm9vyTag-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DB8PR10MB2684943F21F445929C730CF0958F0DB8PR10MB2684EURP_" --_000_DB8PR10MB2684943F21F445929C730CF0958F0DB8PR10MB2684EURP_ Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable That's right, the only (current) request was index 0 - that is why it didn'= t show up. It was a refactoring error. It was picked up when we ported some of the changes back into our "closed s= ource" version of the driver and the unit tests failed. Thanks for pushing this. From: Leif Lindholm Sent: 17 September 2019 16:28 To: Andy Hayes Cc: devel@edk2.groups.io; Ard Biesheuvel Subject: [External] Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg D= isplayLinkGop On Wed, Sep 11, 2019 at 07:42:03AM +0000, Andy Hayes wrote: > Corrected initialisation of one of data structures used to transmit USB > control messages. Mistake had no practical effects but fixing to be on sa= fe > side. So, was the only request used index 0? Or why didn't this cause an issue? Nevertheless, a clear fix. > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Signed-off-by: Andy Hayes > Reviewed-by: Leif Lindholm > Pushed as 958aaf600728. / Leif > --- > Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfe= r.c b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c > index 252293da39d4..9871ab0378ce 100644 > --- a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c > +++ b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c > @@ -107,7 +107,7 @@ DlUsbSendControlWriteMessage ( > UINT32 UsbStatus; > EFI_USB_DEVICE_REQUEST UsbRequest; > > - ZeroMem (&Request, sizeof (Request)); > + ZeroMem (&UsbRequest, sizeof (UsbRequest)); > UsbRequest.RequestType =3D USB_REQ_TYPE_VENDOR | USB_TARGET_INTERFACE; > UsbRequest.Index =3D Device->InterfaceDescriptor.InterfaceNumber; > UsbRequest.Request =3D Request; > -- > 1.8.3.1 > --_000_DB8PR10MB2684943F21F445929C730CF0958F0DB8PR10MB2684EURP_ Content-Type: text/html; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable

That’s right, the only (current) request was i= ndex 0 – that is why it didn’t show up. It was a refactoring er= ror.

 

It was picked up when we ported some of the changes = back into our “closed source” version of the driver and the uni= t tests failed.

 

Thanks for pushing this.

 

From: Leif Lindholm <leif.lindholm@linaro.= org>
Sent: 17 September 2019 16:28
To: Andy Hayes <andy.hayes@displaylink.com>
Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.o= rg>
Subject: [External] Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLi= nkPkg DisplayLinkGop

 

On Wed, Sep 11, 2019 at 07:42:03AM +0000, Andy H= ayes wrote:
> Corrected initialisation of one of data structures used to transmit US= B
> control messages. Mistake had no practical effects but fixing to be on= safe
> side.

So, was the only request used index 0? Or why didn't this cause an
issue? Nevertheless, a clear fix.

> Cc: Leif Lindholm <leif= .lindholm@linaro.org>
> Cc: Ard Biesheuvel <ar= d.biesheuvel@linaro.org>
> Signed-off-by: Andy Hayes <andy.hayes@displaylink.com>

Reviewed-by: Leif Lindholm <= leif.lindholm@linaro.org>
Pushed as 958aaf600728.

/
Leif

> ---
> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 &#= 43;-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTran= sfer.c b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c > index 252293da39d4..9871ab0378ce 100644
> --- a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c<= br> > +++ b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Us= bTransfer.c
> @@ -107,7 +107,7 @@ DlUsbSendControlWriteMessage (
> UINT32 UsbStatus;
> EFI_USB_DEVICE_REQUEST UsbRequest;
>
> - ZeroMem (&Request, sizeof (Request));
> + ZeroMem (&UsbRequest, sizeof (UsbRequest));
> UsbRequest.RequestType =3D USB_REQ_TYPE_VENDOR | USB_TARGET_INTERFACE;=
> UsbRequest.Index =3D Device->InterfaceDescriptor.InterfaceNumber; > UsbRequest.Request =3D Request;
> --
> 1.8.3.1
>

--_000_DB8PR10MB2684943F21F445929C730CF0958F0DB8PR10MB2684EURP_--