Re: [edk2-platforms][PATCH V3 08/14] Platform/Sgi: ACPI PPTT table for RD-E1-Edge platform

["Pranav Madhu" <pranav.madhu@arm.com>]

Hi Sami,

Please find my response:

>
> Hi Pranav,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
>
> On 10/05/2021 09:06 PM, Pranav Madhu wrote:
> > The RD-E1-Edge platform includes two clusters with eight multi-thread
> > CPUs. Each of the CPUs include 32KB L1 Data cache, 32KB L1 Instruction
> > cache and 256KB L2 cache. Each cluster includes a 2MB L3 cache. The
> > platform also includes a system level cache of 8MB. Add PPTT table for
> > RD-E1-Edge platform with this information.
> >

<...>

> \
> > +      PPTT_PROCESSOR_CLUSTER_THREADED_FLAGS,       /* Flag */
> \
> [SAMI] I see that PPTT_PROCESSOR_CLUSTER_THREADED_FLAGS sets the
> ACPI ID flag to invalid. Is there a reason for doing this?
> Also, it looks like the DSDT for RD-E1-Edge platform does not have the
> clusters definitions. Am I missing something here?
> Can you take a look, please?
> [/SAMI]

ACPI CPU container (ACPI0010) is introduced to support combined idles state for CPU core and container. Idle states are not supported for RDE1, and hence container is not added.

> > +      OFFSET_OF
> (EFI_ACPI_6_3_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE,             \

<...>

Regards,
Pranav
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.