From: "Omkar Anand Kulkarni" <omkar.kulkarni@arm.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <Sami.Mujawar@arm.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 0/5] Add support to generate HEST ACPI table
Date: Fri, 3 Sep 2021 13:38:21 +0000 [thread overview]
Message-ID: <DBAPR08MB57818DE60FF258521ED0368392CF9@DBAPR08MB5781.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <DBAPR08MB5781FB14EFC483C3ECFCA7AA92C59@DBAPR08MB5781.eurprd08.prod.outlook.com>
Gentle reminder, to review this patch series.
- Omkar
> On August 24, 2021 11:21 AM, Omkar Kulkarni wrote:
> Hi All,
>
> Sorry for the [edk2-platforms] prefix attached to the subject line. This is edk2
> patch series. Will fix the prefix in next version.
>
> - Omkar.
>
> > Changes since v2:
> > - Addressed the comments given by Sami.
> > - Added Readme file with all cover letter information.
> > - Rebased to the latest upstream code.
> >
> > Hardware Error Source Table (HEST)[1] and Software Delegated Exception
> > Interface (SDEI)[2] ACPI tables are used to acomplish firmware first
> > error handling.This patch series introduces a framework to build and
> > install the HEST ACPI table dynamically.
> >
> > The following figure illustrates the possible usage of the dyanamic
> > generation of HEST ACPI table.
> >
> > NS | S
> > +--------------------------------------+--------------------------------------+
> > | | |
> > |+-------------------------------------+---------------------+
> > |+-------------------------------------+---------------------+ |
> > || +---------------------+--------------------+| |
> > || | | || |
> > || +-----------+ |+------------------+ | +-----------------+|| +-------------+|
> > || |HestTable | || HestErrorSource | | | HestErrorSource ||| |
> > || |DMC-620
> > ||
> > || | DXE | || DXE | | | StandaloneMM ||| |Standalone MM||
> > || +-----------+ |+------------------+ | +-----------------+|| +-------------+|
> > || |GHESv2 | || |
> > || +---------------------+--------------------+| |
> > || +--------------------+ | | |
> > || |PlatformErrorHandler| | | |
> > || | DXE | | | |
> > || +--------------------+ | | |
> > ||FF FWK | | |
> > |+-------------------------------------+---------------------+
> > |+-------------------------------------+---------------------+ |
> > | | |
> > +--------------------------------------+--------------------------------------+
> > |
> > Figure: Firmware First Error Handling approach.
> >
> > All the hardware error sources are added to HEST table as GHESv2[3]
> > error source descriptors. The framework comprises of following DXE and
> > MM
> > drivers:
> >
> > - HestTableDxe:
> > Builds HEST table header and allows appending error source
> > descriptors to the
> > HEST table. Also provides protocol interface to install the built HEST table.
> >
> > - HestErrorSourceDxe & HestErrorSourceStandaloneMM:
> > These two drivers together retrieve all possible error source descriptors of
> > type GHESv2 from the MM drivers implementing HEST Error Source
> > Descriptor
> > protocol. Once all the descriptors are collected HestErrorSourceDxe
> > appends
> > it to HEST table using HestTableDxe driver.
> >
> > Link to github branch with the patches in this series -
> > https://github.com/omkkul01/edk2/tree/ras_firware_first_edk2-
> > platforms_v3
> >
> > Omkar Anand Kulkarni (5):
> > MdeModulePkg: Allow dynamic generation of HEST ACPI table
> > ArmPlatformPkg: add definition for
> > MM_HEST_ERROR_SOURCE_DESC_PROTOCOL
> > ArmPlatformPkg: retreive error source descriptors from MM
> > EmbeddedPkg: Add helpers for HEST table generation
> > ArmPlatformPkg: Add Readme file
> >
> > ArmPlatformPkg/ArmPlatformPkg.dec | 10 +
> > MdeModulePkg/MdeModulePkg.dec | 3 +
> > .../HestMmErrorSources/HestErrorSourceDxe.inf | 45 +++
> > .../HestErrorSourceStandaloneMm.inf | 51 +++
> > .../Universal/Apei/HestDxe/HestDxe.inf | 49 +++
> > .../HestMmErrorSourceCommon.h | 37 ++
> > .../Include/Protocol/HestErrorSourceInfo.h | 64 ++++
> > EmbeddedPkg/Include/Library/AcpiLib.h | 20 ++
> > MdeModulePkg/Include/Protocol/HestTable.h | 71 ++++
> > MdePkg/Include/Protocol/MmCommunication.h | 2 +
> > .../HestMmErrorSources/HestErrorSourceDxe.c | 309
> +++++++++++++++++
> > .../HestErrorSourceStandaloneMm.c | 312 +++++++++++++++++
> > MdeModulePkg/Universal/Apei/HestDxe/HestDxe.c | 318
> > ++++++++++++++++++
> > .../Drivers/HestMmErrorSources/Readme.md | 66 ++++
> > 14 files changed, 1357 insertions(+)
> > create mode 100644
> > ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.inf
> > create mode 100644
> >
> ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandalone
> > Mm.inf
> > create mode 100644 MdeModulePkg/Universal/Apei/HestDxe/HestDxe.inf
> > create mode 100644
> >
> ArmPlatformPkg/Drivers/HestMmErrorSources/HestMmErrorSourceCommo
> > n.h
> > create mode 100644
> > ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h
> > create mode 100644 MdeModulePkg/Include/Protocol/HestTable.h
> > create mode 100644
> > ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceDxe.c
> > create mode 100644
> >
> ArmPlatformPkg/Drivers/HestMmErrorSources/HestErrorSourceStandalone
> > Mm.c
> > create mode 100644 MdeModulePkg/Universal/Apei/HestDxe/HestDxe.c
> > create mode 100644
> > ArmPlatformPkg/Drivers/HestMmErrorSources/Readme.md
> >
> > --
> > 2.17.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#79741):
> > https://edk2.groups.io/g/devel/message/79741
> > Mute This Topic: https://groups.io/mt/85104604/4857533
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [omkar.kulkarni@arm.com]
> > -=-=-=-=-=-=
> >
prev parent reply other threads:[~2021-09-03 13:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <169E2742D9347879.18298@groups.io>
2021-08-24 5:51 ` [edk2-devel] [edk2-platforms][PATCH v3 0/5] Add support to generate HEST ACPI table Omkar Anand Kulkarni
2021-09-03 13:38 ` Omkar Anand Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB57818DE60FF258521ED0368392CF9@DBAPR08MB5781.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox