From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0612.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe02::612]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3287981C83 for ; Mon, 21 Nov 2016 03:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fggaxoD+5K1+dR2knbaL3+V0uGSMAmS5wxB97EhPhKQ=; b=Z9HNeg2Xx1xCSip1vpFHBs5W/rTrdEcQZThjfdJpVxrPH/sapKIR7OuzjIHaZv/n/Xt4hJ/BGDh1LKv1G3Y6A7bemdcue9RauCJ4mZy35ELCJ5EaIJutEvMBnEyDmf0MTw/aIzooVZuqjevqjC4J+73boDDII19ohMbtnNrJmI4= Received: from DBXPR04MB144.eurprd04.prod.outlook.com (10.242.140.16) by HE1PR04MB1131.eurprd04.prod.outlook.com (10.162.27.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.8; Mon, 21 Nov 2016 11:28:49 +0000 Received: from DBXPR04MB144.eurprd04.prod.outlook.com ([169.254.12.243]) by DBXPR04MB144.eurprd04.prod.outlook.com ([169.254.12.243]) with mapi id 15.01.0721.024; Mon, 21 Nov 2016 11:28:50 +0000 From: Pankaj Bansal To: "edk2-devel@lists.01.org" , Ard Biesheuvel Thread-Topic: ArmPkg/PlatformBootManagerLib : Multiple UEFI Shell Boot entries Thread-Index: AdJD5HZ4OlMiOg7MRdCjGBjPNVcJSw== Date: Mon, 21 Nov 2016 11:28:50 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@nxp.com; x-originating-ip: [192.88.169.1] x-microsoft-exchange-diagnostics: 1; HE1PR04MB1131; 7:2RAplajW4Rrca0YfbpQYMknUysNjd6dQ0lTSQH/gc4wgXDi0z6Jc0pxW3HfWp8X9U7B2O7l8CwucChgRwwcN9SV5sHMiZY4DHMeBjr35xx+1jcsVapw1Ioa3si8VJkh/MbVW9KimLc1E3bOK18dY112K+SP2xxShaMnT7pU8qky6AZIPMz8p1BGTeYqMPiii1mIM9dcbXNS9ukUBHXNbQOp6wHTHqwIs8DtuRvn3RS/G1N8Qb+ryhrUGD+xEM8w5B6BwdBWzB3udko1+H+7eD1YEE0ljqk8qlisEwjIGSEe3RUeGB6AUffX4SwgGf2pxJGjN8RUTRhFpIG0WQU4eOoRdfsnH1s1IgDJ9yhcsqQ8= x-ms-office365-filtering-correlation-id: 161f9075-1442-405f-4f28-08d41201912c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR04MB1131; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040307)(6060326)(6045199)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6046074)(6041248)(6061324); SRVR:HE1PR04MB1131; BCL:0; PCL:0; RULEID:; SRVR:HE1PR04MB1131; x-forefront-prvs: 01334458E5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(189002)(199003)(3280700002)(66066001)(101416001)(122556002)(3660700001)(68736007)(2501003)(189998001)(8676002)(76576001)(2906002)(4326007)(87936001)(575784001)(8936002)(92566002)(33656002)(86362001)(7846002)(7736002)(81166006)(54356999)(97736004)(6116002)(106356001)(102836003)(9686002)(105586002)(81156014)(305945005)(3846002)(74316002)(2900100001)(5001770100001)(6506003)(50986999)(7696004)(5660300001)(38730400001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR04MB1131; H:DBXPR04MB144.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2016 11:28:50.4449 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1131 Subject: ArmPkg/PlatformBootManagerLib : Multiple UEFI Shell Boot entries X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 11:28:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Edk2 team, We are observing that sometimes "UEFI Shell" entry is created even though i= t is present in boot manager menu in our ARMV8 NXP board When this happens multiple times, we see multiple entries of "UEFI Shell" i= n boot manager menu: /--------------------------------------------------------------------------= ----\ | Boot Manager = | \--------------------------------------------------------------------------= ----/ Device Path : Boot Manager Menu MemoryMapped(0xB,0= xFF5 B1000,0xFFAC17D7)/= FvFi UEFI Shell le(7C04A583-9E3E-4= F1C- UEFI Misc Device AD65-E05268D0B4D1) UEFI Misc Device 2 UEFI Misc Device 3 UEFI Misc Device 4 UEFI Shell UEFI PXEv4 (MAC:6805CA04D56A) UEFI Shell UEFI Shell UEFI Shell UEFI Shell UEFI Shell v /-----------------= -------------------------------------------------------------\ | = | | ^v=3DMove Highlight =3DSelect Entry Esc=3DExit = | \--------------------------------------------------------------------------= ----/ We see that commit https://github.com/tianocore/edk2/commit/0e2c6c552990edc= d6352c2395860cb0df62b158d can fix this problem. Remove any boot options that point to binaries built into the firmware and have become stale due to any of the following: - FvMain's base address or size changed (historical -- see commit https://github.com/tianocore/edk2/commit/e191a3114f4c8fc0a05e4dc7bb72935= f18ff4de9), - FvMain's FvNameGuid changed, - the FILE_GUID of the pointed-to binary changed, - the referenced binary is no longer built into the firmware. For example, multiple such "EFI Internal Shell" boot options can coexist. They technically differ from each other, but may not describe any built-in shell binary exactly. Such options can accumulate in a varstore over time, and while they remain generally bootable (thanks to the efforts of BmGetFileBufferByFvFilePath()), they look bad. Filter out any stale options. But this commit is for ArmVirtPkg/PlatformBootManagerLib, while we use ArmP= kg/PlatformBootManagerLib. Can this commit be ported from ArmVirtPkg to ArmPkg? Are there any side eff= ects/ precautions for doing so? Thanks & Regards, Pankaj Bansal