From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web12.1325.1588168404825948784 for ; Wed, 29 Apr 2020 06:53:25 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0388e3005b=abner.chang@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03TDblmR027204; Wed, 29 Apr 2020 13:53:24 GMT Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) by mx0b-002e3701.pphosted.com with ESMTP id 30my2p2n5r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Apr 2020 13:53:24 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2353.austin.hpe.com (Postfix) with ESMTPS id A952C90; Wed, 29 Apr 2020 13:53:23 +0000 (UTC) Received: from G4W10204.americas.hpqcorp.net (16.207.82.16) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 29 Apr 2020 13:53:23 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.241.52.12) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 29 Apr 2020 13:53:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLAnr5oyEZxqAjvkkdNe5kX203HQ4b43Y9e3qfuQp3Vb+agbCgV9NvqiENXEW9qhyy1H1Er9vyMElfh1ApYc7Ro+VI5qbZBMPXuTva1zMhEUjS4z6p58xwUsSsxS8+hNYpQjby5gCn2cAwXgSNy8rbu42w+PopmLRExWyHg/8ykM2r7GCsar9EVZo4I/uQpGvbx6MNBrZwLO1NBmAf595wo6XxC2aPTZwpuljDlKsK4blcsxWBC2dd7xaJ9RjKtLZVDVnx7vdYL3f2IwEs835q1jrpa3cNNIg4gkfEZJT3B5SGWg+e9fQ4hW2pgeP2/+2mA7HMKZyXzCi9HnhaFHsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BRm3WQyiLvXj1xkX4EaAc6m02r49r42HPA74aQIp0bs=; b=Tsu0pW4n1peNbgaPjtwATpl4AoH+ni96DAPwYv9e8oXpIAVAM67f+ieec0w2vQsKksn4VuyvRTO3K/GB0MZ4ojhqjeabAMZmCsl8b7f4GTIR80WH/AjxycGZGJ9GIms0spJHMIJceHYFwSCGVauYaNR/BRrZnvEue1qAaoBF8heR3p87XYjplD4MqJmBNGkTcHvv9oXg/7JYcVf92TIomSBnDDI7jI3KSWMIL6Yig45r4FksVsHu9xlta2lmwD8WgJ+vbSUGf9It6T12k51cggJ2/GFOIi5q5hK+FLVhmhObAAE/ZdwNY+kRwhwnBSP1yVqKfd/3pfbbG1IZUj4vPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from DF4PR8401MB0427.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760a::9) by DF4PR8401MB0490.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Wed, 29 Apr 2020 13:53:22 +0000 Received: from DF4PR8401MB0427.NAMPRD84.PROD.OUTLOOK.COM ([fe80::ac94:9f3b:50f1:8931]) by DF4PR8401MB0427.NAMPRD84.PROD.OUTLOOK.COM ([fe80::ac94:9f3b:50f1:8931%6]) with mapi id 15.20.2937.028; Wed, 29 Apr 2020 13:53:22 +0000 From: "Abner Chang" To: Laszlo Ersek , Bob Feng CC: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform Thread-Topic: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for RISC-V platform Thread-Index: AQHWGXvWbYGBxhk83kOKX3cyt+cVSqiP6xwAgAA81EA= Date: Wed, 29 Apr 2020 13:53:22 +0000 Message-ID: References: <20200423135233.7342-1-abner.chang@hpe.com> <22c7b0d8-9726-a03e-a47b-fac7dcf6ff6f@redhat.com> In-Reply-To: <22c7b0d8-9726-a03e-a47b-fac7dcf6ff6f@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=hpe.com; x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 205cad7c-6710-475f-d11d-08d7ec44ae52 x-ms-traffictypediagnostic: DF4PR8401MB0490: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03883BD916 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0427.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(39860400002)(136003)(376002)(346002)(396003)(366004)(53546011)(7696005)(6506007)(8676002)(316002)(478600001)(55016002)(26005)(110136005)(8936002)(186003)(86362001)(4326008)(71200400001)(9686003)(2906002)(966005)(5660300002)(76116006)(66446008)(64756008)(66946007)(19627235002)(66556008)(66476007)(33656002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9MAwy6ONcSfAP9npzBtJaDBAF5t9leATP9B306MxrYY60UynYAakYMJMbscC9wgj9RFsZyeYyRBYA3SkEippv0QYoHu7rv21fDg+BtjHW1XVXep6vIfKcE2NXUi5u0cCuqKOXNa8ac7C5oVa8z8vbY5cIWoUqfUV8hqmTIT2zaLXglv4rUFqotFVxrzClucBGDwUBDfk6kNwnamzM9mzFVseOqTgt4qwL/NVnHwJyjFaZgz0YJWFcEKtw8Muqf9cfhESJD502dF7weJSB0lkScCgNBPFvfwbkfvhqPR+dzXRbyM3oTUwLZpdJ1WqK2Ws9fvvDSA4vYK7tP2hgHRA3lxhuP5Plw8jRaxDcQAk//OFe3E9Md9OTyXa0Qu0vkfoGcRneNC8jBeLCta0MVnQZwhX/h+z8r4f1FWZBdTe0o1c+T110tYcNAceQTXLrN6Dj7yb5ThhyBMUfPkQEY2asKE2PzB6i//Bq3PA55cR69lUWl0UbwA0urO8f3KtVdX1zUvAunCjF/lCQxwYuuV/xQ== x-ms-exchange-antispam-messagedata: OB8IQMpspLeYGgJADVY2Q05wMMRZQfvsez/A6ThQHu4lwTBm9N2uvhVtns3A8oU/BKiS70dDwz9K12j+VIlXOJ6MhRY0/aQr5gQYQvHUOC7EAph3BDR8iraIqVojOgGFkHWxix7tcscBzuHQsu1i4xrJQZKTMZqKsdCE4ZLemKoloyuwXrvqjnz1W3H1/exS8avyUpo06ZXb53RS00Ikt6Vz3kY34F6EItMEHJlh1+AJpTanuekn/hFQfNHv54iyoPNG3kpFOk02/4mgmz1V2S8r8pZBdJHinMbqS1RzuZesbXLpk5qWsnaMgwN3KYQ/r1NVYdow8etV/5enYCGmQnou8qc9IG1WIzQm9xK04o8ym80oVIw1DaLw73VmpzoUTlTT0YRqYcBg0FDxAepJEX+FpscpR+N+bG3yBsoCJuUw47P3YGWUgGpEzD/GLIRCeDkqFm2buEQ6j6Bp6HDL4TFRTfA4krhXpkZ4BZPQTjynccoH0D8eg7LjOwDeJiBehopJHHzw6iyXCv7ZUScoO9EAGhVm3mWGb9LoYTMpF9fgGgUSVps7E9t06r8GyFvyjdVao5MsHJtpKsYIB9UwWDiDMBtRLntwqRZHPH4Snmi0IDhrr8W3OkTyJrZUhco2AFILJYkuJ7wFtdyTqC7G07pOEcvH8dNdH6PR0zwO5MQEElbVULy5E7F9RLlWR0CaHjN06Yohm6VLMxIf3AsJSyUowYjB/TLy0dfKnp9JAK8d+gAe+0b1OUtqhBMjnKPuSNO84HaR+9ixQ9DM5HGudLwtXlm087EaVtRMGTrM7dc= x-ms-exchange-transport-forked: True X-MS-Exchange-CrossTenant-Network-Message-Id: 205cad7c-6710-475f-d11d-08d7ec44ae52 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2020 13:53:22.1609 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mqdfsXORHniRIfQvPdSkkYeenahYRe54urr4EI486pPR1Y0hpDznYMxyZsY6mzqZyQ/4NF1oOtBlYaCraKhFvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0490 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-29_05:2020-04-29,2020-04-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004290115 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, I will revise other commit messages before pushing to edk2 maste= r. Thanks for advice. Abner > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, April 29, 2020 6:15 PM > To: Chang, Abner (HPS SW/FW Technologist) ; Bob > Feng > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH v4 0/3] BaseTools: BaseTools changes for > RISC-V platform >=20 > Hi Abner, Bob, >=20 > On 04/23/20 15:52, Abner Chang wrote: > > BZ for entire RISC-V edk2 port, > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2672 > > > > These commits are verified by below PR, > > https://github.com/tianocore/edk2/pull/512 > > > > In v4, GCC5_ASM_FLAGS is replaced by GCC5_RISCV64_ASM_FLAGS in > > tools_def.template in 3/3 patch. > > > > Abner Chang (3): > > BaseTools: BaseTools changes for RISC-V platform. > > BaseTools: BaseTools changes for RISC-V platform. > > BaseTools: BaseTools changes for RISC-V platform. >=20 > Please don't write patch subjects like this. If I look at the git commit = history > now (just the subject lines), I see: >=20 > $ git log --oneline --reverse cdc3fa54184a..f60d5ca97f25 >=20 > ad1db975c0ca BaseTools: BaseTools changes for RISC-V platform. > 178938b2b9b4 BaseTools: BaseTools changes for RISC-V platform. > f60d5ca97f25 BaseTools: BaseTools changes for RISC-V platform. >=20 > These subjects are nearly useless, especially three of them grouped toget= her. >=20 > The following would have been better (trivially composed from the bodies = of > the commit messages): >=20 > BaseTools: C code changes for building EDK2 RISC-V platform > BaseTools: Tools def. template updates for building EDK2 RISC-V platform > BaseTools: Python code changes for building EDK2 RISC-V platform >=20 > Bob: please remember that it's reviewer / maintainer responsibility as we= ll to > maintain a high level of commit message quality. The git commit history is > relevant to the entire community, not just BaseTools owners. >=20 > Thanks > Laszlo >=20 > > > > BaseTools/Source/C/Common/PeCoffLib.h | 9 + > > BaseTools/Source/C/GenFw/elf_common.h | 62 ++++ > > .../C/Include/IndustryStandard/PeImage.h | 6 + > > BaseTools/Source/C/Common/BasePeCoff.c | 15 +- > > BaseTools/Source/C/Common/PeCoffLoaderEx.c | 86 ++++++ > > BaseTools/Source/C/GenFv/GenFvInternalLib.c | 128 +++++++- > > BaseTools/Source/C/GenFw/Elf32Convert.c | 5 +- > > BaseTools/Source/C/GenFw/Elf64Convert.c | 282 > +++++++++++++++++- > > BaseTools/Conf/tools_def.template | 53 +++- > > BaseTools/Source/Python/Common/DataType.py | 5 +- > > BaseTools/Source/Python/build/buildoptions.py | 6 +- > > 11 files changed, 638 insertions(+), 19 deletions(-) > >