public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Re: [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64
       [not found] <1669059AE1EBA356.20489@groups.io>
@ 2021-03-16  0:55 ` Daniel Schaefer
  0 siblings, 0 replies; only message in thread
From: Daniel Schaefer @ 2021-03-16  0:55 UTC (permalink / raw)
  To: devel@edk2.groups.io, Schaefer, Daniel
  Cc: G Edhaya Chandran, Barton Gao, Samer El-Haj-Mahmoud, Eric Jin,
	Arvin Chen, Leif Lindholm, Heinrich Schuchardt,
	Chang, Abner (HPS SW/FW Technologist)

[-- Attachment #1: Type: text/plain, Size: 8835 bytes --]

Abner has reviewed and approved everything now.
Other people only reviewed v2 5/5.

Does anybody else have any comments?
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Daniel Schaefer <daniel.schaefer@hpe.com>
Sent: Thursday, March 4, 2021 11:21
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen <arvinx.chen@intel.com>; Leif Lindholm <leif@nuviainc.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Subject: [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64

Changes to previous series:

- Fixed the commit to remove whitespace to *only* remove whitespace. Had
  some mixup there...
- Added missing HPE copyright in one file

I was able to run SCT on my EDK2 port to RISCV64 and I don't see any
obvious failures related to this. Additionally Heinrich has tested the
first series on the U-Boot implementation of UEFI.

If you apply these patches or check out my branch [1] you can easily
review the changes with `git diff -w master`. It will hide anything
that's copied and any whitespace changes.

Cheers,
Daniel

[1] https://github.com/johnazoidberg/edk2-test/tree/riscv64

Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Cc: Arvin Chen <arvinx.chen@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Abner Chang <abner.chang@hpe.com>

Daniel Schaefer (5):
  SctPkg: Add RISCV64 support by using Aarch64 sources
  SctPkg: Adapt Aarch64 sources for Riscv64
  SctPkg: Add RISCV64 build support
  SctPkg: Unify CC_FLAGS for all GCC platforms
  SctPkg: Remove trailing whitespace

 uefi-sct/SctPkg/Application/InstallSct/InstallSctDef.h                                                                                  |  4 ++
 uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h                                                                                     |  4 +-
 uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c                                                                                       |  6 +-
 uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/SctLibPlat.h                                                                        |  7 ++-
 uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/initplat.c                                                                          |  6 +-
 uefi-sct/SctPkg/Library/SctLib/SctLib.inf                                                                                               |  6 ++
 uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S                                                                                        |  6 +-
 uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c                                                                                    |  6 +-
 uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/GoVirtual.S                                                                           | 15 +++--
 uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/VirtualMemory.c                                                                       | 22 +++----
 uefi-sct/SctPkg/SCRT/SCRTApp/SCRTApp.inf                                                                                                |  5 ++
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c                                                                                         |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c                                                                                          |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c                                                                                            |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h                                                                                            |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Debug.c                                                                            | 28 ++++-----
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Dump.c                                                                             |  8 +--
 uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Io.c                                                                               | 15 ++---
 uefi-sct/SctPkg/SCRT/SCRTDriver/SCRTDriver.inf                                                                                          |  6 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestCacheFunction.c                          |  6 +-
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/DebugSupportBBTestExceptionCallbackFunction.c              |  7 +--
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/PlatformIsa.c                                              |  6 +-
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/DebugSupportBBTest.inf                                             |  6 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/DebugSupportBBTestCacheFunction.c             |  6 +-
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/DebugSupportBBTestExceptionCallbackFunction.c | 18 +++---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/PlatformIsa.c                                 | 10 ++--
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/Usb2Hc/BlackBoxTest/Usb2HcTest.inf                                                           |  4 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UsbHc/BlackBoxTest/UsbHcTest.inf                                                             |  4 ++
 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLibPlat.h                                                      |  6 +-
 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat.c                                                         |  6 +-
 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/EntsLib.inf                                                                |  5 ++
 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/{Aarch64 => Riscv64}/EntsLibPlat.h                                         |  9 +--
 uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/{Aarch64 => Riscv64}/InitPlat.c                                            |  6 +-
 uefi-sct/SctPkg/Tools/Source/GenBin/GNUmakefile                                                                                         |  4 ++
 uefi-sct/SctPkg/UEFI/IHV_SCT.dsc                                                                                                        | 30 +++++++---
 uefi-sct/SctPkg/UEFI/Protocol/DebugSupport.h                                                                                            | 61 +++++++++++++++++++-
 uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc                                                                                                       | 31 +++++++---
 uefi-sct/SctPkg/build.sh                                                                                                                | 11 +++-
 38 files changed, 269 insertions(+), 143 deletions(-)
 copy uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/SctLibPlat.h (79%)
 copy uefi-sct/SctPkg/Library/SctLib/{Aarch64 => Riscv64}/initplat.c (92%)
 copy uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/GoVirtual.S (83%)
 copy uefi-sct/SctPkg/SCRT/SCRTApp/{Aarch64 => Riscv64}/VirtualMemory.c (85%)
 copy uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Debug.c (65%)
 copy uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Dump.c (93%)
 copy uefi-sct/SctPkg/SCRT/SCRTDriver/{Aarch64 => Riscv64}/Io.c (84%)
 copy uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/DebugSupportBBTestCacheFunction.c (96%)
 copy uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/DebugSupportBBTestExceptionCallbackFunction.c (92%)
 copy uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/{Aarch64 => Riscv64}/PlatformIsa.c (76%)
 copy uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/{Aarch64 => Riscv64}/EntsLibPlat.h (83%)
 copy uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/{Aarch64 => Riscv64}/InitPlat.c (92%)

--
2.30.0







[-- Attachment #2: Type: text/html, Size: 23482 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-03-16  0:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1669059AE1EBA356.20489@groups.io>
2021-03-16  0:55 ` [edk2-devel] [edk2-test PATCHv3 0/5] Port SCT to RISCV64 Daniel Schaefer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox